September 2010 - Wine-Devel

Re: Console issues in recent git

by Octavian Voicu

On Thu, Sep 2, 2010 at 4:29 AM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > Anyone else's terminal emulators really acting up since the last git > batch? On konsole (2.5//4.5.00), I'm unable to see what I'm writing if > there is a wine process running, until it's killed. This is probably a > konsole bug, but still... Actually, I've run into this yesterday, not sure what the cause is (could be Eric's console patches, not cleaning up properly). To fix it, type `reset' in the offending terminal (even if you don't see anything you type, just type <enter>reset<enter>). It will reset all terminal attributes. Octavian

Sept. 2, 2010

Re: msxml3: IXMLDOMText_get_text return trimmed text when XML_TEXT_NODE

by GOUJON Alexandre

On 09/02/2010 12:10 PM, Alexandre Julliard wrote: > That's ugly and inefficient, especially since the common case is to not > modify it. > Well, in fact I don't modify the content. I just trim the output of bstr_from_xmlChar( xmlNodeGetContent( (xmlNodePtr)This->node ) ) And I made a separate function to not overload xml_get_text. Anyway, I understand it's not very clear as the error message is currently "Test marked todo: incorrect get_text string". I'll send a patch to change and add "got %s", wine_dbgstr_w(str) to it. I think it'll be more .. obvious.

Sept. 2, 2010

Re: msvcrt:string Fix codepage table 1361 (Korean Johab) [try2]

by Alexandre Julliard

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -1563,8 +1564,11 @@ sub HANDLE_FILE(@) > } > printf OUTPUT "#include \"wine/unicode.h\"\n\n"; > > + if( $codepage == 1361 ) { @lb_ranges = ( 0x81, 0xd3, 0xd8, 0xde, 0xe0, 0xf9 ); } > + else { @lb_ranges = get_lb_ranges(); } There's no reason to hardcode the whole thing. If some lead bytes aren't detected properly you can add just those. -- Alexandre Julliard julliard(a)winehq.org

Sept. 2, 2010

Re: msxml3: IXMLDOMText_get_text return trimmed text when XML_TEXT_NODE

by Alexandre Julliard

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -181,6 +181,30 @@ static inline BSTR bstr_from_xmlChar(const xmlChar *str) > return ret; > } > > +static inline BSTR bstr_trim(const BSTR str) > +{ > + UINT i, j, len = SysStringLen(str); > + BSTR new_str = NULL; > + > + /* str empty or NULL */ > + if(!len) > + goto err; > + > + for(i=0; isspaceW(str[i]) && i<len; i++); > + for(j=len-1; isspaceW(str[j]) && j>=i; j--); > + > + new_str = SysAllocStringLen(str+i, j-i+1); > + if(!new_str) > + goto err; > + > + SysFreeString(str); > + return new_str; > + > + err: > + SysFreeString(str); > + return SysAllocStringLen(NULL, 0); > +} That's ugly and inefficient, especially since the common case is to not modify it. -- Alexandre Julliard julliard(a)winehq.org

Sept. 2, 2010

AW: Please report mcicda (CDROM audio) test results

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, Saulius Krasuckas wrote: >(I found one such CD today and realised it isn't a Mixed Mode CD which >the test needs for the sake of completeness) Thanks for caring about avoiding skipping tests. >would CD Extra disk (with different types of tracks on the same disk) also >be interesting to test? In this case single data track goes last. Please go ahead -- you could also use test.winehq.org. According to http://de.wikipedia.org/wiki/Compact_Disc "CD-Extra" is a multi-session disc. So it would be like Jeff Zaroyko's disc. He wrote: http://www.winehq.org/pipermail/wine-devel/2010-August/085823.html >I had a look at the CD I claimed was data+audio with a CDBurnerXP. >It's composed of two "sessions" one with audio tracks and the second >session is composed of only a data track. I don't know whether he retried that one with the mcicda tests now in git. Wikipedia says that the Mixed Mode CDs have been largely replaced with multi-session ones. Given Jeff's output it looks like mcicda only sees the audio section of multi session discs. Care to confirm? Regards, Jörg Höhle

Sept. 2, 2010

Re: Console issues in recent git

by Saulius Krasuckas

* On Thu, 2 Sep 2010, Reece Dunn wrote: > On 2 September 2010 02:29, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > > Anyone else's terminal emulators really acting up since the last git > > batch? On konsole (2.5//4.5.00), I'm unable to see what I'm writing if > > there is a wine process running, until it's killed. This is probably a > > konsole bug, but still... > > On gnome-terminal, running an application (StarCraft 2) via a bash > script, using the arrow keys does not cycle through the history and > pressing enter does not output a newline so the "user(a)computer: " bit > gets outputted next to the other one. This is after the second run. Similar things happens here with xterm. Killing wine processes and wineserver doesn't help me and xterm should be killed afterwards. S.

Sept. 2, 2010

Re: [PATCH 3/3] include: Add MCI_INTEGER64 and MCI_INTEGER3264 mci types. (try 2)

by Alexandre Julliard

Octavian Voicu <octavian.voicu(a)gmail.com> writes: > If this is not the correct approach, can you suggest a better one? I > definitely need a constant like MCI_INTEGER3264 to replace all the > MCI_INTEGERs in MCI_STATUS return type (adding one #ifdef for each > status command would be overkill imho). You can add the #define at the top of the .rc files that need it. -- Alexandre Julliard julliard(a)winehq.org

Sept. 2, 2010

Re: Console issues in recent git

by Reece Dunn

On 2 September 2010 02:29, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > Anyone else's terminal emulators really acting up since the last git > batch? On konsole (2.5//4.5.00), I'm unable to see what I'm writing if > there is a wine process running, until it's killed. This is probably a > konsole bug, but still... On gnome-terminal, running an application (StarCraft 2) via a bash script, using the arrow keys does not cycle through the history and pressing enter does not output a newline so the "user(a)computer: " bit gets outputted next to the other one. This is after the second run. I haven't had chance to investigate this yet (raise a bug report or perform a bisect), but might be due to the wineconsole work recently committed. - Reece

Sept. 2, 2010

Re: Mono integration, and when do we ship Mono with Wine?

by Scott Ritchie

On 09/01/2010 04:24 PM, Vincent Povirk wrote: > The one hard requirement I have and have not met is that a working > mono package can be built by me using only free software and that I > can explain the build process to other people. I can do this for the > core runtime and libraries, but I cannot do this for the gluezilla > dependency. > This is nice to have, of course, however I'll note that we don't actually have this with gecko at the moment. Since it's free to redistribute it can still get into (most) distro repositories and ultimately to users (in Ubuntu for instance wine-gecko sits in the Multiverse repository). So, depending on how amenable you are to the idea, I think it would be ok to get it working on an integration level before we actually make it buildable without windows. Given the additional time and use case Mono itself may very well have advance to make it buildable on free software (as I believe Firefox is doing and why our next Gecko will be freely buildable as well) Thanks, Scott Ritchie

Sept. 2, 2010

Console issues in recent git

by Jerome Leclanche

Anyone else's terminal emulators really acting up since the last git batch? On konsole (2.5//4.5.00), I'm unable to see what I'm writing if there is a wine process running, until it's killed. This is probably a konsole bug, but still... CC eric. -- J. Leclanche

Sept. 2, 2010