September 2010 - Wine-Devel

Re: [PATCH 4/6] winmm/tests: Add a few Open/Close MCI tests.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4900 Your paranoid android. === W98SE (32 bit mci) === mci.c:637: Test failed: Expect message 0001 from play to 250 wait notify mci.c:644: Test failed: got 0004 instead of MCI_NOTIFY_xyz 0000 from command after close

Sept. 1, 2010

Re: [PATCH 2/6] winmm: Close MCI device after immediate auto-open commands.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4899 Your paranoid android. === W98SE (32 bit mci) === mci.c:613: Test failed: Expect message 0001 from play to 250 wait notify mci.c:620: Test failed: got 0004 instead of MCI_NOTIFY_xyz 0000 from command after close

Sept. 1, 2010

Re: [PATCH 1/6] winmm: MCI open always creates an alias for subsequent commands.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4898 Your paranoid android. === W98SE (32 bit mci) === mci.c:681: Test failed: not enough time elapsed 58ms mci.c:737: Test failed: mci status position: 58

Sept. 1, 2010

Re: [PATCH] wined3d: Add missing ckey, fx, and pal directdraw caps.

by Stefan Dösinger

Looks OK to me. (unless there are whitespace issues which I can't see in my current mail client) Am 01.09.2010 um 06:44 schrieb Octavian Voicu: > Fixes regression described in bug 24226. > --- > dlls/wined3d/directx.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 01b4e46..9e50f78 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -4259,7 +4259,7 @@ static HRESULT WINAPI IWineD3DImpl_GetDeviceCaps(IWineD3D *iface, UINT Adapter, > int ps_selected_mode; > struct shader_caps shader_caps; > struct fragment_caps fragment_caps; > - DWORD ckey_caps, blit_caps, fx_caps; > + DWORD ckey_caps, blit_caps, fx_caps, pal_caps; > > TRACE_(d3d_caps)("(%p)->(Adptr:%d, DevType: %x, pCaps: %p)\n", This, Adapter, DeviceType, pCaps); > > @@ -4786,6 +4786,8 @@ static HRESULT WINAPI IWineD3DImpl_GetDeviceCaps(IWineD3D *iface, UINT Adapter, > WINEDDCAPS_COLORKEY | > WINEDDCAPS_COLORKEYHWASSIST | > WINEDDCAPS_ALIGNBOUNDARYSRC; > + pal_caps = WINEDDPCAPS_8BIT | > + WINEDDPCAPS_PRIMARYSURFACE; > > /* Fill the ddraw caps structure */ > pCaps->DirectDrawCaps.Caps = WINEDDCAPS_GDI | > @@ -4796,6 +4798,9 @@ static HRESULT WINAPI IWineD3DImpl_GetDeviceCaps(IWineD3D *iface, UINT Adapter, > WINEDDCAPS2_PRIMARYGAMMA | > WINEDDCAPS2_WIDESURFACES | > WINEDDCAPS2_CANRENDERWINDOWED; > + pCaps->DirectDrawCaps.CKeyCaps = ckey_caps; > + pCaps->DirectDrawCaps.FXCaps = fx_caps; > + pCaps->DirectDrawCaps.PalCaps = pal_caps; > pCaps->DirectDrawCaps.SVBCaps = blit_caps; > pCaps->DirectDrawCaps.SVBCKeyCaps = ckey_caps; > pCaps->DirectDrawCaps.SVBFXCaps = fx_caps; > -- > 1.7.0.4 > > >

Sept. 1, 2010

Re: shell32: add stubbed SHGetKnownFolderPath

by Alexandre Julliard

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> writes: > @@ -111,3 +111,8 @@ typedef [v1_enum] enum tagSHCOLSTATE > } SHCOLSTATE; > > typedef DWORD SHCOLSTATEF; > + > +typedef GUID KNOWNFOLDERID; > + > +typedef KNOWNFOLDERID *REFKNOWNFOLDERID; This doesn't match the PSDK definitions. -- Alexandre Julliard julliard(a)winehq.org

Sept. 1, 2010

Re: [PATCH] winealsa.drv: Count micelem in mixer chans, don't add spare capture input for half-duplex mics.

by Alexandre Julliard

Jeff Cook <jeff(a)deserettechnology.com> writes: > @@ -520,7 +520,12 @@ static void ALSA_MixerInit(void) > } > > /* Add master channel, uncounted channels and an extra for capture */ > - mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + 1; > + /* Do not add the extra channel needed for capture on half-duplex capture cards > + like snd_usb_audio mics */ > + if (micelem && !mastelem && !captelem) > + mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + !!micelem; > + else > + mixdev[mixnum].chans += !!mastelem + !!headelem + !!pcmelem + !!micelem + 1; This statement wasn't exactly clear before, but now it's really impossible to follow. Please rewrite this in a way that makes sense to a casual reader. -- Alexandre Julliard julliard(a)winehq.org

Sept. 1, 2010

Fwd: [ANNOUNCE] Git User's Survey 2010

by Andrew Eikum

This mail was sent to the git mailing list today. Since we use Git here, I thought I'd bring it to everyone's attention. -------- Original Message -------- From: Jakub Narebski <jnareb(a)gmail.com> To: git(a)vger.kernel.org Subject: [ANNOUNCE] Git User's Survey 2010 Date: Tue, 31 Aug 2010 23:33:47 +0200 Hello all, We would like to ask you a few questions about your use of the Git version control system. This survey is mainly to understand who is using Git, how and why. The results will be published to the Git wiki on the GitSurvey2010 page (https://git.wiki.kernel.org/index.php/GitSurvey2010) and discussed on the git mailing list. The survey would be open from 1 September till 15 October 2010. Please devote a few minutes of your time to fill this simple questionnaire, it will help a lot the git community to understand your needs, what you like of Git, and of course what you don't like of it. The survey can be found here: http://tinyurl.com/GitSurvey2010 https://www.survs.com/survey/MUPYR8UJ4B

Sept. 1, 2010

Re: d3dx9: Implement D3DXFVFFromDeclarator. (try 2)

by Henri Verbeet

On 1 September 2010 02:40, Misha Koshelev <misha680(a)gmail.com> wrote: > + while (texture <= 8) What is the "texture == 8" case for? Also, it seems to me FVFs require texcoords to be assigned to consecutive texture units.

Sept. 1, 2010

Re: user32: Add a bunch of GetWindowPlacement() tests, fix some simple cases.

by testbot＠testbot.winehq.org

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4896 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

Sept. 1, 2010

Re: msvcp90: Fix 64-bit compilation warnings

by Alexandre Julliard

Octavian Voicu <octavian.voicu(a)gmail.com> writes: >> You should be casting to long, otherwise you'll potentially truncate the >> value. > > %zu is out of the question? Yes. Besides, that's the msvcrt size_t, not the real one. -- Alexandre Julliard julliard(a)winehq.org

Sept. 1, 2010