September 2010 - Wine-Devel

Re: msvcp90: Fix 64-bit compilation warnings

by Octavian Voicu

On Wed, Sep 1, 2010 at 12:56 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Piotr Caban <piotr(a)codeweavers.com> writes: > >> @@ -596,7 +596,7 @@ DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_char_erase, 12) >> basic_string_char* __thiscall MSVCP_basic_string_char_erase( >> basic_string_char *this, size_t pos, size_t len) >> { >> - TRACE("%p %d %d\n", this, pos, len); >> + TRACE("%p %d %d\n", this, (int)pos, (int)len); > > You should be casting to long, otherwise you'll potentially truncate the > value. %zu is out of the question?

Sept. 1, 2010

Re: msvcrt:string Fix codepage table 1361 (Korean Johab)

by GOUJON Alexandre

On 09/01/2010 04:54 AM, Vitaliy Margolen wrote: > On 08/31/2010 04:58 AM, GOUJON Alexandre wrote: >> Is the attached patch well formed ? >> + if( $codepage == 1361 ) my $lb_ranges = ( 0x81, 0xd3, 0xd8, >> 0xde, 0xe0, 0xf9, 0x00, 0x00 ); >> + else my $lb_ranges = get_lb_ranges(); >> + > No, it's wrong. Perl requires curly braces for if(){}else{}. Thank you but it was still not working, so I read a perl tutorial ($->@ and moved 'my' above ). Now it works. I just sent the patch. Thanks for your help !

Sept. 1, 2010

Re: msvcp90: Fix 64-bit compilation warnings

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -596,7 +596,7 @@ DEFINE_THISCALL_WRAPPER(MSVCP_basic_string_char_erase, 12) > basic_string_char* __thiscall MSVCP_basic_string_char_erase( > basic_string_char *this, size_t pos, size_t len) > { > - TRACE("%p %d %d\n", this, pos, len); > + TRACE("%p %d %d\n", this, (int)pos, (int)len); You should be casting to long, otherwise you'll potentially truncate the value. -- Alexandre Julliard julliard(a)winehq.org

Sept. 1, 2010

wanted: sample .avi file for MCI tests

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, I'd like to perform perform some mciavi tests. For that I'd need a .avi with known characteristics, much like MS' clock.avi such as - known number of frames, e.g. 12 - visibly different frames for visual control (e.g. analog clock or digits 0-9) - audio channel not necessary (although the MCI can control it) Who could like to contribute such a file? There are already several dlls/tests/ that create .avis. I'm wondering what makes sense. - copy & paste useful code that creates one on the fly (like avifil32 seems to do?) - have it in a resource like qedit/tests/ does (if I understand it correctly?) - hook into one of the existing tests directories and add some mci tests there? - ...? For checking status position and seeking behaviour (hint: Wine differs from native), a file with known number of frames is best (unlike quartz/tests/ which seems to use whatever test.avi happens to lie in the directory, if any). I'd like to avoid skipping tests when a file is not present, unlike amstream/tests, quartz/tests/avisplitter and winmm/tests/mmio (skip => no coverage => regressions not found). Regards, Jörg Höhle

Sept. 1, 2010

Re: Chinese translation of key pages on wiki.winehq.org?

by Frédéric Delanoy

2010/9/1 Hin-Tak Leung <hintak_leung(a)yahoo.co.uk>: > Frédéric Delanoy wrote: >> >> On Tue, Aug 31, 2010 at 02:40, Dan Kegel <dank(a)kegel.com> wrote: >>> >>> Are there any Chinese speakers on the list? >>> Any interest in starting a Chinese translation of wiki.winehq.org? >>> >>> I bring this up because a Chinese user/developer is asking for help >>> getting started with submitting translations to Wine. I think he would >>> find >>> Chinese versions of >>> http://wiki.winehq.org/SubmittingPatches >>> and perhaps even >>> http://wiki.winehq.org/Translating >>> helpful. >>> >>> It seems strange for a translator to need help reading English >>> documents, but perhaps it would help them come up the curve >>> faster. >> >> Well maybe it's because (some of) these pages are not clear enough for >> non-techies. Maybe he could tell what parts he didn't understand so >> the wiki pages can be improved (it would help for other languages, >> too). > > Wel, I suppose I can help proof-read if it comes to that. But > http://wiki.winehq.org/Translating is really not a good starting point as it > assumes a great deal of development and windows knowledge - at least the > first few paragraphs scare me :-). I think as a start he/she should try to > translate some of the documentation (e.g. say, the user guide, or even the > weekly news) rather than windows resources rc files! BTW http://wiki.winehq.org/TranslateWineHQ mentions "patches(a)winehq.org". I guess it should be changed to "wine-patches(a)winehq.org", no? Or is it an alias to wine-patches?

Sept. 1, 2010

Re: Chinese translation of key pages on wiki.winehq.org?

by Hin-Tak Leung

Frédéric Delanoy wrote: > On Tue, Aug 31, 2010 at 02:40, Dan Kegel <dank(a)kegel.com> wrote: >> Are there any Chinese speakers on the list? >> Any interest in starting a Chinese translation of wiki.winehq.org? >> >> I bring this up because a Chinese user/developer is asking for help >> getting started with submitting translations to Wine. I think he would find >> Chinese versions of >> http://wiki.winehq.org/SubmittingPatches >> and perhaps even >> http://wiki.winehq.org/Translating >> helpful. >> >> It seems strange for a translator to need help reading English >> documents, but perhaps it would help them come up the curve >> faster. > > Well maybe it's because (some of) these pages are not clear enough for > non-techies. Maybe he could tell what parts he didn't understand so > the wiki pages can be improved (it would help for other languages, > too). Wel, I suppose I can help proof-read if it comes to that. But http://wiki.winehq.org/Translating is really not a good starting point as it assumes a great deal of development and windows knowledge - at least the first few paragraphs scare me :-). I think as a start he/she should try to translate some of the documentation (e.g. say, the user guide, or even the weekly news) rather than windows resources rc files!

Sept. 1, 2010

Re: msvcrt:string Fix codepage table 1361 (Korean Johab)

by Vitaliy Margolen

On 08/31/2010 04:58 AM, GOUJON Alexandre wrote: > Is the attached patch well formed ? > + if( $codepage == 1361 ) my $lb_ranges = ( 0x81, 0xd3, 0xd8, 0xde, 0xe0, 0xf9, 0x00, 0x00 ); > + else my $lb_ranges = get_lb_ranges(); > + No, it's wrong. Perl requires curly braces for if(){}else{}. Vitaliy.

Sept. 1, 2010

Re: Wine 1.4 plans?

by Vitaliy Margolen

On 08/30/2010 03:06 PM, Dan Kegel wrote: > Bug 6971, the mouse problem affecting many FPS-style games (Alexandre > thinks it would take a month of his time?) That all depends how far AJ wants to go with restructuring of input layer in X11.drv / server. If all you talking about is making dinput work (and ignore all problems with other input) then it's more-less done (my last patch to use xi2 should be enough). Just add raw input somewhere there (probably extra input stream to server or you'll end up with the same exact problem as dinput) and pointer/focus grabbing (that AJ outright rejected a while back). Vitaliy.

Sept. 1, 2010