January 2011 - Wine-Devel - list.winehq.org

Re: shell32/tests: Remove shlwapi dependency

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8618 Your paranoid android. === WVISTAADM (32 bit shelldispatch) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

Jan. 26, 2011

Re: winex11.drv: initialize drawable (clang)

by denis bonnenfant

Le mardi 25 janvier 2011 à 19:10 +0100, Henri Verbeet a écrit : > 2011/1/25 André Hentschel <nerv(a)dawncrow.de>: > > http://austinenglish.com/logs/clang_analyzer/report-dRpLpZ.html#EndPath > > then the if condition is reliable > I don't think that can happen unless hwnd is NULL and top is non-NULL, > which looks like invalid input to me. > > Maybe http://bugs.winehq.org/show_bug.cgi?id=24621 ? Is it worth to investigate in this direction ? Denis.

Jan. 25, 2011

Re: kernel32: Removing - key from keybindings.

by Trygve Vea

On Tue, Jan 25, 2011 at 8:35 PM, Trygve Vea <trygve.vea(a)gmail.com> wrote: > Fixes bug 25856, introduced in 2a219b948c451213fb4554352b86f3784a8f7e32. > It seems that Eric Pouech already posted an identical patch, which has been applied. This is then unnecessary. I apologize for the noise. -- Trygve Vea

Jan. 25, 2011

Re: wine-patches

by Juan Lang

Hi Vincent, > I sent this email on wine-patch but... nothing. > > Am I doing something wrong ? Sorry, I should have replied earlier. The patch doesn't appear to fix anything, so it's unclear where you're going with it. It'd be better to send a more complete patch series. For example, +static BOOL PCSCLite_loadfunctions(void) +{ + FIXME("%s\n", SONAME_LIBPCSCLITE); + return TRUE; +} this just adds spam to the console. Also, why do you return BOOL, when the return value is never checked? More nitpicking: +static void *g_pcscliteHandle = NULL; The initialization is unnecessary, statics are implicitly initialized to 0. + if (g_pcscliteHandle) + { + wine_dlclose(g_pcscliteHandle, NULL, 0); + g_pcscliteHandle = NULL; The assignment of NULL is unneeded, the process is being unloaded. + if (g_pcscliteHandle) + return TRUE; /* already loaded */ + else This check is unneeded, the function is only called at process load, i.e. only once. --Juan

Jan. 25, 2011

Re: winex11.drv: initialize drawable (clang)

by Henri Verbeet

2011/1/25 André Hentschel <nerv(a)dawncrow.de>: > http://austinenglish.com/logs/clang_analyzer/report-dRpLpZ.html#EndPath > then the if condition is reliable I don't think that can happen unless hwnd is NULL and top is non-NULL, which looks like invalid input to me.

Jan. 25, 2011

Re: po: Update the Dutch translation

by Alexandre Julliard

Sven Baars <sven.wine(a)gmail.com> writes: > Hey, > > All those po editors piss me off. First, the changes I make don't get > saved, then they do get saved but magically disappear when I try to > send them. Now I used poedit, which is apparently the only one that > works, and this one makes whole bunch of changes by itself. > > If this unacceptable, could someone please tell me how to work with > this stuff? Or would it be better to just use a normal editor? Maybe > emacs? And how could I recover the actual changes I made (and not the > ones poedit made) if this patch is not acceptable? You should run it through msgmerge before sending. Something like msgmerge nl.po wine.pot > nl.po.new -- Alexandre Julliard julliard(a)winehq.org

Jan. 25, 2011

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)

by Loïc Maury

On Tue, Jan 25, 2011 at 12:29 AM, Ken Thomases <ken(a)codeweavers.com> wrote: > Loïc, > > Your mailer seems to have mangled your patch with line wrapping. There are > some suggestions on Wine's SubmittingPatches wiki page for avoiding this. > Primarily, you should attach the patch to your email. If you already did > that, then you may need to use a different mailer. For example, Mail.app > used to mess up even attached patches, although it doesn't for me anymore. > (I don't know if that's because Mail.app changed or if git-format-patch > changes.) When it used to be a problem, I had to use Thunderbird to send my > Wine patches. Thank you for advices, I will use Thunderbird. Loïc

Jan. 25, 2011

ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 4)

by Loïc Maury

--- dlls/ntdll/cdrom.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)

Jan. 25, 2011

Re: [Bug 25402] Woody Two Legs crashes with unimplemented function msvcr90.dll._wcslwr_s

by Eric Pouech

the spec should read wstr instead of ptr A+ 2011/1/25 <wine-bugs(a)winehq.org> > http://bugs.winehq.org/show_bug.cgi?id=25402 > > Andrew Millington <andrew.millington(a)gmail.com> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > Keywords| |patch > > --- Comment #5 from Andrew Millington <andrew.millington(a)gmail.com> > 2011-01-25 01:23:06 CST --- > After applying http://source.winehq.org/patches/data/70240 it complains > about > unimplemented function d3dx9_36.dll.D3DXFloat32To16Array and that is bug > #25769. > > -- > Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email > Do not reply to this email, post in Bugzilla using the > above URL to reply. > ------- You are receiving this mail because: ------- > You are watching all bug changes. > > > -- -- Eric Pouech

Jan. 25, 2011

Re: [PATCH 2/4] wined3d: Add support for the NULL format.

by Henri Verbeet

On 25 January 2011 11:17, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Am 24.01.2011 um 18:41 schrieb Henri Verbeet: > >> - if (surface) >> + if (surface && surface->resource.format->id != WINED3DFMT_NULL) > Doesn't this cause GL errors? In my testing I had to set the draw buffer to GL_NONE to be able to draw without a color attachment. > You're probably right, although it worked fine when I tested it, probably by chance. Please ignore this patch for now.

Jan. 25, 2011