January 2011 - Wine-Devel - list.winehq.org

Re: Correction to crash inside RtlCaptureStackBackTrace() + test case

by James McKenzie

On 1/28/11 11:54 AM, Janne Hakonen wrote: > > Now, when I ran these tests on Testbot using all base VMs, the tests > were run also on W2KPROSP4 and WNT4WSSP6. However, the > > function seems to buggy in those. It throws access violation > whenever it is not skipping frames. > > > Is there some way I could prevent/skip these tests to be run on > Windows NT4 and 2000? > > Ah, no matter, I think I've got it. Adding following lines to start > allows the tests to be skipped on NT and 2000: > > __TRY > { > pRtlCaptureStackBackTrace(0, 62, callers, NULL); > } > __EXCEPT_ALL > { > win_skip("RtlCaptureStackBackTrace threw SEH exception, " > "most likely running on Windows NT or 2000\n"); > return; > } > __ENDTRY > Did you try this on WindowsXP or Windows7 to make sure that the win_skip did not function on those platforms? My understanding is that win_skip works on all Windows platforms not just WindowsNT or Windows2000. Also, it is custom to mark your resubmissions with corrections as [try x]. Makes it easier to determine what you are doing. James McKenzie

Jan. 31, 2011

RFC: Final Proposed Riched20 EM_SETMARGINS Test

by James McKenzie

All: Constructive Criticism requested so that this can be made better. I've decided to use two loops in the test: One for fonts. Second for actual tests. This allows for quick and easy expansion. The check code for font changes might be removed, but does no harm by remaining. This patch is based on git as of Friday, January 28. I could find no font that changed the Margin from zero for the EC_USEFONTINFO lparam test case. If someone knows of a font that will do so, please advise as well so I can include it. Thank you. James McKenzie

Jan. 31, 2011

Re: [PATCH 2/2] mshtml: Added support for recursive script runners

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8753 Your paranoid android. === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Jan. 30, 2011

Re: RFC: Adding Mac support to secur32/schannel.c

by Henri Verbeet

On 28 January 2011 17:36, Juan Lang <juan.lang(a)gmail.com> wrote: > What's the issue with building GnuTLS? Is it that GnuTLS doesn't > support the Mac Keychain? Is it that it's an external dependency? If > the latter, we already pull in quite a bit that isn't found on the > Mac, so the incremental change isn't large. > Note that I wasn't actually involved in any of this on the CodeWeavers side, but I think for CodeWeavers the consideration would be that we'd prefer to not be in the business of distributing GnuTLS, since it's extra stuff to carry around, and you'd have to keep track of security issues, etc. Although I think it's perfectly reasonable to ask Wine users, regardless of OS, to install GnuTLS if they want Schannel support, I don't think the same thing is necessarily reasonable to ask of CrossOver users. On the other hand, as a Wine (and Free Software in general) developer I'm not so convinced this would really be beneficial to Wine either. > I do see two problems with the general plan. One isn't specific to > your plan: schannel as it is is buggy. We don't know where the bugs > are, and they've languished for a long time. Your proposed plan Sadly some of that is probably my responsibility. The original plan was to implement server support after the client code went in, and then use that for writing tests. It didn't quite turn out that way, mostly due to wined3d taking priority. On 30 January 2011 20:31, James McKenzie <jjmckenzie51(a)earthlink.net> wrote: > The point is that MacOSX has built-in TLS support out of the box. Why build > GNU TLS when using MacOSX when it is not needed??? > To reduce complexity and maintenance overhead of the Wine schannel code.

Jan. 30, 2011

Re: RFC: Adding Mac support to secur32/schannel.c

by James McKenzie

On 1/28/11 9:36 AM, Juan Lang wrote: > Hi Ken, > >> I'm planning to add an alternative implementation of schannel (SSL/TLS) support for the Mac. The current implementation is based on GnuTLS. That library is not typically found on Mac OS X. Although packagers can build it and ship it and its dependencies with Wine for Mac OS X, I think it's better (especially for security-related functionality) to use the system-provided library. > What's the issue with building GnuTLS? Is it that GnuTLS doesn't > support the Mac Keychain? Is it that it's an external dependency? If > the latter, we already pull in quite a bit that isn't found on the > Mac, so the incremental change isn't large. > The point is that MacOSX has built-in TLS support out of the box. Why build GNU TLS when using MacOSX when it is not needed??? James McKenzie

Jan. 30, 2011

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()

by Peter Schlaile

Hi Vitaliy, On Sun, 30 Jan 2011, Vitaliy Margolen wrote: > On 01/30/2011 04:16 AM, Peter Schlaile wrote: >> Hi, >> >> find fix for a crash in create_alpha_bitmap() attached. > > If it's easy to reproduce please create a test that demonstrates the problem. hmm, don't know, the application that triggered it, can be downloaded here: http://www.phononet.de/downloads/support/downloads/Aktueller_PNClient/PNCLI… It will fail on startup, because of that problem, showing a dialog box, that some of it's data has been damaged and offers you to close or restart. (The program installs it's own page fault exception handler, you can see the reason of the crash if you run wine with WINEDEBUG=+relay .) If you apply my patch, it will start up correctly, ask for a valid license key (which can be skipped) and show a search screen for CDs/DVDs published in Germany. Nevertheless: I hope, I explained pretty well, how and why the current code is wrong (aquiring a bitmap-pointer using CreateDIBSection, setting this bitmap to readonly using the fast track code path within StretchDIBits, writing to this bitmap again.). >> Additional minor fix: bmi_has_alpha() tests for alpha channel != 0, but >> should test for alpha channel != 255. > This should be a separate patch. probably, but you will agree, that this is a rather trivial change... (and pretty obvious, too). Hope that's ok anyways. Cheers, Peter ---- Peter Schlaile

Jan. 30, 2011

Re: Policy regarding 3rd party "windows" distributions and winetest

by GOUJON Alexandre

On 01/30/2011 07:27 PM, James McKenzie wrote: > I think Dan Kegel does not want them in the Winetest list. I'll defer > to AJ as to what HE wants. Sure ! The boss's always right. And it should be great to find a way to identify these "fake" windows. On 01/30/2011 07:29 PM, F Capela wrote: > Couple it with winetest being a fairly comprehensive test of the Windows APIs, > and I would bet such trimmed down windows to be prone to false issues. Understood. Anyway, I just submitted a patch which fix a crash occurring on this "windows" from a winetest result a user posted some days ago. He told me he used this "windows" to submit the results. Even if the errors should be ignored, the crash was real and my patch apply to all windows. Now, It's up to AJ to discard it or not.

Jan. 30, 2011

Re: user32/gdi32: Fix for a crash in create_alpha_bitmap()

by Vitaliy Margolen

On 01/30/2011 04:16 AM, Peter Schlaile wrote: > Hi, > > find fix for a crash in create_alpha_bitmap() attached. If it's easy to reproduce please create a test that demonstrates the problem. > Additional minor fix: bmi_has_alpha() tests for alpha channel != 0, but > should test for alpha channel != 255. This should be a separate patch. Vitaliy.

Jan. 30, 2011

Re: Policy regarding 3rd party "windows" distributions and winetest

by F Capela

> From: GOUJON Alexandre <ale.goujon(a)gmail.com> > > On 01/30/2011 04:47 PM, James McKenzie wrote: >> On 1/27/11 7:04 PM, Dan Kegel wrote: >>> I suspect that we should discourage people from submitting >>> winetest results from 3rd party repackagings of Microsoft Windows, >>> e.g. http://thepiratebay.org/torrent/4254053/MicroXP_v0.82_-_eXPerience >>> >>> Agreed? >> +1. And that is a pirate version of Windows anyway. > I don't see the point ... > I mean, yeah it's not legal, it's bad and what you want but what about if they >provide results that differ from the daily bot results ? > Do you think this 'stripped' version can cause failures that would not happen >on real windows ? > Should we ignore these results ? I always customize my personal use Windows installs with nLite or something like that, and can say first hand that it can cause problems, and difficult to diagnose ones at that. And while I can often determine which component missing or misconfigured is causing the problem (since it was me in the first place that did choose to remove that specific component), I would bet the common user that downloads a stripped down version of Windows more often than not has no idea of the side effects. Couple it with winetest being a fairly comprehensive test of the Windows APIs, and I would bet such trimmed down windows to be prone to false issues.

Jan. 30, 2011

Re: Policy regarding 3rd party "windows" distributions and winetest

by James McKenzie

On 1/30/11 9:02 AM, GOUJON Alexandre wrote: > On 01/30/2011 04:47 PM, James McKenzie wrote: >> On 1/27/11 7:04 PM, Dan Kegel wrote: >>> I suspect that we should discourage people from submitting >>> winetest results from 3rd party repackagings of Microsoft Windows, >>> e.g. http://thepiratebay.org/torrent/4254053/MicroXP_v0.82_-_eXPerience >>> >>> Agreed? >> +1. And that is a pirate version of Windows anyway. > I don't see the point ... > I mean, yeah it's not legal, it's bad and what you want but what about > if they provide results that differ from the daily bot results ? > Do you think this 'stripped' version can cause failures that would not > happen on real windows ? > Should we ignore these results ? > I think Dan Kegel does not want them in the Winetest list. I'll defer to AJ as to what HE wants. I was just pointing out that this is legal to use in the United States and most other countries where Microsoft has enforceable copyrights. James McKenzie

Jan. 30, 2011