January 2011 - Wine-Devel - list.winehq.org

Re: / is writable on mac... leading to lots of awkward msi droppings?

by Charles Davis

On 1/5/11 12:31 AM, Dan Kegel wrote: > Quentin Paris informs me that the root directory is > user-writable on MacOSX (shudder), which means > our beloved z: mapping leads to lots of garbage > directories named e.g. /fd91216cc2ce81eb2ce16a058619 > after running msi installers. Now where would he get that idea from? chips-computer:~ chip$ uname # show that this is Darwin (Mac OS X) Darwin chips-computer:~ chip$ ls -ld / # show permissions of root directory drwxr-xr-x 39 root admin 1394 Nov 15 09:00 / chips-computer:~ chip$ mkdir /a # try to create something in / mkdir: /a: Permission denied At least on my Mac, only root gets to write to /. Chip

Jan. 5, 2011

/ is writable on mac... leading to lots of awkward msi droppings?

by Dan Kegel

Quentin Paris informs me that the root directory is user-writable on MacOSX (shudder), which means our beloved z: mapping leads to lots of garbage directories named e.g. /fd91216cc2ce81eb2ce16a058619 after running msi installers. Is this something Wine's msi could avoid doing?

Jan. 5, 2011

Re: [patch] Support NULL puLen in VerQueryValue

by Rafael Ávila de Espíndola

> You should write some tests to examine the behavior of VerQueryValue > with NULL puLen. > I just found out that wine has a test for it, but it has been commented out: if (0) { /* this test crashes on WinNT4 */ boolret = VerQueryValueA( pVersionInfo, backslash, (LPVOID *)&pFixedVersionInfo, 0); ok (boolret, "VerQueryValue failed: GetLastError = %u\n", GetLastError()); } Cheers, Rafael

Jan. 5, 2011

Re: kernel32/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8130 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W2KPROSP4 (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === WXPPROSP3 (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W2K3R2SESP2 (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === WVISTAADM (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W2K8SE (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W7PRO (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W7PROX64 (32 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting === W7PROX64 (64 bit pipe) === pipe.c:878: Test failed: WriteFile to not-yet-connected pipe pipe.c:880: Test failed: ReadFile from not-yet-connected pipe pipe.c:897: Test failed: WriteFile to disconnected pipe pipe.c:899: Test failed: ReadFile from disconnected pipe with bytes waiting

Jan. 4, 2011

Re: user32/tests: Don't test function directly when reporting GetLastError()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8127 Your paranoid android. === WVISTAADM (32 bit clipboard) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

Jan. 4, 2011

re: include: Add ONCE macro for making debug output less noisy

by Dan Kegel

Alexandre wrote: >> +#define WINE_ONCE(do_once) ... > > I don't think that buys anything over spelling it out explicitly. It makes it easier to grep for, which might be useful if you want to find all the places it's used to throttle messages that shouldn't be happening in the first place.

Jan. 4, 2011

Re: include: Add ONCE macro for making debug output less noisy

by Alexandre Julliard

Sven Baars <sven.wine(a)gmail.com> writes: > @@ -250,6 +250,12 @@ static inline const char *wine_dbgstr_longlong( ULONGLONG ll ) > #define WINE_DPRINTF wine_dbg_printf > #define WINE_MESSAGE wine_dbg_printf > > +#define WINE_ONCE(do_once) \ > + do{ static int wine_once_var; \ > + if (!wine_once_var) { \ > + wine_once_var = 1; \ > + do_once; } } while(0) I don't think that buys anything over spelling it out explicitly. -- Alexandre Julliard julliard(a)winehq.org

Jan. 4, 2011

Re: winemaker: Add def file support

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -2480,7 +2498,9 @@ sub generate_project_files($) > my $canon=canonize("@$target[$T_NAME]"); > $canon =~ s/_so$//; > > - if (@$target[$T_TYPE] == $TT_DLL) { > + if (@$target[$T_TYPE] == $TT_DLL && (@$project_settings[$T_FLAGS] & $TF_HASDEF)) { > + print FILEO "\$(${canon}_MODULE).so: \$(${canon}_OBJS) \$(${canon}_MODULE:%.dll=lib%.def)\n"; > + } elsif (@$target[$T_TYPE] == $TT_DLL) { There's no reason to add a lib prefix. -- Alexandre Julliard julliard(a)winehq.org

Jan. 4, 2011

Re: advapi32: Parital Implement InitiateSystemShutdown(Ex) (try 2)

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -232,6 +233,10 @@ BOOL WINAPI InitiateSystemShutdownExA( LPSTR lpMachineName, LPSTR lpMessage, > DWORD dwTimeout, BOOL bForceAppsClosed, BOOL bRebootAfterShutdown, > DWORD dwReason) > { > + if (!lpMachineName && !lpMessage && !dwTimeout) > + ExitWindowsEx(bRebootAfterShutdown ? EWX_REBOOT : 0 | > + bForceAppsClosed ? EWX_FORCE : 0, > + dwReason); > FIXME("%s %s %d %d %d %d\n", debugstr_a(lpMachineName), > debugstr_a(lpMessage), dwTimeout, bForceAppsClosed, > bRebootAfterShutdown, dwReason); I don't think you want to call user32 functions here. -- Alexandre Julliard julliard(a)winehq.org

Jan. 4, 2011

Re: wined3d: Revert vertex blend capabilities patch

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Yep, the patch(f41fdb22...) should be reverted. As I explained on IRC, the correct approach is to implement a replacement shader for the vertex pipeline and implement vertex blending in it. Henri has a rebased version of my ARBvp experiments from 2008. Am 04.01.2011 um 05:42 schrieb Jeremy Chin: > My previous patch was accepted as f41fdb225cf1e1df494237664ce92e51179f3725, though Henri Verbeet pointed out it was incorrect. stefan on IRC warned that announcing blend capabilities without supporting them may cause issues, hence the revert.<0002-Revert-wined3d-Update-detection-of-vertex-blend-ca.txt> -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) iQIcBAEBAgAGBQJNIxBHAAoJEN0/YqbEcdMw8boQAIy4oDcaDv90bSyxMZJ4HwZy q/bKznK807Rt6UmL8p4OplFLdAOF+mMnqDmNT9vZxr5k7rWC3GDtW+5nohKwyl74 rpQI71lSTo1lixjPP0t+t2bASl9mQ/Gb2AfPqiFsG0dZmKxwP7aa/25h01ZucHTc c39j234nXxQ1po5j00PoaA0Ya5yeCQ3edFdBMSPorPTdYLVGuHWSA4qdVQdf6mq4 /luSIkMp/MUygqEMCvT9/elaRjCG1dJ9RE4JBXOCtK5CgkCxN+MdnVrTguGeWTtc UV2rwNTZA+4KZouegDQPeHb2qKoQRuNWLdM07/yvCE5rVDJBiAem+MYOjJ3LHsP2 nB3Vfff2zmC6mp+544aQIKFtu0RC2IVU+AbcdmRV6yDwbNK3/wZb3ZV1LcOZ5Z1h 9m5uINreq1R54FnjA1xaYPmWMutN8jVYn2SBPfLA11dKh0sFwsjS4PkUPH1fbAOi nmjwtd7r1z6AyoaP12XIrXGkTNSx8bMHQ9twfWq4D8IqbefMYtrkh896F/wfTIQI nT0FGeDL3gCafpW+wkGQT78tVMZXCAIx2rb+C3sZd/KcQzVCMcgbfFY6R5LnrYVf k+M6CsM0ZyAfIyMpkEFwruMAV0zYQ6NAMhFL4muiyRjY4UA2YvtLhPrNjOp5LAi0 EfbvhcGcDQeh4W45ljuv =HOqP -----END PGP SIGNATURE-----

Jan. 4, 2011