January 2011 - Wine-Devel - list.winehq.org

Re: 64-bit Notepad2 crashes

by David Laight

On Fri, Dec 31, 2010 at 06:14:52PM -0700, James McKenzie wrote: > > set | grep LIBRARY > LD_LIBRARY_PATH=/Applications/Wine.app/Contents/Resources/Lib > > is what I get on my Mac (LD_LIBRARY_PATH has to be set due to the > UNIXness of Wine.) Really a properly linked elf binary shouldn't need LD_LIBRARY_PATH be set in order to find its libraries. LD_LIBRARY_PATH should only be used to override the default assignments. (Linux has a complete fubar here, and you have to do something obscure to get LD_LIBRARY_PATH to override the info in the elf image.) If you run 'objdump -p program' the RPATH entries show which which directories are searched. Additionally $ORIGIN can be used (in RPATH) entries to refer to the directory that contains the program binary. The RPATH entries typically need to be different for 32bit and 64bit binaries on a 64bit system. The library names are shown in the NEEDED entries (the value comes from the soname property of the library found when linking the program. This is usually just foo.so, but can contain directory names. David -- David Laight: david(a)l8s.co.uk

Jan. 1, 2011

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by maury loïc

On Sat, Jan 1, 2011 at 2:22 AM, James McKenzie <jjmckenzie51(a)earthlink.net>wrote: > On 12/31/10 1:50 PM, Charles Davis wrote: > >> On 12/31/10 1:11 PM, Ken Thomases wrote: >> >>> I should add that this patch seem correct to me. It couldn't hurt to get >>> Charles Davis's input, of course. >>> >> I agree, for now. He should at least put a comment in to the effect of >> "if we got this far, there's already media in the drive." >> > That was the point I was trying to get to. Based on Ken's comment below, > the device is temporary and only exists for the time period that the device > is in use. > > MSDN documents that the purpose of IOCTL_*_CHECK_VERIFY is to check if the >>> media has changed. The Linux and FreeBSD implementations basically just >>> check if there's media in the drive. On Mac OS X, the BSD device file just >>> plain doesn't exist unless and until there's media mounted. There's no >>> permanent BSD device file for the drive itself. So, if CDROM_Verify() is >>> called, which requires that the BSD device file is opened and thus is >>> present, that by itself implies that there's media in the drive. Therefore, >>> CDROM_Verify() should just return success. >>> >> Makes sense. But the 'right' way to implement this on Mac OS is to ask >> DiskArbitration to tell us when the media changes. (In fact, the right >> way to implement this elsewhere is to ask udev or hald the same thing.) >> Then we can return STATUS_VERIFY_REQUIRED (as documented) when the media >> actually has changed. For now, though, Loïc's patch is OK. >> > Is this going to be changed sometime in the future to work per the > documentation? > > AJ wants to eventually move some (all?) of the disk/CD/DVD/storage >> IOCTLs into mountmgr anyway, where Wine's fake storage drivers are >> hosted. Mountmgr already has infrastructure in place to talk to DA on >> Mac OS and to hald on Linux/FreeBSD, so doing this the 'right' way will >> be much easier there. >> > This is a good point. Maybe the effort should be to move the code over to > mountmgr.sys rather than implement and have to move it later. > > And I am aware what the process is, I was asking general questions based on > what the comments were in the patch. Basically, the comments did not make > sense to me and I was asking for clarification. That was provided by both > Ken and Charles' comments. > > James McKenzie > > > > Hello Mr.McKenzie and Wine community, Happy new years. In fact, I don't try to resolve the SCSI command ioctl, to support the cd-rom, I have just modified the CDROM_Verify(), because I thought, this function verify if the media is present in the device. Here my reasoning : in dll/ntdll/cdrom.c, we are in the function CDROM_DeviceIoControl(). get_parent_device() is called to get the device and Wine try to open the device. For what I understood, Mac Os will create an entry object into the I/O Registry, who represent our device, (the device exist at boot time or when it is plugged). get_parent_device() will find the object, and store the name of device. After the device is found, Wine try to open it. In the case of IOCTL_*_CHECK_VERIFY request, CDROM_Verify is called, In this function, we already know we have a valid device, in use, but if the device is present, the media is present too, we can not have a file descriptor to a device, without media present. merci Loïc

Jan. 1, 2011

Re: happy new year!

by Tom Wickline

Happy New Year to everyone! May office 2010 run in 2011 :) On Sat, Jan 1, 2011 at 1:43 PM, Dan Kegel <dank(a)kegel.com> wrote: > May all your tests be green, and all your patches pass peer review :-) > > > -- Wine is not a conclusion but a process...

Jan. 1, 2011

happy new year!

by Dan Kegel

May all your tests be green, and all your patches pass peer review :-)

Jan. 1, 2011

Re: 64-bit Notepad2 crashes

by James McKenzie

On 12/31/10 6:19 PM, Dan Kegel wrote: > 'set' is not a good way to check the environment, since it also shows > shell variables that are not yet exported. > > The portable way to check the environment is 'env'. > True. Let me check this. correction: env | grep LIBRARY James McKenzie

Jan. 1, 2011

Re: NEW: Arabic Translation support in User32.dll (Basic Support)

by Andrew Nguyen

On 12/31/2010 08:41 AM, Nowres wrote: > Hello, > > here's a basic support for Arabic language in user32.dll > work in progress in other programs to complete support for this language. > > Nowres Rafid. > > > > Changes should be sent as a patch in unified diff format, preferably generated with Git. See http://wiki.winehq.org/SubmittingPatches for detailed guidelines.

Jan. 1, 2011

Re: ntdll/cdrom : implement CDROM_Verify to work on Mac Os

by James McKenzie

On 12/31/10 1:50 PM, Charles Davis wrote: > On 12/31/10 1:11 PM, Ken Thomases wrote: >> I should add that this patch seem correct to me. It couldn't hurt to get Charles Davis's input, of course. > I agree, for now. He should at least put a comment in to the effect of > "if we got this far, there's already media in the drive." That was the point I was trying to get to. Based on Ken's comment below, the device is temporary and only exists for the time period that the device is in use. >> MSDN documents that the purpose of IOCTL_*_CHECK_VERIFY is to check if the media has changed. The Linux and FreeBSD implementations basically just check if there's media in the drive. On Mac OS X, the BSD device file just plain doesn't exist unless and until there's media mounted. There's no permanent BSD device file for the drive itself. So, if CDROM_Verify() is called, which requires that the BSD device file is opened and thus is present, that by itself implies that there's media in the drive. Therefore, CDROM_Verify() should just return success. > Makes sense. But the 'right' way to implement this on Mac OS is to ask > DiskArbitration to tell us when the media changes. (In fact, the right > way to implement this elsewhere is to ask udev or hald the same thing.) > Then we can return STATUS_VERIFY_REQUIRED (as documented) when the media > actually has changed. For now, though, Loïc's patch is OK. Is this going to be changed sometime in the future to work per the documentation? > AJ wants to eventually move some (all?) of the disk/CD/DVD/storage > IOCTLs into mountmgr anyway, where Wine's fake storage drivers are > hosted. Mountmgr already has infrastructure in place to talk to DA on > Mac OS and to hald on Linux/FreeBSD, so doing this the 'right' way will > be much easier there. This is a good point. Maybe the effort should be to move the code over to mountmgr.sys rather than implement and have to move it later. And I am aware what the process is, I was asking general questions based on what the comments were in the patch. Basically, the comments did not make sense to me and I was asking for clarification. That was provided by both Ken and Charles' comments. James McKenzie

Jan. 1, 2011

re: 64-bit Notepad2 crashes

by Dan Kegel

'set' is not a good way to check the environment, since it also shows shell variables that are not yet exported. The portable way to check the environment is 'env'.

Jan. 1, 2011

Re: 64-bit Notepad2 crashes

by James McKenzie

On 12/31/10 11:56 AM, Hin-Tak Leung wrote: > Susan Cragin wrote: >>>>> Does this 'path' exist in LD_LIBRARY_PATH or equivilent? >>>>> >>>>> Otherwise ld might not be able to 'find' it when starting the >>>>> program. >>>>> >>>>> James McKenzie >>>>> >>>> James... >>>> You've just exhausted my technical knowledge. How do I do / find that? >>> Susan: >>> >>> For the BASH shell: >>> Type in set and look for the LD_LIBRARY_PATH line. >>> for the CSH/KSH shell: >>> Type in env >>> Look for the LD_LIBRARY_PATH line. >>> >>> Hopefully, /usr/local/lib is there. >>> >>> BTW, to make Wine work on a Mac, I have to add this line.... >>> >>> James McKenzie >> >> Typed "set" >> Did word search on "library." >> Nothing. > > for BASH, it should be > export | grep LD_LIBRARY_PATH > not "set". > > > If you are setting the value, not searching for it. set | grep LIBRARY LD_LIBRARY_PATH=/Applications/Wine.app/Contents/Resources/Lib is what I get on my Mac (LD_LIBRARY_PATH has to be set due to the UNIXness of Wine.) James McKenzie

Jan. 1, 2011