October 2011 - Wine-Devel - list.winehq.org

Re: 80199: shdocvw: add a stub for InstallReg_RunDLL

by Austin English

On Thu, Oct 20, 2011 at 15:55, Dan Kegel <dank(a)kegel.com> wrote: > Fails to build here? > > On Thu, Oct 20, 2011 at 3:51 PM, <buildbot(a)kegel.com> wrote: >> This is an experimental automated build and test service. >> Please feel free to ignore this email while we work the kinks out. >> >> For more info about this message, see http://wiki.winehq.org/BuildBot >> >> The Buildbot has detected a failed build on builder runtests-default while building Wine. >> Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/803 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) >> BUILD FAILED: failed shell_2 >> >> Errors: >> shdocvw_main.c: In function 'InstallReg_RunDLL': >> shdocvw_main.c:547:159: error: format '%p' expects a matching 'void *' argument [-Werror=format] >> shdocvw_main.c:547:159: error: format '%p' expects a matching 'void *' argument [-Werror=format] >> make[1]: *** [shdocvw_main.o] Error 1 >> make: *** [dlls/shdocvw] Error 2 >> make: *** Waiting for unfinished jobs.... Resent, thanks. -- -Austin

Oct. 31, 2011

Re: [PATCH 2/5] ddraw: Implement copy_mipmap_chain() on top of wined3d_surface_blt().

by Henri Verbeet

On 31 October 2011 15:04, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > On Sunday 30 October 2011 18:06:33 Henri Verbeet wrote: >> + if (FAILED(hr = >> wined3d_surface_blt(dest_level->wined3d_surface, &dst_rect, >> + src_level->wined3d_surface, &src_rect, 0, NULL, >> WINED3DTEXF_POINT))) > Wouldn't wined3d_device_update_surface be a better match? No, the patch actually removes that code.

Oct. 31, 2011

Re: [PATCH 2/5] ddraw: Implement copy_mipmap_chain() on top of wined3d_surface_blt().

by Stefan Dösinger

On Sunday 30 October 2011 18:06:33 Henri Verbeet wrote: > + if (FAILED(hr = > wined3d_surface_blt(dest_level->wined3d_surface, &dst_rect, > + src_level->wined3d_surface, &src_rect, 0, NULL, > WINED3DTEXF_POINT))) Wouldn't wined3d_device_update_surface be a better match? IDirect3DDevice7::Load could probably be handled by wined3d_device_update_texture if it wasn't for color keys/palettes.

Oct. 31, 2011

RFC: Make X11 window rect empty for WS_EX_TRANSPARENT windows

by Octavian Voicu

Hi, Attached patch fixes http://bugs.winehq.org/show_bug.cgi?id=28678. The root problem is that X11 windows cannot be made transparent (allowing other windows to draw over them). My approach I to make the X11 window with WS_EX_TRANSPARENT extended style have an empty region. Obviously, this is very hacky and except for very particular cases (like the bug I'm trying to fix) it won't work at all, so this patch is more like a proof-of-concept than a fix. For example, window decorations aren't drawn and not even the window can paint itself. This becomes kind of a recursive question -- how to draw the contents of the window-less window? Can this approach ever work? Any comments or suggestions are welcome. Octavian

Oct. 30, 2011

d3dx9_36: Simplify the computation of a 2-adic valuation

by David Adam

Hello, please discard this patch. It is logically wrong. David

Oct. 29, 2011

Re: cmd: Avoid mixing signed and unsigned type in conditional expression

by Frédéric Delanoy

2011/10/27 Michael Stefaniuc <mstefani(a)redhat.com>: > On 10/27/2011 02:09 PM, Frédéric Delanoy wrote: >> On Thu, Oct 27, 2011 at 08:38, Eric Pouech <eric.pouech(a)orange.fr> wrote: >>> why do we check for ptr being null or not, when we deref ptr one line above? >> >>>> if (*ptr == '\n') ptr++; >>>> - WCMD_output_asis_len(message, (ptr) ? ptr - message : >>>> strlenW(message), handle); >>>> + WCMD_output_asis_len(message, (ptr) ? (DWORD)(ptr - message) : >>>> strlenW(message), handle); >>>> if (ptr) { >>>> numChars = 0; >>>> if (++line_count >= max_height - 1) { >> >> It's dereferenced but incremented afterwards, so might be null after that line > Only if ptr wraps around ;) Yeah right. Don't know where I saw a * before the ptr in (ptr)...

Oct. 28, 2011

Re: [PATCH 1/2] include: Add a few defines to winscard.h (try 2)

by Bruno Jesus

2011/10/28 André Hentschel <nerv(a)dawncrow.de>: > Am 28.10.2011 19:42, schrieb Bruno Jesus: > ... > btw: if there is no dependencies than you don't need numbered patchsets Agreed. Sorry again. Best wishes, Bruno

Oct. 28, 2011

Re: [PATCH 1/2] include: Add a few defines to winscard.h (try 2)

by André Hentschel

Am 28.10.2011 19:42, schrieb Bruno Jesus: > On Fri, Oct 28, 2011 at 15:01, Alexandre Julliard <julliard(a)winehq.org> wrote: >> Bruno Jesus <00cpxxx(a)gmail.com> writes: >> >>> +/* Max ATR size defined by ISO-7816 */ >>> +#define MAX_ATR_SIZE 33 >> >> I don't see that one in my PSDK, where does it come from? > > My bad, apologies. I copied it from Vincent Hardy patch series but in > fact the variable should be name SCARD_ATR_LENGTH and should be in > winsmcrd.h. I'm still not using these defines yet so if possible I > would like the [2/2] to be commited if no mistakes are found in it, btw: if there is no dependencies than you don't need numbered patchsets -- Best Regards, André Hentschel

Oct. 28, 2011

Re: [PATCH 1/2] include: Add a few defines to winscard.h (try 2)

by Bruno Jesus

On Fri, Oct 28, 2011 at 15:01, Alexandre Julliard <julliard(a)winehq.org> wrote: > Bruno Jesus <00cpxxx(a)gmail.com> writes: > >> +/* Max ATR size defined by ISO-7816 */ >> +#define MAX_ATR_SIZE 33 > > I don't see that one in my PSDK, where does it come from? My bad, apologies. I copied it from Vincent Hardy patch series but in fact the variable should be name SCARD_ATR_LENGTH and should be in winsmcrd.h. I'm still not using these defines yet so if possible I would like the [2/2] to be commited if no mistakes are found in it, I'll resend this one later. Best wishes, Bruno

Oct. 28, 2011

Re: [PATCH 1/2] include: Add a few defines to winscard.h (try 2)

by Alexandre Julliard

Bruno Jesus <00cpxxx(a)gmail.com> writes: > +/* Max ATR size defined by ISO-7816 */ > +#define MAX_ATR_SIZE 33 I don't see that one in my PSDK, where does it come from? -- Alexandre Julliard julliard(a)winehq.org

Oct. 28, 2011