October 2011 - Wine-Devel - list.winehq.org

kernel32: Update English resource

by Ken Sharp

I suspect this is the wrong way to update the US English resource for an .mc file. Could anyone comment? Thanks

Oct. 28, 2011

Re: basic_ifstream implementation

by Frédéric Delanoy

On Fri, Oct 28, 2011 at 01:30, Josh Juran <josh(a)iswifter.net> wrote: > I appreciate your (and others') willingness to provide feedback. Unfortunately, my job in this case is to make certain apps work (by hack or by crack) and move on. What you could do is add/update the AppDB entry for this program, and link to your bug (hence patch). Frédéric

Oct. 28, 2011

Re: Antw.: signal_arc.c failing to cross-compile

by Roger Cruz

Thanks Andre, I realize that I'm breaking some new ground here and I don't mind doing the legwork. I just like to first post to make sure someone hasn't already tried this and found a solution before I spend too much time on it. It looks like you have been trying to cross-compile for Android as well. I'm guessing you must have hit this missing header file as well? Regards, Roger R. Cruz On Oct 28, 2011, at 3:05 AM, "André Hentschel" <nerv(a)dawncrow.de> wrote: > Thats not a problem of cross compiling to ARM, but of android. Android is not Linux, not fully. Maybe i can find a solution, but only maybe. BTW all the problems you will find are Android specific. > > Gesendet mit meinem HTC > > ----- Reply message ----- > Von: "Roger Cruz" <roger_r_cruz(a)yahoo.com> > An: "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> > Betreff: signal_arc.c failing to cross-compile > Datum: Fr., Okt. 28, 2011 06:46 > > > Hi Andre et al, > > Wondering if any of you know how to get around this? The compiler is barfing at the lack of ucontext_t when doing a typedef of SIGCONTEXT. > > Thanks in advance, > > Roger R. Cruz > > arm-linux-androideabi-gcc -c -I/home/rcruz/sandbox/wine-dev-branch/dlls/ntdll -I. -I/home/rcruz/sandbox/wine-dev-branch/include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -o signal_arm.o /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:69: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'SIGCONTEXT' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: warning: type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: error: expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:149: error: expected declaration specifiers or '...' before 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'restore_context': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: 'sigcontext' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: (Each undeclared identifier is reported only once > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: for each function it appears in.) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: At top level: > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: warning: type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: error: expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: warning: type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: error: expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:364: error: expected ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'segv_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: 'SIGCONTEXT' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: 'context' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:545: warning: ISO C90 forbids mixed declarations and code > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:556: warning: implicit declaration of function 'setup_exception_record' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'trap_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:608: warning: implicit declaration of function 'save_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:615: error: too many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'fpe_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:629: warning: implicit declaration of function 'save_fpu' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:683: error: too many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:684: warning: implicit declaration of function 'restore_fpu' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'int_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:708: error: too many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'abrt_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:732: error: too many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'usr1_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:758: error: too many arguments to function 'restore_context' > make[1]: *** [signal_arm.o] Error 1

Oct. 28, 2011

Re: ntdll: Make the VirtualProtect tests pass under Wine. Resend.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Updated to current git. > --- > dlls/kernel32/tests/virtual.c | 16 ---------------- > dlls/ntdll/virtual.c | 3 +++ > 2 files changed, 3 insertions(+), 16 deletions(-) This completely breaks Wine here. There are several places where we use WRITECOPY for protections, they would have to be fixed first. -- Alexandre Julliard julliard(a)winehq.org

Oct. 28, 2011

Re: signal_arc.c failing to cross-compile

by Paul Chitescu

Hi! Android is hopeless, its C library (bionic) is a very trimmed down and bug ridden version of the BSD library. The Android devel team is not willing to fix any bugs unless they affect native Android applications or Dalvik. In particular the .so loader and related initialization is broken. dlopen() doesn't properly call initializers, dlclose() doesn't work at all. Unless a proper C library is installed on the target systems (and a matching cross-toolchain used for compiling) there are no chances wine will run on Android. Many of the libraries required for Wine will not work properly with bionic even if they may compile. Paul On Friday 28 October 2011 07:46:26 am Roger Cruz wrote: > Hi Andre et al, > > Wondering if any of you know how to get around this? The compiler is > barfing at the lack of ucontext_t when doing a typedef of SIGCONTEXT. > > Thanks in advance, > > Roger R. Cruz > > > arm-linux-androideabi-gcc -c > -I/home/rcruz/sandbox/wine-dev-branch/dlls/ntdll -I. > -I/home/rcruz/sandbox/wine-dev-branch/include -I../../include > -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe > -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement > -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings > -Wpointer-arith -Wlogical-op -g -O2 -o signal_arm.o > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:69: error: > expected '=', ',', ';', 'asm' or '__attribute__' before 'SIGCONTEXT' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: warning: > type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: error: > expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:149: error: > expected declaration specifiers or '...' before 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'restore_context': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: > 'sigcontext' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: > (Each undeclared identifier is reported only once > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: for > each function it appears in.) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: At top level: > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: warning: > type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: error: > expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: warning: > type defaults to 'int' in declaration of 'ucontext_t' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: error: > expected ';', ',' or ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:364: error: > expected ')' before '*' token > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'segv_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: > 'SIGCONTEXT' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: > 'context' undeclared (first use in this function) > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:545: warning: > ISO C90 forbids mixed declarations and code > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:556: warning: > implicit declaration of function 'setup_exception_record' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'trap_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:608: warning: > implicit declaration of function 'save_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:615: error: too > many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'fpe_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:629: warning: > implicit declaration of function 'save_fpu' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:683: error: too > many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:684: warning: > implicit declaration of function 'restore_fpu' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'int_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:708: error: too > many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'abrt_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:732: error: too > many arguments to function 'restore_context' > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function > 'usr1_handler': > /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:758: error: too > many arguments to function 'restore_context' make[1]: *** [signal_arm.o] > Error 1

Oct. 28, 2011

Antw.: signal_arc.c failing to cross-compile

by André Hentschel

Thats not a problem of cross compiling to ARM, but of android. Android is not Linux, not fully. Maybe i can find a solution, but only maybe. BTW all the problems you will find are Android specific. Gesendet mit meinem HTC ----- Reply message ----- Von: "Roger Cruz" <roger_r_cruz(a)yahoo.com> An: "wine-devel(a)winehq.org" <wine-devel(a)winehq.org> Betreff: signal_arc.c failing to cross-compile Datum: Fr., Okt. 28, 2011 06:46 Hi Andre et al, Wondering if any of you know how to get around this? The compiler is barfing at the lack of ucontext_t when doing a typedef of SIGCONTEXT. Thanks in advance, Roger R. Cruz arm-linux-androideabi-gcc -c -I/home/rcruz/sandbox/wine-dev-branch/dlls/ntdll -I. -I/home/rcruz/sandbox/wine-dev-branch/include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -o signal_arm.o /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:69: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'SIGCONTEXT' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: warning: type defaults to 'int' in declaration of 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: error: expected ';', ',' or ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:149: error: expected declaration specifiers or '...' before 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'restore_context': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: 'sigcontext' undeclared (first use in this function) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: (Each undeclared identifier is reported only once /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: for each function it appears in.) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: At top level: /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: warning: type defaults to 'int' in declaration of 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: error: expected ';', ',' or ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: warning: type defaults to 'int' in declaration of 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: error: expected ';', ',' or ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:364: error: expected ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'segv_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: 'SIGCONTEXT' undeclared (first use in this function) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: 'context' undeclared (first use in this function) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:545: warning: ISO C90 forbids mixed declarations and code /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:556: warning: implicit declaration of function 'setup_exception_record' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'trap_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:608: warning: implicit declaration of function 'save_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:615: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'fpe_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:629: warning: implicit declaration of function 'save_fpu' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:683: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:684: warning: implicit declaration of function 'restore_fpu' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'int_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:708: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'abrt_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:732: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'usr1_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:758: error: too many arguments to function 'restore_context' make[1]: *** [signal_arm.o] Error 1

Oct. 28, 2011

signal_arc.c failing to cross-compile

by Roger Cruz

Hi Andre et al, Wondering if any of you know how to get around this? The compiler is barfing at the lack of ucontext_t when doing a typedef of SIGCONTEXT. Thanks in advance, Roger R. Cruz arm-linux-androideabi-gcc -c -I/home/rcruz/sandbox/wine-dev-branch/dlls/ntdll -I. -I/home/rcruz/sandbox/wine-dev-branch/include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -o signal_arm.o /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:69: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'SIGCONTEXT' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: warning: type defaults to 'int' in declaration of 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:127: error: expected ';', ',' or ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:149: error: expected declaration specifiers or '...' before 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'restore_context': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: 'sigcontext' undeclared (first use in this function) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: (Each undeclared identifier is reported only once /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:153: error: for each function it appears in.) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: At top level: /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: warning: type defaults to 'int' in declaration of 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:170: error: expected ';', ',' or ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: warning: type defaults to 'int' in declaration of 'ucontext_t' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:181: error: expected ';', ',' or ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:364: error: expected ')' before '*' token /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'segv_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: 'SIGCONTEXT' undeclared (first use in this function) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:544: error: 'context' undeclared (first use in this function) /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:545: warning: ISO C90 forbids mixed declarations and code /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:556: warning: implicit declaration of function 'setup_exception_record' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'trap_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:608: warning: implicit declaration of function 'save_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:615: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'fpe_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:629: warning: implicit declaration of function 'save_fpu' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:683: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:684: warning: implicit declaration of function 'restore_fpu' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'int_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:708: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'abrt_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:732: error: too many arguments to function 'restore_context' /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c: In function 'usr1_handler': /home/rcruz/sandbox/wine-dev-branch/dlls/ntdll/signal_arm.c:758: error: too many arguments to function 'restore_context' make[1]: *** [signal_arm.o] Error 1

Oct. 28, 2011

Re: basic_ifstream implementation

by Josh Juran

On Oct 27, 2011, at 12:35 AM, Piotr Caban wrote: > On 10/27/11 2:01 AM, Josh Juran wrote: >> On Oct 26, 2011, at 11:59 AM, Josh Juran wrote: >> >>> I'm ready to begin work on a basic_ifstream implementation for Wine, which is needed for the game Vampire Secrets among others. > In order to implement it correctly lots of functions/classes needs to be implemented first. I've started stubbing some of them but there's still lots to be done. >>> Well, it turns out that the game creates an ifstream for its intro movie and then uses a completely different mechanism to read from it. Defining a (nearly) empty constructor and destructor for basic_ifstream<char> was sufficient to make things work. > It may happen because of inlining some functions. I don't understand this explanation. Most games don't have this issue. It looks like the developer was originally using ifstream to read the file and then switched to something else, but forgot to remove the ifstream object definition. > The game may also use created streams later. Possible in theory, but unlikely. > It's not good to add an incomplete structure. We'll end having lots of bugs that will need to be debugged to find where the problem is. Especially adding uninitialized vtable pointer is not a good idea. I agree that this patch should not go into Wine as is. > I think it should be implemented by adding all fstream class dependencies first. Thanks to it it will be possible to create a complete basic_ifstream_char structure. I appreciate your (and others') willingness to provide feedback. Unfortunately, my job in this case is to make certain apps work (by hack or by crack) and move on. Josh

Oct. 27, 2011

Re: cmd: Avoid mixing signed and unsigned type in conditional expression

by Michael Stefaniuc

On 10/27/2011 02:09 PM, Frédéric Delanoy wrote: > On Thu, Oct 27, 2011 at 08:38, Eric Pouech <eric.pouech(a)orange.fr> wrote: >> why do we check for ptr being null or not, when we deref ptr one line above? > >>> if (*ptr == '\n') ptr++; >>> - WCMD_output_asis_len(message, (ptr) ? ptr - message : >>> strlenW(message), handle); >>> + WCMD_output_asis_len(message, (ptr) ? (DWORD)(ptr - message) : >>> strlenW(message), handle); >>> if (ptr) { >>> numChars = 0; >>> if (++line_count >= max_height - 1) { > > It's dereferenced but incremented afterwards, so might be null after that line Only if ptr wraps around ;) bye michael

Oct. 27, 2011

Re: cmd: Avoid mixing signed and unsigned type in conditional expression

by Frédéric Delanoy

2011/10/27 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > On Thu, Oct 27, 2011 at 08:38, Eric Pouech <eric.pouech(a)orange.fr> wrote: >> why do we check for ptr being null or not, when we deref ptr one line above? > >>> if (*ptr == '\n') ptr++; >>> - WCMD_output_asis_len(message, (ptr) ? ptr - message : >>> strlenW(message), handle); >>> + WCMD_output_asis_len(message, (ptr) ? (DWORD)(ptr - message) : >>> strlenW(message), handle); >>> if (ptr) { >>> numChars = 0; >>> if (++line_count >= max_height - 1) { > > It's dereferenced but incremented afterwards, so might be null after that line Of course if (*ptr != '\n') the check is unnecessary. I guess the original author simply wanted to merge both cases. Might need some reorganization, but that's probably outside of the scope of this patch

Oct. 27, 2011