November 2011 - Wine-Devel - list.winehq.org

Re: [4/5] ntdll: Remove an invalid test.

by Dmitry Timoshkov

Alexandre Julliard <julliard(a)winehq.org> wrote: > > The test initializers that call GetProcAddress() do write to the same section > > where the static buffer resides, which leads to the image section protection > > change. > > That doesn't make the test invalid. Correct, it makes it todo_wine. Shoudl I resend the whole set, or will you do a favour for me and mark the test as todo? -- Dmitry.

Nov. 22, 2011

Re: [4/5] ntdll: Remove an invalid test.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > On the second thought I think that the test is really invalid, it depends on > the linker to put both the static buffer and the changed data (API pointers) > in the same page of the same section in a PE binary. That still doesn't make it invalid. You can write to the variable if you want to make sure it's modified. -- Alexandre Julliard julliard(a)winehq.org

Nov. 22, 2011

Re: po: Update French translation

by Francois Gouget

On Mon, 21 Nov 2011, Frédéric Delanoy wrote: [...] > msgid "%1!u!MB used, %2!u!MB available" > -msgstr "%u MB utilisés, %u MB disponibles" > +msgstr "%1!u! MB utilisés, %2!u! MB disponibles" [...] > msgctxt "unit kilobyte" > msgid "kB" > -msgstr "" > +msgstr "kB" > > #: winefile.rc:122 > msgctxt "unit megabyte" > msgid "MB" > -msgstr "" > +msgstr "MB" > > #: winefile.rc:123 > msgctxt "unit gigabyte" > msgid "GB" > -msgstr "" > +msgstr "GB" kB, MB and GB should be translated to ko, Mo and Go respectively. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: the choice of a GNU generation

Nov. 22, 2011

Re: [4/5] ntdll: Remove an invalid test.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > The test initializers that call GetProcAddress() do write to the same section > where the static buffer resides, which leads to the image section protection > change. That doesn't make the test invalid. -- Alexandre Julliard julliard(a)winehq.org

Nov. 22, 2011

Re: [PATCH] wininet: Initialize netconn_stream's content_length

by Jacek Caban

Hi Andy, On 11/22/11 5:49 AM, Andy Clayton wrote: > The size that net_conn_read reads is limited by netconn_stream's > remaining content_length, so if the content_length is zero it reads > nothing. It also means that the read size it returns is 0, which > typically indicates that the socket was closed. As a result of the > change from 193da884ad9b982d9b740b15453aa8d3c19b054f, > HTTP_ReceiveRequestData acts on the read size of 0 and closes the > connection. HttpSendRequest calls HTTP_ReceiveRequestData if there is no > post data, closing the connection with none of the response data ever > being read. > > This patch fixes this case by initializing netconn_stream's > content_length to ~0. > > Fixes http://bugs.winehq.org/show_bug.cgi?id=27816 > This doesn't seem right. At the point where we call HTTP_ReceiveRequestData, content_length is supposed to be set based on response header. The bug must be somewhere else. Jacek

Nov. 22, 2011

Re: [PATCH] dxgi: 0 / 0 means 0 for a DXGI_RATIONAL

by Henri Verbeet

On 22 November 2011 00:42, Eduard - Gabriel Munteanu <eduard.munteanu(a)linux360.ro> wrote: > This fixes a division by zero generated in Unigine Tropics in D3D10 > mode. It also adds a helper to handle such conversions, which takes the > form of a macro so we don't need to worry about the result's type. > I'd prefer an actual function. A small test for this probably wouldn't hurt either.

Nov. 22, 2011

Re: user32: Fix 64-bit 'msg' test hang in test_timers (try 2).

by Dmitry Timoshkov

"Erich E. Hoover" <ehoover(a)mines.edu> wrote: > > Why not use kernel32.RaiseException (which is always available) instead? > > MSDN indicates that RaiseException is only available starting with > win2k, is it actually safe to use? I used RtlRaiseException because > that's what's used in the ntdll tests and I saw no other exception > raising examples in a quick "grep" though Wine's tests. kernel32.RaiseException is just a wrapper around an ntdll one. I'd expect the kernel32 API be always available despite what MSDN claims. -- Dmitry.

Nov. 22, 2011

Re: user32: Fix 64-bit 'msg' test hang in test_timers (try 2).

by Dmitry Timoshkov

"Erich E. Hoover" <ehoover(a)mines.edu> wrote: > The attached patch changes the test_timers() crash function to use > RtlRaiseException (if available) rather than attempting to write to memory > address 0. This change stops the timer tests from hanging on the 64-bit VM. Why not use kernel32.RaiseException (which is always available) instead? -- Dmitry.

Nov. 22, 2011

Re: winefile: Make it possible to translate the disk size units.

by Dmitry Timoshkov

Jerome Leclanche <adys.wh(a)gmail.com> wrote: > Users who do not understand the meaning of GiB/MiB/kiB are unlikely to > understand GB/MB/kB. I think the "too geeky" bit is a non-issue. > > Personally, I believe kiB is the way to go. Windows is not necessarily > correct in its usage of kB. Most Linux apps also tend to use kiB; > although there's probably no need to take the integration too far. ... > On Mon, Nov 21, 2011 at 4:56 PM, Francois Gouget <fgouget(a)free.fr> wrote: > > On Sat, 19 Nov 2011, Francois Gouget wrote: > > [...] > >> - static const WCHAR sFmtGB[] = {'%', '.', '1', 'f', ' ', 'G', 'B', '\0'}; > >> - static const WCHAR sFmtMB[] = {'%', '.', '1', 'f', ' ', 'M', 'B', '\0'}; > >> - static const WCHAR sFmtkB[] = {'%', '.', '1', 'f', ' ', 'k', 'B', '\0'}; > > > > To be totally correct these should actually be 'GiB', 'MiB' and 'kiB' > > (the code divides by powers of 1024). However that may be too geeky for > > regular users so I'm not sure we want to do that. But now is probably a > > good time to debate this. Personally I think that adding 'GiB', 'MiB' and 'kiB' only adds more confusion than it solves. 1024 bytes per KByte is a historical thing, or if you prefer 'backwards compatibility' thing. Using new abbrevations don't help neither with calculation precision, nor with clarity of terms IMO. And since Windows doesn't use 'GiB', 'MiB' and 'kiB' Wine shouldn't either. -- Dmitry.

Nov. 22, 2011

Re: user32: Fix 64-bit 'msg' test hang in test_timers (try 2).

by Erich E. Hoover

On Mon, Nov 21, 2011 at 9:51 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > "Erich E. Hoover" <ehoover(a)mines.edu> wrote: > > The attached patch changes the test_timers() crash function to use > > RtlRaiseException (if available) rather than attempting to write to memory > > address 0. This change stops the timer tests from hanging on the 64-bit VM. > > Why not use kernel32.RaiseException (which is always available) instead? MSDN indicates that RaiseException is only available starting with win2k, is it actually safe to use? I used RtlRaiseException because that's what's used in the ntdll tests and I saw no other exception raising examples in a quick "grep" though Wine's tests. Erich Hoover ehoover(a)mines.edu

Nov. 22, 2011