February 2011 - Wine-Devel - list.winehq.org

Re: shlwapi/tests: remove win9x hacks (try 2)

by Nikolay Sivov

On 3/1/2011 01:28, Austin English wrote: > Apparently it's flaky on win2k...cleared WTB: > https://testbot.winehq.org/JobDetails.pl?Key=9585 > - /* shlwapi on Win98 SE does not appear to apply delimiters to the output > - * and does not correctly handle extremely large values. */ > - ok(!strcmp(result->kb_size, szBuff) || > - (result->kb_size_broken&& !strcmp(result->kb_size2, szBuff)), > - "Formatted %x%08x wrong: got %s, expected %s\n", > + ok(!strcmp(result->kb_size, szBuff), "Formatted %x%08x wrong: got %s, expected %s\n", > (LONG)(result->value>> 32), (LONG)result->value, szBuff, result->kb_size); I think it's better to keep comments that describe version dependent behaviour even if it's not tested by default now.

Feb. 28, 2011

Re: ntprint/tests: remove win9x hacks

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9577 Your paranoid android. === WNT4WSSP6 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W2KPROSP4 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === WXPPROSP3 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W2K3R2SESP2 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === WVISTAADM (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W2K8SE (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W7PRO (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W7PROX64 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W7PROX64 (64 bit ntprint) === Timeout

Feb. 28, 2011

Re: shlwapi/tests: remove win9x hacks

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9576 Your paranoid android. === W2KPROSP4 (32 bit string) === string: unhandled exception c0000005 at 77C84DD7

Feb. 28, 2011

Fwd: Applications for Mentoring Organizations Now Being Accepted

by Dan Kegel

So, shall I do the honors? ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Feb 28, 2011 at 12:35 PM Subject: Applications for Mentoring Organizations Now Being Accepted To: Google Summer of Code Announce <google-summer-of-code-announce(a)googlegroups.com> Hi all, We're pleased to announce the applications for mentoring organizations for Google Summer of Code 2011 are now being accepted [1]. Please go Melange [2] to apply on behalf of your organization. Please note that the application period [3] closes on 11 March at 23:00 UTC [4]. [1] - http://google-opensource.blogspot.com/2011/02/mentoring-organization-applic… [2] - http://www.google-melange.com [3] - http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/ti… [4] - http://goo.gl/paMZU Cheers, Carol -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Announce" group. To post to this group, send email to google-summer-of-code-announce(a)googlegroups.com. To unsubscribe from this group, send email to google-summer-of-code-announce+unsubscribe(a)googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-summer-of-code-announce?hl=en.

Feb. 28, 2011

Re: Please help me with document extraction.

by Alexandre Julliard

Max TenEyck Woodbury <max(a)mtew.isa-geek.net> writes: > Frankly, I believe embedded documentation is the way to go. It is _not_ > a panacea, but it is better than trying to maintain a separate set of > functional documentation. I have seen cases where it worked. Not great > but OK. I tried the separate document approach and got _very_ > frustrated, and _no_one_ was really interested. As I've explained, embedded documentation is not going to happen. And the reason no one is interested is not because it's separate from the source, it's because documenting the Windows API is a huge and boring task, and there's no real need for it. -- Alexandre Julliard julliard(a)winehq.org

Feb. 28, 2011

Re: Please help me with document extraction.

by André Hentschel

Am 28.02.2011 17:20, schrieb Max TenEyck Woodbury: >> I think the idea of building upon the existing "documentation" somewhere else >> has a better chance than the "deal on the 100" >> > Frankly, I believe embedded documentation is the way to go. It is _not_ > a panacea, but it is better than trying to maintain a separate set of > functional documentation. I have seen cases where it worked. Not great > but OK. I tried the separate document approach and got _very_ > frustrated, and _no_one_ was really interested. Yeah, so let's see how interested people will be in the new aproach. (Also OK might not be enough for Wine) -- Best Regards, André Hentschel

Feb. 28, 2011

Re: Please help me with document extraction.

by Max TenEyck Woodbury

On 02/28/2011 08:08 AM, André Hentschel wrote: > Am 27.02.2011 20:37, schrieb Max TenEyck Woodbury: >> I've picked up Perl in the last couple weeks. An interesting language >> with lots of adopted features. It's been easy to learn, so I think I >> will _not_ need help with the language itself, but I will listen to any >> advice. > > When i started with Wine developing i tackled winemaker which is also in perl. > I also had to learn Perl for it, so i know you situation. Perl is truely cool, > but the "inline" use of RegEx is sometimes confusing (So are $_ and friends) > and i hate to use curly brackets for every "if". > Perl's focus seems to be on compact code. Since I have an existing program to work from, I don't have to learn it all at once. The Perl regex is quite a bit more advanced than some others and I'm happy to learn the new features it present. I find it easy to learn. Curlies are frustrating if you insist on a style that emphasize them, but I think that is due to the conflict between a 'lots of white space' style and the compact philosophy built into the language. The focus should be on the purpose of the code, not on the syntax of the language. >> The c2man.pl code is extensive and sparsely commented. In order to >> understand what it does, I've made a transcription of it with a more >> compact style and lots more comments. I check the rewrite against the >> source code so there should not be any serious errors. There are also a >> number of what I believe to be defects in the original and places where >> my comments may be inappropriate or my style may be very objectionable. >> _This_ is what I need help with. >> >> Would someone be willing to review my rewrite? If so, send me e-mail so >> I can arrange to get a copy of it to you. > > Remember that you won't get one big patch in at once, you need to split it up later. > I was going to try for a whole hog replacement, call it c2man2 or something like that, but I can retro-fit as needed. >> P.S. to AJ et al. >> >> There is a _lot_ of documentation embedded in the wine code, but it is >> hard to find at the moment. I'd like to see it indexed and this is the >> program that does the extraction and indexing. Advice on making this >> new version available and active are in order. >> > > I think the idea of building upon the existing "documentation" somewhere else > has a better chance than the "deal on the 100" > Frankly, I believe embedded documentation is the way to go. It is _not_ a panacea, but it is better than trying to maintain a separate set of functional documentation. I have seen cases where it worked. Not great but OK. I tried the separate document approach and got _very_ frustrated, and _no_one_ was really interested. Max

Feb. 28, 2011

Re: gdi32: Fixes GetDIBits for top-down destination bitmaps (Bug #26236).

by Alexandre Julliard

John Edmonds <pocketcookies2(a)gmail.com> writes: > Resolves Bug #26236. Please update the test cases to catch this. -- Alexandre Julliard julliard(a)winehq.org

Feb. 28, 2011

Re: Please help me with document extraction.

by André Hentschel

Am 27.02.2011 20:37, schrieb Max TenEyck Woodbury: > I've picked up Perl in the last couple weeks. An interesting language > with lots of adopted features. It's been easy to learn, so I think I > will _not_ need help with the language itself, but I will listen to any > advice. When i started with Wine developing i tackled winemaker which is also in perl. I also had to learn Perl for it, so i know you situation. Perl is truely cool, but the "inline" use of RegEx is sometimes confusing (So are $_ and friends) and i hate to use curly brackets for every "if". > The c2man.pl code is extensive and sparsely commented. In order to > understand what it does, I've made a transcription of it with a more > compact style and lots more comments. I check the rewrite against the > source code so there should not be any serious errors. There are also a > number of what I believe to be defects in the original and places where > my comments may be inappropriate or my style may be very objectionable. > _This_ is what I need help with. > > Would someone be willing to review my rewrite? If so, send me e-mail so > I can arrange to get a copy of it to you. Remember that you won't get one big patch in at once, you need to split it up later. > P.S. to AJ et al. > > There is a _lot_ of documentation embedded in the wine code, but it is > hard to find at the moment. I'd like to see it indexed and this is the > program that does the extraction and indexing. Advice on making this > new version available and active are in order. > I think the idea of building upon the existing "documentation" somewhere else has a better chance than the "deal on the 100" -- Best Regards, André Hentschel

Feb. 28, 2011

Re: d3dx9_36: Stub ID3DXRenderToSurface, with tests

by Henri Verbeet

On 27 February 2011 20:22, Misha Koshelev <misha680(a)gmail.com> wrote: > +static HRESULT WINAPI ID3DXRenderToSurfaceImpl_QueryInterface(ID3DXRenderToSurface *iface, REFIID riid, void **ppobj) > +{ > + ID3DXRenderToSurfaceImpl *This = impl_from_ID3DXRenderToSurface(iface); You don't actually need "This" here. > + return D3D_OK; S_OK is more appropriate for QueryInterface. > + WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj); > + return E_NOINTERFACE; > +} You should set "*ppobj" to NULL here, unless there's a reason not to.

Feb. 28, 2011

Re: jscript: Fixed corner cases in parseInt implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9558 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Feb. 28, 2011

Re: Valgrind --malloc-fill=A5 --free-fill=DE crashes Wine

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, Maarten Lankhorst wrote: >> It turns out that malloc-fill is harmless, -free-fill causes havoc currently. >It's most likely a valgrind/wine bug, does this patch work? Yes, that did the job with wine-1.3.12-14. So is it a Valgrind or a Wine bug? Thank you, Jörg Höhle

Feb. 28, 2011

Re: Please help me with document extraction.

by Max TenEyck Woodbury

On 02/27/2011 05:55 PM, Alexandre Julliard wrote: > > ... If you want to prove me wrong, start writing it. Once you > have properly documented 100 functions, we can discuss what > extra infrastructure is needed for the remaining 50,000. > Deal on the 100! Max

Feb. 28, 2011

Re: Please help me with document extraction.

by Alexandre Julliard

Max TenEyck Woodbury <max(a)mtew.isa-geek.net> writes: > I'd also like clarification on why you think it does _not_ belong in > the source code. Some projects insist that documentation _has_ to be > part of the source code so that it will be properly maintained. That's because in most projects the API is defined by the implementation, and when you change the code you want to update the documentation accordingly. The Windows API is defined by Microsoft and is independent of the Wine source. If you want to store it along with the code you'd have to put it inside the Windows source. The other reason is that a decent documentation of the Windows API would be huge; look at how much information there is on MSDN, and that's still incomplete. It's completely impossible to maintain something of that size in the middle of the source code. As long as it's inside the source, it will just be one or two sentences per function, and maybe a list of parameters. That's not useful documentation. The reality is that this is not going to happen; nobody is going to invest the time to write real documentation for even a subset of the API. There's just no point, and MSDN is good enough for most needs. And I'm not interested in developing infrastructure for something that won't happen. If you want to prove me wrong, start writing it. Once you have properly documented 100 functions, we can discuss what extra infrastructure is needed for the remaining 50,000. -- Alexandre Julliard julliard(a)winehq.org

Feb. 27, 2011

Re: gdi32: first look for a printer driver name in the registry (try 6)

by Vitaliy Margolen

On 02/25/2011 10:33 AM, André Hentschel wrote: > Hi, > Now you entirely remove the ini-stuff, why? Where you seeing that? He still calling the same ini function(s) as before. > and why do you use a OR (||) for the registry function? What's the problem with that? Can you actually point to the piece of code that doesn't work correctly? This piece of code: > + if ((RegOpenKeyExW(HKEY_CURRENT_USER, WinNT_CV_devicesW, 0, KEY_READ, &hKey) || > + RegQueryValueExW(hKey, device, NULL, NULL, (LPBYTE) driver, &size)) && > + !GetProfileStringW(devicesW, device, empty_strW, driver, size)) will first try registry, if that fails then try ini, and if that also fails will print warning. Both registry functions return ERROR_SUCCESS (which is 0) on success. Vitaliy.

Feb. 27, 2011

Re: [2/2] msxml3: Reject xmlns attribute to be added to element

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9543 Your paranoid android. === W2KPROSP4 (32 bit domdoc) === domdoc: unhandled exception c0000005 at 90909090 === WXPPROSP3 (32 bit domdoc) === domdoc: unhandled exception c0000005 at 749BCF8E === W2K3R2SESP2 (32 bit domdoc) === domdoc: unhandled exception c0000005 at 90909090 === WVISTAADM (32 bit domdoc) === domdoc: unhandled exception c0000005 at FF85F88B === W2K8SE (32 bit domdoc) === domdoc: unhandled exception c0000005 at FF8B9090 === W7PRO (32 bit domdoc) === domdoc.c:7308: Test failed: got 0x80070057 domdoc.c:7327: Test failed: got 0x00000000 domdoc.c:7351: Test failed: got 0x80070057 domdoc.c:7360: Test failed: got 0x80070057 domdoc.c:7396: Test failed: got 0x80070057 === W7PROX64 (32 bit domdoc) === domdoc.c:7308: Test failed: got 0x80070057 domdoc.c:7327: Test failed: got 0x00000000 domdoc.c:7351: Test failed: got 0x80070057 domdoc.c:7360: Test failed: got 0x80070057 domdoc.c:7396: Test failed: got 0x80070057 === W7PROX64 (64 bit domdoc) === domdoc.c:7308: Test failed: got 0x80070057 domdoc.c:7327: Test failed: got 0x00000000 domdoc.c:7351: Test failed: got 0x80070057 domdoc.c:7360: Test failed: got 0x80070057 domdoc.c:7396: Test failed: got 0x80070057

Feb. 27, 2011

Re: msxml3/tests: Remove broken test and parameter check

by Nikolay Sivov

On 2/27/2011 22:09, Nikolay Sivov wrote: > Test was recently enabled, and it crashes on several machines, > including mine. QueryInterface generally should never check for return > pointer. > Ignore that please, there's another line to remove.

Feb. 27, 2011

Re: Please help me with document extraction.

by Max TenEyck Woodbury

On 02/27/2011 02:49 PM, Alexandre Julliard wrote: > Max TenEyck Woodbury<max(a)mtew.isa-geek.net> writes: > >> P.S. to AJ et al. >> >> There is a _lot_ of documentation embedded in the wine code, but it is >> hard to find at the moment. I'd like to see it indexed and this is the >> program that does the extraction and indexing. Advice on making this >> new version available and active are in order. > > This has already been discussed, but documentation on the Windows API > doesn't belong in the source code. I've been accepting small amounts of > function documentation (which IMHO is pretty much useless) along with > implementations, but I'm not going to accept significantly more than > that. This is why you were directed to do this as a separate project. > But it _does_ belong someplace in the repository and there is already a lot of it embedded. I'm also not sure that what is in there already can really be called documentation of the _Windows_ API. Rather it is documentation of what we _think_ the API is. That is a small but important difference. I'd also like clarification on why you think it does _not_ belong in the source code. Some projects insist that documentation _has_ to be part of the source code so that it will be properly maintained. Max

Feb. 27, 2011

Re: Please help me with document extraction.

by Alexandre Julliard

Max TenEyck Woodbury <max(a)mtew.isa-geek.net> writes: > P.S. to AJ et al. > > There is a _lot_ of documentation embedded in the wine code, but it is > hard to find at the moment. I'd like to see it indexed and this is the > program that does the extraction and indexing. Advice on making this > new version available and active are in order. This has already been discussed, but documentation on the Windows API doesn't belong in the source code. I've been accepting small amounts of function documentation (which IMHO is pretty much useless) along with implementations, but I'm not going to accept significantly more than that. This is why you were directed to do this as a separate project. -- Alexandre Julliard julliard(a)winehq.org

Feb. 27, 2011

Re: [PATCH 1/5] d3dcompiler: Fix SystemValueType for pixelshader output signature.

by Henri Verbeet

2011/2/27 Rico Schüller <kgbricola(a)web.de>: > +static BOOL case_insensitive_compare(const char *s1, const char *s2) Isn't that called strcasecmp()?

Feb. 27, 2011

Please help me with document extraction.

by Max TenEyck Woodbury

As my previous efforts have probably informed you, I am interested in documentation. My initial efforts were _not_ on target and had missed the existing 'c2man.pl' tool. I am in the process of correcting my failure on that. I've picked up Perl in the last couple weeks. An interesting language with lots of adopted features. It's been easy to learn, so I think I will _not_ need help with the language itself, but I will listen to any advice. The c2man.pl code is extensive and sparsely commented. In order to understand what it does, I've made a transcription of it with a more compact style and lots more comments. I check the rewrite against the source code so there should not be any serious errors. There are also a number of what I believe to be defects in the original and places where my comments may be inappropriate or my style may be very objectionable. _This_ is what I need help with. Would someone be willing to review my rewrite? If so, send me e-mail so I can arrange to get a copy of it to you. P.S. to AJ et al. There is a _lot_ of documentation embedded in the wine code, but it is hard to find at the moment. I'd like to see it indexed and this is the program that does the extraction and indexing. Advice on making this new version available and active are in order. Max

Feb. 27, 2011

Patches to fix GetDIBits for top down destination bitmaps

by John Edmonds

Please ignore the patches http://source.winehq.org/patches/data/71716 and http://source.winehq.org/patches/data/71711. I was having trouble with my mail client and accidentally sent the same code 3 times.

Feb. 27, 2011

Re: comctl32: Shed an unused parameter of TOOLTIPS_HitTestT and rename to TOOLTIPS_HitTest.

by James McKenzie

On 2/27/11 1:46 AM, Nikolay Sivov wrote: > On 2/26/2011 23:01, Gerald Pfeifer wrote: >> --- >> dlls/comctl32/tooltips.c | 7 +++---- >> 1 files changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c >> index a2e58e0..445845c 100644 >> --- a/dlls/comctl32/tooltips.c >> +++ b/dlls/comctl32/tooltips.c >> @@ -1396,8 +1396,7 @@ TOOLTIPS_GetToolInfoT (const TOOLTIPS_INFO >> *infoPtr, TTTOOLINFOW *ti, BOOL isW) >> >> >> static LRESULT >> -TOOLTIPS_HitTestT (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW >> lptthit, >> - BOOL isW) >> +TOOLTIPS_HitTest (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW >> lptthit) >> { >> TTTOOL_INFO *toolPtr; >> INT nTool; >> @@ -2209,8 +2208,8 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, >> WPARAM wParam, LPARAM lParam) >> >> case TTM_HITTESTA: >> case TTM_HITTESTW: >> - return TOOLTIPS_HitTestT (infoPtr, (LPTTHITTESTINFOW)lParam, >> - uMsg == TTM_HITTESTW); >> + return TOOLTIPS_HitTest (infoPtr, (LPTTHITTESTINFOW)lParam); >> + >> case TTM_NEWTOOLRECTA: >> case TTM_NEWTOOLRECTW: >> return TOOLTIPS_NewToolRectT (infoPtr, (LPTTTOOLINFOW)lParam); > This should properly handle text instead of removing A/W case. > > Even if all it does is convert ANSI to UNICODE and then call the UNICODE case correct? This is more a question on how I should handle a case I'm working with for riched20, not a comment on this particular piece of code. James McKenzie

Feb. 27, 2011

Re: comctl32: Shed an unused parameter of TOOLTIPS_HitTestT and rename to TOOLTIPS_HitTest.

by Nikolay Sivov

On 2/26/2011 23:01, Gerald Pfeifer wrote: > --- > dlls/comctl32/tooltips.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c > index a2e58e0..445845c 100644 > --- a/dlls/comctl32/tooltips.c > +++ b/dlls/comctl32/tooltips.c > @@ -1396,8 +1396,7 @@ TOOLTIPS_GetToolInfoT (const TOOLTIPS_INFO *infoPtr, TTTOOLINFOW *ti, BOOL isW) > > > static LRESULT > -TOOLTIPS_HitTestT (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit, > - BOOL isW) > +TOOLTIPS_HitTest (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit) > { > TTTOOL_INFO *toolPtr; > INT nTool; > @@ -2209,8 +2208,8 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) > > case TTM_HITTESTA: > case TTM_HITTESTW: > - return TOOLTIPS_HitTestT (infoPtr, (LPTTHITTESTINFOW)lParam, > - uMsg == TTM_HITTESTW); > + return TOOLTIPS_HitTest (infoPtr, (LPTTHITTESTINFOW)lParam); > + > case TTM_NEWTOOLRECTA: > case TTM_NEWTOOLRECTW: > return TOOLTIPS_NewToolRectT (infoPtr, (LPTTTOOLINFOW)lParam); This should properly handle text instead of removing A/W case.

Feb. 27, 2011

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

by Misha Koshelev

On Sat, Feb 26, 2011 at 4:48 PM, Juan Lang <juan.lang(a)gmail.com> wrote: > Hi Misha, > >> My own (very unhelpful) diagnosis of the pattern is that, for the >> mantissa values: >> >> 2018.5 should round to 2018 >> 2019.5 should round to 2020 > > The pattern appears to be "round half to even", which you may read > about on Wikipedia: > http://en.wikipedia.org/wiki/Rounding#Round_half_to_even > --Juan > Thanks Juan. I have implemented this in the patch. I am, unfortunately, still pretty stumped. There are quite a few cases per Matteo's wonderful rounding code for truncation of very small (?) numbers where rounding should _not_ occur. I have included relevant output from running make math.ok for those cases. Note, that it is not the specific mantissa #'s per se (I checked), not even combinations of mantissa #'s and exp's, and not mantissa #'s and exp's and <= 0.25f difference between ((unsigned int) tmp) and (((unsigned int) tmp) & 0x3ff) - I checked all these. There is apparently some pattern in the original single #'s themselves that I am not seeing. If anyone has a keener eye than I let me know. Also, I am assuming a stub of this function would actually not be accepted into Wine (can't return E_NOTIMPL, e.g.). If I am _incorrect_ about this please let me know. Thank you. Have a great Saturday! Misha

Feb. 27, 2011