February 2011 - Wine-Devel - list.winehq.org

Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases. (try 2)

by Janne Hakonen

> This test is safe, but it depends on the caller setting handle to some > value other than INVALID_HANDLE_VALUE. I think it might be safer to > have NotifyAddrChange set the handle value instead, and to mark the > test todo_wine. I'm worried that some other app might assume that the > call to NotifyAddrChange succeeded and attempt to do a wait on an > invalid handle value, resulting in a crash. Yes, sounds reasonable. I'll change that. Thanks, Janne

Feb. 8, 2011

Re: Wine and Summer of Code 2011

by Juan Lang

Hi Dan, > Who's interested in mentoring this year? And can y'all think of any > fresh ideas for the suggested projects list, or ideas that should be > retired? Isn't IUri implemented? That idea looks like it could be retired. Also, the DOS VGA modes idea: how is that affected by the DOSBox integration? --Juan

Feb. 8, 2011

Re: po: Update French translation

by Frédéric Delanoy

2011/2/8 Paul Vriens <paul.vriens.wine(a)gmail.com> > On 02/08/2011 05:28 PM, Frédéric Delanoy wrote: > >> #: avifil32.rc:27 >> +#, fuzzy >> > > Hi, > > Are you adding the 'fuzzy' on purpose? I think that the fuzzy ones are > ignored for translations: > > > http://source.winehq.org/git/wine.git/?a=commitdiff;h=1898f22ca5d2d79750e98… > > -- > Cheers, > > Paul. > "fuzzy" was indeed added on purpose, to mark invalid/not good enough translations. >From the tests I made, it is effectively used by Wine, i.e. the original En string is used as expected. Frédéric

Feb. 8, 2011

Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases. (try 2)

by Juan Lang

Hi Janne, + handle = NULL; + ZeroMemory(&overlapped, sizeof(overlapped)); + overlapped.hEvent = CreateEvent(NULL, FALSE, FALSE, NULL); + ret = gNotifyAddrChange(&handle, &overlapped); + ok(ret == ERROR_IO_PENDING, "NotifyAddrChange returned %d, expected ERROR_IO_PENDING\n", ret); + ok(handle != INVALID_HANDLE_VALUE, "NotifyAddrChange returned invalid file handle\n"); This test is safe, but it depends on the caller setting handle to some value other than INVALID_HANDLE_VALUE. I think it might be safer to have NotifyAddrChange set the handle value instead, and to mark the test todo_wine. I'm worried that some other app might assume that the call to NotifyAddrChange succeeded and attempt to do a wait on an invalid handle value, resulting in a crash. Thanks, --Juan

Feb. 8, 2011

Wine and Summer of Code 2011

by Dan Kegel

http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/fa… says projects can apply starting on Feb 28. In preparation, I moved the 2010 projects from http://wiki.winehq.org/SummerOfCode to http://wiki.winehq.org/SummerOfCode/PreviousProjects I also added a DSS Provider project idea, removed the gstreamer idea since that's implemented, and tidied up the dxdiag idea a bit. Who's interested in mentoring this year? And can y'all think of any fresh ideas for the suggested projects list, or ideas that should be retired? - Dan

Feb. 8, 2011

Re: po: Update French translation

by Paul Vriens

On 02/08/2011 05:28 PM, Frédéric Delanoy wrote: > #: avifil32.rc:27 > +#, fuzzy > msgid "Waveform: %s" > msgstr "Waveform : %s" > > #: avifil32.rc:28 > +#, fuzzy > msgid "Waveform" > msgstr "Waveform" Hi, Are you adding the 'fuzzy' on purpose? I think that the fuzzy ones are ignored for translations: http://source.winehq.org/git/wine.git/?a=commitdiff;h=1898f22ca5d2d79750e98… -- Cheers, Paul.

Feb. 8, 2011

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

by Andrew Eikum

On 02/08/2011 10:48 AM, Loïc Maury wrote: >> First of all set your tab size to 8, and ask your editor to not use tabs >> at all. > I have modified my editor, but I don't know if it 's correct now ? The indentation looks fine to me now. You've got an extra newline after the "if(printer->doc)" block and before the "else." The formatting on the TRACE statement is still bizarre. Fix the commas and put it on just a couple of lines. No reason for one line and a ton of whitespace for each parameter. See line 1944 for an example. Otherwise, two little things I noticed. First, you must also check the return value for HeapAlloc(). Second, you should be using the LIST_FOR_EACH_ENTRY_SAFE macro, which will eliminate the local cursor and cursor2 variables and make the code a little more simple. (Unless there's something I'm missing?) Almost done, nice work :) Andrew

Feb. 8, 2011

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

by Misha Koshelev

On Tue, Feb 8, 2011 at 12:02 AM, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > Misha Koshelev <misha680(a)gmail.com> wrote: > >> +static inline unsigned short float_32_to_16(const float *in) > >> +static inline float float_16_to_32(const unsigned short *in) { > > Is there a reason that you pass a pointer to the helper instead of > a value? Also placing a brace on its own line would follow the style > of other functions. > > -- > Dmitry. > Fair enough. The latter is a Java-ism. How about this one? Thanks Misha

Feb. 8, 2011

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

by Loïc Maury

Hello Mr.Timoshkov, Thank you for your reply. > Loïc Maury<lmaury(a)gmail.com> wrote: > >> After the various comments, I have modified the patch. > First of all set your tab size to 8, and ask your editor to not use tabs > at all. I have modified my editor, but I don't know if it 's correct now ? >> + TRACE("(%s, %s, %p, %d, %d)\n",debugstr_w(printer->name) >> + ,debugstr_w(printer->printername) >> + ,printer->backend_printer >> + ,printer->queue->ref >> + ,list_count(&printer->queue->jobs)); > TRACE() with the API parameters usually is the very first statement in > the API implementation, comma should be placed at the end of the statement, > not before. Ok, I have remplaced this TRACE(). >> + GetPrinterW(hPrinter, 2, NULL, 0,&needed); >> + pi2 = HeapAlloc(GetProcessHeap(), 0, needed); >> + GetPrinterW(hPrinter, 2, (LPBYTE)pi2, needed,&needed); > You need to check the return value of GetPrinterW() and handle the errors. Ok >> + if(pi2) >> + HeapFree(GetProcessHeap(), 0, pi2); > NULL check before HeapFree() is not needed. Ok, I have removed the NULL check. >> + TRACE("return %d\n", ret); > This trace is redundant. Ok, I have removed this TRACE(). I have make an other patch. Thank you Loïc

Feb. 8, 2011

Re: Try to Implement my first Stub function - AbortPrinter() - (try 2).

by Dmitry Timoshkov

Loïc Maury <lmaury(a)gmail.com> wrote: > After the various comments, I have modified the patch. First of all set your tab size to 8, and ask your editor to not use tabs at all. > + TRACE("(%s, %s, %p, %d, %d)\n",debugstr_w(printer->name) > + ,debugstr_w(printer->printername) > + ,printer->backend_printer > + ,printer->queue->ref > + ,list_count(&printer->queue->jobs)); TRACE() with the API parameters usually is the very first statement in the API implementation, comma should be placed at the end of the statement, not before. > + GetPrinterW(hPrinter, 2, NULL, 0, &needed); > + pi2 = HeapAlloc(GetProcessHeap(), 0, needed); > + GetPrinterW(hPrinter, 2, (LPBYTE)pi2, needed, &needed); You need to check the return value of GetPrinterW() and handle the errors. > + if(pi2) > + HeapFree(GetProcessHeap(), 0, pi2); NULL check before HeapFree() is not needed. > + TRACE("return %d\n", ret); This trace is redundant. -- Dmitry.

Feb. 8, 2011

Try to Implement my first Stub function - AbortPrinter() - (try 2).

by Loïc Maury

Hello, After the various comments, I have modified the patch. What do you think ? Thank You Loïc

Feb. 8, 2011

Re: [PATCH 3/5] d3dx9_36: Implemented ID3DXConstantTable_SetVector and ID3DXConstantTable_SetVectorArray

by Matteo Bruni

> + if (is_vertex_shader(This->desc.Version)) > + IDirect3DDevice9_SetVertexShaderConstantF(device, desc.RegisterIndex + i, (float *)fvector, > + desc.RegisterCount); You should probably just use 1 instead of desc.RegisterCount in SetVertexShaderConstantF, as you are already in a loop for each vector. Also, why are you casting a (float *) to a (float *)? Especially after creating a float array just for that. However, making you use a temporary array to convert struct D3DXVECTOR4 to (float *) was somewhat my bad suggestion I believe. My concern was that the structure maybe didn't have its fields packed (with some padding between the fields of the structure for alignment reasons) and just casting the struct pointer to (float *) would not give correct results. Looking at the definition of D3DXVECTOR4 (and assuming it is correct), it appears to not be the case, so you can simply cast it to (float *). Then you can remove the for loop altogether and just set min(count, desc.RegisterCount) registers in the Set{Vertex/Pixel}ShaderConstantF call. Sorry for not being clear enough / giving wrong directions. Please add a "(try n)" suffix to the email subject when you're sending new versions of a patch.

Feb. 8, 2011

Re: [PATCH 2/5] d3dx9_36: Implemented ID3DXConstantTable_SetIntArray and ID3DXConstantTable_SetInt

by Matteo Bruni

> + /* We need the for loop, since we need to convert the integer to a float */ > + for (i = 0; i < count && i < desc.RegisterCount; i++) > + { > + row[0] = (float)n[i]; The cast is unneeded, and the comment above is too.

Feb. 8, 2011

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.

by Dmitry Timoshkov

Marvin <testbot(a)testbot.winehq.org> wrote: > === W7PROX64 (64 bit win) === > win.c:3480: Test failed: SetForegroundWindow() failed That's pretty strange, a standalone test I sent to testbot passed without any failures. -- Dmitry.

Feb. 8, 2011

Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9039 Your paranoid android. === W7PROX64 (64 bit win) === win.c:3480: Test failed: SetForegroundWindow() failed

Feb. 8, 2011

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.

by Nicolas Le Cam

2011/2/8 Jack Edmonds <jack(a)jack-desktop.> > Fixes bug 25698 and addresses one of the test cases in bug 24278 (possibly > resolves bug 24278 but more testing is required to be sure). > > dib.c: Fills BITMAPINFOHEADER with correct width and height when bits == > NULL and copying from a top-to-bottom bitmap. > For top-to-bottom bitmaps, reverses the source pointer rather than the > destination pointer. > Ignoring the case when both source and destination are top-to-bottom > bitmaps and treating this as if the destination is only a top-to-bottom > bitmap. > --- > dlls/gdi32/dib.c | 113 > ++++++++++++++++++++++++--------------------- > dlls/gdi32/tests/bitmap.c | 112 > ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 173 insertions(+), 52 deletions(-) > > diff --git a/dlls/gdi32/dib.c b/dlls/gdi32/dib.c > index 5067e49..bf7a525 100644 > --- a/dlls/gdi32/dib.c > +++ b/dlls/gdi32/dib.c > @@ -636,54 +636,6 @@ INT WINAPI GetDIBits( > > switch (bpp) > { > - case 0: /* query bitmap info only */ > - if (core_header) > - { > - BITMAPCOREHEADER* coreheader = (BITMAPCOREHEADER*) info; > - coreheader->bcWidth = bmp->bitmap.bmWidth; > - coreheader->bcHeight = bmp->bitmap.bmHeight; > - coreheader->bcPlanes = 1; > - coreheader->bcBitCount = bmp->bitmap.bmBitsPixel; > - } > - else > - { > - info->bmiHeader.biWidth = bmp->bitmap.bmWidth; > - info->bmiHeader.biHeight = bmp->bitmap.bmHeight; > - info->bmiHeader.biPlanes = 1; > - info->bmiHeader.biSizeImage = > - DIB_GetDIBImageBytes( bmp->bitmap.bmWidth, > - bmp->bitmap.bmHeight, > - bmp->bitmap.bmBitsPixel ); > - if (bmp->dib) > - { > - info->bmiHeader.biBitCount = bmp->dib->dsBm.bmBitsPixel; > - switch (bmp->dib->dsBm.bmBitsPixel) > - { > - case 16: > - case 32: > - info->bmiHeader.biCompression = BI_BITFIELDS; > - break; > - default: > - info->bmiHeader.biCompression = BI_RGB; > - break; > - } > - } > - else > - { > - info->bmiHeader.biCompression = (bmp->bitmap.bmBitsPixel > > 8) ? BI_BITFIELDS : BI_RGB; > - info->bmiHeader.biBitCount = bmp->bitmap.bmBitsPixel; > - } > - info->bmiHeader.biXPelsPerMeter = 0; > - info->bmiHeader.biYPelsPerMeter = 0; > - info->bmiHeader.biClrUsed = 0; > - info->bmiHeader.biClrImportant = 0; > - > - /* Windows 2000 doesn't touch the additional struct members if > - it's a BITMAPV4HEADER or a BITMAPV5HEADER */ > - } > - lines = abs(bmp->bitmap.bmHeight); > - goto done; > - > case 1: > case 4: > case 8: > @@ -877,10 +829,10 @@ INT WINAPI GetDIBits( > LPBYTE dbits = bits, sbits = (LPBYTE) bmp->dib->dsBm.bmBits + > (startscan * srcwidthb); > unsigned int x, y, width, widthb; > > - if ((height < 0) ^ (bmp->dib->dsBmih.biHeight < 0)) > + if (bmp->dib->dsBmih.biHeight < 0) > { > - dbits = (LPBYTE)bits + (dstwidthb * (lines-1)); > - dstwidthb = -dstwidthb; > + sbits += (srcwidthb * (abs(bmp->dib->dsBmih.biHeight) - > startscan - 1)); > + srcwidthb = -srcwidthb; > } > > switch( bpp ) { > @@ -1086,7 +1038,64 @@ INT WINAPI GetDIBits( > } > } > } > - else lines = abs(height); > + else /* query bitmap info only */ > + { > + if (core_header) > + { > + BITMAPCOREHEADER* coreheader = (BITMAPCOREHEADER*) info; > + if (bmp->dib) > + { > + coreheader->bcWidth = bmp->dib->dsBmih.biWidth; > + coreheader->bcHeight = bmp->dib->dsBmih.biHeight; > + } > + else > + { > + coreheader->bcWidth = bmp->bitmap.bmWidth; > + coreheader->bcHeight = bmp->bitmap.bmHeight; > + } > + coreheader->bcPlanes = 1; > + coreheader->bcBitCount = bmp->bitmap.bmBitsPixel; > + } > + else > + { > + if (bmp->dib) > + { > + info->bmiHeader.biHeight = bmp->dib->dsBmih.biHeight; > + info->bmiHeader.biWidth = bmp->dib->dsBmih.biWidth; > + info->bmiHeader.biBitCount = bmp->dib->dsBm.bmBitsPixel; > + switch (bmp->dib->dsBm.bmBitsPixel) > + { > + case 16: > + case 32: > + info->bmiHeader.biCompression = BI_BITFIELDS; > + break; > + default: > + info->bmiHeader.biCompression = BI_RGB; > + break; > + } > + } > + else > + { > + info->bmiHeader.biWidth = bmp->bitmap.bmWidth; > + info->bmiHeader.biHeight = bmp->bitmap.bmHeight; > + info->bmiHeader.biCompression = (bmp->bitmap.bmBitsPixel > > 8) ? BI_BITFIELDS : BI_RGB; > + info->bmiHeader.biBitCount = bmp->bitmap.bmBitsPixel; > + } > + info->bmiHeader.biPlanes = 1; > + info->bmiHeader.biSizeImage = > + DIB_GetDIBImageBytes( bmp->bitmap.bmWidth, > + bmp->bitmap.bmHeight, > + bmp->bitmap.bmBitsPixel ); > + info->bmiHeader.biXPelsPerMeter = 0; > + info->bmiHeader.biYPelsPerMeter = 0; > + info->bmiHeader.biClrUsed = 0; > + info->bmiHeader.biClrImportant = 0; > + > + /* Windows 2000 doesn't touch the additional struct members if > + it's a BITMAPV4HEADER or a BITMAPV5HEADER */ > + } > + lines = abs(bmp->bitmap.bmHeight); > + } > > /* The knowledge base article Q81498 ("DIBs and Their Uses") states > that > if bits == NULL and bpp != 0, only biSizeImage and the color table > are > diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c > index d0d7a9c..a76d437 100644 > --- a/dlls/gdi32/tests/bitmap.c > +++ b/dlls/gdi32/tests/bitmap.c > @@ -3050,6 +3050,116 @@ static void test_32bit_bitmap_blt(void) > DeleteDC(hdcScreen); > } > > +static void test_GetDIBits_info_query(void) > +{ > + BITMAPINFO bi; > + HBITMAP bmp; > + HDC hdc; > + int *picture; > + > + hdc = GetDC(NULL); > + > + bi.bmiHeader.biSize=sizeof(bi.bmiHeader); > + bi.bmiHeader.biWidth=2; > + bi.bmiHeader.biHeight=2; > + bi.bmiHeader.biPlanes=1; > + bi.bmiHeader.biBitCount=32; > + bi.bmiHeader.biCompression=BI_RGB; > + bmp = CreateDIBSection(hdc, &bi, DIB_RGB_COLORS, (void**)&picture, > NULL, 0); > + /*Clear the structure to make sure that we really are testing that the > structure is being written to.*/ > + memset(&bi, 0, sizeof(bi)); > + /*Test with a BITMAPINFOHEADER.*/ > + bi.bmiHeader.biSize = sizeof(BITMAPINFOHEADER); > + GetDIBits(hdc, bmp, 0, 0, NULL, &bi, DIB_RGB_COLORS); > + ok(bi.bmiHeader.biHeight == 2, "Height should be 2."); > + ok(bi.bmiHeader.biWidth == 2, "Width should be 2."); > + /*Clear the structure to make sure that we really are testing that the > structure is being written to.*/ > + memset(&bi, 0, sizeof(bi)); > + /*Now test with a BITMAPCOREHEADER.*/ > + bi.bmiHeader.biSize=sizeof(BITMAPCOREHEADER); > + GetDIBits(hdc, bmp, 0, 0, NULL, &bi, DIB_RGB_COLORS); > + ok(((BITMAPCOREHEADER*)&bi)->bcHeight == 2, "Height should be 2."); > + ok(((BITMAPCOREHEADER*)&bi)->bcWidth == 2, "Width should be 2."); > + /*Clean up.*/ > + DeleteObject(bmp); > + > + /*Test top to bottom bitmap.*/ > + bi.bmiHeader.biSize=sizeof(bi.bmiHeader); > + bi.bmiHeader.biWidth=2; > + bi.bmiHeader.biHeight=-2; > + bi.bmiHeader.biPlanes=1; > + bi.bmiHeader.biBitCount=32; > + bi.bmiHeader.biCompression=BI_RGB; > + bmp = CreateDIBSection(hdc, &bi, DIB_RGB_COLORS, (void**)&picture, > NULL, 0); > + /*Clear the structure to make sure that we really are testing that the > structure is being written to.*/ > + memset(&bi, 0, sizeof(bi)); > + /*Test with a BITMAPINFOHEADER.*/ > + bi.bmiHeader.biSize=sizeof(BITMAPINFOHEADER); > + GetDIBits(hdc, bmp, 0, 0, NULL, &bi, DIB_RGB_COLORS); > + ok(bi.bmiHeader.biHeight == -2, "Height should be -2."); > + ok(bi.bmiHeader.biWidth == 2, "Width should be 2."); > + /*Clear the structure to make sure that we really are testing that the > structure is being written to.*/ > + memset(&bi, 0, sizeof(bi)); > + /*Now test with a BITMAPCOREHEADER.*/ > + bi.bmiHeader.biSize=sizeof(BITMAPCOREHEADER); > + GetDIBits(hdc, bmp, 0, 0, NULL, &bi, DIB_RGB_COLORS); > + ok(((BITMAPCOREHEADER*)&bi)->bcHeight == (WORD)-2, "Height should be > -2."); > + ok(((BITMAPCOREHEADER*)&bi)->bcWidth == (WORD)2, "Width should be > 2."); > + /*Clean up.*/ > + DeleteObject(bmp); > +} > + > +static void test_GetDIBits_single_pixel_destination(void) > +{ > + BITMAPINFO bi; > + HBITMAP bmptb, bmpbt; > + HDC hdc; > + int pixelOut; > + int *picture; > + bi.bmiHeader.biSize=sizeof(bi.bmiHeader); > + bi.bmiHeader.biWidth=2; > + bi.bmiHeader.biHeight=2; > + bi.bmiHeader.biPlanes=1; > + bi.bmiHeader.biBitCount=32; > + bi.bmiHeader.biCompression=BI_RGB; > + > + /*Get the device context for the screen.*/ > + hdc=GetDC(NULL); > + > + /*Create the bottom to top image (image's bottom scan line is at the > top in memory).*/ > + bmpbt=CreateDIBSection(hdc, &bi, DIB_RGB_COLORS, (void**)&picture, > NULL, 0); > + /*Now that we have a pointer to the pixels, we write to them.*/ > + picture[0]=1; > + picture[1]=2; > + picture[2]=3; > + picture[3]=4; > + /*Create the top to bottom image (images' bottom scan line is at the > bottom in memory).*/ > + bi.bmiHeader.biHeight=-2; /*We specify that we want a top to bottom > image by specifying a negative height.*/ > + bmptb=CreateDIBSection(hdc, &bi, DIB_RGB_COLORS, (void**)&picture, > NULL, 0); > + /*Write to this top to bottom bitmap.*/ > + picture[0]=1; > + picture[1]=2; > + picture[2]=3; > + picture[3]=4; > + > + bi.bmiHeader.biWidth=1; > + > + bi.bmiHeader.biHeight=2; > + GetDIBits(hdc, bmpbt, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > + ok(pixelOut==1, "Bottom-up -> bottom-up should have first scanline."); > + GetDIBits(hdc, bmptb, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > + ok(pixelOut==3, "Top-down -> bottom-up should have last scanline."); > + > + bi.bmiHeader.biHeight=-2; > + GetDIBits(hdc, bmpbt, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > + ok(pixelOut==1, "Bottom-up -> top-down should have first scanline."); > + GetDIBits(hdc, bmptb, 0, 1, &pixelOut, &bi, DIB_RGB_COLORS); > + ok(pixelOut==3, "Top-down -> top-down should have last scanline."); > + > + DeleteObject(bmpbt); > + DeleteObject(bmptb); > +} > + > START_TEST(bitmap) > { > HMODULE hdll; > @@ -3080,4 +3190,6 @@ START_TEST(bitmap) > test_bitmapinfoheadersize(); > test_get16dibits(); > test_clipping(); > + test_GetDIBits_single_pixel_destination(); > + test_GetDIBits_info_query(); > } > -- > 1.7.1 > > > > Hi Jack, You forgot trailing \n in the ok() calls. -- Nicolas Le Cam

Feb. 8, 2011

Re: gdi32/tests: Use virtual screen size instead of primary monitor screen size.

by Dmitry Timoshkov

Peter Urbanec <winehq.org(a)urbanec.net> wrote: > It seems that GetSystemMetrics(SM_CXVIRTUALSCREEN) is supported on Win2k > and later, but not on NT4. Presumably, on an NT4 system, the test could > use GetSystemMetrics(SM_CXSCREEN) and it would work as long as there is > only one monitor. > > What's the proper incantation I need to use to detect NT4 and execute > platform specific test code? Something like this should work: screen_width = GetSystemMetrics(SM_CXVIRTUALSCREEN); if (!screen_width) screen_width = GetSystemMetrics(SM_CXSCREEN); screen_height = GetSystemMetrics(SM_CYVIRTUALSCREEN); if (!screen_height) screen_height = GetSystemMetrics(SM_CYSCREEN); -- Dmitry.

Feb. 8, 2011

Re: gdi32/tests: Use virtual screen size instead of primary monitor screen size.

by Peter Urbanec

On 08/02/11 16:02, Marvin wrote: > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=9028 > > Your paranoid android. > > > === WNT4WSSP6 (32 bit clipping) === > clipping.c:438: Test failed: expected 0,0-0,0, got 0,0-800,600 It seems that GetSystemMetrics(SM_CXVIRTUALSCREEN) is supported on Win2k and later, but not on NT4. Presumably, on an NT4 system, the test could use GetSystemMetrics(SM_CXSCREEN) and it would work as long as there is only one monitor. What's the proper incantation I need to use to detect NT4 and execute platform specific test code?

Feb. 8, 2011

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9030 Your paranoid android. === WNT4WSSP6 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4342 tests executed (0 marked as todo, 2 failures), 1 skipped. === W2KPROSP4 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4357 tests executed (0 marked as todo, 2 failures), 0 skipped. === WXPPROSP3 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K3R2SESP2 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === WVISTAADM (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K8SE (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PRO (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (64 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped.

Feb. 8, 2011

Re: gdi32/dib.c: Write true bitmap height into info and copy scanlines in the correct order.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9029 Your paranoid android. === WNT4WSSP6 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4342 tests executed (0 marked as todo, 2 failures), 1 skipped. === W2KPROSP4 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4357 tests executed (0 marked as todo, 2 failures), 0 skipped. === WXPPROSP3 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K3R2SESP2 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === WVISTAADM (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W2K8SE (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PRO (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (32 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped. === W7PROX64 (64 bit bitmap) === bitmap.c:3099: Test failed: Height should be -2.bitmap.c:3106: Test failed: Height should be -2.bitmap: 4358 tests executed (0 marked as todo, 2 failures), 0 skipped.

Feb. 8, 2011

wine is passing make test again :-)

by Austin English

Looks like Jacek and Gentoo have the magic combination. It's passed 4 days in a row: http://test.winehq.org/data/ae3e768a2e1f9c21b355798c8fbf473db3d83434/wine_j… http://test.winehq.org/data/bf640445c748b0588616da201e8ff8f3b1c778e9/wine_j… http://test.winehq.org/data/780f9b3b4fe8ff17784860a2a65b4ecab268436a/wine_j… http://test.winehq.org/data/745a50c9dbb03d37db58ff53136e93f00943bc0d/wine_j… now let's see if we can spread the love to someone else :-). -- -Austin

Feb. 8, 2011

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

by Dmitry Timoshkov

Misha Koshelev <misha680(a)gmail.com> wrote: > +static inline unsigned short float_32_to_16(const float *in) > +static inline float float_16_to_32(const unsigned short *in) { Is there a reason that you pass a pointer to the helper instead of a value? Also placing a brace on its own line would follow the style of other functions. -- Dmitry.

Feb. 8, 2011

Re: gdi32/tests: Use virtual screen size instead of primary monitor screen size.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9028 Your paranoid android. === WNT4WSSP6 (32 bit clipping) === clipping.c:438: Test failed: expected 0,0-0,0, got 0,0-800,600

Feb. 8, 2011

Re: d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

by Misha Koshelev

On Mon, Feb 7, 2011 at 6:20 PM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > Am 07.02.2011 um 23:49 schrieb Misha Koshelev: > I have no full explanation yet, just bits and pieces. By the way, if you haven't done so already I recommend a thorough study of http://en.wikipedia.org/wiki/Floating_point for background knowledge. http://en.wikipedia.org/wiki/IEEE_754-2008 may also be interesting, but I haven't read that wikipedia page so I don't really know what is in it. > >> I believe I've found that the threshold value is actually 65520.0 for >> conversions from single to half precision > That makes sense, it is halfway between 65536 and 65604. At this threshold values are rounded up or down > >> In any case, I have gotten the half to single precision conversion to >> work in Wine by extending to 16 bits for the exponent (changing < 31 >> to < 32). > You may as well replace it with TRUE because the exponent won't be >= 32. Too few bits to express anything bigger than 31. > >> However, I am still having trouble with the single to half precision >> and believe I am spinning my wheels a bit at this point. > I'm still trying to make sense of the Windows values :-/ > >> math.c:2249: Test failed: Got 7800, expected 7bff or 7bff for index 3. > Looks like the exponent is 1 too high and the mantissa zero instead of 1023. Probably a rounding / off by one bug in the code from wined3d. Different behavior wrt what happens when you exactly hit the rounding threshold. (Ie, do you round an exact 5 up or down(to 0 or 10)?) > >> math.c:2249: Test failed: Got ffff, expected fc00 or fce2 for index 8. >> math.c:2249: Test failed: Got ffff, expected fc00 or fc00 for index 12. >> math.c:2249: Test failed: Got ffff, expected fc00 or fc00 for index 13. >> math.c:2249: Test failed: Got ffff, expected fc00 or fc00 for index 14. >> math.c:2249: Test failed: Got ffff, expected fc00 or fc00 for index 15. > This is this statement: > + if (*in < -65520) return 0xFFFF; > You probably wanted to return fc00 here, if you are trying to emulate case 1. Otherwise remove both CONFUSION HERE statements, change the if(exp > 30) case to exp > 31 and set ret = 0x7fff there. This will give you case 2. > >> math.c:2249: Test failed: Got 6400, expected 7fff or 7fff for index 18. >> math.c:2249: Test failed: Got 6400, expected ffff or ffff for index 19. > Hmm, I am afraid you can't remove the check for NaN entirely. If you try to any float operation on NaN undefined things are going to happen(Well, you get NaN, and later try to pick its bits apart) > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG/MacGPG2 v2.0.17 (Darwin) > > iQIcBAEBAgAGBQJNUH4mAAoJEN0/YqbEcdMwiNcP/R4sa+Z6L39FtN8qE1nX+Pwj > KER3a4MWQ8DWDQgjXR09l3kYua9tM8kH5XmZNNpthH5Uck/CCdFOfCx+j3+CLuJq > nbFkT5kwVA4qzv67o9qJxJhCaL2+9rXtB6ADOSU3QfLYn7L/UXzxwENzxgQlvFG5 > +0GzkdlimMGB8+Rj8mYte/ORFEQQnLoCFe3d1UT9RQQhOCqQvlDuaptBWQCiFiAc > GgSQuBzC7YbZxLz8i0EDjfn50X5lW0iVo0p682RJzmod+oCeFztjY/G33wGyA1MA > 45Ui6onTYpN1OES1esw/WtePkM8dKrSDlw+gu5rmU9c8JwhPFnNvs/1FUvHD1bGG > WjHkv3hLCf3XVjMk1aT70ItFQ8ph2b6IlU3GOSvQvrYbDB8jfb7lbJnuqzd4hrd4 > ycTzAf5YULwuQ5m7Ie5QtWO+hG0iB/I0aqGIAnNj6tSO3b/bfmBlQKAauVnoUnDq > sYgIEmW0GO15Ndsd/ipfbh414qQsNPyGQNdnhivkJK2PrVaiyXb/ztJf/vLDKjEw > cRPoaAfQyIsfPD+cqKq4pnw2rwvr2tkOby11UQ8jfDeaTldp3redf0py0o37CGq1 > 520QC0CqC/A4MHawwbgcbFTi6XX/DCkHW4IOEirJvnweV8mw8V9IP4XyY/xmYepV > ukB4hwY8XvIe4/Zxj8IP > =bs4K > -----END PGP SIGNATURE----- > Wow, thanks so much. That really helped. The attached patch now passes all Wine tests and Windows tests as well: https://testbot.winehq.org/JobDetails.pl?Key=9020 I had to use the signbit function as the > 0.0f check does not work for NaNs. Any other suggestions for the patch before re-submission to wine-patches? And sorry if I missed is Henri on vacation? Thanks Misha

Feb. 8, 2011

Re: mstask/tests: make sure return values are used (LLVM/Clang)

by Austin English

On Mon, Feb 7, 2011 at 16:31, Marvin <testbot(a)testbot.winehq.org> wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=9011 > > Your paranoid android. > > > === WNT4WSSP6 (32 bit task_trigger) === > task_trigger.c:165: Test failed: Failed to setup test_task My patch doesn't touch this test. Compiler or other error. -- -Austin

Feb. 8, 2011