February 2011 - Wine-Devel - list.winehq.org

Re: Apologies to the List

by James McKenzie

On 2/22/11 4:37 AM, Alexandre Julliard wrote: > James McKenzie<jjmckenzie51(a)earthlink.net> writes: > >> First, my tirade was not intended to be as such. I wanted to pull the >> patch because it was incorrect and I did not want anyone else working >> on it while I silently trimmed it and made it better. >> Second, I realize this has affected my 'Jeremy White' score. I hope >> that AJ understands why the code was pulled and that this happens >> frequently with a project this large. > No, it doesn't. Requesting your code to be pulled is a serious matter, > and a major break of the trust that is necessary for us all to work > together. You can't do something like this and expect it not to have > consequences. > > It was already unlikely that you would get any of your patches in, based > on their technical merit, but now even if you managed to make your code > acceptable, I wouldn't put it in, because I can't trust you not to make > me pull it out again next time you get mad at me. > And I agree with this decision. You are technically "the keeper of the code" and I have on more than one occasion transgressed this unwritten rule. However, I will still post patches for comments in Wine Development and subsequently release them to the LGPL/Wine in Wine-Patches so that others can work with them. I feel that is only fair for what I have done. Is that acceptable? This seems to be the method used by others, however I have been known to be massively incorrect in the past, and I could be wrong now. If posting them to bug reports is the preferred method I will that instead. James McKenzie

Feb. 22, 2011

Re: RFC: Patch to change what sets the is_win9x in riched20/tests

by James McKenzie

On 2/22/11 12:42 AM, Paul Vriens wrote: > On 02/22/2011 01:21 AM, James McKenzie wrote: >> All: >> >> Upon examining other test code that creates a variable called is_win9x, >> I realized that using get_version and comparing it to a fixed value may >> not be best for the riched20 tests and have attached a proposed change >> to how this variable is set. It uses a called function, lstrcmpW and if >> it does not exist, the variable is set to a false value. This change has >> been tested on the testbot for >> Windows95/98/98SE/2K/2K3/XP/XP_64/Vista/Vista64/Win7/Win7_64 and no >> discrepancies were found. > > Win9x tests are no longer run with winetest. I also see that Austin > sent some 9x cleanup patches. That said, I think the best way is to > get rid of all the win9x 'hacks' in editor.c and rely on the fact that > we have NT4+. > Paul: While that is true, I thought the consensus was that testing would still be available for Window9X/ME. There are users (like me) that are running Windows9x/ME programs and don't want to loose the ability to run them under Wine. This function may not exist in Windows versions after Windows2K either, that is why I proposed changing this from a version check to actually checking for the called function. And lastly, I agree with adding tests to specifically check what happens in the riched20.dll for UNICODE calls. James McKenzie

Feb. 22, 2011

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

by Misha Koshelev

2011/2/21 Rico Schüller <kgbricola(a)web.de>: > Am 21.02.2011 20:19, schrieb Misha Koshelev: >> >> Thanks Rico. >> >> Still trying to investigate this further. >> >> Perhaps, if you have any more hints as to how you arrived at this >> magical value, much appreciated. > > I got to this value by running the attached test patch applied after yours. > You probably may > modify the for loop. I've chosen the increment because of time/usage. > You may try with 0xff or a lower value instead of 0xfff, but be warned > running at 1 will take a > while to see a failed test. > > You need a copy of native d3dx9_36.dll renamed to d3dx9_36_2.dll in the > path. The test > should show the difference between native and wine's implementation. I > haven't run the test > on windows, yet. >> >> Namely, at first my hunch was that this value (2.9806e-08 with the >> following bitwise representation): >> 0 01100110 00000000000010000000000 >> was simply being truncated to the smallest denormalized value >> representable by a half precision float: >> 0 000.00 00.0000.0001 6×10-8 (Smallest denormalized value) >> but this is clearly not true for other values that are too small (they >> are returned as 0.0f). > > I haven't had the time to investigate this completely, yet. But probably > there are a couple of values > produced by the patch which should give a hint to what bits are > truncated/rounded. > > Cheers > Rico > Thank you. I'm pretty stumped. I've gotten a little farther by making the following changes to the rounding code (handling the special case of mantissa = 2048 = 2^11 = maximal value; "overflow" from rounding). if (tmp - mantissa > 0.5f) mantissa++; /* round to nearest, away from zero */ if (mantissa == 2048) { mantissa = 1024; exp++; } This seems to handle all the cases that are, to my understanding, within the representable range (I may be somewhat incorrect, please see attached test results, that include output of exp, unrounded mantissa = tmp, and mantissa). Note, that _most_ of these results fall in the case of fabs(in) > 65520, so I have commented out this line in the test version of the converted (see attached patch). Any hints appreciated. Thank you Misha

Feb. 22, 2011

Re: Valgrind --malloc-fill=A5 --free-fill=DE crashes Wine

by Austin English

On Mon, Feb 21, 2011 at 09:10, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Hi Joerg, > > Op 21-02-11 12:26, Joerg-Cyril.Hoehle(a)t-systems.com schreef: >> >> Hi, >> >> I used to run Valgrind with the additional options >> --malloc-fill=A5 --free-fill=DE >> around Wine 1.2 times. Now I retried it and it crashes >> Wine 1.3.13 and 1.3.14 (it fails to load kernel32.dll). >> >> It turns out that malloc-fill is harmless, -free-fill causes havoc >> currently. >> >> Am I the only one using or seeing this (Ubuntu Lucid)? > > It's most likely a valgrind/wine bug, does this patch work? Works for me on Gentoo 32-bit. -- -Austin

Feb. 22, 2011

Re: GSOC idea to implement the explorer

by Juan Lang

Hi Andrew, > Though I understand this is probably the lower priority on the wine > developers list. As integrating into Linux desktop is probably the > preferred and most used mode. I thought that sharing reactos explorer > and working on making a complete explorer(including extensions) would > be the goal. > Though now I'm saying it I feel rather silly, as this really is the > least important part of wine. Hey, if it's your itch, feel free to scratch it. I actually would like to see a better explorer in Wine, if nothing else to have a more intuitive way to play around with the shell namespace than opening a file/save dialog. I haven't had time to work on it myself. Regarding sharing code: last I heard, the official attitude is "it's complicated." C++ code isn't acceptable in the Wine tree at all, of course, so that ruled out ReactOS's explorer long ago. New submissions that are aimed at their tree as well as ours would probably be acceptable. --Juan

Feb. 22, 2011

Re: gdi32: first look for a printer driver name in the registry

by Dmitry Timoshkov

Vitaly Perov <vitperov(a)etersoft.ru> wrote: > + if (!RegOpenKeyExW(HKEY_CURRENT_USER, user_printers_reg_key, 0, KEY_READ, &hKey) > + && !RegQueryValueExW(hKey, device, NULL, NULL, (LPBYTE) driver, &size)) > + { > + TRACE("Get value from registry\n"); > + RegCloseKey(hKey); > + } You are leaking hKey if RegOpenKeyExW() succeeds but RegQueryValueExW() does not. -- Dmitry.

Feb. 22, 2011

Re: gdi32: first look for a printer driver name in the registry

by Jacek Caban

Hi Vitaly, On 2/22/11 4:01 PM, Vitaly Perov wrote: > + if (!RegOpenKeyExW(HKEY_CURRENT_USER, user_printers_reg_key, 0, KEY_READ,&hKey) > +&& !RegQueryValueExW(hKey, device, NULL, NULL, (LPBYTE) driver,&size)) > + { > + TRACE("Get value from registry\n"); > + RegCloseKey(hKey); > + } You leak hKey on RegQueryValueExW failure. Jacek

Feb. 22, 2011

Re: wined3d profiling

by Roderick Colenbrander

In case of Intel make sure you use drivers with debug symbols :) Yeah, you could use oprofile, but for some quick and easy profiling sysprof can be easier and much quicker. Roderick On Tue, Feb 22, 2011 at 2:55 AM, Jeff Zaroyko <jeffzaroyko(a)gmail.com> wrote: > On Tue, Feb 22, 2011 at 8:53 PM, Tobias Jakobi <liquid.acid(a)gmx.net> wrote: >> >> What is the recommended way of profiling wine components? oprofile? >> > > See http://wiki.winehq.org/Performance > > oprofile works well if things are cpu bound, or for illustrating cases > of redundant calls. If oprofile shows a lot of time in video drivers, > you could try gDEBugger mentioned on the above wiki page to gain some > insight. > > Jeff > > >

Feb. 22, 2011

Re: oleaut32: Implement ITypeInfo_GetNames Stub/Proxy (resend)

by Huw Davies

On Tue, Feb 22, 2011 at 09:02:38PM +1100, Alistair Leslie-Hughes wrote: > >From 6aa7bfa0c06b746ee64daf56f2b02e6f38542d54 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 18 Feb 2011 12:04:56 +1100 > Subject: [PATCH] Implement ITypeInfo_GetNames Stub/Proxy > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/oleaut32/usrmarshal.c | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) This looks good to me. I'm not sure why this function is marked as [call_as], I expect they originally had planned to allow for a NULL pcNames if cMaxNames == 1 (rather like IEnum*_Next). However a quick test shows that this doesn't appear to be the case. Huw.

Feb. 22, 2011

Re: Apologies to the List

by Tom Wickline

On Tue, Feb 22, 2011 at 7:37 PM, Alexandre Julliard <julliard(a)winehq.org>wrote: > > It was already unlikely that you would get any of your patches in, based > on their technical merit, but now even if you managed to make your code > acceptable, I wouldn't put it in, because I can't trust you not to make > me pull it out again next time you get mad at me. > +1 :) > > -- > Alexandre Julliard > julliard(a)winehq.org > > > -- Wine is not a conclusion but a process...

Feb. 22, 2011

Re: Apologies to the List

by Alexandre Julliard

James McKenzie <jjmckenzie51(a)earthlink.net> writes: > First, my tirade was not intended to be as such. I wanted to pull the > patch because it was incorrect and I did not want anyone else working > on it while I silently trimmed it and made it better. > Second, I realize this has affected my 'Jeremy White' score. I hope > that AJ understands why the code was pulled and that this happens > frequently with a project this large. No, it doesn't. Requesting your code to be pulled is a serious matter, and a major break of the trust that is necessary for us all to work together. You can't do something like this and expect it not to have consequences. It was already unlikely that you would get any of your patches in, based on their technical merit, but now even if you managed to make your code acceptable, I wouldn't put it in, because I can't trust you not to make me pull it out again next time you get mad at me. -- Alexandre Julliard julliard(a)winehq.org

Feb. 22, 2011

Re: wined3d profiling

by Jeff Zaroyko

On Tue, Feb 22, 2011 at 8:53 PM, Tobias Jakobi <liquid.acid(a)gmx.net> wrote: > > What is the recommended way of profiling wine components? oprofile? > See http://wiki.winehq.org/Performance oprofile works well if things are cpu bound, or for illustrating cases of redundant calls. If oprofile shows a lot of time in video drivers, you could try gDEBugger mentioned on the above wiki page to gain some insight. Jeff

Feb. 22, 2011

wined3d profiling

by Tobias Jakobi

Hey there, I'm experiencing some performance problems with wined3d. The affected game is FEAR (demo does the trick). At first I thought it was related to running the demo on my Intel i965, but I got the same problem running the demo on my Radeon HD4750(a)r600g. If anyone wants to test this himself: http://www.gamershell.com/download_10167.shtml Performance collapses (kinda SW rendering level) after exiting the first underground section. My guess is that the water plane rendering is causing the issue. So anyway, I wanted to profile this one, but gprof doesn't seem to work so well with wine. I tried to only compile wined3d with -pg, but this doesn't seem to have any effect. At least I don't get any gmon.out after the process exits. What is the recommended way of profiling wine components? oprofile? Thanks, Tobias

Feb. 22, 2011

Re: RFC: Patch to change what sets the is_win9x in riched20/tests

by Paul Vriens

On 02/22/2011 01:21 AM, James McKenzie wrote: > All: > > Upon examining other test code that creates a variable called is_win9x, > I realized that using get_version and comparing it to a fixed value may > not be best for the riched20 tests and have attached a proposed change > to how this variable is set. It uses a called function, lstrcmpW and if > it does not exist, the variable is set to a false value. This change has > been tested on the testbot for > Windows95/98/98SE/2K/2K3/XP/XP_64/Vista/Vista64/Win7/Win7_64 and no > discrepancies were found. Win9x tests are no longer run with winetest. I also see that Austin sent some 9x cleanup patches. That said, I think the best way is to get rid of all the win9x 'hacks' in editor.c and rely on the fact that we have NT4+. -- Cheers, Paul.

Feb. 22, 2011

RFC: Patch to change what sets the is_win9x in riched20/tests

by James McKenzie

All: Upon examining other test code that creates a variable called is_win9x, I realized that using get_version and comparing it to a fixed value may not be best for the riched20 tests and have attached a proposed change to how this variable is set. It uses a called function, lstrcmpW and if it does not exist, the variable is set to a false value. This change has been tested on the testbot for Windows95/98/98SE/2K/2K3/XP/XP_64/Vista/Vista64/Win7/Win7_64 and no discrepancies were found. Comments on this patch are appreciated. I would like to submit this for inclusion into the Wine code base on Friday. James McKenzie

Feb. 21, 2011

Apologies to the List

by James McKenzie

First, my tirade was not intended to be as such. I wanted to pull the patch because it was incorrect and I did not want anyone else working on it while I silently trimmed it and made it better. Second, I realize this has affected my 'Jeremy White' score. I hope that AJ understands why the code was pulled and that this happens frequently with a project this large. I am aware that the code was placed into the LGPL at the time it was posted to Wine Patches. Third, I will be posting here three patches for riched20/test/editor.c. It is my desire that these patches be examined, with a critical eye and feedback applied. Be brutal, be blunt and most of all be helpful. If I write back that I don't understand what you are talking about, I really don't and may need additional guidance (examples, pointing out other code with a similar purpose.) This is how we grow and learn. Very respectfully, James McKenzie

Feb. 21, 2011

Re: fix sharing handling for CreateFile

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9411 Your paranoid android. === W2K3R2SESP2 (32 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5 === WVISTAADM (32 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5 === W2K8SE (32 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5 === W7PRO (32 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5 === W7PROX64 (32 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5 === W7PROX64 (64 bit file) === file.c:1929: Test failed: open failed for modes map 4/0/0 file.c:1929: Test failed: open failed for modes map 4/0/1 file.c:1929: Test failed: open failed for modes map 4/0/4 file.c:1929: Test failed: open failed for modes map 4/0/5 file.c:1929: Test failed: open failed for modes map 4/80000000/0 file.c:1929: Test failed: open failed for modes map 4/80000000/1 file.c:1929: Test failed: open failed for modes map 4/80000000/4 file.c:1929: Test failed: open failed for modes map 4/80000000/5 file.c:1929: Test failed: open failed for modes map 4/40000000/0 file.c:1929: Test failed: open failed for modes map 4/40000000/1 file.c:1929: Test failed: open failed for modes map 4/40000000/4 file.c:1929: Test failed: open failed for modes map 4/40000000/5 file.c:1929: Test failed: open failed for modes map 4/c0000000/0 file.c:1929: Test failed: open failed for modes map 4/c0000000/1 file.c:1929: Test failed: open failed for modes map 4/c0000000/4 file.c:1929: Test failed: open failed for modes map 4/c0000000/5 file.c:1929: Test failed: open failed for modes map 4/10000/0 file.c:1929: Test failed: open failed for modes map 4/10000/1 file.c:1929: Test failed: open failed for modes map 4/10000/4 file.c:1929: Test failed: open failed for modes map 4/10000/5 file.c:1929: Test failed: open failed for modes map 4/80010000/0 file.c:1929: Test failed: open failed for modes map 4/80010000/1 file.c:1929: Test failed: open failed for modes map 4/80010000/4 file.c:1929: Test failed: open failed for modes map 4/80010000/5 file.c:1929: Test failed: open failed for modes map 4/40010000/0 file.c:1929: Test failed: open failed for modes map 4/40010000/1 file.c:1929: Test failed: open failed for modes map 4/40010000/4 file.c:1929: Test failed: open failed for modes map 4/40010000/5 file.c:1929: Test failed: open failed for modes map 4/c0010000/0 file.c:1929: Test failed: open failed for modes map 4/c0010000/1 file.c:1929: Test failed: open failed for modes map 4/c0010000/4 file.c:1929: Test failed: open failed for modes map 4/c0010000/5

Feb. 21, 2011

winetricks

by Mariusz Janeczko

Could you correct link to msxml3 in winetricks instaler ? Fhx

Feb. 21, 2011

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

by Rico Schüller

Am 21.02.2011 20:19, schrieb Misha Koshelev: > > Thanks Rico. > > Still trying to investigate this further. > > Perhaps, if you have any more hints as to how you arrived at this > magical value, much appreciated. I got to this value by running the attached test patch applied after yours. You probably may modify the for loop. I've chosen the increment because of time/usage. You may try with 0xff or a lower value instead of 0xfff, but be warned running at 1 will take a while to see a failed test. You need a copy of native d3dx9_36.dll renamed to d3dx9_36_2.dll in the path. The test should show the difference between native and wine's implementation. I haven't run the test on windows, yet. > Namely, at first my hunch was that this value (2.9806e-08 with the > following bitwise representation): > 0 01100110 00000000000010000000000 > was simply being truncated to the smallest denormalized value > representable by a half precision float: > 0 000.00 00.0000.0001 6×10-8 (Smallest denormalized value) > but this is clearly not true for other values that are too small (they > are returned as 0.0f). I haven't had the time to investigate this completely, yet. But probably there are a couple of values produced by the patch which should give a hint to what bits are truncated/rounded. Cheers Rico

Feb. 21, 2011

Re: Two enhancement requests for winetricks

by Dan Kegel

On Wed, Jun 9, 2010 at 6:03 AM, Dan Kegel <dank(a)kegel.com> wrote: > On Wed, Jun 9, 2010 at 3:03 AM, Octavian Voicu <octavian.voicu(a)gmail.com> wrote: >> If you implement a status feature for every trick, you can change the >> main UI into a list of checkboxes, with the installed tricks already >> ticked. > > Right, of course. I had even realized that before. I guess I was > just in 'no' mode... It took me a while, but I finally implemented this in winetricks-alpha today. To get a list of installed verbs from the commandline, you can do winetricks-alpha list-installed In the GUI, the installed verbs now have their checkboxes already checked. Unchecking them does nothing still, though. Please test http://winetricks.googlecode.com/svn/trunk/src/winetricks-alpha and let me know what you think. - Dan

Feb. 21, 2011

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

by Misha Koshelev

2011/2/20 Rico Schüller <kgbricola(a)web.de>: > Hi, > > I have a small hint to the D3DXFloat32To16Array function. It seems that some > values are handled in some other way. > > A small test: > D3DXFLOAT16 res; > union p > { > float f; > DWORD d; > } x; > > x.d = 0x33000800; > D3DXFloat32To16Array(&res, &x.f, 1); > ok(res.value == 1, "Failed %f %x\n", x.f, res.value); > > This fails with the current implementation. It's not the only value, there > are a couple of them which are of by one. This could be easily seen by > loading both d3dx36.dll (wine and native) and comparing the values directly. > > Cheers > Rico > Thanks Rico. Still trying to investigate this further. Perhaps, if you have any more hints as to how you arrived at this magical value, much appreciated. Namely, at first my hunch was that this value (2.9806e-08 with the following bitwise representation): 0 01100110 00000000000010000000000 was simply being truncated to the smallest denormalized value representable by a half precision float: 0 000.00 00.0000.0001 6×10-8 (Smallest denormalized value) but this is clearly not true for other values that are too small (they are returned as 0.0f). Thank you Misha

Feb. 21, 2011

Re: Valgrind --malloc-fill=A5 --free-fill=DE crashes Wine

by Maarten Lankhorst

Hi Joerg, Op 21-02-11 12:26, Joerg-Cyril.Hoehle(a)t-systems.com schreef: > Hi, > > I used to run Valgrind with the additional options > --malloc-fill=A5 --free-fill=DE > around Wine 1.2 times. Now I retried it and it crashes > Wine 1.3.13 and 1.3.14 (it fails to load kernel32.dll). > > It turns out that malloc-fill is harmless, -free-fill causes havoc currently. > > Am I the only one using or seeing this (Ubuntu Lucid)? It's most likely a valgrind/wine bug, does this patch work? Cheers, Maarten

Feb. 21, 2011

Re: [PATCH 2/2] jscript: Added more uninitialization tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9399 Your paranoid android. === WVISTAADM (32 bit jscript) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

Feb. 21, 2011

Re: ws2_32: make gethostbyname fail if WSAStartup was not called before

by Alexandre Julliard

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > @@ -1104,6 +1106,7 @@ int WINAPI WSAStartup(WORD wVersionRequested, LPWSADATA lpWSAData) > /* don't do anything with lpWSAData->lpVendorInfo */ > /* (some apps don't allocate the space for this field) */ > > + WSAStartup_called = TRUE; > TRACE("succeeded\n"); > return 0; There's already a counter for tracking WSAStartup calls. -- Alexandre Julliard julliard(a)winehq.org

Feb. 21, 2011

Re: gdiplus: Implement in-memory font-storage

by Vincent Povirk

I approve of this product and/or service. On Mon, Feb 21, 2011 at 3:54 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > --- > > > >

Feb. 21, 2011