February 2011 - Wine-Devel - list.winehq.org

Re: D3DXCreateTorus patch... thoughts?

by Misha Koshelev

On Sun, Feb 13, 2011 at 11:37 PM, David Adam <david.adam.cnrs(a)gmail.com> wrote: > Here is cool link to show what D3DXCreateTorus does: > http://www.xmission.com/~legalize/book/snippets/rt_D3DXSphere.zip > > A+ > > David > Fixed small typo in spec file. Thank you Misha

Feb. 15, 2011

Re: Re: [PATCH] Implement software DXT1 compression

by alberto＠mattea.info

Hi Stefan. I'm not really into opengl internals, so I think the best solution for now is to implement 1), and give complete support when the blitting code will be in a better shape. Would this be okay? if (!context->valid) { context_release(context); FIXME("No gl context, cannot perform conversion\n"); return; } Thanks

Feb. 15, 2011

Anyone using Wine D3D under Parallels?

by Misha Koshelev

I am trying some simple patches for: http://bugs.winehq.org/show_bug.cgi?id=24642 and noticed that although glxinfo reports: misha(a)ubuntu:~/.wine/drive_c/Program Files/Tag$ glxinfo | grep -i render direct rendering: Yes OpenGL renderer string: Parallels using NVIDIA GeForce GT 330M OpenGL Engine I get: misha(a)ubuntu:~/.wine/drive_c/Program Files/Tag$ wine Tag.exe err:winediag:X11DRV_WineGL_InitOpenglInfo The Mesa OpenGL driver is using software rendering, most likely your OpenGL drivers haven't been installed correctly fixme:d3d_caps:wined3d_guess_card No card selector available for GL vendor 4 and card vendor 0000. fixme:win:EnumDisplayDevicesW ((null),0,0x32e6f4,0x00000000), stub! and I get different results under Parallels than running directly on the Mac This does not seem to cause a problem for other game demos, such as http://bugs.winehq.org/show_bug.cgi?id=24642, but the message is still there. Any ideas? Thank you Misha p.s. I compiled wine git with: ./configure CPPFLAGS='-I/usr/X11/include' LIBS='-lGL -lGLU' LDFLAGS='-L/usr/X11/lib' make && sudo make install and am using the command: DYLD_FALLBACK_LIBRARY_PATH="/usr/X11/lib:/usr/lib" wine ... on the Mac side. Thank you.

Feb. 15, 2011

Re: [PATCH] Implement software DXT1 compression

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 15.02.2011 um 14:39 schrieb alberto(a)mattea.info: > Good idea. This new patch implements this approach. It seems to be working > perfectly at least with the nvidia blob. It is also much smaller than the > previous one, and doesn't require hacks like inverting colors and so on.<dxt1.patch> It has one major architectural problem however. You need a GL context, but the SW conversion code cannot use one because it may be called from surface_gdi.c, which works without opengl. There are two ways out: 1) The easy one is to lift this restriction and just handle a context_acquire failure(ok, context_acquire needs some extensions for that). Error handling could just look like FIXME("no gl, bad luck"). But I think that is pretty ugly. 2) Implement the s3tc blits in the opengl blitting code in surface.c. Unfortunately the opengl blitting code is a mess, and adding s3tc blits won't make it better. To allow this we'll need to clean it up first. Rockerick was working on that but dropped the ball because other work interfered. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNWt+JAAoJEN0/YqbEcdMw17UP/jPtQkMRmTbfBMhgfDTfWNt8 4OgWC73XpMkyR924CcoHoZBQVRLN9ILSApgg8cjyrdsUOPJFoOEIHC/gyIyISbi3 PWtSVAGMTOLv7AkbSR/08pkJyFsGT1gen4HpRmDKRmaAjifiINcAkLhpLSmNOYx7 vFmf7ltknPviaODlOJZS02Lsi1HjGqXL4GaismR4U1oPJUzDAgwi9HeBBp2axrPN mzvnCsIoaZlVGq1SyX8pa3k2WkNLKWHCDwIA4FQFVM+MWoMxLTgxLvo9nuRpyh8F EoCUO68wO77jeKS4N1R4xMSd0ZBpS//V7h4M2MO3Hc1YWA5TJWr6Lo+MhWdMTYD0 ysn2am/Dw69U9ojOWRey4AXDDX3RjekXJzSGIaGPa3/783ThAun5n3E9SCWy/TZf /YZggIG0RckH50d4VWLCarWM3Pp7mF/tIAZSHheqD3r/PBBW/pfE8fDeG6Sw3Tae Mxqmacy+8W/kPVJ/SP+S9DuY2qqKD48YkD+QWn9PUze2NahIdtSTnDH6jn+SC5YJ Zl4ZVGPFLNDMoXN7E3QfWjYntczdzbA8O2jyYNv+45oPGO378OdZcrsEVIJnYi/v VlbMLxnYeE5w+tv0XsqVzDQ9WL9eEjTALO8NWtpQDbCMXE0UJnkJuIrMQxlvXg1y PxT69+lhBXsLlGlprb5+ =fZjK -----END PGP SIGNATURE-----

Feb. 15, 2011

Re: [website] Turn on gzip compression

by Jeremy Newman

Actually, a better way to accomplish this is to add: php_flag zlib.output_compression On to the .htaccess file. I'm a little surprised it was not there already. -N On 02/15/2011 01:02 PM, André Hentschel wrote: > First make sure that works with your server... > --- > site | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/site b/site > index 5a7bd46..a776199 100644 > --- a/site > +++ b/site > @@ -5,6 +5,8 @@ > by Jeremy Newman<jnewman(a)codeweavers.com> > */ > > +ob_start("ob_gzhandler"); > + > // load modules and defines > $file_root = realpath(dirname(__FILE__)); > require("{$file_root}/include/incl.php"); > @@ -114,4 +116,5 @@ $html->page = $html->template("local", PAGE); > $html->showpage(); > > // done > +ob_end_flush(); > ?>

Feb. 15, 2011

Re: [PATCH 3/4] urlmon: Properly handle BINDSTATUS_BEGINDOWNLOADDATA.

by Janne Hakonen

> On 2/15/11 5:13 PM, Marvin wrote: >> Hi, >> >> While running your changed tests on Windows, I think I found new >> failures. >> Being a bot and all I'm not very good at pattern recognition, so I might >> be >> wrong, but could you please double-check? >> Full results can be found at >> http://testbot.winehq.org/JobDetails.pl?Key=9273 >> >> Your paranoid android. >> >> >> === W7PROX64 (64 bit protocol) === >> protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED >> got 12045 > > I don't believe it's related, it seems like a random failure. It passed > clearly here: > http://testbot.winehq.org/JobDetails.pl?Key=9269&log_226=1#k226 > and sometimes fails in regular winetest run: > http://test.winehq.org/data/a24e8c8f0bd3924cc72501007eaaee10349c6c93/win7_w… Tried also on my Windows 7 Professional, but I couldn't reproduce those failures, even after multiple runs. E:\jhakonen\Downloads>urlmon_test64.exe protocol protocol.c:2544: Testing file protocol... protocol.c:2897: Testing http protocol (not from urlmon)... protocol.c:2901: Testing http protocol (from urlmon)... protocol.c:2905: Testing http protocol (to file)... protocol.c:2909: Testing http protocol (post data)... protocol.c:2915: Testing http protocol (post data stream)... protocol.c:2918: Testing http protocol (direct read)... protocol.c:2922: Testing http protocol (redirected)... protocol.c:2926: Testing http protocol abort... protocol.c:2939: Testing https protocol (from urlmon)... protocol.c:2959: Testing ftp protocol... protocol.c:3042: Testing gopher protocol... protocol.c:3084: Testing mk protocol... protocol.c:3158: Testing CreateBinding... protocol.c:3516: Testing file binding (mime verification, emulate prot)... protocol.c:3518: Testing http binding (mime verification, emulate prot)... protocol.c:3520: Testing its binding (mime verification, emulate prot)... protocol.c:3522: Testing http binding (mime verification, emulate prot, short read, direct read)... protocol.c:3524: Testing file binding (mime verification, emulate prot, mime filter)... protocol.c:3526: Testing http binding (mime verification, emulate prot, mime filter)... protocol.c:3528: Testing http binding (mime verification, emulate prot, direct read)... protocol.c:3530: Testing http binding (mime verification, emulate prot, abort)... protocol.c:3533: Testing file binding (use IUri, mime verification, emulate prot)... protocol.c:3535: Testing file binding (use IUri, impl StartEx, mime verification, emulate prot)... protocol.c:3537: Testing file binding (impl StartEx, mime verification, emulate prot)... protocol: 5135 tests executed (0 marked as todo, 0 failures), 0 skipped. Best Regards, Janne Hakonen

Feb. 15, 2011

Re: [1/2] winex11.drv: Add PS_USERSTYLE support to pens (take 2)

by Alexandre Julliard

Daniel <danielfsantos(a)att.net> writes: > @@ -54,11 +56,13 @@ HPEN CDECL X11DRV_SelectPen( X11DRV_PDEVICE *physDev, HPEN hpen ) > elp = HeapAlloc( GetProcessHeap(), 0, size ); > > GetObjectW( hpen, size, elp ); > - /* FIXME: add support for user style pens */ > + > logpen.lopnStyle = elp->elpPenStyle; > logpen.lopnWidth.x = elp->elpWidth; > logpen.lopnWidth.y = 0; > logpen.lopnColor = elp->elpColor; > + user_style_size = elp->elpNumEntries; > + user_style = elp->elpStyleEntry; This can't work, the data will be freed before you use it. -- Alexandre Julliard julliard(a)winehq.org

Feb. 15, 2011

Re: [PATCH 3/4] urlmon: Properly handle BINDSTATUS_BEGINDOWNLOADDATA.

by Jacek Caban

On 2/15/11 5:13 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=9273 > > Your paranoid android. > > > === W7PROX64 (64 bit protocol) === > protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 I don't believe it's related, it seems like a random failure. It passed clearly here: http://testbot.winehq.org/JobDetails.pl?Key=9269&log_226=1#k226 and sometimes fails in regular winetest run: http://test.winehq.org/data/a24e8c8f0bd3924cc72501007eaaee10349c6c93/win7_w… Jacek

Feb. 15, 2011

Re: [PATCH 3/4] urlmon: Properly handle BINDSTATUS_BEGINDOWNLOADDATA.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9273 Your paranoid android. === W7PROX64 (64 bit protocol) === protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045 protocol.c:278: Test failed: Expected ERROR_INTERNET_SEC_CERT_REV_FAILED got 12045

Feb. 15, 2011

Re: [PATCH 2/4] urlmon: Read remaining protocol data if report_data was called after binding finished.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9272 Your paranoid android. === WVISTAADM (32 bit url) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

Feb. 15, 2011

Re: [PATCH] Fixed several links in the documentation...

by Alexandre Julliard

max(a)mtew.isa-geek.net writes: > @@ -204,7 +204,7 @@ int CDECL MSVCRT__chdir(const char * newdir) > /********************************************************************* > * _wchdir (MSVCRT.@) > * > - * Unicode version of _chdir. > + * Unicode version of MSVCRT__chdir. You don't want to use the internal name here, it's not useful for users. -- Alexandre Julliard julliard(a)winehq.org

Feb. 15, 2011

Re: gdi32: Fixed GetDIBits for top-down bitmaps (try 2).

by Alexandre Julliard

Jack Edmonds <pocketcookies2(a)gmail.com> writes: > gdi32/dib.c: Reversed source bitmap pointer instead of destination bitmap pointer. > Removed check for destination bitmap height when determining whether to copy the source bitmap upside down. > gdi32/tests/bitmap.c: Added a test for copying between top-down bitmaps. The rest of the code won't cope so well with a negative source width. -- Alexandre Julliard julliard(a)winehq.org

Feb. 15, 2011

Re: [3/5] msxml3/xsl: Basic put_input() method for IXSLProcessor

by Nikolay Sivov

On 2/15/2011 18:53, Jacek Caban wrote: > Hi Nikolay, > > On 2/14/11 9:04 PM, Nikolay Sivov wrote: >> Basic put_input() method for IXSLProcessor >> > > + IXMLDOMNode *old_input = This->input; > + HRESULT hr; > > - FIXME("(%p): stub\n", This); > - return E_NOTIMPL; > + TRACE("(%p)->(type=%d)\n", This, V_VT(&input)); > + > + /* try IXMLDOMNode directly first */ > + if (V_VT(&input) == VT_UNKNOWN) > + hr = > IUnknown_QueryInterface(V_UNKNOWN(&input),&IID_IXMLDOMNode, > (void**)&This->input); > + else if (V_VT(&input) == VT_DISPATCH) > + hr = > IDispatch_QueryInterface(V_DISPATCH(&input),&IID_IXMLDOMNode, > (void**)&This->input); > + > + if (hr != S_OK) > + { > + IXMLDOMDocument *doc; > + > + hr = DOMDocument_create(&CLSID_DOMDocument, NULL, (void**)&doc); > + if (hr == S_OK) > + { > + hr = IXMLDOMDocument_QueryInterface(doc,&IID_IXMLDOMNode, > (void**)&This->input); > + IXMLDOMDocument_Release(doc); > + } > + } > + > + if (hr == S_OK&& old_input) IXMLDOMNode_Release(old_input); > > Failure of QueryInterface call will set This->input to NULL (you > probably want it not changed and even if not, that's a leak). It's > probably better idea to have local pointer to the new input instead of > old one and change it once you know the function will succeed. Right, another thing is that I don't load a document from input variant. > > Jacek >

Feb. 15, 2011

Re: [4/5] msxml3/xsl: Store output stream for processor

by Jacek Caban

Hi Nikolay, On 2/14/11 9:04 PM, Nikolay Sivov wrote: > + case VT_UNKNOWN: > + hr = IUnknown_QueryInterface(V_UNKNOWN(&output),&IID_IStream, (void**)&This->output); > + break; You leak This->output here. Jacek

Feb. 15, 2011

Re: [3/5] msxml3/xsl: Basic put_input() method for IXSLProcessor

by Jacek Caban

On 2/15/11 4:53 PM, Jacek Caban wrote: > Hi Nikolay, > > On 2/14/11 9:04 PM, Nikolay Sivov wrote: >> Basic put_input() method for IXSLProcessor >> > + TRACE("(%p)->(type=%d)\n", This, V_VT(&input)); I missed it in my previous mail, but we have debugstr_variant for this in msxml3 now. Jacek

Feb. 15, 2011

Re: [3/5] msxml3/xsl: Basic put_input() method for IXSLProcessor

by Jacek Caban

Hi Nikolay, On 2/14/11 9:04 PM, Nikolay Sivov wrote: > Basic put_input() method for IXSLProcessor > + IXMLDOMNode *old_input = This->input; + HRESULT hr; - FIXME("(%p): stub\n", This); - return E_NOTIMPL; + TRACE("(%p)->(type=%d)\n", This, V_VT(&input)); + + /* try IXMLDOMNode directly first */ + if (V_VT(&input) == VT_UNKNOWN) + hr = IUnknown_QueryInterface(V_UNKNOWN(&input),&IID_IXMLDOMNode, (void**)&This->input); + else if (V_VT(&input) == VT_DISPATCH) + hr = IDispatch_QueryInterface(V_DISPATCH(&input),&IID_IXMLDOMNode, (void**)&This->input); + + if (hr != S_OK) + { + IXMLDOMDocument *doc; + + hr = DOMDocument_create(&CLSID_DOMDocument, NULL, (void**)&doc); + if (hr == S_OK) + { + hr = IXMLDOMDocument_QueryInterface(doc,&IID_IXMLDOMNode, (void**)&This->input); + IXMLDOMDocument_Release(doc); + } + } + + if (hr == S_OK&& old_input) IXMLDOMNode_Release(old_input); Failure of QueryInterface call will set This->input to NULL (you probably want it not changed and even if not, that's a leak). It's probably better idea to have local pointer to the new input instead of old one and change it once you know the function will succeed. Jacek

Feb. 15, 2011

Re: Re: [PATCH] Implement software DXT1 compression

by alberto＠mattea.info

> An idea that was proposed before was to delegate the conversion (and the > patents burden) to the OpenGL drivers, something like using > glCompressedTexImage2D() / glGetCompressedTexImage(). Not sure > whether there are hidden issues with that approach (except, well, requiring > an OpenGL driver with compressed textures support), but at a first glance > it doesn't look as something particularly hard to do. Good idea. This new patch implements this approach. It seems to be working perfectly at least with the nvidia blob. It is also much smaller than the previous one, and doesn't require hacks like inverting colors and so on.

Feb. 15, 2011

Re: [1/4] mshtml: Ignore IActiveScript interface for IXMLHTTPRequest (resend)

by Alistair Leslie-Hughes

Hi Jacek, On 14/02/2011 9:48 PM, Jacek Caban wrote: > On 2/14/11 10:03 AM, Alistair Leslie-Hughes wrote: >> Changelog: >> mshtml: Ignore IActiveScript interface for IXMLHTTPRequest > > mshtml? > > + else if ( IsEqualGUID( riid,&IID_IActiveScript)) > + { > + TRACE("(%p)->(IID_IActiveScript %p) returning NULL\n", This, ppvObject); > + *ppvObject = NULL; > + return E_NOINTERFACE; > + } > else > { > FIXME("Unsupported interface %s\n", debugstr_guid(riid)); > > As discussed on wine-devel, please just change the later FIXME to TRACE > instead. By just changing the FIXME to a TRACE would hide this fact that IObjectWithSite and IObjectSafety need to be implemented at some point. Only with msxml tracing would be see this fact, which would lead to hard to pin point errors. We need to just ignore two know interfaces IActiveScript and IDispatchEx. If we are going to stop silencing interfaces, Should be just remove the ones already in webbrowser(shdocvw)? No, We do this so other developers can see that these interfaces are not supported and so they don't need to waste there time researching them. We silence interfaces like the above in other places, so why no here? Best Regards Alistair Leslie-Hughes

Feb. 15, 2011

Re: [1/2] winex11.drv: Add PS_USERSTYLE support to pens (take 2)

by Daniel

OK, actually it looks like the problem is already in X11DRV_SelectPen and is unlikely to occur, so my patches are good. Still, I'm thinking that if GetObjectW fails (http://source.winehq.org/source/dlls/winex11.drv/pen.c#L45) then we should immediately exit the function returning zero rather than mucking around any further, setting the pen's ext field to zero, etc. Then PEN_SelectObject (http://source.winehq.org/source/dlls/gdi32/pen.c#L220) wont replace the current pen with the uninitialized data. I realize this perhaps "shouldn't fail" after a successful call to GDI_inc_ref_count, but it still seems more responsible. Daniel On 02/15/2011 01:37 AM, Daniel wrote: > grr, please disregard previous patches. I've discovered a problem > that can lead to use of un-initialized values. > > Daniel > > On 02/15/2011 01:09 AM, Daniel wrote: >> Clean up per Vitaliy's direction. Also found a FIXME comment that needed >> to be removed. >> >> Daniel >> >> >>

Feb. 15, 2011

Re: [1/2] winex11.drv: Add PS_USERSTYLE support to pens (take 2)

by Daniel

grr, please disregard previous patches. I've discovered a problem that can lead to use of un-initialized values. Daniel On 02/15/2011 01:09 AM, Daniel wrote: > Clean up per Vitaliy's direction. Also found a FIXME comment that needed > to be removed. > > Daniel > > >

Feb. 15, 2011

Re: gdi32: correct substitutions (take 2)

by Dmitry Timoshkov

Rafał Mużyło <galtgendo(a)gmail.com> wrote: > Corrected version of the previous patch. > This time I'm not adding a new helper function, just putting it in one > place. > Corrections: > - as oppossed to get_font_subst, reverse check can have more than one > result, so changed to adjust all of them > - just in case a->a substitution would result, explicitly prevent that > (perhaps gdi32 handles it gracefully, but it's still redundant) Did you test that Windows handles font substitutions this way? -- Dmitry.

Feb. 15, 2011

Re: Re: [PATCH] Implement software DXT1 compression

by Matteo Bruni

2011/2/14 <alberto(a)mattea.info>: > Hi Stefan, thanks for your answer. I've checked the nvidia texture tools > but, sadly, I think it's impossible to use them in wine: while they have c > bindings, those bindings lack the essential function > nvttSetOutputOptionsOutputHandler(NvttOutputOptions * outputOptions, > nvttOutputHandler outputHandler, nvttImageHandler imageHandler) > (commented out in the headers), so the output can only be written to a > file. > What about going the mesa way, where the drivers aren't linked with any > s3tc library, but load it at runtime if it is present? > Any idea is welcome. > An idea that was proposed before was to delegate the conversion (and the patents burden) to the OpenGL drivers, something like using glCompressedTexImage2D() / glGetCompressedTexImage(). Not sure whether there are hidden issues with that approach (except, well, requiring an OpenGL driver with compressed textures support), but at a first glance it doesn't look as something particularly hard to do.

Feb. 14, 2011

Re: wine is passing make test again :-)

by Alexandre Julliard

Juan Lang <juan.lang(a)gmail.com> writes: >> Frankly, I'm a bit surprised and disappointed to see that people are not >> taking responsibility for fixing failures they introduced in tests. I don't >> expect to have time to clean up after them for the next month or so. > > Hopefully, if we can get the tests passing as a more normal > occurrence, we can make not introducing new failures a stronger > requirement than it already is. It's already a strict requirement, but failures don't always get caught by the testbot, especially when they are triggered by some previous test. -- Alexandre Julliard julliard(a)winehq.org

Feb. 14, 2011

Re: Re: [PATCH] Implement software DXT1 compression

by alberto＠mattea.info

Hi Stefan, thanks for your answer. I've checked the nvidia texture tools but, sadly, I think it's impossible to use them in wine: while they have c bindings, those bindings lack the essential function nvttSetOutputOptionsOutputHandler(NvttOutputOptions * outputOptions, nvttOutputHandler outputHandler, nvttImageHandler imageHandler) (commented out in the headers), so the output can only be written to a file. What about going the mesa way, where the drivers aren't linked with any s3tc library, but load it at runtime if it is present? Any idea is welcome.

Feb. 14, 2011

Re: [PATCH] Implement software DXT1 compression

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 14.02.2011 um 16:50 schrieb alberto(a)mattea.info: > I would also like some feedback about > the patent situation, e.g. if the patch can be mainlined as it is or if it > would be better to load libtxc_dxtn directly at runtime. I'm afraid neither solution is entirely satisfactory. I recommend to take a look at the Nvidia Texture tools. This is a BSD-licensed(I think) library(+ callable programs) for which Nvidia has licensed the S3TC patent. So if we dynamically link to this library and use it we should be in the clear. The library behind nv texture tools is C++, but it does have C bindings. libtxc_dxtn has at least some decompression bugs, some games like gothic 2 didn't render properly with it. (When using the S3tc->ARGB8 sw decompression path of gothic 2. With HW dxtn the game doesn't use SW decompression) -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJNWXkXAAoJEN0/YqbEcdMwxWsQAIkF62VJ0CxrVS3UWhXmqf8n UHKyDdrQr4e2EybZL8Q8EptYQO5hjvWuABgyZcrRpwXo11edNB5rcOVpyAcHimxz 0DH2X5q06KmlExmEKx2+8ePS5B8yTxoXDSfFKDF2Kb+f28X3IT6w+nE0iFyUv2nU aioO6ad8z+3EjzLSiY3zMYls5KMH3a41gSfEzvzHi/W3HtlWE1oJ6zg4Ep+/EgAd 5AXsp7GAjjJxjl+LGTBCwQyREZ07+Qbyra7ne1MZvZjgYe2M74q16QXf7mZ16/OH NUe4dq3Deyq/wXaPbh6xTau6GSQPJztZif/Tg0eryD/Vlated5fA7a75sLqVNeCH nhu80jjBeGJv+l6dEeLLnXnYRE08+Fdalzbii2uc+jiJlYXuhQdKSc0GcXRWl4U/ TvYwYe/yh84UlhBLAWGcwxZG4SXGRuGR6DyFPAYfjzg7Y5JPrrJYjjLyOAAeza4K e4b4enBqB4IYj66RU8a7eaOv+g2VRXaeb/HIAEd6DgpvN05Qs8k0MUGvZCGQy5uM W0FzWGaDLvGL8V+vchMWrYN925nJqFLGRpGPcOahvqMA9IdRXVMqy62Ohx7NLa3h vPOp8zPg//xAoEzBE3j0Z1Xy1pNKvcPSuG3uMpYqnH0qsuSbO/JtCAA2hel47EfQ fOScjJoppTUon/mbYl85 =ehwC -----END PGP SIGNATURE-----

Feb. 14, 2011