February 2011 - Wine-Devel - list.winehq.org

Please help me with document extraction.

by Max TenEyck Woodbury

As my previous efforts have probably informed you, I am interested in documentation. My initial efforts were _not_ on target and had missed the existing 'c2man.pl' tool. I am in the process of correcting my failure on that. I've picked up Perl in the last couple weeks. An interesting language with lots of adopted features. It's been easy to learn, so I think I will _not_ need help with the language itself, but I will listen to any advice. The c2man.pl code is extensive and sparsely commented. In order to understand what it does, I've made a transcription of it with a more compact style and lots more comments. I check the rewrite against the source code so there should not be any serious errors. There are also a number of what I believe to be defects in the original and places where my comments may be inappropriate or my style may be very objectionable. _This_ is what I need help with. Would someone be willing to review my rewrite? If so, send me e-mail so I can arrange to get a copy of it to you. P.S. to AJ et al. There is a _lot_ of documentation embedded in the wine code, but it is hard to find at the moment. I'd like to see it indexed and this is the program that does the extraction and indexing. Advice on making this new version available and active are in order. Max

Feb. 27, 2011

Patches to fix GetDIBits for top down destination bitmaps

by John Edmonds

Please ignore the patches http://source.winehq.org/patches/data/71716 and http://source.winehq.org/patches/data/71711. I was having trouble with my mail client and accidentally sent the same code 3 times.

Feb. 27, 2011

Re: comctl32: Shed an unused parameter of TOOLTIPS_HitTestT and rename to TOOLTIPS_HitTest.

by James McKenzie

On 2/27/11 1:46 AM, Nikolay Sivov wrote: > On 2/26/2011 23:01, Gerald Pfeifer wrote: >> --- >> dlls/comctl32/tooltips.c | 7 +++---- >> 1 files changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c >> index a2e58e0..445845c 100644 >> --- a/dlls/comctl32/tooltips.c >> +++ b/dlls/comctl32/tooltips.c >> @@ -1396,8 +1396,7 @@ TOOLTIPS_GetToolInfoT (const TOOLTIPS_INFO >> *infoPtr, TTTOOLINFOW *ti, BOOL isW) >> >> >> static LRESULT >> -TOOLTIPS_HitTestT (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW >> lptthit, >> - BOOL isW) >> +TOOLTIPS_HitTest (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW >> lptthit) >> { >> TTTOOL_INFO *toolPtr; >> INT nTool; >> @@ -2209,8 +2208,8 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, >> WPARAM wParam, LPARAM lParam) >> >> case TTM_HITTESTA: >> case TTM_HITTESTW: >> - return TOOLTIPS_HitTestT (infoPtr, (LPTTHITTESTINFOW)lParam, >> - uMsg == TTM_HITTESTW); >> + return TOOLTIPS_HitTest (infoPtr, (LPTTHITTESTINFOW)lParam); >> + >> case TTM_NEWTOOLRECTA: >> case TTM_NEWTOOLRECTW: >> return TOOLTIPS_NewToolRectT (infoPtr, (LPTTTOOLINFOW)lParam); > This should properly handle text instead of removing A/W case. > > Even if all it does is convert ANSI to UNICODE and then call the UNICODE case correct? This is more a question on how I should handle a case I'm working with for riched20, not a comment on this particular piece of code. James McKenzie

Feb. 27, 2011

Re: comctl32: Shed an unused parameter of TOOLTIPS_HitTestT and rename to TOOLTIPS_HitTest.

by Nikolay Sivov

On 2/26/2011 23:01, Gerald Pfeifer wrote: > --- > dlls/comctl32/tooltips.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c > index a2e58e0..445845c 100644 > --- a/dlls/comctl32/tooltips.c > +++ b/dlls/comctl32/tooltips.c > @@ -1396,8 +1396,7 @@ TOOLTIPS_GetToolInfoT (const TOOLTIPS_INFO *infoPtr, TTTOOLINFOW *ti, BOOL isW) > > > static LRESULT > -TOOLTIPS_HitTestT (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit, > - BOOL isW) > +TOOLTIPS_HitTest (const TOOLTIPS_INFO *infoPtr, LPTTHITTESTINFOW lptthit) > { > TTTOOL_INFO *toolPtr; > INT nTool; > @@ -2209,8 +2208,8 @@ TOOLTIPS_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) > > case TTM_HITTESTA: > case TTM_HITTESTW: > - return TOOLTIPS_HitTestT (infoPtr, (LPTTHITTESTINFOW)lParam, > - uMsg == TTM_HITTESTW); > + return TOOLTIPS_HitTest (infoPtr, (LPTTHITTESTINFOW)lParam); > + > case TTM_NEWTOOLRECTA: > case TTM_NEWTOOLRECTW: > return TOOLTIPS_NewToolRectT (infoPtr, (LPTTTOOLINFOW)lParam); This should properly handle text instead of removing A/W case.

Feb. 27, 2011

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

by Misha Koshelev

On Sat, Feb 26, 2011 at 4:48 PM, Juan Lang <juan.lang(a)gmail.com> wrote: > Hi Misha, > >> My own (very unhelpful) diagnosis of the pattern is that, for the >> mantissa values: >> >> 2018.5 should round to 2018 >> 2019.5 should round to 2020 > > The pattern appears to be "round half to even", which you may read > about on Wikipedia: > http://en.wikipedia.org/wiki/Rounding#Round_half_to_even > --Juan > Thanks Juan. I have implemented this in the patch. I am, unfortunately, still pretty stumped. There are quite a few cases per Matteo's wonderful rounding code for truncation of very small (?) numbers where rounding should _not_ occur. I have included relevant output from running make math.ok for those cases. Note, that it is not the specific mantissa #'s per se (I checked), not even combinations of mantissa #'s and exp's, and not mantissa #'s and exp's and <= 0.25f difference between ((unsigned int) tmp) and (((unsigned int) tmp) & 0x3ff) - I checked all these. There is apparently some pattern in the original single #'s themselves that I am not seeing. If anyone has a keener eye than I let me know. Also, I am assuming a stub of this function would actually not be accepted into Wine (can't return E_NOTIMPL, e.g.). If I am _incorrect_ about this please let me know. Thank you. Have a great Saturday! Misha

Feb. 27, 2011

Re: [3/3] comctl32/tests: Add a statusbar test for setting number of parts to zero.

by Peter Urbanec

On 26/02/11 04:12, Marvin wrote: > http://testbot.winehq.org/JobDetails.pl?Key=9486 > > === W7PROX64 (64 bit status) === > status.c:412: Test failed: Expected 1, got 0 Please ignore all 3 patches in the set. I will investigate Win behaviour a little closer and resubmit the patches once I learn more.

Feb. 27, 2011

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

by Juan Lang

Hi Misha, > My own (very unhelpful) diagnosis of the pattern is that, for the > mantissa values: > > 2018.5 should round to 2018 > 2019.5 should round to 2020 The pattern appears to be "round half to even", which you may read about on Wikipedia: http://en.wikipedia.org/wiki/Rounding#Round_half_to_even --Juan

Feb. 26, 2011

Re: d3dx9: Implement D3DXFloat32To16Array and D3DXFloat16To32Array. (try 2)

by Misha Koshelev

> Hi Misha, > > ... > > I'm attaching your patch with some modifications (mostly I took some > missing pieces from my old, way broken, patch). It seems to help a bit > but it's not perfect yet. It fixes handling of > 65520.0 values and > denormalized numbers. The interesting bit was to have some ad-hoc > rounding for the denormalized case. > The current implementation doesn't match native on some rounding > cases, but it's not clear what really the issue is. If you replace >= > with a > in "if (tmp - mantissa >= 0.5f) mantissa++;" you essentially > switch some failing cases with others. Maybe it has something to do > with floating point CPU rounding mode, but that seems unlikely to me. > Some testing under Windows is also needed. > > Ok, that's all. Please continue your work, correct 32/16 bit float > conversion functions are really a good thing to have (and you can fix > the implementation in wined3d after this is done ;)) > Hi Guys, Just thought I'd forward to the list (I hope it's ok Matteo). I'm pretty stumped. Matteo's patches were a big help. I did test on Windows and saw same result. My own (very unhelpful) diagnosis of the pattern is that, for the mantissa values: 2018.5 should round to 2018 2019.5 should round to 2020 2016.5 should round to 2016 2017.5 should round to 2018 2014.5 should round to 2014 2015.5 should round to 2016 2012.5 should round to 2012 2013.5 should round to 2014 1954.5 should round to 1954 1955.5 should round to 1956 1952.5 should round to 1952 1953.5 should round to 1954 1950.5 should round to 1950 1951.5 should round to 1952 1948.5 should round to 1948 1949.5 should round to 1950 I have attached a patch that makes this explicit and has just one failing test. Unfortunately, if we change the increment from 0xfff to 0xff, we seem to have a lot more disagreements. If anyone has any ideas pls let me know. I am stumped. I am going to see if perhaps I can make the relevant game work better by stubbing, and, if so, will submit a stub patch for now. Thank you Misha p.s. Note: the singles2halfp function is not mine, and is licensed under the BSD license. I modified it slightly to see if it would make things better. It didn't. It is not meant to actually be included in Wine but is useful for testing. http://www.mathworks.com/matlabcentral/fileexchange/23173 Thank you

Feb. 26, 2011

Re: kernel32/tests: remove win9x hacks (try 2)

by James McKenzie

On 2/25/11 10:33 AM, Alexandre Julliard wrote: > Saulius Krasuckas<saulius2(a)ar.fi.lt> writes: > >> Thanks. Do you mean something like integrating OpenWatcom C compiler >> optionally into dlls/*/tests? >> >> And then running 16-bit part of winetest on Win3.1? WinXP seems to be >> broken in my case. While Win98 seems OK. > No, winetest would run on XP. If your app doesn't work on XP then it's > unlikely to work on Wine. We are *not* going to replicate the Win95 > 16-bit architecture. I've been looking at the use of is_win9x and all the tests do for riched20 (except one) is check for the presence of UNICODE calls, namely lstrcmpW. I would like to rename the variable and redo the test. Is this acceptable or should the test itself be dropped? James McKenzie

Feb. 26, 2011

Re: [wiki] Fix Link to MoinMoin

by John Klehm

2011/2/26 André Hentschel <nerv(a)dawncrow.de>: > - 'Sponsored by <a href="http://lattica.com/">Lattica</a> <a href="http://moinmoin.wikiwikiweb.de/">MoinMoin Powered</a>' > + 'Sponsored by <a href="http://lattica.com/">Lattica</a> <a href="http://www.moinmo.in/">MoinMoin Powered</a>' Death to www? Just http://moinmo.in/ perhaps? Regards, --John

Feb. 26, 2011