March 2011 - Wine-Devel - list.winehq.org

Re: [PATCH] Label verbosity levels.

by Joris Huizer

On 03/19/2011 11:32 PM, Vitaliy Margolen wrote: > On 03/18/2011 09:24 PM, max(a)mtew.isa-geek.net wrote: >> - if ($opt_verbose> 0) >> - { >> - print "Processing ".$spec_name."\n"; >> - } >> + print "Processing ".$spec_name."\n" >> + if $opt_verbose>= $VERBOSE_INPUT; > Please don't do this reverse notation. It's much more confusing to > most people who are not too familiar with Perl. > > Also you changing logic, by replacing ">" (greater then) with ">=" > (greater of equal. This is a big no-no to combine any logical changes > with cleanup changes. > > This doesn't seem to change logic as $VERBOSE_INPUT equals 1 ( $VERBOSE_QUIET equals 0 )

March 20, 2011

Re: [PATCH] Label verbosity levels.

by Vitaliy Margolen

On 03/18/2011 09:24 PM, max(a)mtew.isa-geek.net wrote: > - if ($opt_verbose> 0) > - { > - print "Processing ".$spec_name."\n"; > - } > + print "Processing ".$spec_name."\n" > + if $opt_verbose>= $VERBOSE_INPUT; Please don't do this reverse notation. It's much more confusing to most people who are not too familiar with Perl. Also you changing logic, by replacing ">" (greater then) with ">=" (greater of equal. This is a big no-no to combine any logical changes with cleanup changes.

March 19, 2011

GSOC-Introduction

by Sanket Patel

Hi there I am Sanket Patel I can code well in C If Anything is say to Implement I have good skill in coding in C At all And can Use Efficient C help topics.

March 19, 2011

Summer of Code 2011 is on!

by Maarten Lankhorst

Hi all, As you may have known wine has been accepted for summer of code 2011 as a mentoring organization. As such the wine project is now looking for students to participate this year with wine. On our wiki page[1] you can find some ideas, but if you come up with your own idea you will have a lot better chance of getting accepted, as long as you listen to feedback. Summer of code is not just learning to code, but also getting your code accepted into the wine git tree. We'll try to help with that, but the interaction with the wine community is definitely required. For some advice you can read [2] for example. [1] http://wiki.winehq.org/SummerOfCode [2] http://bit.ly/efXVqz Cheers, Maarten PS1: Is anyone willing to add a 'news' blurb about summer of code to the main site? PS2: Also looking for mentor applies.

March 19, 2011

Re: clusapi: add stub for GetClusterInformation

by Michael Stefaniuc

On 03/18/2011 06:53 PM, Wolfram Sang wrote: >> Content-Type: text/plain; charset="us-ascii"; Format="flowed" >> >> I am out of ideas if this is acceptable for wine-patches@, though:) > > I'd clearly say no because it obviously produces unpredictable results > :) They are discouraged in kernel-space as well. And Format="flowed" is actually a typo in the spec; they wanted to say "flawed" ;) bye michael

March 18, 2011

Vacation

by Alexandre Julliard

Folks, There won't be any commits next week, since I'll be busy skiing. Next release should be on schedule two weeks from now. See you all in a week! -- Alexandre Julliard julliard(a)winehq.org

March 18, 2011

Re: urlmon: Use unescaped Urls for FTP actions (try 2)

by Jacek Caban

Hi André, On 3/17/11 8:58 PM, André Hentschel wrote: > ...don't leak path... > --- > dlls/urlmon/ftp.c | 16 ++++++++++++---- > 1 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/dlls/urlmon/ftp.c b/dlls/urlmon/ftp.c > index c9d43b8..a27d84c 100644 > --- a/dlls/urlmon/ftp.c > +++ b/dlls/urlmon/ftp.c > @@ -59,22 +59,30 @@ static HRESULT FtpProtocol_open_request(Protocol *prot, IUri *uri, DWORD request > HINTERNET internet_session, IInternetBindInfo *bind_info) > { > FtpProtocol *This = impl_from_Protocol(prot); > - BSTR url; > + DWORD path_size = INTERNET_MAX_URL_LENGTH; > + BSTR url, path; > HRESULT hres; > > hres = IUri_GetAbsoluteUri(uri,&url); > if(FAILED(hres)) > return hres; > + path = heap_alloc(path_size); > + hres = UrlUnescapeW((LPWSTR)url, path,&path_size, 0); It looks like using GetDisplayUri is what you need. Jacek

March 18, 2011

Re: clusapi: add stub for GetClusterInformation

by Wolfram Sang

> Content-Type: text/plain; charset="us-ascii"; Format="flowed" > > I am out of ideas if this is acceptable for wine-patches@, though:) I'd clearly say no because it obviously produces unpredictable results :) They are discouraged in kernel-space as well. Regards, Wolfram

March 18, 2011

Re: [1/2] msvcrt: Implement _mbsupr_s (try2).

by Dan Kegel

On Thu, Mar 17, 2011 at 11:19 PM, Konrad Rzepecki <hannibal(a)astral.lodz.pl> wrote: >> Tests might be in order... > > Probably you have right. But if you look at code support for multibyte case > change is in fact notexistent. I've only wrtite this code for my immediate > need - I've only adopted current _mbsupr to have character count and error > handling described in MSDN. > > Sorry, but I have no resources to implement all underlying multibyte support. But you could do a few tests. It's ok if some of them are todo_wine. - Dan

March 18, 2011

Re: clusapi: add stub for GetClusterInformation

by Saulius Krasuckas

* On Fri, 18 Mar 2011, Nikolay Sivov wrote: > On 3/18/2011 11:04, Dmitry Timoshkov wrote: > > Konrad Rzepecki<hannibal(a)astral.lodz.pl> wrote: > > > > > +DWORD WINAPI GetClusterInformation(HCLUSTER hCluster, LPWSTR > > > lpszClusterName, LPDWORD lpcchClusterName, LPCLUSTERVERSIONINFO > > > lpClusterInfo) > > It looks like your mailer has wrapped all your patches. > Strange, looks fine for me, maybe mine unwrapped it. Yes, I guess it did. Mine did too. The message was in flowed format: Content-Type: text/plain; charset="us-ascii"; Format="flowed" I am out of ideas if this is acceptable for wine-patches@, though:) S.

March 18, 2011

Re: clusapi: add stub for GetClusterInformation

by Nikolay Sivov

On 3/18/2011 11:04, Dmitry Timoshkov wrote: > Konrad Rzepecki<hannibal(a)astral.lodz.pl> wrote: > >> +/*********************************************************************** >> + * GetClusterInformation (CLUSAPI.@) >> + * >> + */ >> +DWORD WINAPI GetClusterInformation(HCLUSTER hCluster, LPWSTR >> lpszClusterName, LPDWORD lpcchClusterName, LPCLUSTERVERSIONINFO >> lpClusterInfo) > It looks like your mailer has wrapped all your patches. Strange, looks fine for me, maybe mine unwrapped it.

March 18, 2011

Re: clusapi: add stub for GetClusterInformation

by Dmitry Timoshkov

Konrad Rzepecki <hannibal(a)astral.lodz.pl> wrote: > +/*********************************************************************** > + * GetClusterInformation (CLUSAPI.@) > + * > + */ > +DWORD WINAPI GetClusterInformation(HCLUSTER hCluster, LPWSTR > lpszClusterName, LPDWORD lpcchClusterName, LPCLUSTERVERSIONINFO > lpClusterInfo) It looks like your mailer has wrapped all your patches. -- Dmitry.

March 18, 2011

Re: [1/2] msvcrt: Implement _mbsupr_s (try2).

by Konrad Rzepecki

Dnia piątek, 18 marca 2011, Dan Kegel napisał(a): > Konrad wrote: > > + c = _mbctoupper(_mbsnextc(s)); > > + /* Note that I assume that the size of the character is unchanged > > */ + if (c > 255) > > + { > > + *s++=(c>>8); > > + c=c & 0xff; > > + } > > + *s++=c; > > Tests might be in order... > (Here's one possible interesting test case: > http://blogs.msdn.com/b/michkap/archive/2009/08/11/9864576.aspx ) > - Dan Probably you have right. But if you look at code support for multibyte case change is in fact notexistent. I've only wrtite this code for my immediate need - I've only adopted current _mbsupr to have character count and error handling described in MSDN. Sorry, but I have no resources to implement all underlying multibyte support. PC. Please CC I'm not on the list -- Konrad Rzepecki (Hannibal)

March 18, 2011

re: [1/2] msvcrt: Implement _mbsupr_s (try2).

by Dan Kegel

Konrad wrote: > + c = _mbctoupper(_mbsnextc(s)); > + /* Note that I assume that the size of the character is unchanged */ > + if (c > 255) > + { > + *s++=(c>>8); > + c=c & 0xff; > + } > + *s++=c; Tests might be in order... (Here's one possible interesting test case: http://blogs.msdn.com/b/michkap/archive/2009/08/11/9864576.aspx ) - Dan

March 18, 2011

Re: msxml3: Prevent a crash at second call to vsnprintf

by Nikolay Sivov

On 3/18/2011 02:00, André Hentschel wrote: > i did test that now for a while and if the first time the buffer isn't enough and len gets incremented (no matter how much) then the next call to vnsprintf crashes. > that seems to happen only with 64 bits and i would blame Ubuntu for it :) > see http://test.winehq.org/data/12b24af8d7bbb515c4cc678eef45c396487816a4/wine_a… > > so bumping the buffer length to 64 is enough to not trigger that case with our testsuite > --- > dlls/msxml3/main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/msxml3/main.c b/dlls/msxml3/main.c > index 01eabab..d3fda99 100644 > --- a/dlls/msxml3/main.c > +++ b/dlls/msxml3/main.c > @@ -63,7 +63,7 @@ HINSTANCE MSXML_hInstance = NULL; > void wineXmlCallbackLog(char const* caller, xmlErrorLevel lvl, char const* msg, va_list ap) > { > char* buf = NULL; > - int len = 32, needed; > + int len = 64, needed; > enum __wine_debug_class dbcl = __WINE_DBCL_ERR; > switch (lvl) > { I feel like you need to figure out why it crashes.

March 17, 2011

Re: Spammer on AppDB

by Rosanne DiMesio

On Thu, 17 Mar 2011 16:09:30 -0600 Erich Hoover <ehoover(a)mines.edu> wrote: > Account named "AnnaT": > http://appdb.winehq.org/objectManager.php?sClass=version&iId=7440#Comment-6… I've deleted the comment and the user. -- Rosanne DiMesio <dimesio(a)earthlink.net>

March 17, 2011

Spammer on AppDB

by Erich Hoover

Account named "AnnaT": http://appdb.winehq.org/objectManager.php?sClass=version&iId=7440#Comment-6…

March 17, 2011

Re: wineport: Add support for ctz().

by Adam Martinson

On 03/17/2011 02:04 PM, Alexander Kochetkov wrote: >> For my purposes the 'return -1' path will never be taken, so it's not >> needed. I want to be able to do: >> >> while (bitmap) >> { >> i = ctz(bitmap); /* get the LSB index */ >> bitmap ^= 1<< i; /* zero LSB */ >> >> /* for each set bit i... */ >> } >> >> If there's a faster way to do this I'm all ears. >> > while (bitmap) > { > bitmap = (bitmap& (bitmap - 1)); /* zero LSB */ > > /* for each set bit i... */ > } > > You could try this solution to zero lsb. > Yes, that's another way to zero the LSB, but I need the index (i).

March 17, 2011

Re: msvcrt: add implementation of _mbsupr_s and _mbslwr_s

by Austin English

On Thu, Mar 17, 2011 at 09:39, Konrad Rzepecki <hannibal(a)astral.lodz.pl> wrote: > --- > dlls/msvcr100/msvcr100.spec | 4 +- > dlls/msvcr80/msvcr80.spec | 4 +- > dlls/msvcr90/msvcr90.spec | 4 +- > dlls/msvcrt/mbcs.c | 72 > +++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/msvcrt.spec | 4 +- > 5 files changed, 80 insertions(+), 8 deletions(-) These should be two separate patches, one for each function. Thanks for working on Wine! -- -Austin

March 17, 2011

Re: wineport: Add support for ctz().

by Adam Martinson

On 03/17/2011 02:54 AM, Marcus Meissner wrote: > On Wed, Mar 16, 2011 at 01:26:31PM -0500, Adam Martinson wrote: >> On 03/16/2011 08:34 AM, Alexandre Julliard wrote: >>> Adam Martinson<amartinson(a)codeweavers.com> writes: >>> >>>> @@ -239,6 +243,19 @@ extern int getopt_long_only (int ___argc, char *const *___argv, >>>> int ffs( int x ); >>>> #endif >>>> >>>> +#if defined(__GNUC__)&& (GCC_VERSION>= 30406) >>>> + #define ctz(x) __builtin_ctz(x) >>>> +#elif defined(__GNUC__)&& (defined(__i386__) || defined(__x86_64__)) >>>> + static inline int ctz( unsigned int x ) >>>> + { >>>> + int ret; >>>> + __asm__("bsfl %1, %0" : "=r" (ret) : "r" (x)); >>>> + return ret; >>>> + } >>>> +#else >>>> + #define ctz(x) (ffs(x)-1) >>>> +#endif >>> There's no reason to add this. Just use ffs(). >>> >> If I thought ffs() was adequate, I would. I need this for iterating >> sparse bitsets. >> >> __builtin_ctz() compiles to: >> mov 0x8(%ebp),%eax >> bsf %eax,%eax >> >> (ffs()-1) compiles to: >> mov $0xffffffff,%edx >> bsf 0x8(%ebp),%eax >> cmove %edx,%eax >> add $0x1,%eax >> sub $0x1,%eax >> >> ... Fortunately -O2 catches the add/sub. So yes, there is a reason, >> ctz() is at least 50% faster. > You are optimizing in the wrong spot. > > If this is not in performance relevant code, readability is always better > than hacks. > > ciao, Marcus I agree 100% with the 2nd part; this is for some of the functions that top the CPU time charts in wined3d.

March 17, 2011

Re: wineport: Add support for ctz().

by Adam Martinson

On 03/17/2011 03:23 AM, David Laight wrote: > On Wed, Mar 16, 2011 at 01:26:31PM -0500, Adam Martinson wrote: >> __builtin_ctz() compiles to: >> mov 0x8(%ebp),%eax >> bsf %eax,%eax >> >> (ffs()-1) compiles to: >> mov $0xffffffff,%edx >> bsf 0x8(%ebp),%eax >> cmove %edx,%eax > ... >> So yes, there is a reason, ctz() is at least 50% faster. > I'm not where you get 50% from! > > I've read both the intel and amd x86 instruction performance manuals > (but can't clain to remember all of it!). > The 'bsf' will be a slow instruction (with constraints on where it > exectutes, and what can execute in parallel). > The 'cmove' has even worse constraints since it can't execute until > the 'flags' from the previous instruction are known. > cmove is only slightly better than a mis-predicted branch! > In this case there will be complete pipeline stall between the 'bsf' > and the 'cmove'. > > ffs would probably execute faster with a forwards conditional branch > (predicted not taken) in the 'return -1' path. > > David > For my purposes the 'return -1' path will never be taken, so it's not needed. I want to be able to do: while (bitmap) { i = ctz(bitmap); /* get the LSB index */ bitmap ^= 1 << i; /* zero LSB */ /* for each set bit i... */ } If there's a faster way to do this I'm all ears.

March 17, 2011

Re: usp10: corrections to ScriptXtoCP

by Nikolay Sivov

On 3/17/2011 18:20, Aric Stewart wrote: > > It is correct for both LRT and RTL runs > --- > dlls/usp10/tests/usp10.c | 211 > +++++++++++++++++++++++++++++++++------------- > dlls/usp10/usp10.c | 128 +++++++++++++++++++++++----- > 2 files changed, 259 insertions(+), 80 deletions(-) > Maybe it's better to store test data in a table, cause looks like you do similar calls over and over again.

March 17, 2011

re: Please ban this spammer from the forum

by Dan Kegel

Done.

March 17, 2011

Please ban this spammer from the forum

by Rosanne DiMesio

We've had repeated spam posts from user darlingntq9 over the past couple of days. Please ban him/her from the forum. -- Rosanne DiMesio <dimesio(a)earthlink.net>

March 17, 2011

Re: [2/2] server: Make sure that CreateFile(CREATE_ALWAYS) overwrites existing file attributes.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > @@ -1829,6 +1828,11 @@ struct fd *open_fd( struct fd *root, const char *name, int flags, mode_t *mode, > return NULL; > } > ftruncate( fd->unix_fd, 0 ); > + if (flags & O_CREAT) > + { > + fchmod( fd->unix_fd, *mode ); > + fstat( fd->unix_fd, &st ); > + } You'd have to take umask into account. And I'd like to see some tests for this at the ntdll level. > @@ -178,7 +178,7 @@ static struct object *create_file( struct fd *root, const char *nameptr, data_si > switch(create) > { > case FILE_CREATE: flags = O_CREAT | O_EXCL; break; > - case FILE_OVERWRITE_IF: /* FIXME: the difference is whether we trash existing attr or not */ > + case FILE_OVERWRITE_IF: /* the difference is whether we trash existing attr or not */ It's still a FIXME. -- Alexandre Julliard julliard(a)winehq.org

March 17, 2011