Wine-Devel

By thread

wine-devel@list.winehq.org

March 2011

94 participants
462 messages

Re: winex11.drv: Ensure that wintab xinput_handle is not NULL.

by John Klehm

On Mon, Feb 28, 2011 at 8:50 PM, Peter Urbanec <winehq.org(a)urbanec.net> wrote: > --- > dlls/winex11.drv/wintab.c | 13 ++++++++++--- > 1 files changed, 10 insertions(+), 3 deletions(-) > Nice find on this code path being able to run without loading xinput. I have a couple comments: You don't need to guard inside GetCurrentPacket. It's only called when WT_PACKET is passed to the global tablet event hwnd message queue. WT_PACKET is only sent to that queue from XInput event handlers that get registered when xinput is loaded. In short GetCurrentPacket won't get called if xinput isn't loaded so I don't believe it needs the xinput check. As for the AttachEventQueue and WTInfoW checks: I think we'd achieve the same end by having a loaded check in WTOpen just like we do in WTInfo. The benefit would be that we'd let the app know sooner that something was wrong. As it is right now we try to load but don't return 0 if we fail to load in dll/wintab32/context.c:WTInfoT: 370 if (gLoaded == FALSE) 371 LoadTablet(); 372 If we return 0 when loading fails in the dll/wintab32 WTInfo and WTOpen entry points we save the trouble of running through a bunch of function calls that are doomed to fail anyway. Even worse in most places in the wintab code we don't check if the winex11 calls succeed or fail. This would require modifications to LoadTablet and its winex11 buddy LoadTabletInfo so they could bubble up the failure. Regards, --John Klehm

March 1, 2011

Re: Fwd: Applications for Mentoring Organizations Now Being Accepted

by Maarten Lankhorst

Hi Dan, Op 28-02-11 21:41, Dan Kegel schreef: > So, shall I do the honors? I've already been applying wine for summer of code this year, haven't finished it up though, you could always join as second backup admin. However I'd like everyone to have another look at our http://wiki.winehq.org/SummerOfCode page. I want to be sure that they're all doable within the allotted time frame, and that they won't be too hard for people just starting on wine. If people can add a few more good ideas I'd be happy. It feels like I'm missing some outside of direct3d. Cheers, Maarten

March 1, 2011

Jump to page: