April 2011 - Wine-Devel - list.winehq.org

Re: VarDateFromStr parses yyyy-mm-dd as yyyy-dd-mm in European locales

by John Fremlin

Dan Kegel <dank(a)kegel.com> writes: > Nikolay wrote: >>> Who has authority to approve it? >> A patch? Alexandre Julliard, he's the only project maintainer. >> Send a patch to wine-patches at winehq.org when you think >> it's ready and you'll get some feedback if it's not. > > Be sure to send it to winetestbot first, and fix any problems it finds; > see http://wiki.winehq.org/SubmittingPatches I added an additional testcase as requested. winetestbot didn't find any problems (proving I think that native never prefers y-d-m, as one might expect). I've submitted it to wine-patches. Should I have subscribed to that list first? I'm willing to jump though any hoop to get this trivial one-liner in :-)

April 25, 2011

Re: ERROR: Compile wine tests on WINDOWS with MS C/C++

by Austin English

On Sat, Apr 23, 2011 at 11:03, Gerold Jens Wucherpfennig <gjwucherpfennig(a)gmx.net> wrote: > Regarding: > > 5.5.4. Standalone, using the Microsoft C++ Toolkit > > of > > http://www.winehq.org/docs/winedev-guide/testing-windows : > > > > I tried to compile dlls/rasapi32/test/rasapi.c on Windows > > and got these error messages: > > > > Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 15.00.30729.01 > for 80x86 > Copyright (C) Microsoft Corporation. All rights reserved. > > rasapi.c > .\wine/test.h(66) : error C2143: syntax error : missing '{' before 'const' > .\wine/test.h(70) : error C2054: expected '(' to follow 'inline' > .\wine/test.h(71) : error C2085: 'winetest_strcmpW' : not in formal > parameter li > st > .\wine/test.h(71) : error C2143: syntax error : missing ';' before '{' Bug reports should go to http://bugs.winehq.org. -- -Austin

April 25, 2011

Re: [PATCH 6/6] mmdevapi/tests: Add tests for IAudioClock

by Alexandre Julliard

Andrew Eikum <aeikum(a)codeweavers.com> writes: > + pcpos = 0; > + hr = IAudioClock_GetPosition(acl, &pos, &pcpos); > + ok(hr == S_OK, "GetPosition failed: %08x\n", hr); > + ok(pos == 0, "GetPosition returned non-zero pos before being started: %lld\n", pos); Please avoid %ll formats. -- Alexandre Julliard julliard(a)winehq.org

April 25, 2011

Re: [PATCH 3/6] wineoss.drv: Add MMDevAPI driver

by Alexandre Julliard

Andrew Eikum <aeikum(a)codeweavers.com> writes: > +{ > + int i, mixer_fd; > + oss_sysinfo sysinfo; > + static int print_once = 0; > + > + TRACE("%d %p %p %p\n", flow, ids, num, def_index); > + > + mixer_fd = open("/dev/mixer", O_RDONLY, 0); > + if(mixer_fd < 0){ > + ERR("OSS /dev/mixer doesn't seem to exist\n"); > + return AUDCLNT_E_SERVICE_NOT_RUNNING; > + } > + > + if(ioctl(mixer_fd, SNDCTL_SYSINFO, &sysinfo) < 0){ > + close(mixer_fd); > + > + if(errno == EINVAL){ > + ERR("OSS version too old, need at least OSSv4\n"); > + return AUDCLNT_E_SERVICE_NOT_RUNNING; You'll need a configure check too, things like the oss_sysinfo type don't exist on OSSv3. -- Alexandre Julliard julliard(a)winehq.org

April 25, 2011

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 2)

by Alexandre Julliard

Charles Davis <cdavis(a)mymail.mines.edu> writes: > On 4/25/11 5:01 AM, Alexandre Julliard wrote: >> Charles Davis <cdavis(a)mymail.mines.edu> writes: >> >>> Try 2: don't depend on the existence of scsi-generic entries in the HAL tree. >> >> It's still not listing my /dev/hda CD drive. > Hmm... which IDE driver is your kernel using, the "legacy" driver or the > new libata-based driver? (I'm using libata, so that might account for > what you're seeing.) Yeah it's using the old IDE driver. -- Alexandre Julliard julliard(a)winehq.org

April 25, 2011

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 2)

by Charles Davis

On 4/25/11 5:01 AM, Alexandre Julliard wrote: > Charles Davis <cdavis(a)mymail.mines.edu> writes: > >> Try 2: don't depend on the existence of scsi-generic entries in the HAL tree. > > It's still not listing my /dev/hda CD drive. Hmm... which IDE driver is your kernel using, the "legacy" driver or the new libata-based driver? (I'm using libata, so that might account for what you're seeing.) Chip

April 25, 2011

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 2)

by Alexandre Julliard

Charles Davis <cdavis(a)mymail.mines.edu> writes: > Try 2: don't depend on the existence of scsi-generic entries in the HAL tree. It's still not listing my /dev/hda CD drive. -- Alexandre Julliard julliard(a)winehq.org

April 25, 2011

Re: [PATCH 1/3] d3dx9: Implement ID3DXBaseEffect::GetParameterByName().

by Rico Schüller

Am 21.04.2011 16:46, schrieb Henri Verbeet: > 2011/4/20 Rico Schüller<kgbricola(a)web.de>: >> +inline LPSTR get_partial_string(LPCSTR name, char initial, char final) > That should probably be static instead of inline. Also, > get_parameter_by_name() looks like it could be split up, and you can > probably avoid the copy in get_partial_string(). > > Something like the attached patch should be better in that regards. Any thoughts? Cheers Rico

April 25, 2011

Style updates for source.winehq/patches

by Jerome Leclanche

Attached patch to tools.git/patches/patches.css adds the necessary styling for a WineHQ-style patch status page: http://i.imgur.com/5ToSc.png The div class="main" needs to be replaced by the html attached in the other file. I can write a patch for it if it's to be included, but I cannot test it. Is it worth doing? J. Leclanche

April 24, 2011

RFC: doc for message contexts additions in PO files

by Frédéric Delanoy

Hi guys, I've put together the following doc for the introduction of message contexts. It's still a bit raw but I'd improve it for the wiki version. Could you please have a look and help proofread it? I'd like to ensure I didn't miss an important step. Thanks in advance. Frédéric Delanoy PS: BTW what is the reference version? en_US.po or en.po? ********* Adding one/more message contexts (ADD LINK TO EXTERNAL DOC) (QUICK MC EXPLANATION) Prerequisite: enable maintainer mode using ./configure --enable-maintainer-mode (you might have to add some development packages; check with your distribution for infos). 1. Locate strings to be "altered" Say you have in your localized po file: #: file1.rc:123 file2.rc:456 msgid "ambiguous word" msgstr "translation" and you want to disambiguate, you'd do the following 2. Find appropriate translations - check the respective rc entries (in file1.rc line 123) FOO "ambiguous word" (in file2.rc line 456) BAR "ambiguous word" and find their meaning/context (e.g. using some code browsing tools, like cscope to find references; running the program is recommanded, ...) 3. Add the messages contexts - The following syntax is used: "translation" -> "#msgctxt#your context#translation" - You end up with sthg like FOO "#msgctxt#context #ambiguous word#" Similarly BAR "#msgctxt#context 2#ambiguous word#" 3. Run 'make depend && make' 4. Edit your po file to add the new translations 5. Ideally, remove the "#, fuzzy" automatically inserted in the En_US.po reference file (and En.rc ). 6. Run 'make' again and test your changes.

April 24, 2011