April 2011 - Wine-Devel - list.winehq.org

Managing word agreements in PO translations?

by Frédéric Delanoy

Hi, In various languages, there are multiple forms/agreements for a pronoun/adjective. In French, for instance masculine and feminine forms exist; in other languages (like German IIRC) there's even a neutral form (other languages may also be more complicated) while agreements in English are limited, e.g. there's only one form for masculine/feminine/plural adjectives. This makes translating short English words problematic. In my case, I've a problem with the following PO entry #: comctl32.rc:44 crypt32.rc:198 progman.rc:78 winecfg.rc:76 msgid "None" According to context, it can be translated (in French) as either "Aucun" or "Aucune" (agreements on the same word). Admitedly, it could be translated with "Aucun(e)" but that seems more like a workaround and feels a bit weird (user shouldn't see partially incorrect/odd translations because of technical issues) OTOH, creating a distinct msgcontext for every agreement in every supported language may be overkill, although the number of affected msgids is limited. What's your opinion on how to handle that, folks? Frédéric Delanoy NB: This obviously posed no problem before the rc->po migration, since it was duplicated in different rc files

April 21, 2011

Re: [PATCH 1/3] d3dx9: Implement ID3DXBaseEffect::GetParameterByName().

by Henri Verbeet

2011/4/20 Rico Schüller <kgbricola(a)web.de>: > +inline LPSTR get_partial_string(LPCSTR name, char initial, char final) That should probably be static instead of inline. Also, get_parameter_by_name() looks like it could be split up, and you can probably avoid the copy in get_partial_string().

April 21, 2011

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.

by Charles Davis

On 4/21/11 4:21 AM, Alexandre Julliard wrote: > Charles Davis <cdavis(a)mymail.mines.edu> writes: > >> On 4/20/11 9:43 AM, Alexandre Julliard wrote: >>> It doesn't seem to work here, I don't get any devices. >> Funny. It works fine on both my 32-bit and 64-bit VMs. Clearly my setup >> is broken :). >> >> By any chance, do you not have any SCSI generic (sg<x>) files in /dev/? > > I don't, I have only hd and sd devices. That explains it. The patch used the SCSI generic entries on Linux, which aren't present if that support hasn't been compiled in/loaded. I'll rework the patch so it isn't so dependent on them. Chip

April 21, 2011

Re: winex11.drv: Ignore the zero-size owners used by Delphi apps when deciding whether to add NET_WM_STATE_SKIP_TASKBAR.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch reverts a part of 61e50e15ba45ad54655f98619f5ef33917033165 and > fixes the regression reported in the bug 26670. This will cause spurious task bar entries in many apps. -- Alexandre Julliard julliard(a)winehq.org

April 21, 2011

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.

by Alexandre Julliard

Charles Davis <cdavis(a)mymail.mines.edu> writes: > On 4/20/11 9:43 AM, Alexandre Julliard wrote: >> It doesn't seem to work here, I don't get any devices. > Funny. It works fine on both my 32-bit and 64-bit VMs. Clearly my setup > is broken :). > > By any chance, do you not have any SCSI generic (sg<x>) files in /dev/? I don't, I have only hd and sd devices. -- Alexandre Julliard julliard(a)winehq.org

April 21, 2011

Re: [PATCH 1/4] msvcp90: Added basic_string<char>::append(size_t, char) implementation.

by Vincas Miliūnas

Hi, >It's probably not allowed to use %lc format. Both %c and %lc produce the same trace output: trace:msvcp90:MSVCP_basic_string_wchar_assign_cstr_len 0x32fc20 L"abc" 3 trace:msvcp90:MSVCP_basic_string_wchar_append_len_wchar 0x32fc20 0 z trace:msvcp90:MSVCP_basic_string_wchar_c_str 0x32fc20 trace:msvcp90:MSVCP_basic_string_wchar_append_len_wchar 0x32fc20 2 z trace:msvcp90:MSVCP_basic_string_wchar_c_str 0x32fc20 Should I send a patch with %c instead? The "l" modifier most likely is ignored and will print correct result only for ASCII symbols. Regards, Vincas M. On 04/20/2011 05:24 PM, Piotr Caban wrote: > Hi, > > On 04/18/11 23:53, Vincas Miliūnas wrote: >> My remark: (The method is implemented by reusing existing code) this->size+count<this->size is the same as count< 0 and throwing a "string too long" exception in that case is not semantic. > count is an unsigned variable so it cannot be smaller then 0. My > intention was to make sure there's no overflow. This check is not needed > because MSVCP_basic_string_char_npos-this->size <= count already makes > sure this->size+count has small enough value. > > +basic_string_wchar* __thiscall MSVCP_basic_string_wchar_append_len_wchar( > + basic_string_wchar *this, size_t count, wchar_t c) > +{ > + TRACE("%p %lu %lc\n", this, (unsigned long)count, c); > It's probably not allowed to use %lc format. > > Cheers, > Piotr >

April 21, 2011

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.

by Charles Davis

On 4/20/11 9:43 AM, Alexandre Julliard wrote: > Charles Davis <cdavis(a)mymail.mines.edu> writes: > >> --- >> dlls/kernel32/Makefile.in | 1 - >> dlls/kernel32/oldconfig.c | 404 ------------------------------------------ >> dlls/kernel32/process.c | 3 - >> dlls/mountmgr.sys/hal.c | 116 ++++++++++++ >> dlls/mountmgr.sys/mountmgr.c | 138 ++++++++++++++ >> dlls/mountmgr.sys/mountmgr.h | 3 + >> 6 files changed, 257 insertions(+), 408 deletions(-) >> delete mode 100644 dlls/kernel32/oldconfig.c > > It doesn't seem to work here, I don't get any devices. Funny. It works fine on both my 32-bit and 64-bit VMs. Clearly my setup is broken :). By any chance, do you not have any SCSI generic (sg<x>) files in /dev/? Chip

April 21, 2011

Re: d3dxof/tests: Make expected value in string and comparison match.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10525 Your paranoid android. === WVISTAADM (32 bit d3dxof) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

April 20, 2011

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.

by Alexandre Julliard

Charles Davis <cdavis(a)mymail.mines.edu> writes: > --- > dlls/kernel32/Makefile.in | 1 - > dlls/kernel32/oldconfig.c | 404 ------------------------------------------ > dlls/kernel32/process.c | 3 - > dlls/mountmgr.sys/hal.c | 116 ++++++++++++ > dlls/mountmgr.sys/mountmgr.c | 138 ++++++++++++++ > dlls/mountmgr.sys/mountmgr.h | 3 + > 6 files changed, 257 insertions(+), 408 deletions(-) > delete mode 100644 dlls/kernel32/oldconfig.c It doesn't seem to work here, I don't get any devices. -- Alexandre Julliard julliard(a)winehq.org

April 20, 2011

Re: [PATCH 1/4] msvcp90: Added basic_string<char>::append(size_t, char) implementation.

by Piotr Caban

Hi, On 04/18/11 23:53, Vincas Miliūnas wrote: > My remark: (The method is implemented by reusing existing code) this->size+count<this->size is the same as count< 0 and throwing a "string too long" exception in that case is not semantic. count is an unsigned variable so it cannot be smaller then 0. My intention was to make sure there's no overflow. This check is not needed because MSVCP_basic_string_char_npos-this->size <= count already makes sure this->size+count has small enough value. +basic_string_wchar* __thiscall MSVCP_basic_string_wchar_append_len_wchar( + basic_string_wchar *this, size_t count, wchar_t c) +{ + TRACE("%p %lu %lc\n", this, (unsigned long)count, c); It's probably not allowed to use %lc format. Cheers, Piotr

April 20, 2011