April 2011 - Wine-Devel - list.winehq.org

Re: ntdll: Add Windows XP x64

by André Hentschel

Am 17.04.2011 19:26, schrieb Alexandre Julliard: > André Hentschel <nerv(a)dawncrow.de> writes: > >> in 64-bit processor mode you can't use vm86 for 16-bit apps, so you need to use dosbox on Windows an Wine does that automaticly (but needs some more love). >> So 16-bit vs. kernel-versoin on 64-bit is no problem. > > 16-bit code doesn't need vm86. > true, i confused it with realmode -- Best Regards, André Hentschel

April 18, 2011

Re: wintrust: Implement IsCatalogFile

by Austin English

On Sat, Apr 16, 2011 at 12:34, Juan Lang <juan.lang(a)gmail.com> wrote: > Since I didn't see an updated patch from Austin, here's what I think > should suffice. Without knowing the app that depends on it, I can't > be certain. Sorry, I had a busy weekend, thanks for fixing it. It works great here! -- -Austin

April 18, 2011

Re: serial: improve handling of usb2serial adapters

by Austin English

2011/4/18 Wolfgang Walter <wolfgang.walter(a)stwm.de>: Please, one patch per email. Thanks for helping Wine! -- -Austin

April 18, 2011

Can someone ban tiaotiao (tiaotiao213@hotmail.com -- link spammer) <EOM>

by Reece Dunn

April 18, 2011

DEC Alpha Support

by André Hentschel

Hi all, i would like to remove the remaining Alpha support code, because of all our ports Alpha is the most incomplete and it seems it has no chance to get some love. Further Alpha chips aren't produced anymore since years AFAIK. Any Objections? -- Best Regards, André Hentschel

April 18, 2011

Re: ntdll: Remove more path trailing chars. (try 2)

by Alexandre Julliard

Vincent Pelletier <plr.vincent(a)gmail.com> writes: > Add tests via FindFirstFileA. You need tests for the low-level ntdll functions. -- Alexandre Julliard julliard(a)winehq.org

April 18, 2011

Re: Fix to bug 25504 for gnutls based schannel

by Alexandre Julliard

Hans Leidekker <hans(a)codeweavers.com> writes: > On Mon, 2011-04-18 at 04:23 -0500, Ken Thomases wrote: >> http://www.gnu.org/software/gnutls/manual/gnutls.html#Multi_002dthreaded-ap… >> >> Apparently, one uses gnutls_global_set_mutex() to configure the locking functions used by GnuTLS. > > Yes, that seems to do what we need, but it must be a recent addition > because it's missing here from libgnutls.so.26.14.12. The default pthread functions should work fine though. This sounds like a gnutls bug. -- Alexandre Julliard julliard(a)winehq.org

April 18, 2011

Re: Fix to bug 25504 for gnutls based schannel

by Hans Leidekker

On Mon, 2011-04-18 at 04:23 -0500, Ken Thomases wrote: > >> I also wonder why libgcrypt is now needed, where this dll is using libgnutls? > > > > Yes, if there's a way to set the locking functions via gnutls then we > > wouldn't need to load libgcrypt. > > http://www.gnu.org/software/gnutls/manual/gnutls.html#Multi_002dthreaded-ap… > > Apparently, one uses gnutls_global_set_mutex() to configure the locking functions used by GnuTLS. Yes, that seems to do what we need, but it must be a recent addition because it's missing here from libgnutls.so.26.14.12.

April 18, 2011

Re: [PATCH 02/10] msvcrt: Use callback based printf in cprintf functions family

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > +printf_arg arg_clbk_valist(void *ctx, int arg_pos, size_t size, __ms_va_list *valist) > +{ > + printf_arg ret; > + > + if(size == sizeof(LONGLONG)) > + ret.get_longlong = va_arg(*valist, LONGLONG); > + else if(size == sizeof(int)) > + ret.get_int = va_arg(*valist, int); > + else { > + ERR("Incorrect size\n"); > + ret.get_int = 0; > + } You can't do that, you need to use the correct type in va_arg. Different types can be passed differently even if they have the same size. -- Alexandre Julliard julliard(a)winehq.org

April 18, 2011

Re: Fix to bug 25504 for gnutls based schannel

by Ken Thomases

On Apr 18, 2011, at 3:46 AM, Hans Leidekker wrote: > On Mon, 2011-04-18 at 10:36 +0200, Marcus Meissner wrote: >> On Mon, Apr 18, 2011 at 10:04:08AM +0200, Hans Leidekker wrote: >>> On Sun, 2011-04-17 at 09:42 -0400, jbalentine(a)tuffmail.com wrote: >>>> #ifdef SONAME_LIBGNUTLS >>>> #include <gnutls/gnutls.h> >>>> +#include <gcrypt.h> >>>> +#include <pthread.h> >>>> +#include <errno.h> >>>> +GCRY_THREAD_OPTION_PTHREAD_IMPL; >>> >>> You should add a separate configure check for libgcrypt. Use of pthreads >>> reveals an implementation detail of Wine threads, I think it would be >>> cleaner to supply Win32 implementations of the locking functions via >>> GCRY_THREAD_OPTION_USER. >> >> I also wonder why libgcrypt is now needed, where this dll is using libgnutls? > > Yes, if there's a way to set the locking functions via gnutls then we > wouldn't need to load libgcrypt. http://www.gnu.org/software/gnutls/manual/gnutls.html#Multi_002dthreaded-ap… Apparently, one uses gnutls_global_set_mutex() to configure the locking functions used by GnuTLS. Regards, Ken

April 18, 2011