April 2011 - Wine-Devel - list.winehq.org

Re: gsoc theming

by Andrew Green

Thank you so much for your assistance and patience. The thing that confuses me is you want only one dll for comctl32 Though the only way i can think of to do this is to to have an xml parser inside the dll and then trying to load the correct manifest file. To check if the manifest exists or asks for version 6+. There may be some api for this. Though I havn't been able to find it. At this link in the Window Class section I assume is what you referred to about the comctl32 having a manifest in our previous discussions. So i'm trying to get my head around that. http://msdn.microsoft.com/en-us/library/aa374219(v=vs.85).aspx On Mon, Apr 4, 2011 at 11:19 PM, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > On 4/4/2011 16:45, Reece Dunn wrote: >> >> On 4 April 2011 13:08, Andrew Green<greeniekin(a)gmail.com> wrote: >>> >>> Hi, >>> I hate to message you on this email. I have messaged the mailing >>> lists. Though I became more confused than anything. >> >> Can you please keep the discussions on the mailing list? Thanks. >> >>> I would like to propose a project where comctl32 is implement >>> correctly in windows for google summer of code. >>> As far as i know windows uses SxS to load version 6 of comctl allowing >>> theming. >> >> This is correct -- an application needs to add a manifest file to tell >> it to load version 6 of the comctl32 DLL in order to get theming >> support on Windows. >> >>> It also uses windows class redirection to hijack controls >>> from user32 to be themed(I don't know if it somehow uses subclassing). >> >> This is how it is implemented in wine. > > Native doesn't subclass, it has its own copy of so called builtin controls > in comctl32. > First evidence for that is a special class registration call from comctl32 > v6 to register themed classes. > Second evidence is that new Button functionality for example is available > only in comctl32 v6, not in latest user32 module, > I doubt they customize existing behaviour, I think it's more likely some > message handlers are reused (compiled in both modules) and some are present > in comctl32 only. > > > >>> The confusing thing on the mailing list i was told not to make a >>> separate version of comctl32. Which is understandable from a code >>> maintenance point of view. Though contradicts what the gsoc ideas page >>> says >>> "control is overridden by a themed drawing version by subclassing. >>> This is not the way it is implemented on Windows and this causes >>> drawing issues and other nasty issues." >>> As someone who is to be a mentor of this section. What is the goal? >>> and if subclassing is the option, how is this meant to work? >> >> There isn't a contradition. >> >> AFAICS, the subclassing works -- the subclassed window procedure gets >> called correctly. >> >> The drawing issues can be seen clearly on the button controls -- if >> the button changes state (enabled<-> disabled, pressed, etc.) then it >> gets drawn without theming. This is because the button control in Wine >> does not call WM_PAINT to do the drawing, which the themed button >> overrides. > > Subclass may work fine of course, but could cause problems. For example it's > possible that application clears > all subclass slots (if we're talking about comctl32 mechanism with procedure > stack). When you create button with v6 on windows you don't get sublcassed > control (stack is empty), that may be important. > > Anyway if you subclass let's say a Button you need to override lot of > handlers potentially, cause for example new window styles could be rejected > by modern user32 but accepted in comctl32 logic. That could cause a mess > when different code works with not necessary valid control data. This needs > some testing. > > Another question is to determine if we need to use controls from comctl32 in > a first place. If you have active theme it doesn't mean that developer > wanted to use it if he doesn't specify manifest to load version 6. > > So to summarize, the way I see this to be properly done step by step: > > 1) add class redirect detection for activation context code > (ntdll/kernel32). Returned structures are undocumented, but if you dump data > you'll see something (I did); > 2) (hard part, for me at least) figure out when to invoke class registration > call from comctl32 to move registration to comctl32. > 3) add tests for user32 to see how builtin classes respond to new version 6 > styles/messages; > 4) figure out what code could be reused between user32 and comctl32 and > reuse as much handlers from user32 as possible. This will need some build > tweaks probably, I'm not sure, to share files between dlls. > > What also bothers me is that I'm not sure comctl32 versions of controls (in > windows) use A/W magic for procedures that user32 uses. >> >> Therefore, you will need to either: >> 1/ convince Alexandre through tests that these tests do call >> WM_PAINT [*] and update the non-themed control accordingly; or >> 2/ implement the state tracking/logic in the themed button and have >> it call WM_PAINT [*]. >> >> [*] or the correct custom drawing messages. >> >> HTH, >> - Reece >> >> >> > >

April 7, 2011

Re: [PATCH 1/2] ntdll: Restore stack guard and prevent stack from shrinking

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -1617,9 +1617,18 @@ BOOL virtual_handle_stack_fault( void *addr ) > BYTE vprot = view->prot[((const char *)page - (const char *)view->base) >> page_shift]; > if (vprot & VPROT_GUARD) > { > + struct _TEB *teb = NtCurrentTeb(); > VIRTUAL_SetProt( view, page, page_size, vprot & ~VPROT_GUARD ); > - if ((char *)page + page_size == NtCurrentTeb()->Tib.StackLimit) > - NtCurrentTeb()->Tib.StackLimit = page; > + if ((char *)page - page_size == teb->DeallocationStack) > + teb->Tib.StackLimit = page; > + else if ((char*)addr > (char*)teb->Tib.StackLimit + page_size && > + teb->Tib.StackLimit == (char*)teb->DeallocationStack + page_size && > + (view = VIRTUAL_FindView( (char*)teb->Tib.StackLimit, 0))) > + { > + vprot = view->prot[((char*)teb->Tib.StackLimit - (char*)view->base) >> page_shift]; > + VIRTUAL_SetProt( view, teb->Tib.StackLimit, page_size, vprot | VPROT_GUARD); > + teb->Tib.StackLimit = (char*)teb->Tib.StackLimit + page_size; > + } Why do you want to lookup the view again? -- Alexandre Julliard julliard(a)winehq.org

April 7, 2011

Re: Wanted: TestBot maintainer

by Деян Стоянов

Hi Greg, I'm system administrator in application development unit of company "Information services" Plc. ( about us on http://www.is-bg.net/site_io/?cat=77 ). I am Vmware Certified Professional of VI3 and so far of VI4, and I have good experience with VMware Infrastructure. Also I have no problem with support various operation systems Windows 98, NT, 2000, XP, Vista, 7. Also I have experience with Linux Debian derivations, as well i manage with success other Linux distributions. I am interested to see how TestBot works, and maintain indefinitely. I spoke with my employer for time to maintain the TestBot, and I have a positive answer. I remain at your disposal, and I expect your response. Best regards Deyan Stoyanov

April 7, 2011

Re: Wanted: TestBot maintainer

by Vit Hrachovy

Hi Greg, I'm interested. I'm pretty confident in Perl and have experience with VMware server+player/VirtualBox/XEN so I hope to learn vSphere quickly. Regards Hark On 04/ 5/11 08:23 PM, Greg Geldorp wrote: > Due to personal circumstances I won't be able to maintain the TestBot > much longer. I'm looking for a volunteer to take over this > responsibility. I can offer the hardware on which the bot runs for > another 2 years or so. You'll get full access to the hardware. It > helps if you have a bit of experience with VMware vSphere, but that's > not absolutely required. > > Day-to-day operations have been running pretty smooth for the last > couple of months, so the demand on your time won't be that great. > There's the occasional account request that needs to be approved and > that's pretty much it. Every now and then the VMs should be updated > using Windows Update. The code itself seems to be reasonably stable. > It's all Perl. > > If you're interested or would like more info, please let me know. > > Greg.

April 7, 2011

Re: configure.ac: add a --without-prelink option

by Austin English

On Wed, Apr 6, 2011 at 22:33, Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote: > On 04/06/2011 07:53 PM, Austin English wrote: >> >> Prelink is only available on Linux. > > It's not a reason to disable the warning. Without prelink, or other means to > set load addresses of core dlls, compiled Wine won't be compatible with some > programs. Mainly copy protection. Of course. The warning is still there by default, but there's no reason we shouldn't allow hiding the warning. Hell, we allow disabling X/freetype/etc., which break Wine much worse. There's no reason to warn users of *BSD/OS X/Solaris about something that they can't fix. -- -Austin

April 7, 2011

Re: configure.ac: add a --without-prelink option

by Vitaliy Margolen

On 04/06/2011 07:53 PM, Austin English wrote: > Prelink is only available on Linux. It's not a reason to disable the warning. Without prelink, or other means to set load addresses of core dlls, compiled Wine won't be compatible with some programs. Mainly copy protection. Vitaliy.

April 7, 2011

Re: user32: Add a test for activating a menu consisting from a single menu item using a hot key.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10366 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

April 6, 2011

Translation commits for wine-1.2.3

by Michael Stefaniuc

Hello Alexandre, attached is the list of translation commits that can be cherry-picked for wine-1.2.3. Notes: - The cherry-picks for cryptui and wineconsole will need a manual conflict resolution as they depend on my janitorial commits. - The Arab and Hebrew translations are filtered out (support for mirroring is only in wine-1.3.x). bye michael

April 5, 2011

Re: [PATCH] cmd: Added set /a (try 3, fixed tests and patch formatting) Some tests were written by Jack Kutilek

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10353 Your paranoid android. === W7PROX64 (64 bit) === batch.c:70: Test failed: CreateFile failed

April 5, 2011

Re: ntdll: Remove more path trailing chars.

by Nikolay Sivov

On 4/5/2011 23:36, Vincent Pelletier wrote: > Hi. > > Le samedi 02 avril 2011 09:16:53, Nikolay Sivov a écrit : >> Please use table for test data and put your macro body in a loop. > Done locally (indeed nicer). > I have one more thing to figure out before posting again: how to deal with the > NT4 failures testbot detected[1]. > > Those tests are boolean, so I doubt an "ok(pass || fail /* NT4 */)" makes any > sense. > I saw that it is discouraged (forbidden ?) to depend on OS version in tests, > so I will avoid that path unless asked to follow it. > I've been advised on IRC to use "broken()", but I don't see how to use it for > such boolean case (in my understanding it has a meaning if different error > status a returned by different windows versions, not between a success and an > error status). It depends on test. I see two ways at least - use broken() as alternative result always when it should fail or add another test data field named like broken_ret for example, and compare with it. It's discouraged to explicitly check for OS version, if some feature is missing in earlier versions you should detect that and win_skip() for it. > [1] http://testbot.winehq.org/JobDetails.pl?Key=10288#k201 > > Regards,

April 5, 2011