April 2011 - Wine-Devel - list.winehq.org

Re: ntdll: Remove more path trailing chars.

by Juan Lang

Hi Vincent, > Those tests are boolean, so I doubt an "ok(pass || fail /* NT4 */)" makes any > sense. > I saw that it is discouraged (forbidden ?) to depend on OS version in tests, > so I will avoid that path unless asked to follow it. > I've been advised on IRC to use "broken()", but I don't see how to use it for > such boolean case (in my understanding it has a meaning if different error > status a returned by different windows versions, not between a success and an > error status). It does work for a boolean case too. You'd want to use "ok(pass || broken(fail /* NT4 */)". --Juan

April 5, 2011

Re: cmd: Added set /a (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10349 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

April 5, 2011

Re: ntdll: Remove more path trailing chars.

by Vincent Pelletier

Hi. Le samedi 02 avril 2011 09:16:53, Nikolay Sivov a écrit : > Please use table for test data and put your macro body in a loop. Done locally (indeed nicer). I have one more thing to figure out before posting again: how to deal with the NT4 failures testbot detected[1]. Those tests are boolean, so I doubt an "ok(pass || fail /* NT4 */)" makes any sense. I saw that it is discouraged (forbidden ?) to depend on OS version in tests, so I will avoid that path unless asked to follow it. I've been advised on IRC to use "broken()", but I don't see how to use it for such boolean case (in my understanding it has a meaning if different error status a returned by different windows versions, not between a success and an error status). [1] http://testbot.winehq.org/JobDetails.pl?Key=10288#k201 Regards, -- Vincent Pelletier

April 5, 2011

Sorry about the duplicate patches.

by Joel Teichroeb

When trying to submit my first patch I did not do it correctly, and on http://source.winehq.org/patches/ it shows up 5 times. The correct patch is http://www.winehq.org/pipermail/wine-patches/2011-April/100677.html Thanks for your patience. Joel Teichroeb

April 5, 2011

Wanted: TestBot maintainer

by Greg Geldorp

Due to personal circumstances I won't be able to maintain the TestBot much longer. I'm looking for a volunteer to take over this responsibility. I can offer the hardware on which the bot runs for another 2 years or so. You'll get full access to the hardware. It helps if you have a bit of experience with VMware vSphere, but that's not absolutely required. Day-to-day operations have been running pretty smooth for the last couple of months, so the demand on your time won't be that great. There's the occasional account request that needs to be approved and that's pretty much it. Every now and then the VMs should be updated using Windows Update. The code itself seems to be reasonably stable. It's all Perl. If you're interested or would like more info, please let me know. Greg.

April 5, 2011

Re: gdi32/tests: Start of a framework for writing dib driver tests.

by Huw Davies

On Tue, Apr 05, 2011 at 03:31:23PM +0100, Huw Davies wrote: > > Try2. Using the A_SHA functions to generate the hashes. Although somewhat neater than the first version it doesn't work on nt4/win2k as they don't export these functions. So we're better off using the original. Huw.

April 5, 2011

Re: gdi32/tests: Start of a framework for writing dib driver tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10338 Your paranoid android. === WNT4WSSP6 (32 bit dib) === Timeout === W2KPROSP4 (32 bit dib) === Timeout

April 5, 2011

Re: mshtml: Properly handle upload streams containing headers

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > + if(nschannel->post_data_contains_headers) { > + if(data[0] == '\r' && data[1] == '\n') { > + post_data = data+2; > + data_len -= 2; > + }else { > + WCHAR *headers; > + DWORD size; > + > + post_data = memmem(data, data_len, "\r\n\r\n", 4); memmem is not portable. -- Alexandre Julliard julliard(a)winehq.org

April 5, 2011

Re: [PATCH] cmd: Added set /a

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10334 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:223: Test failed: unexpected char 0x34 position 0 in line 118 (got '4', wanted '3') batch.c:223: Test failed: unexpected char 0x34 position 0 in line 120 (got '4', wanted '11') batch.c:223: Test failed: unexpected char 0x30 position 0 in line 24 (got '0', wanted '2') batch.c:223: Test failed: unexpected char 0x31 position 0 in line 30 (got '12', wanted '2') batch.c:223: Test failed: unexpected char 0x2d position 0 in line 42 (got '-2147483648', wanted '0') batch.c:223: Test failed: unexpected char 0x33 position 0 in line 46 (got '3', wanted '1') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 124 (got '5', wanted '6') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 130 (got '5', wanted '2') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 140 (got '5', wanted '1') batch.c:223: Test failed: unexpected char 0x35 position 0 in line 146 (got '5', wanted '10')

April 5, 2011

Re: msi: Fix parsing of an empty property followed by a non-empty property.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10333 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

April 5, 2011