April 2011 - Wine-Devel - list.winehq.org

Re: msvcrt: fix utime to correctly handle a NULL-pointer for the utimbuf structure field

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10627 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

April 29, 2011

Re: po: Update French translation

by Frédéric Delanoy

On Fri, Apr 29, 2011 at 08:04, Nicolas Le Cam <niko.lecam(a)gmail.com> wrote: > Hi Frédéric, > > Le 29 avril 2011 00:16, Frédéric Delanoy <frederic.delanoy(a)gmail.com> a écrit : >> #: winerror.mc:441 >> msgid "No more search handles\n" >> -msgstr "Il n'y a plus de descripteurs de recherche\n" >> +msgstr "Il n'y a plus de descripteur de recherche\n" > This one isn't correct. There's not only one handle when available but > many so it should take an 's' in the negative form too. Right. Fixed that and resent patch. > Thanks for your work ! > -- > Nicolas Le Cam Frédéric Delanoy

April 29, 2011

Re: po: Update French translation

by Nicolas Le Cam

Hi Frédéric, Le 29 avril 2011 00:16, Frédéric Delanoy <frederic.delanoy(a)gmail.com> a écrit : > #: winerror.mc:441 > msgid "No more search handles\n" > -msgstr "Il n'y a plus de descripteurs de recherche\n" > +msgstr "Il n'y a plus de descripteur de recherche\n" This one isn't correct. There's not only one handle when available but many so it should take an 's' in the negative form too. Thanks for your work ! -- Nicolas Le Cam

April 29, 2011

Re: [1/5] wined3d: Add missing temporary variable declaration to ARB shader backend.

by Matteo Bruni

2011/4/29 Stefan Dösinger <stefandoesinger(a)gmx.at>: >> + shader_addline(buffer, "TEMP TB;\n"); > Which shader instruction uses this? Afair vertex shaders should only use TA, > but there's no proper infrastructure that manages that. > AFAICS, TB could get used in shader_hw_pow(): ... shader_arb_get_src_param(ins, &ins->src[1], 1, src1); ... where the '1' in the third argument means that shader_arb_get_src_param() is allowed to use TB as temporary storage. There may be other pieces of code with the same assumption, I didn't look deeper.

April 28, 2011

Re: [2/5] wined3d: Remove rcp special handling of 0 from the ARB shader backend.

by Stefan Dösinger

On Thursday 28 April 2011 00:34:24 Matteo Bruni wrote: > This should fix http://bugs.winehq.org/show_bug.cgi?id=26780 I see this patch was committed, I think I should really read wine-patches more often. I added the RCP 0 handling because StarCraft 2 needed it. Did you test this with SC2? Specifically, the Water was black without proper handling of rcp 0

April 28, 2011

Re: [1/5] wined3d: Add missing temporary variable declaration to ARB shader backend.

by Stefan Dösinger

> + shader_addline(buffer, "TEMP TB;\n"); Which shader instruction uses this? Afair vertex shaders should only use TA, but there's no proper infrastructure that manages that.

April 28, 2011

Re: comctl32/tests: Remove practically unused parameters from test functions

by Michael Stefaniuc

On 04/28/2011 02:05 AM, Vitaliy Margolen wrote: > On 04/27/2011 09:47 AM, Nikolay Sivov wrote: >> On 4/27/2011 17:53, Vitaliy Margolen wrote: >>> On 04/27/2011 01:14 AM, Nikolay Sivov wrote: >>>> Remove practically unused parameters from test functions >>>> >>> >>> So how is global variable any better then local variable passed as >>> function parameter? >> Because there's no need to have different parent windows for currently >> present tests. I don't see a reason of >> having window handle created exactly once and then passed in each test >> function, it's tests after all with a straightforward structure. > The reason - all global variables are bad, do not use them. Regardless > why and how they are created and/or used. All generalizations are bad, do not use them. bye michael

April 28, 2011

Re: include: Generate rmxftmpl.h from rmxftmpl.x using new build tool. (try 3)

by Dylan Smith

On Thu, Apr 28, 2011 at 3:59 PM, Austin English <austinenglish(a)gmail.com>wrote: > > Looks like some C99 comments slipped in. > > It is an X file, not a c file, so the c compiler never touches it directly. C style comments are also not supported in X files, just // or # style comments.

April 28, 2011

Re: include: Generate rmxftmpl.h from rmxftmpl.x using new build tool. (try 3)

by David Adam

April 28, 2011

Re: include: Generate rmxftmpl.h from rmxftmpl.x using new build tool. (try 3)

by Austin English

On Thu, Apr 28, 2011 at 14:52, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote: > --- > Now using atexit function to cleanup up the output file on errors, and > parsing errors are signaled using a boolean error variable. > > diff --git a/include/rmxftmpl.x b/include/rmxftmpl.x > new file mode 100644 > index 0000000..e7144b0 > --- /dev/null > +++ b/include/rmxftmpl.x > @@ -0,0 +1,268 @@ > +xof 0302txt 0064 > +// Copyright (C) 2011 Dylan Smith > +// > +// This library is free software; you can redistribute it and/or > +// modify it under the terms of the GNU Lesser General Public > +// License as published by the Free Software Foundation; either > +// version 2.1 of the License, or (at your option) any later version. > +// > +// This library is distributed in the hope that it will be useful, > +// but WITHOUT ANY WARRANTY; without even the implied warranty of > +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > +// Lesser General Public License for more details. > +// > +// You should have received a copy of the GNU Lesser General Public > +// License along with this library; if not, write to the Free Software > +// Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA Looks like some C99 comments slipped in. -- -Austin

April 28, 2011