May 2011 - Wine-Devel - list.winehq.org

Re: [PATCH 3/4] d3dx9: Implement ID3DXBaseEffect::GetPixelShader().

by Henri Verbeet

2011/5/3 Rico Schüller <kgbricola(a)web.de>: > +#define SAFE_ADDREF(x) if(x) IUnknown_AddRef(x) > +#define SAFE_RELEASE(x) if(x) IUnknown_Release(x) That's not so safe, actually. Consider e.g. what happens when "x" has side effects, or when you write something like "if (cond) SAFE_ADDREF(x); else return;". If you really want this an inline function should do just as well, but for the handful of uses I see in this series it just obfuscates the code.

May 3, 2011

msvcrt: Add tests to show that utime() can take a NULL-pointer for the utimbuf structure field

by Louis Lenders

See http://www.winehq.org/pipermail/wine-patches/2011-April/101371.html Anything i could do to improve to get it in?

May 3, 2011

Re: ddraw (try 2): Add a few tests for Setcooperativelevel

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=10695 Your paranoid android. === WNT4WSSP6 (32 bit ddrawmodes) === ddrawmodes.c:800: Test failed: SetCooperativelevel(DDSCL_SETFOCUSWINDOW) returned: 80070057 ddrawmodes.c:803: Test failed: SetCooperativelevel(DDSCL_CREATEDEVICEWINDOW | DDSCL_EXCLUSIVE | DDSCL_FULLSCREEN) returned: 80070057 ddrawmodes.c:828: Test failed: SetCooperativelevel(DDSCL_SETFOCUSWINDOW) returned: 80070057 === W7PROX64 (64 bit ddrawmodes) === Timeout

May 3, 2011

Re: [2/2] msxml3/domdoc: Add support for VT_ARRAY|VT_UI1 in domdoc_load().

by Nikolay Sivov

On 5/3/2011 08:07, Adam Martinson wrote: > > Fixes bug 14864. > --- > dlls/msxml3/domdoc.c | 255 > ++++++++++++++++++++++++++------------------------ > 1 files changed, 134 insertions(+), 121 deletions(-) > > + case VT_ARRAY|VT_UI1: > + { > + SAFEARRAY* psa; > + BSTR bstr; > + psa = V_ARRAY(&source); > + bstr = bstr_from_xmlChar(psa->pvData); > + hr = domdoc_loadXML(iface, bstr, isSuccessful); > + SysFreeString(bstr); > + return hr; > + } > + break; Is it really supposed to be utf8 array? Or this will work cause one-byte chars match utf8? Also I don't like this method dependency, I think the proper way is to call IXMLDOMDocument3_loadXML(iface...) here. Or another way to avoid call through vtable - introduce something called domdoc_load_xml(This...) and use it in both places, but I think it's not worth it.

May 3, 2011

Re: [PATCH 1/2] d3d9/tests: Added a test for resetting an invisible, inactive window to fullscreen mode.

by Henri Verbeet

On 2 May 2011 13:24, Marvin <testbot(a)testbot.winehq.org> wrote: > === WXPPROSP3 (32 bit device) === > device: unhandled exception c0000005 at 0040320F > For what it's worth, not sure if you figured this out by yourself yet or not, but you need to handle create_device() failing to create a device on machines like the testbot that don't have D3D hardware.

May 2, 2011

Re: [PATCH 2/2] wined3d: Turn off message filtering temporarily in the Reset() method to allow certain messages (e.g. WM_ACTIVATEAPP) through.

by Henri Verbeet

On 2 May 2011 23:28, John Edmonds <pocketcookies2(a)gmail.com> wrote: > Are you suggesting that we turn off message filtering altogether or just for > the Reset function? > Just Reset().

May 2, 2011

Re: [PATCH 2/2] wined3d: Turn off message filtering temporarily in the Reset() method to allow certain messages (e.g. WM_ACTIVATEAPP) through.

by John Edmonds

Are you suggesting that we turn off message filtering altogether or just for the Reset function? I would like to add that I did disable all message filtering (by commenting out the code in Wine's wndproc) and the games I was testing worked fine. However, I did not investigate the effects of that change very thoroughly. On May 2, 2011 7:52 AM, "Henri Verbeet" <hverbeet(a)gmail.com> wrote: > On 2 May 2011 13:18, John Edmonds <pocketcookies2(a)gmail.com> wrote: >> Toki Tori and RUSH both depend on receing WM_ACTIVATEAPP before they will start. These messages are currently getting filtered out. >> This resolves bug #25640. > > It doesn't look right to me to filter messages during > IWineD3DDevice_ReleaseFocusWindow() but not > IWineD3DDevice_AcquireFocusWindow(). Maybe it just shouldn't filter at > all. > >

May 2, 2011

Working on UpdateSemantics or D3DXWeldVertices in D3DX9?

by Michael Mc Donnell

Hi Guys! I'm doing Google Summer of Code 2011 and found out that some of the functions I was to implement have been implemented while my application was being processed. This means I have to find some other functions in D3DX9 to implement. I see that UpdateSemantics and D3DXWeldVertices are unimplemented in D3DX9, and was wondering if anyone is working on these? Cheers, Michael

May 2, 2011

Re: comctl32: avoid using ZeroMemory()

by Austin English

On Mon, May 2, 2011 at 10:58, Marcus Meissner <meissner(a)suse.de> wrote: > On Mon, May 02, 2011 at 10:52:50AM -0500, Austin English wrote: >> Avoids a Clang bug: >> http://bugs.winehq.org/show_bug.cgi?id=26754 > > clang cannot even survive a simple memset() to 0? http://llvm.org/bugs/show_bug.cgi?id=9830 -- -Austin

May 2, 2011

Re: comctl32: avoid using ZeroMemory()

by Marcus Meissner

On Mon, May 02, 2011 at 10:52:50AM -0500, Austin English wrote: > Avoids a Clang bug: > http://bugs.winehq.org/show_bug.cgi?id=26754 clang cannot even survive a simple memset() to 0? Ciao, Marcus

May 2, 2011