June 2011 - Wine-Devel - list.winehq.org

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

by Michael Mc Donnell

I've implemented ConvertPointRepsToAdjacency, but would like some help to make it's worst case performance bearable. In init_edge_face_map I initialize an array of edge_face structs, and in find_adjacent_face I do a linear search through that array. I would like to replace the array with a hash table, so that the search time becomes constant. I've found a standard list (wine/list.h) and red-black tree implementation (wine/rbtree.h), but not a standard hash table implementation. Is there a standard hash table implementation, should I roll my own or find an LGPL'ed one? Thanks, Michael Mc Donnell

June 30, 2011

Re: [PATCH 1/3] d3dx9/line: Implemented ID3DXLine's Draw method.

by Matteo Bruni

2011/6/30 Charles Welton <charleswfb(a)gmail.com>: > --- > > + memcpy(buffer_mem, vertices, size); There is no need to allocate and write into your own buffer then copy the content, you can directly write into the vertex buffer. A more important issue: MSDN says "The ID3DXLine interface implements line drawing using textured triangles", which is probably true (as far as I know there is otherwise no support in D3D9 to antialiased/stippled/wide lines, which are instead supported by ID3DXLine). So, drawing with D3DPT_LINESTRIP primitives in general is probably not the right way...

June 30, 2011

Re: [PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX

by Detlef Riekenberg

On Mo, 2011-06-27 at 11:59 +0200, Jacek Caban wrote: > > How can we force tests to use VT_UI4? > It's not JScript builtin type, you need to extend tests host object for > that. Sorry, no clue. Which host object? > > +/* 0x7fffffff is 2147483647 is INT_MAX */ > > +tmp = 2147483647*-1; > > 0x... is correct jscript syntax, why not use it? Didn't know that. Thanks for the hint -- By by ... Detlef

June 30, 2011

Re: [3/8] msi: Handle escaped double quotes in command line parsing.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12111 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon) === W7PRO (32 bit install) === Timeout

June 30, 2011

RectInRegion Question

by Alistair Leslie-Hughes

Hi, When looping Region rects in function RectInRegion, we have the condition if(pCurRect->top >= rc.bottom) break; Should this break actually be a continue, like the other conditions? Best Regards Alistair Leslie-Hughes

June 30, 2011

Re: GSoC: dinput8 Action Mapping

by Lucas Zawacki

Hey guys, how are you doing? I've got some patches for you. The first is a refactoring of the BuildActionMap implementations for keyboard and mouse. I think with 'semantic_to_obj_id' the mapping is pretty much correct for keyboard and mouse and it's being done "the right way". The second patch is much like one I sent some time ago, it's SetActionMap for keyboard and mouse, this time (hopefully) with the dataformat stuff done right too. I've split it up in a third patch, which implements the "action mapping" per se. Anyway, tomorrow I'll code some mouse tests to be sure that this is working. Cheers

June 30, 2011

Re: wine bug 27600

by Vincas Miliūnas

On 06/30/2011 02:19 AM, wylda(a)volny.cz wrote: >> There is some garbage added to the patch code, I >> suspect that the way >> you downloaded the patch corrupted it. >> >> I wrote a bash script that will download the >> patches correctly and apply >> them: >> >> git clean -fd >> git reset --hard origin/master >> for i in 75876 75883 75878 75882 75881 75884 75877 75879 75880 >> do >> wget http://source.winehq.org/patches/data/$i -O >> /tmp/raw-$i.patch >> git apply /tmp/raw-$i.patch >> done >> ./tools/make_requests > > Even before i used wget for downloads & patch -p1. Anyway i gave > your script a chance, but i got during the compilation: > > > gcc -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe > -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body > -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith > -Wlogical-op -g -O2 -o raw_input.o raw_input.c > > In file included from raw_input.c:28: > > ../include/winternl.h:2361: error: expected declaration specifiers > or ‘...’ before ‘va_list’ > > ../include/winternl.h:2531: error: expected declaration specifiers > or ‘...’ before ‘va_list’ > > ../include/winternl.h:2532: error: expected declaration specifiers > or ‘...’ before ‘va_list’ > > In file included from raw_input.c:29: > > ../include/winbase.h:1578: error: expected declaration specifiers or > ‘...’ before ‘va_list’ > > ../include/winbase.h:1579: error: expected declaration specifiers or > ‘...’ before ‘va_list’ > > make[1]: *** [raw_input.o] Error 1 > > make[1]: Leaving directory `/build/wine-git_build/server' > > make: *** [server] Error 2 > > Ok, try with a modified header: git clean -fd git reset --hard origin/master for patch in \ 0001-user32-tests-Added-client-side-raw-input-function-te.patch \ 0002-user32-Added-DefRawInputProc-implementation-try-10.patch \ 0003-server-user32-Added-GetRawInputDeviceList-implementa.patch \ 0004-server-user32-Added-GetRawInputDeviceInfoW-implement.patch \ 0005-user32-Added-GetRawInputDeviceInfoA-implementation-t.patch \ 0006-server-user32-Added-GetRegisteredRawInputDevices-imp.patch \ 0007-server-user32-Added-RegisterRawInputDevices-implemen.patch \ 0008-user32-Added-GetRawInputBuffer-implementation-try-10.patch \ 0009-server-user32-Added-GetRawInputData-implementation-t.patch do wget http://dl.dropbox.com/u/6901628/$patch -O /tmp/$patch git apply /tmp/$patch done ./tools/make_requests

June 30, 2011

Re: [PATCH 3/3] d3dx9/tests: Implemented Draw and DrawTransform tests for ID3DXLine.

by Charles Welton

Forgot that this patch was based on the previous one I sent. I should probably resend when and if the others are committed. On 06/29/2011 10:20 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=12105 > > Your paranoid android. > > > === WINEBUILD (build) === > Patch failed to apply -- Charles Welton

June 30, 2011

Re: [PATCH 3/3] d3dx9/tests: Implemented Draw and DrawTransform tests for ID3DXLine.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12105 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

June 30, 2011

Re: [2/2] d3dx9_36: Implement and add tests for D3DXFloat16To32Array.

by Matteo Bruni

2011/6/29 Misha Koshelev <misha680(a)gmail.com>: > --- ... > + else return sgn * powf(2, -14.0f) * ((float)m / 1024.0f); ... > + return sgn * powf(2, (float)e - 15.0f) * (1.0f + ((float)m / 1024.0f)); I think you don't need the explicit casts here, the values should be automatically promoted to floats as the other operand is a float as well.

June 29, 2011