June 2011 - Wine-Devel - list.winehq.org

Re: wine bug 27600

by wylda＠volny.cz

> > Did you run ./tools/make_requests ? > > -- > -Austin > Nope. So i did: ./tools/make_requests make distclean ./configure followed by make and got (-O0 issue??): gcc -c -I. -I. -I../include -I../include -D__WINESRC__ -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempt y-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -o raw_input.o raw_input.c In file included from raw_input.c:28: ../include/winternl.h:2359: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2529: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winternl.h:2530: error: expected declaration specifiers or ‘...’ before ‘va_list’ In file included from raw_input.c:29: ../include/winbase.h:1578: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../include/winbase.h:1579: error: expected declaration specifiers or ‘...’ before ‘va_list’ make[1]: *** [raw_input.o] Error 1 make[1]: Leaving directory `/build/wine-git_build/server' make: *** [server] Error 2 -- IHNED.cz je nový, přehlednější a rychlejší. Přesvědčte se na: www.ihned.cz

June 28, 2011

Re: wine bug 27600

by Austin English

On Tue, Jun 28, 2011 at 13:16, <wylda(a)volny.cz> wrote: > > Hi Vincas, i wanted to give bug 27600 a try. So on top of > wine-1.3.23-50-g2497a91 i applied patches: > > 1. 75818 > 2. 75819 > 3. 75831 > 4. 75830 > 5. 75829 > 6. 75820 > 7. 75821 > 8. 75822 > 9. 75823 > > but i end up with failure during the buildup: > > gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ > -D_USER32_ -D_WINABLE_ -D_REENTRANT -fPIC -Wall -pipe -fno-stric > t-aliasing -Wdeclaration-after-statement -Wempty-body > -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith > -Wlogi > cal-op -g -O0 -o input.o input.c > > input.c: In function ‘GetRawInputDeviceList’: > > input.c:495: error: ‘union generic_request’ has no member named > ‘get_raw_input_device_list_request’ > > input.c:495: error: ‘union generic_reply’ has no member named > ‘get_raw_input_device_list_reply’ > > > Regards, > W. Did you run ./tools/make_requests ? -- -Austin

June 28, 2011

wine bug 27600

by wylda＠volny.cz

Hi Vincas, i wanted to give bug 27600 a try. So on top of wine-1.3.23-50-g2497a91 i applied patches: 1. 75818 2. 75819 3. 75831 4. 75830 5. 75829 6. 75820 7. 75821 8. 75822 9. 75823 but i end up with failure during the buildup: gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_USER32_ -D_WINABLE_ -D_REENTRANT -fPIC -Wall -pipe -fno-stric t-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogi cal-op -g -O0 -o input.o input.c input.c: In function ‘GetRawInputDeviceList’: input.c:495: error: ‘union generic_request’ has no member named ‘get_raw_input_device_list_request’ input.c:495: error: ‘union generic_reply’ has no member named ‘get_raw_input_device_list_reply’ Regards, W. -- IHNED.cz je nový, přehlednější a rychlejší. Přesvědčte se na: www.ihned.cz

June 28, 2011

Re: gcc 4.6 warning report

by Juan Lang

../../../dlls/netapi32/nbt.c:580:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] This is a false positive. h_addr_list is declared as a char **, and technically it is, but gethostbyname only returns IPv4 addresses, i.e. ones that can fit in a DWORD. --Juan

June 28, 2011

Re: [PATCH] comctl32: Fixed strncpy (Coverity)

by GOUJON Alexandre

... > What is wrong with: > buff[0] = 'x'; > buff[1] = 0; > > David and why not buff = { 'x', '\0' };

June 28, 2011

Re: [PATCH] comctl32: Fixed strncpy (Coverity)

by David Laight

On Tue, Jun 28, 2011 at 09:37:39AM +0200, Michael Stefaniuc wrote: > Hello Marcus, > > On 06/28/2011 09:15 AM, Marcus Meissner wrote: > > This is a 2 CHAR buffer, and we copy in 1 CHAR and \0. So just do that > > via strcpy() and dont confuse the static checker. ... > > - strncpy(buff, "x", sizeof(buff)/sizeof(CHAR)); > > + strcpy(buff, "x"); What is wrong with: buff[0] = 'x'; buff[1] = 0; David -- David Laight: david(a)l8s.co.uk

June 28, 2011

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

by Lucas Zawacki

The new patches address this issue, make some little corrections that are pointed in the comments. Also I organized them better, with the tests first. 2011/6/28 Lucas Zawacki <lfzawacki(a)gmail.com>: >> Do you really need to copy it back? It looks like an input parameter. > > Yes, you're right. In SetActionMap this copy should not be necessary. > I'll take this code out and roll a new version of the patches. >

June 28, 2011

Re: gcc 4.6 warning report

by Vincent Povirk

> ../../../../dlls/gdiplus/tests/image.c: In function ‘test_palette’: > ../../../../dlls/gdiplus/tests/image.c:1773:104: warning: array subscript is above array bounds [-Warray-bounds] This is because the ColorPalette structure has an array of length 1 at the end, which is really a variable-length array. We'd need a way to let gcc know of this fact, without breaking compatibility with Windows headers that declare it as an array of length 1. On Sat, Jun 18, 2011 at 9:55 AM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > Had to check a few warnings earlier and there hasn't been a warning > report in a while, thought I'd share it. It's also still impossible to > configure with -Werror because of warnings in configure scripts. > > Wine version > wine-1.3.22-203-gac90c1b ac90c1bd1878599710605fa5b4e2fe8ce224b280 > > Enabled packages > alsa freetype gstreamer jpeg ldap openal opengl openssl png x > xinerama xinput2 xml xrandr > > Disabled packages > capi cms cups curses esd fontconfig gettextpo gnutls gphoto gsm hal > jack mpg123 nas opencl oss sane tiff v4l xslt xxf86vm > > CFLAGS > -msse4 -O3 -Wall > > Built on > Linux azura 3.0-0-generic #1-Ubuntu SMP Thu Jun 9 16:32:10 UTC 2011 > x86_64 x86_64 x86_64 GNU/Linux > > > J. Leclanche > > > >

June 28, 2011

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

by Lucas Zawacki

> Do you really need to copy it back? It looks like an input parameter. Yes, you're right. In SetActionMap this copy should not be necessary. I'll take this code out and roll a new version of the patches.

June 28, 2011

Re: [PATCH 3/6] dinput: SetActionMap setting the device buffer (try 2)

by Alexandre Julliard

Lucas Fialho Zawacki <lfzawacki(a)gmail.com> writes: > + FIXME("(%p)->(%p,%s,%08x): semi-stub !\n", iface, lpdiaf, lpszUserName, dwFlags); > + > + diafW.rgoAction = HeapAlloc(GetProcessHeap(), 0, sizeof(DIACTIONW)*lpdiaf->dwNumActions); > + _copy_diactionformatAtoW(&diafW, lpdiaf); > + > + hr = IDirectInputDevice8WImpl_SetActionMap(&This->IDirectInputDevice8W_iface, &diafW, NULL, dwFlags); > + > + _copy_diactionformatWtoA(lpdiaf, &diafW); Do you really need to copy it back? It looks like an input parameter. -- Alexandre Julliard julliard(a)winehq.org

June 28, 2011