July 2011 - Wine-Devel - list.winehq.org

Re: [2/6] wined3d: Move FBO application into a state handler

by Henri Verbeet

On 1 July 2011 18:49, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > I put the code that used to be in context_apply_draw_state into state.c > because the FBO stuff is now a state handler. The alternative would be to keep > it in context.c and just export one function - that means we don't need the rt > mask functions in wined3d_private.h > That's probably nicer.

July 1, 2011

Re: [PATCH] advapi32: Set *lpSize properly in GetUserNameA (resend)

by Alexandre Julliard

Alex Stanev <alex(a)stanev.org> writes: > - ret = GetUserNameW( buffer, &sizeW ); > + ret = GetUserNameW( buffer, lpSize ); > if (ret) > - WideCharToMultiByte( CP_ACP, 0, buffer, -1, lpszName, *lpSize, NULL, NULL ); > - else > - *lpSize = sizeW; > + *lpSize = WideCharToMultiByte( CP_ACP, 0, buffer, -1, lpszName, *lpSize, NULL, NULL ); This is wrong, you can't use the W result as the A buffer size. -- Alexandre Julliard julliard(a)winehq.org

July 1, 2011

try to open *.doc files with explorer.exe

by Vitaly Perov

Windows can open *.doc files with command $explorer example.doc Several applications (for example russian accounting application "1C") use this command. Wine can't do it. I have prepared a patch to fix this bug. It works, but it seems a little bit hacky now. Please, help me to implement it correctly. -- Best regards, Vitaly Perov

July 1, 2011

Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

by Dylan Smith

On Thu, Jun 30, 2011 at 3:50 PM, Michael Mc Donnell <michael(a)mcdonnell.dk> wrote: > I've implemented the look-up scheme that you described. > + if (!point_reps) /* Indentity point reps */ > + { > + memset(adjacency, -1, 3 * num_faces * sizeof(*adjacency)); > + return D3D_OK; > + } I think you are missing the most common cases, where vertices are reused between triangles. For example: 0--1 | /| |/ | 2--3 If identity point reps are passed to your function it will find the adjacent edge, but if NULL is passed to the function for point reps, then it will find no adjacencies even though semantically they should be the same. Also, note the spelling error: Indentity -> Identity > +static void free_edge_face_map(struct edge_face_map *edge_face_map) > +{ > + if (!edge_face_map) > + return; > + > + HeapFree(GetProcessHeap(), 0, edge_face_map->lists); > + HeapFree(GetProcessHeap(), 0, edge_face_map->entries); > +} ... > static HRESULT WINAPI ID3DXMeshImpl_ConvertPointRepsToAdjacency(ID3DXMesh *iface, CONST DWORD *point_reps, DWORD *adjacency) > { > + struct edge_face_map *edge_face_map = NULL; ... > + free_edge_face_map(edge_face_map); > + iface->lpVtbl->UnlockIndexBuffer(iface); > + return hr; > } edge_face_map isn't freed. Also, it doesn't need to be allocated on the heap. > + hr = iface->lpVtbl->LockIndexBuffer(iface, 0, &ib_ptr); The LockIndexBuffer flags could be D3DLOCK_READONLY rather than 0 (which seems to have read-write semantics).

July 1, 2011