August 2011 - Wine-Devel - list.winehq.org

Re: [1/5] ddraw: Introduce a function to convert a DDSURFACEDESC to a DDSURFACEDESC2

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 29.08.2011 um 21:38 schrieb Henri Verbeet: > On 29 August 2011 20:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >> On Monday 29 August 2011 19:40:13 Henri Verbeet wrote: >>> On 29 August 2011 19:20, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >>>> +/* Note that this function writes the full sizeof(DDSURFACEDESC2) size, >>>> don't use it >>> >>> So no need to clear it first. >> Well, the clear is part of the code that writes to the structure. The rest of >> the code only writes members that are set in the source DDSURFACEDESC. >> > If they aren't set in the source structure we should never read them anyway. Technically that's true for this specific function since the result is only used by our code and never the application. Yet I prefer to keep the memset for consistency with other code that handles DDSURFACEDESC(2) structures. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.17 (Darwin) iQIcBAEBAgAGBQJOW+6PAAoJEN0/YqbEcdMw9Q4QAIzL0rJ/RQ+pz2eS2Bm6Ojf2 aiOLyWe5Bwuc+qBL3uvt+l+L/PiUQSHXCViDyjvOlZL9IK/fdVfcEDLiWd8/884N FV9NtnR0MB5nUwOHpZYk70zXocY+Fyi47b7yuC0SC9DU8Pf1y+MvvTyu30GC8T5t J/vG6LLUlkuSDSsmomg5GAAEEGEst25D21m9nVlt8IiaaqP1oNdsshSwh3FWjP7w PmVR1Pzi2gNIyhRrXuTasbHFtgME4HwUrjgglRe4R/dacMopfLAHM+swxHQykgmw HGLYsRhKFMoegsAsiAkIARyF4Oc73uJaVdhcBP/mRXPcGBT93cICV69XbNgGJ7AN xdEfxFWVujCF0x94KTC1XLEt+sM1bkjlIoITcPsqEjbrm16jU3jtuSLL58KAOtsh QVlksMQ8b3Fo0zY/tKzucBQoAZpDgMJY4EvkfcB5HLqIRlHHK/ZzMhe6vjEzZfZn 0ELwEl2+QRaAITLEnmK8DxL/PtI9unemLAeOOZkigi8ooeo6KVOM5g5VqCqhEhMp XNi1yQdkINthCZpPqDWnx9SnYJS3bqlUqXHi+SoZnuwBc41AFctsYjPVeRnIF6Sm zf6Ae7MD2piA/elrHlCyQfS5CQWUmkY0xNZDGHD0sBEsh5SYFFbPoM4kJAKJZrTq OJR39TbofSSvpESIua2n =Mzq4 -----END PGP SIGNATURE-----

Aug. 29, 2011

Re: [1/5] ddraw: Introduce a function to convert a DDSURFACEDESC to a DDSURFACEDESC2

by Henri Verbeet

On 29 August 2011 20:53, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > On Monday 29 August 2011 19:40:13 Henri Verbeet wrote: >> On 29 August 2011 19:20, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >> > +/* Note that this function writes the full sizeof(DDSURFACEDESC2) size, >> > don't use it >> >> So no need to clear it first. > Well, the clear is part of the code that writes to the structure. The rest of > the code only writes members that are set in the source DDSURFACEDESC. > If they aren't set in the source structure we should never read them anyway.

Aug. 29, 2011

Re: [5/5] ddraw: Add a test for DDSD_ZBUFFERBITDEPTH and DDSD_PIXELFORMAT

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13811 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WXPPROSP3 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K3R2SESP2 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WVISTAADM (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K8SE (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PRO (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (64 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091.

Aug. 29, 2011

Re: [4/5] ddraw: Set dwZBufferBitDepth in old z buffers

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13810 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WXPPROSP3 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K3R2SESP2 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WVISTAADM (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K8SE (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PRO (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (64 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091.

Aug. 29, 2011

Re: winspool.drv/tests: Fix tracing a NULL string

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13819 Your paranoid android. === WINEBUILD (build) === Can't determine base name

Aug. 29, 2011

Re: [wine-devel] Re: Severe regression in wine startup latencies

by Alan W. Irwin

On 2011-08-29 07:56+1000 Ben Peddell wrote: > On 29/08/2011 2:37 AM, Alan W. Irwin wrote: >> bash.exe-3.1$ time /z/home/wine/newstart1/MinGW/msys/1.0/bin/echo.exe >> hello >> hello >> >> real 0m0.503s >> user 0m0.080s >> sys 0m0.020s >> >> Also, I tried >> time (x; x; x; x; x; x; x; x; x; x), where "x" represents the complete >> echo command above, and the result was >> >> real 0m5.281s >> user 0m0.800s >> sys 0m0.200s > [snip] >> >> While I am doing those additional investigations, please consider the >> question of why there is a huge difference between built-in and >> executable latency for MSYS bash commands under wine. To start that >> investigation it would be good to compare the wine results for those >> two cases with the Windows results for those two cases. (I assume the >> two time results for built-in versus executable will be fairly similar >> in the Windows case, but that assumption needs to be checked.) I don't >> have access to Windows myself. Anybody up for doing that simple test >> and reporting the results back here? The automatic MinGW/MSYS >> installer at http://sourceforge.net/projects/mingw/files/Automated >> MinGW Installer/mingw-get-inst/ makes it easy to install the relevant >> MinGW/MSYS software on both wine and Windows. > > Under MSYS 1.0.17 running on Windows 7 x64 SP1: > > bash.exe-3.1$ /bin/bash --version > GNU bash, version 3.1.17(1)-release (i686-pc-msys) > Copyright (C) 2005 Free Software Foundation, Inc. > > bash.exe-3.1$ alias x='/bin/echo.exe -n .' > > bash.exe-3.1$ time x > . > real 0m0.031s > user 0m0.000s > sys 0m0.015s > > bash.exe-3.1$ time (x;x;x;x;x;x;x;x;x;x) > .......... > real 0m0.296s > user 0m0.075s > sys 0m0.136s > > This shows a latency of approximately 2 jiffies for each command - 1 > jiffy in Windows is 15.6ms. > > -- > Ben Peddell > IT Support Bowen, Collinsville, Proserpine and Home Hill Catholic schools > http://klightspeed.killerwolves.net/ Thanks, Ben, for doing the requested test for the executable echo test. That shows the Windows startup latency is measureable but acceptable for that executable. Just out of curiosity, what happens for the corresponding bash executable built-in echo functionality? Is it essentially instantaneous (i.e., elapsed time less than 0.001 seconds) like in the wine case? Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net) the Time Ephemerides project (timeephem.sf.net) PLplot scientific plotting software package (plplot.sf.net) the libLASi project (unifont.org/lasi) the Loads of Linux Links project (loll.sf.net) and the Linux Brochure Project (lbproject.sf.net) __________________________ Linux-powered Science __________________________

Aug. 29, 2011

Re: [3/5] ddraw: Convert dwZBufferBitDepth into a DDPIXELFORMAT

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13809 Your paranoid android. === W2KPROSP4 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WXPPROSP3 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K3R2SESP2 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === WVISTAADM (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W2K8SE (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PRO (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (32 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091. === W7PROX64 (64 bit dsurface) === dsurface.c:3878: Test failed: IDirectDraw_CreateSurface failed, hr 0x88760091.

Aug. 29, 2011

Re: [2/2] net: Add support for enumerating the running services with 'net start'.

by Francois Gouget

On Mon, 29 Aug 2011, Frédéric Delanoy wrote: [...] > > diff --git a/programs/net/net.c b/programs/net/net.c > > index 249c14d..ed26b43 100644 > > + STRING_RUNNING, " %s\n" > > This one is not particularly translatable. That's quite true. I'll send a patch to remove it. -- Francois Gouget <fgouget(a)codeweavers.com>

Aug. 29, 2011

Re: Hebrew: update

by Francois Gouget

On Mon, 29 Aug 2011, Shachar Shemesh wrote: [...] > Yes, it does not support Unicode. That's why I said "1255", as in "Windows 1255", the ANSI > encoding for Hebrew. It does support Unicode (UTF-16) otherwise 'Hello' would have not been displayed correctly. Furthermore I also tested with a Windows 1255 encoded and did not have any luck with it either. > The first line was ok but the second one was either question marks or > squares. The only fonts Windows will let me pick are 'Consolas', 'Lucida > Console' and 'Raster Fonts'. > > It should let you pick any monospace font. At least one of those should contain a Hebrew > encoding. If not, you might need to set the default locale to Hebrew in order to test this > (which will only be possible after clicking "add support for complex text layout languages", or > something to similar effect, in Regional Settings). This will also install the Hebrew fonts. I am only given the three font choices I listed. Also I did test this in a Hebrew locale. I did not have to check an 'add support for complex text layout languages' option however. All I did was go to the Windows Update site and select the Hebrew support option. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: the choice of a GNU generation

Aug. 29, 2011

Re: [2/2] net: Add support for enumerating the running services with 'net start'.

by Frédéric Delanoy

On Fri, Aug 26, 2011 at 17:41, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > Quite useful to see what services are actually running. > > programs/net/net.c | 55 ++++++++++++++++++++++++++++++++++++++++++++- > programs/net/net.rc | 4 ++- > programs/net/resources.h | 2 + > 3 files changed, 58 insertions(+), 3 deletions(-) > > diff --git a/programs/net/net.c b/programs/net/net.c > index 249c14d..ed26b43 100644 > + STRING_RUNNING, " %s\n" This one is not particularly translatable.

Aug. 29, 2011