August 2011 - Wine-Devel - list.winehq.org

Re: wine crashtests

by Alexandre Julliard

Vitaly Perov <vitperov(a)etersoft.ru> writes: > Then, my second qustion is: > I need a big-size pictures (jpg, png, gif, bmp) for my tests. > I think I am unable to generate them in the test. > Is it normal to add them as files? You should generate fake files, it's not hard. -- Alexandre Julliard julliard(a)winehq.org

Aug. 1, 2011

Re: wine crashtests

by Vitaly Perov

On Mon, 01 Aug 2011 12:45:12 +0200, Alexandre Julliard wrote: > You should not be trying to write a test that proves that Wine > crashes, > that's not interesting. What you should do is demonstrate Windows > behavior for various types of invalid input, and then make Wine > conform > to that. As I understood, I should send a fix and tests (which crash without the fix) in one patch, shouldn't I? And couple of tests should cover all possible variants of invalid input. Then, my second qustion is: I need a big-size pictures (jpg, png, gif, bmp) for my tests. I think I am unable to generate them in the test. Is it normal to add them as files?

Aug. 1, 2011

Re: wine crashtests

by Alexandre Julliard

Vitaly Perov <vitperov(a)etersoft.ru> writes: > On Mon, 01 Aug 2011 14:11:31 +0400, Nikolay Sivov wrote: >> On 8/1/2011 14:04, Vitaly Perov wrote: >>> Is it possible to add a test to show that Wine crashes? >> You mean inside exception handler? Test that crashes comes with or >> after a fix that fix a crash. > > Yes, I have sent a patch that fix a crash. The status of my patch is > "need tests". > I want to add a test to show that Wine really crashes, and the patch > really fix the crash. You should not be trying to write a test that proves that Wine crashes, that's not interesting. What you should do is demonstrate Windows behavior for various types of invalid input, and then make Wine conform to that. -- Alexandre Julliard julliard(a)winehq.org

Aug. 1, 2011

Re: wine crashtests

by Nikolay Sivov

On 8/1/2011 14:31, Vitaly Perov wrote: > On Mon, 01 Aug 2011 14:11:31 +0400, Nikolay Sivov wrote: >> On 8/1/2011 14:04, Vitaly Perov wrote: >>> Is it possible to add a test to show that Wine crashes? >> You mean inside exception handler? Test that crashes comes with or >> after a fix that fix a crash. > > Yes, I have sent a patch that fix a crash. The status of my patch is > "need tests". > I want to add a test to show that Wine really crashes, and the patch > really fix the crash. Send fix with a test as a single path, if a change is trivial and test bot doesn't crash on new test then it's enough.

Aug. 1, 2011

Re: wine crashtests

by Vitaly Perov

On Mon, 01 Aug 2011 14:11:31 +0400, Nikolay Sivov wrote: > On 8/1/2011 14:04, Vitaly Perov wrote: >> Is it possible to add a test to show that Wine crashes? > You mean inside exception handler? Test that crashes comes with or > after a fix that fix a crash. Yes, I have sent a patch that fix a crash. The status of my patch is "need tests". I want to add a test to show that Wine really crashes, and the patch really fix the crash.

Aug. 1, 2011

Re: make "bisected" a keyword in bugzilla?

by Wolfram Sang

On 28/07/11 22:15, Austin English wrote: > On Sun, May 23, 2010 at 22:45, Wolfram Sang <wolfram(a)the-dreams.de> wrote: >>> Probably it would be better to add a field for commit id that caused >>> a regression just like there is one for url/keywords instead of inventing >>> new keywords. So a 'regression' with a commit id would automatically mean >>> 'bisected'. That would also save time of finding the commit id by looking >>> at every comment in the bug, and possibly avoiding finding incorrect >>> bisect results. >> >> Yay, that would be even better! > > While doing some other bugzilla maintenance, I've found where to add > custom fields, so a 'regression commit sha1-id' (or other preferred > name) field is now a possibility. > > I'll wait a week for comments before adding it. Yay! \o/

Aug. 1, 2011

Re: wine crashtests

by Nikolay Sivov

On 8/1/2011 14:04, Vitaly Perov wrote: > Is it possible to add a test to show that Wine crashes? You mean inside exception handler? Test that crashes comes with or after a fix that fix a crash.

Aug. 1, 2011

wine crashtests

by Vitaly Perov

Is it possible to add a test to show that Wine crashes?

Aug. 1, 2011

Re: Wine and endianness

by GOUJON Alexandre

On 08/01/2011 09:09 AM, David Laight wrote: > If you have 'unsigned char bloc[]' and want to read a 32 bit LE value > you can do: > value = bloc[20 + 0]; > value |= bloc[20 + 1]<< 8; > value |= bloc[20 + 2]<< 16; > value |= bloc[20 + 3]<< 24; > *offs = value; > And that is correct on all architectures. I have a BYTE[] so I will do that. I was worried about compatibility across architectures but as you pointed out, my code is slow and even wrong. As always, KISS ! > To write a LE value use: > buf[0] = value; > buf[1] = value>>= 8; > buf[2] = value>>= 8; > buf[3] = value>>= 8; > > (For BE reverse the indexes) Thanks for remembering me this compact syntax. > If the item is known to be correctly aligned (or the architecture supports > mis-aligned reads) then you can just do (eg): > value = *(uint32_t *)(bloc + 20); > value = le32toh(value); > but you'll have to chase around the OS headers to find how to spell le32toh(). If I had something like uint128_t (I doubt it will ever exist), then yeah, I would try to avoid 32 lines of code and bit shifting but I prefer the above solution in my case. > If you define a C struct that matches the data area (packed if it might I thought about it but I only use the value once. Thanks for all your advices. Will "star" this e-mail if I need it later. > David

Aug. 1, 2011

Re: GSoC: dinput8 Action Mapping

by Marcus Meissner

On Fri, Jul 29, 2011 at 05:48:43PM -0300, Lucas Zawacki wrote: > Hello! > > Here's a lot of patches with a ConfigureDevices implementation. These > patches can be tested with this app I built that uses ConfigureDevices > to set up a joystick action mapping > (https://github.com/downloads/lfzawacki/dinput-samples/dolphin-plugin.exe) > . I also tested it with the Rally Trophy and Star Sonata games. > > Any advice on the dialog code is appreciated, it's the first time I've > coded something like this and may have missed some things. > > This implementation still lacks some things: > > * Implement username property for devices > * Tracking down a bug with Rally Trophy that makes the mouse disappear > while inside the ConfigureDevices dialog. > * Implement the "Sort Assigned" checkbox > * Some fixes to the code > > I'll let the code resting here while I keep working on this stuff. If this is to some degree functional it can also be included already :) One thing in 0001: > + /* Copy action names */ > + for (i=0; i < diafW.dwNumActions; i++) > + { > + const char* from = lpdiCDParams->lprgFormats->rgoAction[i].u.lptszActionName; > + WCHAR *to = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR)*MAX_PATH); > + MultiByteToWideChar(CP_ACP, 0, from , -1, to , MAX_PATH); > + diafW.rgoAction[i].u.lptszActionName = to; > + } The pattern to do this is usually by querying MBtoWC for the result length and then allocating and doing it for real (untested): const char* from = lpdiCDParams->lprgFormats->rgoAction[i].u.lptszActionName; WCHAR *to; DWORD len; len = MultiByteToWideChar(CP_ACP, 0, from , -1, NULL , 0); to = HeapAlloc(GetProcessHeap(),0,len*sizeof(WCHAR)); MultiByteToWideChar(CP_ACP, 0, from , -1, to, len); diafW.rgoAction[i].u.lptszActionName = to; > + hr = IDirectInput8WImpl_ConfigureDevices(&This->IDirectInput8W_iface, lpdiCallback, &diCDParamsW, dwFlags, pvRefData); Should the action format be copied back on error? > + /* Copy back configuration */ > + _copy_diactionformatWtoA(lpdiCDParams->lprgFormats, &diafW); > + > + /* Free memory */ > + for (i=0; i < diafW.dwNumActions; i++) > + HeapFree(GetProcessHeap(), 0, (LPVOID) diafW.rgoAction[i].u.lptszActionName); > + > + HeapFree(GetProcessHeap(), 0, diafW.rgoAction); > > - FIXME("(this=%p,%p,%p,%04x,%p): stub\n", This, lpdiCallback, lpdiCDParams, > - dwFlags, pvRefData); > - return 0; > + return hr; I also read over the dialog stuff ... I did not see anything problematic, looked to my untrained eyes :) Ciao, Marcus

Aug. 1, 2011