September 2011 - Wine-Devel

Re: Daily builds of latest Git now available as Ubuntu packages

by Qian Hong

On Thu, Sep 1, 2011 at 8:43 PM, Scott Ritchie <scott(a)open-vote.org> wrote: > Unfortunately I have to use Launchpad Recipe's supported substitution > variables here, and while they do have one for the latest git-tag if I > build locally this doesn't work on launchpad itself. The reason for > this is that the launchpad recipe builders don't have git proper, but > instead rely on bzr-git imports (the package is actually building off > the launchpad bzr import of the Wine git tree merged with my packaging > bzr branch). > > > Yeah it's a bit lame, and I'll raise the issue with the launchpad folks > when I see them next, but it's a pretty minor problem atm. Hello, Is there any good ways to get the git-describe-like version number from the daily build ppa version number? That's useful while running a regression test. For example, I'd like to know exactly what is wine1.3_1.3.28+daily-20110912 in http://bugs.winehq.org/show_bug.cgi?id=28450 . Thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

Sept. 20, 2011

Re: [PATCH 1/3] shell32: Don't call SendMessage inside critical section

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -355,24 +351,34 @@ void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID dwItem1, LPCVOID > if( !notify ) > continue; > > - ptr->pidlSignaled = ILClone(Pidls[0]); > + item = SHAlloc(sizeof(struct notification_recipients)); > + if(!item) { > + ERR("out of memory\n"); > + continue; > + } This one is never freed. -- Alexandre Julliard julliard(a)winehq.org

Sept. 20, 2011

re: [PATCH 2/9] cmd: use GetCommandline() rather than argv

by Dan Kegel

Hi Martin, on my i7 machine, your patch series fails every time for me when run normally. Here's the log: ]] ../../../tools/runtest -q -P wine -M cmd.exe -T ../../.. -p cmd.exe_test.exe.so batch.c && touch batch.ok ]] ... ]] wine: cannot find L"C:\\windows\\system32\\tell;1;;2.exe" ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 50 (got '0 ', wanted '0(a)space@') ]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line 53 (got 'error 9009', wanted '1(a)space@') ]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line 59 (got 'error 9009', wanted '1(a)space@') ]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line 62 (got 'error 9009', wanted '2(a)space@') ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 75 (got '"hi"', wanted '"hi"') ]] batch.c:301: Test failed: unexpected char 0x65 position 0 in line 78 (got 'error 9009', wanted '1(a)space@') ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 81 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 90 (got '1 ', wanted '1(a)space@') ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 93 (got '0 ', wanted '0(a)space@') ]] batch.c:301: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 102 (got '3 ', wanted '3(a)space@') ]] Command exited with non-zero status 10 ]] make: *** [batch.ok] Error 10 ]] make: Target `test' not remade because of errors. When run with WINEDEBUG=warn+heap, it passes. Not sure what to make of that, but something's fishy, and the patch should not go in as is. You might try valgrind to see if it turns anything up. - Dan

Sept. 20, 2011

Re: [2/2] shell32: Be safe against removal of entries in SHChangeNotify

by Piotr Caban

Hi, On 09/19/11 20:52, André Hentschel wrote: > @@ -325,7 +325,7 @@ void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID dwItem1, LPCVOID > EnterCriticalSection(&SHELL32_ChangenotifyCS); > > /* loop through the list */ > - LIST_FOR_EACH_ENTRY( ptr,&notifications, NOTIFICATIONLIST, entry ) > + LIST_FOR_EACH_ENTRY_SAFE( ptr, next,&notifications, NOTIFICATIONLIST, entry ) The function should not call SendMessage inside critical section. Cheers, Piotr

Sept. 20, 2011

Re: [PATCH 4/5] vbscript: Added more tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14413 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 20, 2011

Re: [PATCH 3/5] vbscript: Added support for short if statements

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14412 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 20, 2011

Re: [PATCH 2/5] vbscript: Added support for rem statement-like comments

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14411 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 20, 2011

Re: [PATCH 1/5] vbscript: Added support for ':' as statement separator

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14410 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Sept. 20, 2011

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android. === WINEBUILD (build) === Can't determine base name

Sept. 20, 2011

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android. === WINEBUILD (build) === Can't determine base name

Sept. 20, 2011

Re: [PATCH 3/3 try3] wshom.ocx: Added beginning WshShell object tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14409 Your paranoid android. === WINEBUILD (build) === Can't determine base name

Sept. 20, 2011

Re: [PATCH 1/3 try2] wshom.ocx: Added WshShell class factory implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14406 Your paranoid android. === WINEBUILD (build) === Can't determine base name

Sept. 20, 2011

Re: [PATCH 1/3] wshom.ocx: Added WshShell class factory implementation

by Jacek Caban

On 09/19/11 20:13, Dan Kegel wrote: > build failed here? > > ../../tools/makedep -C. -S../.. -T../.. shell.c wshom_main.c > wshom.rc wshom.idl wshom.idl wshom.tlb > wshom_private.h: No such file or directory > wshom_private.h was first included from shell.c:19 > make[1]: *** [depend] Error 1 > make[1]: Leaving directory > `/home/bob/wineslave.dir/sandbox/slave/runtests-default/build/dlls/wshom.ocx' > make: *** [dlls/wshom.ocx/__depend__] Error 2 > make: *** Waiting for unfinished jobs.... I forgot to include wshom_private.h in the patch, sorry about that. Jacek

Sept. 20, 2011

Re: msi: Print the string and not the pointer in a TRACE.

by Hans Leidekker

On Tue, 2011-09-20 at 10:51 +0200, Michael Stefaniuc wrote: > Hans Leidekker wrote: > > On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote: > >> @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, LPCSTR szFolder, > >> awstring str; > >> UINT r; > >> > >> - TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf); > >> + TRACE("%s %s %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf); > > > > szPathBuf is an output buffer. > Ok, then the format should stay as %p and the debugstr_a() should go. Yes, note that Francois has already sent a patch.

Sept. 20, 2011

Re: msi: Print the string and not the pointer in a TRACE.

by Michael Stefaniuc

Hans Leidekker wrote: > On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote: >> @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, LPCSTR szFolder, >> awstring str; >> UINT r; >> >> - TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf); >> + TRACE("%s %s %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf); > > szPathBuf is an output buffer. Ok, then the format should stay as %p and the debugstr_a() should go. bye michael

Sept. 20, 2011

Re: [1/2] d3dx9: Implemented D3DXWeldVertices.

by Michael Mc Donnell

Hi Alexandre My D3DXWeldVertices patch set (see [1] and [2]) scrolled of the patches list . It has been reviewed by Stefan and others on wine-devel, so it should be ok. Do you see anything wrong with it? Should I resend it? Thanks, Michael Mc Donnell [1] http://www.winehq.org/pipermail/wine-patches/2011-August/105423.html [2] http://www.winehq.org/pipermail/wine-patches/2011-August/105422.html

Sept. 20, 2011

Re: [PATCH 1/9] cmd/tests: add tests for command line parsing

by Frédéric Delanoy

2011/9/20 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > On Tue, Sep 20, 2011 at 01:51, Martin Wilck <mwilck(a)arcor.de> wrote: >> This patch adds some tests for command line parsing and treatment >> of quotes and special characters in the command line and in program >> names and parameters. The .exp file was created using Win XP. >> --- >> programs/cmd/tests/rsrc.rc | 6 + >> programs/cmd/tests/test_cmdline.cmd | 159 ++++++++++++++++++++++ >> programs/cmd/tests/test_cmdline.cmd.exp | 219 +++++++++++++++++++++++++++++++ >> 3 files changed, 384 insertions(+), 0 deletions(-) >> create mode 100755 programs/cmd/tests/test_cmdline.cmd >> create mode 100755 programs/cmd/tests/test_cmdline.cmd.exp > > You might want to do a single "@echo off" at the start of the .cmd file. > Echoing every command in the .exp isn't very helpful: you don't want > to replicate the .cmd contents in the .exp file. Add comments or > "subsections" as is done in test_builtins.cmd if necessary, or even > better use descriptive results, like e.g. 'text in single quotes' if > possible > (Also the @ before every rem or echo just add visual clutter IMHO but > that's due to the enabled echo mode) Also, there should be no trailing whitespace. See http://wiki.winehq.org/SubmittingPatches

Sept. 20, 2011

Re: [PATCH 9/9] cmd/tests: adapt TODOs in test output (parameter passing)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14400 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0(a)space@@or_broken(a)3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>cmd ignoreme/c say one ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 135 (got '0 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+(a)space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2 === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === TEST64_W7SP1 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === TEST64_W7SP1 (64 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@')

Sept. 20, 2011

Re: [PATCH 7/9] cmd/tests: adapt TODOs in test output (special characters)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14399 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0(a)space@@or_broken(a)3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>cmd ignoreme/c say one ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 135 (got '0 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+(a)space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2 === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === TEST64_W7SP1 (32 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@') === TEST64_W7SP1 (64 bit) === batch.c:301: Test failed: unexpected char 0x21 position 0 in line 161 (got '! ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 164 (got '0 ', wanted '!@space@')

Sept. 20, 2011

Re: [PATCH 5/9] cmd/tests: fix TODOs in test output (quotes)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14398 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0(a)space@@or_broken(a)3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>cmd ignoreme/c say one ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 135 (got '0 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+(a)space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2

Sept. 20, 2011

Re: [PATCH 3/9] cmd/tests: fix TODOs in test output (GetCommandline())

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14397 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0(a)space@@or_broken(a)3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>cmd ignoreme/c say one ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 135 (got '0 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+(a)space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2

Sept. 20, 2011

Re: [PATCH 1/9] cmd/tests: add tests for command line parsing

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14396 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ') batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ') batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ') batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ') batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ') batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ') batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ') batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ') batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '') batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"') batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ') batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ') batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ') batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ') batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ') batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ') batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ') batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ') batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0(a)space@@or_broken(a)3@space@') batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ') batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3(a)space@') batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ') batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ') batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ') batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2(a)space@') batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ') batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------') batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ') batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1(a)space@') batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ') batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ') batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------') batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '') batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 135 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ') batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ') batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@') batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ') batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@') batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ') batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@') batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ') batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@') batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ') batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@') batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ') batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ') batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '!@space@') batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ') batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ') batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ') batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+(a)space@') batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ') batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0(a)space@') batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ') batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@') batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ') batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing --------------') batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '') batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@') batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing --------------', wanted '>call tell (1) ') batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ') batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@') batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ') batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@') batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ') batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@') batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@') batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ') batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2(a)space@') batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '') batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ') batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:1,2:2 === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === TEST64_W7SP1 (32 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@') === TEST64_W7SP1 (64 bit) === batch.c:301: Test failed: unexpected char 0x3e position 0 in line 129 (got '>echo THIS FAILS: cmd ignoreme/c say one ', wanted '>cmd ignoreme/c say one ') batch.c:301: Test failed: unexpected char 0x54 position 0 in line 130 (got 'THIS FAILS: cmd ignoreme/c say one', wanted '0(a)space@')

Sept. 20, 2011

Re: [PATCH 3/9] cmd/tests: fix TODOs in test output (GetCommandline())

by Frédéric Delanoy

On Tue, Sep 20, 2011 at 01:51, Martin Wilck <mwilck(a)arcor.de> wrote: > Fix output after "cmd: use GetCommandline() rather than argv" patch. > This also fixes the test case where Wine would hang. Having path P1 fixing issue and P2 changing .cmd/.exp is wrong. Testsuite has to pass after every patch committed. The normal procedure is: P1 (add tests); P2 (add fixes + update results) In cases it's not possible, you may merge the two patches in a single patch

Sept. 19, 2011

Re: [PATCH 1/9] cmd/tests: add tests for command line parsing

by Frédéric Delanoy

On Tue, Sep 20, 2011 at 01:51, Martin Wilck <mwilck(a)arcor.de> wrote: > This patch adds some tests for command line parsing and treatment > of quotes and special characters in the command line and in program > names and parameters. The .exp file was created using Win XP. > --- > programs/cmd/tests/rsrc.rc | 6 + > programs/cmd/tests/test_cmdline.cmd | 159 ++++++++++++++++++++++ > programs/cmd/tests/test_cmdline.cmd.exp | 219 +++++++++++++++++++++++++++++++ > 3 files changed, 384 insertions(+), 0 deletions(-) > create mode 100755 programs/cmd/tests/test_cmdline.cmd > create mode 100755 programs/cmd/tests/test_cmdline.cmd.exp You might want to do a single "@echo off" at the start of the .cmd file. Echoing every command in the .exp isn't very helpful: you don't want to replicate the .cmd contents in the .exp file. Add comments or "subsections" as is done in test_builtins.cmd if necessary, or even better use descriptive results, like e.g. 'text in single quotes' if possible (Also the @ before every rem or echo just add visual clutter IMHO but that's due to the enabled echo mode)

Sept. 19, 2011

Re: msi: Print the string and not the pointer in a TRACE.

by Hans Leidekker

On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote: > @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, LPCSTR szFolder, > awstring str; > UINT r; > > - TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf); > + TRACE("%s %s %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf), pcchPathBuf); szPathBuf is an output buffer.

Sept. 19, 2011