September 2011 - Wine-Devel

Re: [PATCH 13/19] vbscript: Added class functions parser implementation

by Jacek Caban

On 09/15/11 18:38, Dan Kegel wrote: > Fails here under WINEDEBUG=warn-heap: > > ../../../tools/runtest -q -P wine -M vbscript.dll -T ../../.. -p > vbscript_test.exe.so run.c&& touch run.ok > wine: Unhandled page fault on read access to 0x55555555 at address > 0x4004c1e4 (thread 0019), starting debugger... > Backtrace: > =>0 0x4004c1e4 add_class_function+0x29(ctx=0x33fad8, > class_decl=0x151dd4, decl=0x151dbc) [dlls/vbscript/parser.y:638] > 1 0x4004b63e parser_parse+0xee6(ctx=0x33fad8) [dlls/vbscript/parser.y:294] > 2 0x4004c3a2 parse_script+0xae(ctx=0x33fad8, code="...", > ret=0x33fbe8) [dlls/vbscript/compile.c:961] > 4 0x40049685 VBScriptParse_ParseScriptText+0x12d(iface=0x125e5c, > pstrCode="...", pstrItemName=0x0(nil), punkContext=(nil), > pstrDelimiter=0x0(nil), dwSourceContextCookie=0, ulStartingLine=0, > dwFlags=0, pvarResult=(nil), pexcepinfo=(nil)) > [dlls/vbscript/vbscript.c:554] > 5 0x684b796d parse_script+0x32c(flags=0x8, script_str="...") > [dlls/vbscript/tests/run.c:683] > 6 0x684b7e99 run_from_res+0x15b(name="lang.vbs") > [dlls/vbscript/tests/run.c:784] > 7 0x684b845c run_tests+0x4eb() [dlls/vbscript/tests/run.c:841] > 8 0x684b854c func_run+0x7a() [dlls/vbscript/tests/run.c:871] > 9 0x684bb2d3 run_test+0x9e(name="run.c") > [dlls/vbscript/tests/../../../include/wine/test.h:556] > 0x4004c1e4 add_class_function+0x29 [dlls/vbscript/parser.y:638] in > vbscript: movl 0x0(%eax),%eax > 638 if(!strcmpiW(iter->name, decl->name)) { Thanks for the report. It lacks initialization of a variable (that was done in later, not yet sent patch). I've sent a fix. Jacek

Sept. 15, 2011

re: [PATCH 13/19] vbscript: Added class functions parser implementation

by Dan Kegel

Fails here under WINEDEBUG=warn-heap: ../../../tools/runtest -q -P wine -M vbscript.dll -T ../../.. -p vbscript_test.exe.so run.c && touch run.ok wine: Unhandled page fault on read access to 0x55555555 at address 0x4004c1e4 (thread 0019), starting debugger... Backtrace: =>0 0x4004c1e4 add_class_function+0x29(ctx=0x33fad8, class_decl=0x151dd4, decl=0x151dbc) [dlls/vbscript/parser.y:638] 1 0x4004b63e parser_parse+0xee6(ctx=0x33fad8) [dlls/vbscript/parser.y:294] 2 0x4004c3a2 parse_script+0xae(ctx=0x33fad8, code="...", ret=0x33fbe8) [dlls/vbscript/compile.c:961] 4 0x40049685 VBScriptParse_ParseScriptText+0x12d(iface=0x125e5c, pstrCode="...", pstrItemName=0x0(nil), punkContext=(nil), pstrDelimiter=0x0(nil), dwSourceContextCookie=0, ulStartingLine=0, dwFlags=0, pvarResult=(nil), pexcepinfo=(nil)) [dlls/vbscript/vbscript.c:554] 5 0x684b796d parse_script+0x32c(flags=0x8, script_str="...") [dlls/vbscript/tests/run.c:683] 6 0x684b7e99 run_from_res+0x15b(name="lang.vbs") [dlls/vbscript/tests/run.c:784] 7 0x684b845c run_tests+0x4eb() [dlls/vbscript/tests/run.c:841] 8 0x684b854c func_run+0x7a() [dlls/vbscript/tests/run.c:871] 9 0x684bb2d3 run_test+0x9e(name="run.c") [dlls/vbscript/tests/../../../include/wine/test.h:556] 0x4004c1e4 add_class_function+0x29 [dlls/vbscript/parser.y:638] in vbscript: movl 0x0(%eax),%eax 638 if(!strcmpiW(iter->name, decl->name)) { On Thu, Sep 15, 2011 at 8:16 AM, <buildbot(a)kegel.com> wrote: > This is an experimental automated build and test service. > Please feel free to ignore this email while we work the kinks out. > > For more info about this message, see http://wiki.winehq.org/BuildBot > > The Buildbot has detected a failed build on builder runtests-heaptest while building Wine. > Full details are available at: http://buildbot.kegel.com/builders/runtests-heaptest/builds/92 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) > BUILD FAILED: failed shell_3 > > Errors: > make: *** [run.ok] Error 5 > >

Sept. 15, 2011

Re: ole32/tests: Fix compilation on systems that don't support nameless unions.

by Alexandre Julliard

Dan Kegel <dank(a)kegel.com> writes: > Also be a bit more uniform about using U() instead of .u when accessing LowPart. .u is better. -- Alexandre Julliard julliard(a)winehq.org

Sept. 15, 2011

Re: Something's rotten in git today...

by Maarten Lankhorst

Hey Dan, On 09/15/2011 02:02 AM, Dan Kegel wrote: > It might be just me, but I've seen five very strange test failures > today out of about 30 build/test runs. > Has anybody else noticed problems? > Does it happen if you try wine.git from before yesterday too? ~Maarten

Sept. 15, 2011

Re: [PATCH] oleaut32: OLEPictureImpl_Load uses Seek(STREAM_SEEK_END) to find the stream length

by Marcus Meissner

On Thu, Sep 15, 2011 at 02:09:56PM +0200, Bernhard Loos wrote: > --- > dlls/oleaut32/olepicture.c | 148 +++++++++++++------------------------- > dlls/oleaut32/tests/olepicture.c | 16 ++--- > 2 files changed, 54 insertions(+), 110 deletions(-) Did make check work for you even? Marvin does not like it at least. This will break NonStatable streams, also seekability of streams can not be assumed. Ciao, Marcus > diff --git a/dlls/oleaut32/olepicture.c b/dlls/oleaut32/olepicture.c > index 8081785..725207f 100644 > --- a/dlls/oleaut32/olepicture.c > +++ b/dlls/oleaut32/olepicture.c > @@ -1324,15 +1324,13 @@ static HRESULT OLEPictureImpl_LoadAPM(OLEPictureImpl *This, > */ > static HRESULT WINAPI OLEPictureImpl_Load(IPersistStream* iface, IStream *pStm) { > HRESULT hr; > - BOOL headerisdata; > - BOOL statfailed = FALSE; > - ULONG xread, toread; > - ULONG headerread; > + ULONG xread, toread = 0; > BYTE *xbuf; > DWORD header[2]; > WORD magic; > - STATSTG statstg; > OLEPictureImpl *This = impl_from_IPersistStream(iface); > + ULARGE_INTEGER end, start; > + LARGE_INTEGER offset; > > TRACE("(%p,%p)\n",This,pStm); > > @@ -1348,104 +1346,56 @@ static HRESULT WINAPI OLEPictureImpl_Load(IPersistStream* iface, IStream *pStm) > * At least in Visual Basic 6, resource streams, valid headers are > * header[0] == "lt\0\0", > * header[1] == length_of_stream. > - * > - * Also handle streams where we do not have a working "Stat" method by > - * reading all data until the end of the stream. > */ > - hr = IStream_Stat(pStm,&statstg,STATFLAG_NONAME); > - if (hr != S_OK) { > - TRACE("stat failed with hres %x, proceeding to read all data.\n",hr); > - statfailed = TRUE; > - /* we will read at least 8 byte ... just right below */ > - statstg.cbSize.QuadPart = 8; > - } > + offset.QuadPart = 0; > > - toread = 0; > - headerread = 0; > - headerisdata = FALSE; > do { > - hr = IStream_Read(pStm, header, 8, &xread); > - if (hr != S_OK || xread!=8) { > - ERR("Failure while reading picture header (hr is %x, nread is %d).\n",hr,xread); > - return (hr?hr:E_FAIL); > - } > - headerread += xread; > - xread = 0; > - > - if (!memcmp(&(header[0]),"lt\0\0", 4) && (statfailed || (header[1] + headerread <= statstg.cbSize.QuadPart))) { > - if (toread != 0 && toread != header[1]) > - FIXME("varying lengths of image data (prev=%u curr=%u), only last one will be used\n", > - toread, header[1]); > - toread = header[1]; > - if (toread == 0) break; > - } else { > - if (!memcmp(&(header[0]), "GIF8", 4) || /* GIF header */ > - !memcmp(&(header[0]), "BM", 2) || /* BMP header */ > - !memcmp(&(header[0]), "\xff\xd8", 2) || /* JPEG header */ > - (header[0] == EMR_HEADER) || /* EMF header */ > - (header[1] > statstg.cbSize.QuadPart)|| /* invalid size */ > - (header[1]==0) > - ) {/* Found start of bitmap data */ > - headerisdata = TRUE; > - if (toread == 0) > - toread = statstg.cbSize.QuadPart-8; > - else toread -= 8; > - xread = 8; > - } else { > - FIXME("Unknown stream header magic: %08x\n", header[0]); > - toread = header[1]; > - } > - } > - } while (!headerisdata); > - > - if (statfailed) { /* we don't know the size ... read all we get */ > - int sizeinc = 4096; > - int origsize = sizeinc; > - ULONG nread = 42; > - > - TRACE("Reading all data from stream.\n"); > - xbuf = HeapAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, origsize); > - if (headerisdata) > - memcpy (xbuf, header, 8); > - while (1) { > - while (xread < origsize) { > - hr = IStream_Read(pStm,xbuf+xread,origsize-xread,&nread); > - xread += nread; > - if (hr != S_OK || !nread) > - break; > - } > - if (!nread || hr != S_OK) /* done, or error */ > - break; > - if (xread == origsize) { > - origsize += sizeinc; > - sizeinc = 2*sizeinc; /* exponential increase */ > - xbuf = HeapReAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, xbuf, origsize); > - } > - } > - if (hr != S_OK) > - TRACE("hr in no-stat loader case is %08x\n", hr); > - TRACE("loaded %d bytes.\n", xread); > - This->datalen = xread; > - This->data = xbuf; > - } else { > - This->datalen = toread+(headerisdata?8:0); > - xbuf = This->data = HeapAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, This->datalen); > - if (!xbuf) > - return E_OUTOFMEMORY; > - > - if (headerisdata) > - memcpy (xbuf, header, 8); > - > - while (xread < This->datalen) { > - ULONG nread; > - hr = IStream_Read(pStm,xbuf+xread,This->datalen-xread,&nread); > - xread += nread; > - if (hr != S_OK || !nread) > - break; > - } > - if (xread != This->datalen) > - ERR("Could only read %d of %d bytes out of stream?\n",xread,This->datalen); > + hr = IStream_Seek(pStm, offset, STREAM_SEEK_CUR, &start); > + if (FAILED(hr)) > + return hr; > + > + hr = IStream_Read(pStm, header, 8, &xread); > + if (FAILED(hr) || xread!=8) { > + ERR("Failure while reading picture header (hr is %x, nread is %d).\n",hr,xread); > + return (FAILED(hr)?hr:E_FAIL); > + } > + > + if (memcmp(&(header[0]),"lt", 2)) { > + if (!toread) { > + hr = IStream_Seek(pStm, offset, STREAM_SEEK_END, &end); > + if (FAILED(hr)) > + return hr; > + toread = end.QuadPart - start.QuadPart; > + } > + offset.QuadPart = start.QuadPart; > + hr = IStream_Seek(pStm, offset, STREAM_SEEK_SET, NULL); > + if (FAILED(hr)) > + return hr; > + break; > + } > + else { > + toread = header[1]; > + if (toread == 0) > + break; > + } > + } while (1); > + > + This->datalen = toread; > + xbuf = This->data = HeapAlloc (GetProcessHeap(), HEAP_ZERO_MEMORY, This->datalen); > + if (!xbuf) > + return E_OUTOFMEMORY; > + > + xread = 0; > + while (xread < This->datalen) { > + ULONG nread; > + hr = IStream_Read(pStm,xbuf+xread,This->datalen-xread,&nread); > + xread += nread; > + if (FAILED(hr) || !nread) > + break; > } > + if (xread != This->datalen) > + ERR("Could only read %d of %d bytes out of stream?\n",xread,This->datalen); > + > if (This->datalen == 0) { /* Marks the "NONE" picture */ > This->desc.picType = PICTYPE_NONE; > return S_OK; > diff --git a/dlls/oleaut32/tests/olepicture.c b/dlls/oleaut32/tests/olepicture.c > index 54de1cb..b1fad94 100644 > --- a/dlls/oleaut32/tests/olepicture.c > +++ b/dlls/oleaut32/tests/olepicture.c > @@ -1063,20 +1063,14 @@ static HRESULT WINAPI NoStatStreamImpl_Read( > { > NoStatStreamImpl* const This = impl_from_IStream(iface); > void* supportBuffer; > - ULONG bytesReadBuffer; > - ULONG bytesToReadFromBuffer; > > - if (pcbRead==0) > - pcbRead = &bytesReadBuffer; > - bytesToReadFromBuffer = min( This->streamSize.u.LowPart - This->currentPosition.u.LowPart, cb); > supportBuffer = GlobalLock(This->supportHandle); > - memcpy(pv, (char *) supportBuffer+This->currentPosition.u.LowPart, bytesToReadFromBuffer); > - This->currentPosition.u.LowPart+=bytesToReadFromBuffer; > - *pcbRead = bytesToReadFromBuffer; > + memcpy(pv, (char *) supportBuffer+This->currentPosition.u.LowPart, cb); > + This->currentPosition.u.LowPart+=cb; > GlobalUnlock(This->supportHandle); > - if(*pcbRead == cb) > - return S_OK; > - return S_FALSE; > + if(pcbRead) > + *pcbRead = cb; > + return S_OK; > } > > static HRESULT WINAPI NoStatStreamImpl_Write( > -- Working, but not speaking, for the following german company: SUSE LINUX Products GmbH, HRB 16746 (AG Nuernberg) Geschaeftsfuehrer: Jeff Hawn, Jennifer Guild, Felix Imendoerffer

Sept. 15, 2011

Re: [PATCH 19/19] vbscript: Added stop statement semi-stub implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14271 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 15, 2011

Re: [PATCH 18/19] vbscript: Added this object to identifier lookup chanin

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14270 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 15, 2011

Re: [PATCH 17/19] vbscript: Added interp_mcall implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14269 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 15, 2011

Re: [PATCH 13/19] vbscript: Added class functions parser implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14266 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 15, 2011

Re: [PATCH 12/19] vbscript: Added function storage specifiers support

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14265 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 15, 2011

Re: [PATCH 06/19] vbscript: Added interp_new implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14262 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 15, 2011

Re: [PATCH 04/19] vbscript: Added interp_set_ident implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14261 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 15, 2011

Re: [PATCH 01/19] vbscript: Added class parser implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14260 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 15, 2011

Re: [PATCH] oleaut32: OLEPictureImpl_Load uses Seek(STREAM_SEEK_END) to find the stream length

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14259 Your paranoid android. === W2KPROSP4 (32 bit olepicture) === olepicture: unhandled exception c0000005 at 780109B3 === WXPPROSP3 (32 bit olepicture) === olepicture: unhandled exception c0000005 at 77C46FA3 === W2K3R2SESP2 (32 bit olepicture) === olepicture: unhandled exception c0000005 at 77BD7E23 === WVISTAADM (32 bit olepicture) === olepicture: unhandled exception c0000005 at 76F29B2B === W2K8SE (32 bit olepicture) === olepicture: unhandled exception c0000005 at 76149F09 === W7PRO (32 bit olepicture) === olepicture: unhandled exception c0000005 at 75CA9B60 === W7PROX64 (32 bit olepicture) === olepicture: unhandled exception c0000005 at 777A9B60 === W7PROX64 (64 bit olepicture) === Timeout

Sept. 15, 2011

Re: pdh/tests: Some tests require that the user interface be in English. (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14256 Your paranoid android. === W2KPROSP4 (32 bit pdh) === pdh.c:157: Test failed: PdhAddCounterA failed 0xc0000bc4 pdh.c:204: Test failed: PdhAddCounterW failed 0xc0000bc4

Sept. 15, 2011

Re: msi: Improve parsing of the package platform.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14255 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6000: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

Sept. 15, 2011

Something's rotten in git today...

by Dan Kegel

It might be just me, but I've seen five very strange test failures today out of about 30 build/test runs. Has anybody else noticed problems? Here they are, most recent first: ==== http://buildbot.kegel.com/builders/runtests-default/builds/72 ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so service.c && touch service.ok err:rpc:I_RpcGetBuffer no binding err:rpc:I_RpcGetBuffer no binding service.c:152: Test failed: Expected success, got error 1060 err:rpc:I_RpcGetBuffer no binding service.c:176: Test failed: Expected ERROR_SERVICE_DOES_NOT_EXIST, got 123 ... ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c && touch file.ok file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\bob\Temp\ err=5 should be 3 file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\bob\Temp\removeme\ err=5 should be 3 file.c:933: Tests skipped: Either no authority to volume, or is todo_wine for C:\ err=5 should be 3 file.c:946: Test failed: CreateFileA failed on \\?\C:, hFile 0xffffffffffffffff, err=2, should be 0 ... ==== http://buildbot.kegel.com/builders/runtests-default/builds/70 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok ... action.c:4792: Test failed: The 'Spooler' service does not exist make: *** [action.ok] Error 1 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so install.c && touch install.ok install.c:5393: Test failed: Directory not created ... make: *** [install.ok] Error 8 ==== http://buildbot.kegel.com/builders/runtests-default-x86_64/builds/68 ../../../tools/runtest -q -P wine -M advapi32.dll -T ../../.. -p advapi32_test.exe.so service.c && touch service.ok ... service.c:2084: Test failed: Winetest Sleep Service: QueryServiceStatusEx() failed le=1727 service.c:2085: Test failed: Winetest Sleep Service: should be stopped state=ff service.c:2092: Test failed: Winetest Sleep Service: the second try should yield the same error: 1728 != 1727 service.c:2098: Test failed: Winetest Sleep Service: 1727 != ERROR_SERVICE_NOT_ACTIVE service.c:2099: Test failed: Winetest Sleep Service: should be stopped state=deadbeef service.c:2188: Test failed: 1728 != ERROR_SERVICE_REQUEST_TIMEOUT service.c:2223: Test failed: Expected success, got error 6 ... make: *** [service.ok] Error 20 ==== http://buildbot.kegel.com/builders/runtests-default/builds/67 ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok ... action.c:4792: Test failed: The 'Spooler' service does not exist

Sept. 14, 2011

Re: cmd/tests: Add RENAME tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14246 Your paranoid android. === WVISTAADM (32 bit) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

Sept. 14, 2011

Re: [RFC] Re: [PATCH 1/2]rpcrt4/tests: Add some commented tests for widl

by Alexandre Julliard

Jérôme Gardou <jerome.gardou(a)laposte.net> writes: > Hello. > > I've seen that this patch is in "pending" state, and I would like to > know what is the problem with it. Also, if commenting the tests isn't > a policy you want to enforce (that I would understand), I'm ready to > skip them on wine, but how to? I already explained the problem, I'll have a go at fixing it properly when I find the time, but of course you are welcome to beat me to it... -- Alexandre Julliard julliard(a)winehq.org

Sept. 14, 2011

[RFC] Re: [PATCH 1/2]rpcrt4/tests: Add some commented tests for widl

by Jérôme Gardou

Hello. I've seen that this patch is in "pending" state, and I would like to know what is the problem with it. Also, if commenting the tests isn't a policy you want to enforce (that I would understand), I'm ready to skip them on wine, but how to? Those tests were made with midl from Visual Studio 10, with or without /Os option, and ran smoothly. http://www.winehq.org/pipermail/wine-patches/2011-August/106200.html Regards. Jérôme. Le 06/09/2011 00:50, Jérôme Gardou a écrit : > Also, the added function which seems to be useless permits to detect > the problem that the next patch fixes. > Enable -Oif, and the test of server.c line 947 (after patch > application) will fail. > --- > dlls/rpcrt4/tests/server.c | 46 > ++++++++++++++++++++++++++++++++++++++++++ > dlls/rpcrt4/tests/server.idl | 1 + > 2 files changed, 47 insertions(+), 0 deletions(-) > > > > >

Sept. 14, 2011

Re: quartz: Fix converting between the media time and REFTIME

by Maarten Lankhorst

Hey, On 09/14/2011 05:07 PM, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > I've never tried to understand quartz, but I'd like to know whether quartz > expects particular behaviour from the underlying winmm or mmdevapi > time/position/length functions. > For instance, quartz says its clocks are monotically increasing, whereas no > such requirement is documented (or at least known to me) for the audio stream > positions. This may seem obvious, but then I came across some mailing list where > people reported a sudden backward change in stream position when pluggin/unplugging > earphones or the like. > Is quartz very decoupled from the underlying audio information? > Who stops the clock (if at all) while the stream is paused? There are 3 different times in quartz which makes it all confusing. However, wine just saves the time when pausing, and subtracts the difference when running again, so for audio clocks it would be a noop, but for wall clocks it's necessary to continue it again without skipping for the amount of time paused. http://msdn.microsoft.com/en-us/library/dd374626%28v=vs.85%29.aspx There is also a separate time for seeking, where it corresponds to the time in the file, for example when you seek to 03:10 in a video. This makes it kind of confusing, and wine doesn't handle it completely right in the parsers iirc, but with wineqtdecoder and winegstreamer, that isn't much of an issue. :) > BTW, in theory I have the tools to easily test quartz, using my interactive MCI shell > http://bugs.winehq.org/show_bug.cgi?id=20232#c10 > > However every time I tried, I found mciqtz too underpowered to be able > to reasonably use it. :-( > > Using the MCI to use mciqtz (which in turn uses quartz.dll) goes as follows: > wine wintest.exe mcishell > > open foo.wav alias w type mpegvideo > status w length > play w from 0 notify wait > close w > # lots of other commands are available > > open foo.avi alias a type mpegvideo > window a state show > status a length > play a from 0 > close a > > Omit the "type mpegvideo" and mciwave or mciavi will be used instead of mciqtz32.dll I have some mciqtz changes in http://repo.or.cz/w/wine/multimedia.git/blobdiff/327ce94048dba45c0ed8f727b4… But I lost track, so I don't know how valid those are still.

Sept. 14, 2011

Re: quartz: Fix converting between the media time and REFTIME

by Erich Hoover

On Wed, Sep 14, 2011 at 9:07 AM, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: > I've never tried to understand quartz, but I'd like to know whether quartz > expects particular behaviour from the underlying winmm or mmdevapi > time/position/length functions. > At least for what I've been dealing with so far quartz uses dsound for handling the underlying buffers. So, I would imagine if you've solved the quirks for dsound then you've likely handled quartz as well. For instance, quartz says its clocks are monotically increasing, whereas no > such requirement is documented (or at least known to me) for the audio > stream > positions. This may seem obvious, but then I came across some mailing list > where > people reported a sudden backward change in stream position when > pluggin/unplugging > earphones or the like. > There are a few different ways to *return* time in quartz, but it appears that everything comes down to the reference clock eventually. Have you looked at REFERENCE_TIME and IReferenceClock?.<http://msdn.microsoft.com/en-us/library/dd377507%28v=vs.85%29.aspx> Is quartz very decoupled from the underlying audio information? > >From my exploration it appears to be, but I'm not an expert yet. In the patch you're replying to I just corrected the time conversion between IMediaSeeking (which uses REFERENCE_TIME, LONGLONG measured in 100ns) and IMediaPosition (which uses REFTIME, double measured in seconds). I am trying to look into the time handling further though, as the background music stutters horribly in Fallout 3 (though it works great in Fallout New Vegas). Who stops the clock (if at all) while the stream is paused? > At least in Wine the reference clock is not stopped when a stream is paused. When pausing the clock is retrieved and stored (MediaControl_Pause) and then on resume it is retrieved again and adjusted to create a new start time (MediaControl_Run). From the reading I've done I don't think there is a way to stop the reference clock, aside from writing and using your own custom clock. I hope that helps somewhat. I'm not sure exactly what you're trying to do wrt. testing quartz, but if there's some way I can help then please let me know. Erich Hoover ehoover(a)mines.edu

Sept. 14, 2011

quartz: Fix converting between the media time and REFTIME

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, I've never tried to understand quartz, but I'd like to know whether quartz expects particular behaviour from the underlying winmm or mmdevapi time/position/length functions. For instance, quartz says its clocks are monotically increasing, whereas no such requirement is documented (or at least known to me) for the audio stream positions. This may seem obvious, but then I came across some mailing list where people reported a sudden backward change in stream position when pluggin/unplugging earphones or the like. Is quartz very decoupled from the underlying audio information? Who stops the clock (if at all) while the stream is paused? BTW, in theory I have the tools to easily test quartz, using my interactive MCI shell http://bugs.winehq.org/show_bug.cgi?id=20232#c10 However every time I tried, I found mciqtz too underpowered to be able to reasonably use it. :-( Using the MCI to use mciqtz (which in turn uses quartz.dll) goes as follows: wine wintest.exe mcishell open foo.wav alias w type mpegvideo status w length play w from 0 notify wait close w # lots of other commands are available open foo.avi alias a type mpegvideo window a state show status a length play a from 0 close a Omit the "type mpegvideo" and mciwave or mciavi will be used instead of mciqtz32.dll Regards, Jörg Höhle

Sept. 14, 2011

Re: [PATCH 11/21] vbscript: Added function parser implementation

by Dan Kegel

On Wed, Sep 14, 2011 at 7:56 AM, Jacek Caban <jacek(a)codeweavers.com> wrote: > Hi Dan, > > On 09/14/11 16:49, Dan Kegel wrote: >> >> Fails tests reliably (4 out of 4 runs) here under WINEDEBUG=warn+heap on a >> q9300 >> (but not on 32 or 64 bit non-warn-heap runs on q9300 or i7). >> > > Thanks for the report, I've sent a fixed version. Great. That's the first win for the warn+heap buildbot, I think.

Sept. 14, 2011

Re: [PATCH 11/21] vbscript: Added function parser implementation

by Jacek Caban

Hi Dan, On 09/14/11 16:49, Dan Kegel wrote: > Fails tests reliably (4 out of 4 runs) here under WINEDEBUG=warn+heap on a q9300 > (but not on 32 or 64 bit non-warn-heap runs on q9300 or i7). > Thanks for the report, I've sent a fixed version.

Sept. 14, 2011