September 2011 - Wine-Devel

Re: [PATCH 15/21] vbscript: Added interp_add implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14156 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 12, 2011

Re: [PATCH 13/21] vbscript: Added interp_neg implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14155 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 12, 2011

Re: [PATCH 08/21] vbscript: Added hex literal implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14153 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 12, 2011

Re: [PATCH 07/21] vbscript: Added interpreter support for numeric literals

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14152 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 12, 2011

Re: [1/3] msxml3: Add xmlparser interfaces

by Alistair Leslie-Hughes

Hi Francois, > I think that's the problem. Wine reimplements the Windows' Platform SDK > Win32 and Win64 APIs, not Windows Mobile which is what the PowerPC SDK > is. Apparently there are some differences so it would be best not to mix > the two. > > Note that this is not to say that Wine should not also implement the > Windows Mobile API, just that adding support for it would require larger > adjustments. It shouldn't be a problem, this is the only place you can get a reference to these interfaces. It appears that once these interfaces were Deprecated they where removed from the SDK for msxml. See MSDN to show that they now deprecated, and they aren't just for Mobile Devices. http://msdn.microsoft.com/en-us/library/ms757816%28VS.85%29.aspx It was part of the msxml3 at some point on windows, see bug http://bugs.winehq.org/show_bug.cgi?id=5841 Best Regards Alistair Leslie-Hughes

Sept. 12, 2011

Re: Auto-selecting local variable/parameters when 'p'rinting values using winedbg?

by Frédéric Delanoy

2011/9/12 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > I found that --file accepts the set of commands to execute (but > winedbg exits afterwards), but what does --command do? OK --command simply executes a single command and exits/continues the program until termination. > Is there a way to specify initial commands to execute, then stay > *inside* winedbg after the last command of the file is issued? Or maybe I should use stuff like 'expect' to do that? Frédéric

Sept. 12, 2011

Re: Auto-selecting local variable/parameters when 'p'rinting values using winedbg?

by Frédéric Delanoy

2011/9/9 Eric Pouech <eric.pouech(a)orange.fr>: > WineDbg> set ! symbol_picker scoped > will do what you want > unfortunately, there's no way to store it as a default command (you can > always use --command or --file on command line to help) > A+ Speaking of --command and --file options, they aren't documented either. I'm willing to update winedev guide, but I'd like more info first. I found that --file accepts the set of commands to execute (but winedbg exits afterwards), but what does --command do? Is there a way to specify initial commands to execute, then stay *inside* winedbg after the last command of the file is issued? Frédéric

Sept. 12, 2011

Re: Marking test cases as flaky?

by Alexandre Julliard

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > On Saturday 10 September 2011 21:56:26 Dan Kegel wrote: >> Might want to define the new form as ok2_ or something >> so we can defer changing the explicit uses of ok_(). > I dislike the idea, it has the feeling of legacy cruft. Either way it is a > fairly minor point - the main change that needs debating is whether we should > print the function name or not. We don't want that by default, especially since __FUNCTION__ is not portable. If you have cases where you get frequent failures that are hard to debug, you can always print extra info in the ok message. -- Alexandre Julliard julliard(a)winehq.org

Sept. 12, 2011

Re: [PATCH] cmd: Add help info for xcopy

by Christian Costa

On 10/09/2011 00:56, Octavian Voicu wrote: > 2011/9/9 Frédéric Delanoy <frederic.delanoy(a)gmail.com > <mailto:frederic.delanoy(a)gmail.com>> > > Patch is OK, but for consistency, shouldn't the externals be put at > the start of wcmdmain.c, just after the inbuilt[][]10]? > This way, you could see directly which command is built-in, and which > is external. > > > + make it static const, since it's not used outside of builtins.c. > > Octavian > That's true in that case but the list will go to another file. I sent a patch for that. Christian

Sept. 12, 2011

Re: notepad: Die if we get an unknown encoding name in load_encoding_name().

by Francois Gouget

On Mon, 12 Sep 2011, Octavian Voicu wrote: > On Mon, Sep 12, 2011 at 12:22 AM, Francois Gouget <fgouget(a)free.fr> wrote: > > - assert(0 && "bad encoding in load_encoding_name"); > > + assert("bad encoding in load_encoding_name"); > > Hello, > > assert() is a debug macro which generates some code such that, during > runtime: if the argument is non-zero, nothing happens; Ah right. Sorry for the noise. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !

Sept. 11, 2011

re: [5/5] ddraw: Use a Z format suported by the driver in the visual test

by Dan Kegel

Fails to compile on gcc-2.95 here: visual.c: In function `enum_z_fmt': visual.c:61: request for member `u1' in something not a structure or union visual.c:61: request for member `u1' in something not a structure or union make[1]: *** [visual.o] Error 1 make: *** [dlls/ddraw/tests] Error 2 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 11, 2011 at 1:56 PM Subject: Re: 78663: Subject: [5/5] ddraw: Use a Z format suported by the driver in the visual test To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-gcc295 while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-gcc295/builds/31 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 For more info about this message, see http://wiki.winehq.org/BuildBot

Sept. 11, 2011

re: [PATCH 2/4] ntdll: Colon character is not allowed in dir/filenames

by Dan Kegel

Hi Frédéric, fails a test here: ../../../tools/runtest -q -P wine -M cryptnet.dll -T ../../.. -p cryptnet_test.exe.so cryptnet.c && touch cryptnet.ok fixme:cryptnet:CryptGetObjectUrl unimplemented for 0 cryptnet.c:444: Test failed: Expected ERROR_FILE_NOT_FOUND or ERROR_PATH_NOT_FOUND, got 123 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sun, Sep 11, 2011 at 3:14 PM Subject: Re: 78678: Subject: [PATCH 2/4] ntdll: Colon character is not allowed in dir/filenames To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-default-x86_64 while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default-x86_64/builds/44 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

Sept. 11, 2011

Re: notepad: Die if we get an unknown encoding name in load_encoding_name().

by Octavian Voicu

On Mon, Sep 12, 2011 at 12:22 AM, Francois Gouget <fgouget(a)free.fr> wrote: > - assert(0 && "bad encoding in load_encoding_name"); > + assert("bad encoding in load_encoding_name"); Hello, assert() is a debug macro which generates some code such that, during runtime: if the argument is non-zero, nothing happens; if the argument is zero, a message like "Assertion `X' failed" is printed (where X is exactly the expression that was given as an argument to assert, string-ified). assert(X) is something like: "I assert that at this point in the code, X holds; if you get there and X doesn't hold, tell me and abort the program". So assert(0 && "msg") will always trigger an assertion failure and tell you something like "Assertion `0 && "msg"' failed" then exit, which is good. If you change it to assert("msg"), condition will always be true so assertion will never be triggered. Octavian

Sept. 11, 2011

Re: [1/3] msxml3: Add xmlparser interfaces

by Francois Gouget

On Sun, 11 Sep 2011, Alistair Leslie-Hughes wrote: [...] > > So what's going on? > > > I have taken my values from xmlparser.idl found in the the PocketPC SDK that > is included with VS 2008. I think that's the problem. Wine reimplements the Windows' Platform SDK Win32 and Win64 APIs, not Windows Mobile which is what the PowerPC SDK is. Apparently there are some differences so it would be best not to mix the two. Note that this is not to say that Wine should not also implement the Windows Mobile API, just that adding support for it would require larger adjustments. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Be careful of reading health books, you might die of a misprint. -- Mark Twain

Sept. 11, 2011

Re: wpp: Shed an unused parameter from generic_msg. (RESEND)

by Michael Stefaniuc

On 09/11/2011 04:58 AM, Gerald Pfeifer wrote: > On Thu, 8 Sep 2011, Alexandre Julliard wrote: >> It's still wrong, the parameter is used inside the #ifdef. > > Fair enough! How about the patch below then? Tested with and > without WANT_NEAR_INDICATION defined this time. This is patch is ugly. Just keeping the unused parameter warning is way better. Code needs to be optimized for the human reader not perverted to make a tool stfu. bye michael > Or would you rather see a patch that remove WANT_NEAR_INDICATION > altogether? > > Gerald > > > diff --git a/libs/wpp/preproc.c b/libs/wpp/preproc.c > index 99934d6..996c0f8 100644 > --- a/libs/wpp/preproc.c > +++ b/libs/wpp/preproc.c > @@ -684,7 +684,11 @@ int pp_get_if_depth(void) > > /* #define WANT_NEAR_INDICATION */ > > -static void generic_msg(const char *s, const char *t, const char *n, va_list ap) > +static void generic_msg(const char *s, const char *t, > +#ifdef WANT_NEAR_INDICATION > + const char *n, > +#endif > + va_list ap) > { > fprintf(stderr, "%s:%d:%d: %s: ", pp_status.input ? pp_status.input : "stdin", > pp_status.line_number, pp_status.char_number, t); > @@ -709,13 +713,21 @@ end: > > static void wpp_default_error(const char *file, int line, int col, const char *near, const char *msg, va_list ap) > { > +#ifdef WANT_NEAR_INDICATION > generic_msg(msg, "Error", near, ap); > +#else > + generic_msg(msg, "Error", ap); > +#endif > exit(1); > } > > static void wpp_default_warning(const char *file, int line, int col, const char *near, const char *msg, va_list ap) > { > +#ifdef WANT_NEAR_INDICATION > generic_msg(msg, "Warning", near, ap); > +#else > + generic_msg(msg, "Warning", ap); > +#endif > } > > static const struct wpp_callbacks default_callbacks = > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Otto-Hahn-Strasse 20, 85609 Dornach Handelsregister: Amtsgericht Muenchen HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Charles Cachera

Sept. 11, 2011

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14145 Your paranoid android. === WNT4WSSP6 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC === W2KPROSP4 (32 bit peer) === peer.c:52: Test failed: CoCreateInstance failed with 0x80040154 peer: unhandled exception c0000005 at 004013BC

Sept. 11, 2011

Re: Marking test cases as flaky?

by Stefan Dösinger

On Saturday 10 September 2011 21:56:26 Dan Kegel wrote: > Might want to define the new form as ok2_ or something > so we can defer changing the explicit uses of ok_(). I dislike the idea, it has the feeling of legacy cruft. Either way it is a fairly minor point - the main change that needs debating is whether we should print the function name or not.

Sept. 11, 2011

Re: shell32/tests: Make test explicit about return pointer

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14136 Your paranoid android. === WVISTAADM (32 bit shelldispatch) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

Sept. 11, 2011

Re: [1/3] msxml3: Add xmlparser interfaces

by Alistair Leslie-Hughes

Hi Francois, > > This patch defines an XML_ERROR_CODE enumeration type in xmlparser.idl > which is a bit strange because I cannot find this type in the Windows > SDK. But in the Windows 7 SDK there is an XmlError enumeration type in > xmllite.h that looks similar but subtly different. > > These two enumaration types share some error codes, in particular > XML_E_INVALID_HEXIDECIMAL (Microsoft can't spell apparently) but with > different values. In this case 0xc00ce51e in Wine vs. 0xc00ce01e in the > Windows 7 SDK. > > So what's going on? > I have taken my values from xmlparser.idl found in the the PocketPC SDK that is included with VS 2008. I've double check the values, and they are correct. >From the windows xmlparser.idl typedef enum { XML_E_PARSEERRORBASE = 0xC00CE500L, XML_E_ENDOFINPUT = XML_E_PARSEERRORBASE, ... XML_E_INVALID_HEXIDECIMAL, // 1E <- WINE = 0xC00CE51E .... } XML_ERROR_CODE; Hope this clears things up. Best Regards Alistair Leslie-Hughes

Sept. 11, 2011

Re: wpp: Shed an unused parameter from generic_msg. (RESEND)

by Gerald Pfeifer

On Thu, 8 Sep 2011, Alexandre Julliard wrote: > It's still wrong, the parameter is used inside the #ifdef. Fair enough! How about the patch below then? Tested with and without WANT_NEAR_INDICATION defined this time. Or would you rather see a patch that remove WANT_NEAR_INDICATION altogether? Gerald diff --git a/libs/wpp/preproc.c b/libs/wpp/preproc.c index 99934d6..996c0f8 100644 --- a/libs/wpp/preproc.c +++ b/libs/wpp/preproc.c @@ -684,7 +684,11 @@ int pp_get_if_depth(void) /* #define WANT_NEAR_INDICATION */ -static void generic_msg(const char *s, const char *t, const char *n, va_list ap) +static void generic_msg(const char *s, const char *t, +#ifdef WANT_NEAR_INDICATION + const char *n, +#endif + va_list ap) { fprintf(stderr, "%s:%d:%d: %s: ", pp_status.input ? pp_status.input : "stdin", pp_status.line_number, pp_status.char_number, t); @@ -709,13 +713,21 @@ end: static void wpp_default_error(const char *file, int line, int col, const char *near, const char *msg, va_list ap) { +#ifdef WANT_NEAR_INDICATION generic_msg(msg, "Error", near, ap); +#else + generic_msg(msg, "Error", ap); +#endif exit(1); } static void wpp_default_warning(const char *file, int line, int col, const char *near, const char *msg, va_list ap) { +#ifdef WANT_NEAR_INDICATION generic_msg(msg, "Warning", near, ap); +#else + generic_msg(msg, "Warning", ap); +#endif } static const struct wpp_callbacks default_callbacks =

Sept. 11, 2011

Re: Marking test cases as flaky?

by Dan Kegel

On Sat, Sep 10, 2011 at 10:55 AM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > On Saturday 10 September 2011 19:43:08 Dan Kegel wrote: >> #define ok_(file, func, line) (winetest_set_location(file, func, >> line), 0) ? (void)0 : winetest_ok >> #define ok ok_(__FILE__, __FUNCTION__, __LINE__) >> >> That would get you most of what you propose without any changes to the >> tests, I think. > I think that would work. Of course you have to change the tests that > explicitly use ok_() Might want to define the new form as ok2_ or something so we can defer changing the explicit uses of ok_().

Sept. 10, 2011

re: msi: Properly check for a specified flag combination

by Dan Kegel

Test failed here: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so action.c && touch action.ok ... err:msi:env_parse_flags Invalid flags: 00000007 err:msi:ITERATE_Actions Execution halted, action L"RemoveEnvironmentStrings" returned 1627 err:msi:env_parse_flags Invalid flags: 00000007 action.c:5588: Test failed: Expected ERROR_SUCCESS, got 1627 action.c:5594: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 action.c:5597: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 action.c:5609: Test failed: Expected ERROR_FILE_NOT_FOUND, got 0 fixme:ntdll:NtQueryInformationToken QueryInformationToken( ..., TokenElevationType, ...) semi-stub action.c:5666: Test failed: key not created action.c:5670: Test failed: key not created action.c:5674: Test failed: key not created ... Command exited with non-zero status 7 4.04user 0.50system 0:05.03elapsed 90%CPU (0avgtext+0avgdata 51216maxresident)k 0inputs+7360outputs (0major+17117minor)pagefaults 0swaps make: *** [action.ok] Error 7 ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Sat, Sep 10, 2011 at 12:33 PM Subject: Re: 78647: Subject: msi: Properly check for a specified flag combination To: dank(a)kegel.com This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-default while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/15 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

Sept. 10, 2011

Re: urlmon/tests: Removed a test that causes random failures on some machines

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14120 Your paranoid android. === WVISTAADM (32 bit sec_mgr) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

Sept. 10, 2011

Re: urlmon:sec_mgr failure on XP

by Thomas Mullaly

Hi Francois, On Sat, Sep 10, 2011 at 6:33 AM, Francois Gouget <fgouget(a)free.fr> wrote: > This test now fails on my Widnows XP VMs that have IE >= 7 with 'All > zones reset to default level': > http://test.winehq.org/data/3b40c03a8f0e3dcbb236d59125b115b2501086f8/xp_fg-… > > sec_mgr.c:1695: Test failed: Expected zone 3, but got 1 for 'file/testing/test.test' I wasn't able to reproduce this problem on my Windows XP VM. I was, however, able to reproduce this problem using Windows 7. > So I'm hoping that you can fix the test. > > The easiest fix would be to remove the 'file/testing/test.test' check. > An alternative would be to check what the settings are and adjust the > expected result or skip the test. But it seems like this would be much > more complex. The test in question isn't really relevant with showing how the function itself should work, so removing it will be fine (I'll be sending a patch shortly removing it). Thanks for pointing this issue out. -- Thomas Mullaly thomas.mullaly(a)gmail.com

Sept. 10, 2011

Re: Marking test cases as flaky?

by Stefan Dösinger

On Saturday 10 September 2011 19:43:08 Dan Kegel wrote: > #define ok_(file, func, line) (winetest_set_location(file, func, > line), 0) ? (void)0 : winetest_ok > #define ok ok_(__FILE__, __FUNCTION__, __LINE__) > > That would get you most of what you propose without any changes to the > tests, I think. I think that would work. Of course you have to change the tests that explicitly use ok_()

Sept. 10, 2011