September 2011 - Wine-Devel

Re: What is the PulseAudio underrun bug?

by Andrew Eikum

On Fri, Sep 09, 2011 at 12:31:10PM +0200, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > As I see that the PA team is preparing release candidates for 1.0, I > wonder whether the Wine team communicated them the issues we face. > Browsing open tickets http://pulseaudio.org/report/1 I found nothing obvious. The launchpad ticket I've been following is <https://bugs.launchpad.net/ubuntu/+source/alsa-plugins/+bug/805940> Their solution was to introduce yet another option, handle_underrun=2, which handles underruns even better than handle_underrun=1! Or something. Really I don't know. handle_underrun=2 is now the new default, unless it's overridden by a user- or application-specified configuration. Which Wine does, so we no longer get this new-and-improved default... Have I mentioned my unending love for audio APIs? Some testing has shown that handle_underrun=1 and handle_underrun=2 both work well with winealsa.drv. So we'll probably drop the handle_underrun=1 override after alsa-plugins 1.0.25 becomes common. Andrew

Sept. 9, 2011

Re: [PATCH 01/14] vbscript: Added support for |f a, b, c| call statement

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14094 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

Sept. 9, 2011

user32: Avoid drawing the caret out of the window

by Bruno Jesus

Please, ignore this patch. It's overkill to check the bounding box during every caret timer callback. I have found a better approach to this by checking inside SetCaretPos/ShowCaret. That's because the caret doesn't move by itself so it's useless to check everytime. Thanks, Bruno -- universe* god::bigbang (void); //and then it all began...

Sept. 9, 2011

Re: Auto-selecting local variable/parameters when 'p'rinting values using winedbg?

by Frédéric Delanoy

2011/9/9 Eric Pouech <eric.pouech(a)orange.fr>: > WineDbg> set ! symbol_picker scoped > will do what you want > unfortunately, there's no way to store it as a default command (you can > always use --command or --file on command line to help) Thanks for that quick response! Is there some doc on the internal commands, besides the code? http://www.winehq.org/docs/winedev-guide/dbg-config may be a bit out of date Frédéric

Sept. 9, 2011

What is the PulseAudio underrun bug?

by Joerg-Cyril.Hoehle＠t-systems.com

Hi again, Something that I still have trouble understanding is: Why did I find out only 2 weeks ago that Ubuntu Lucid is affected? Perhaps because I'm mostly using Intrepid which works better as far as the dreaded Intel Xorg screen flicker, suspend/resume and audio are concerned. Why do the Wine users only observe random drop outs after some time? Why does it look like the new mmdevapi code accentuated the problem (does it?)? Perhaps because most apps use dsound and dsound does efforts to send a continuous stream of data to the audio device, without underruns. Likewise, MCIWAVE/MCIAVI/winmm:PlaySound send data in a tight loop. Perhaps because the current GetPosition in both mmdevapi and winmm is not trustworthy and may cause underruns when a sound ends? Perhaps because "underrun at end" is almost designed into winmm? (unless you end with waveOutReset) Also, there may be more than underruns which is broken in PA. Underruns do not explain why I sometimes need to restart the PA server, as mentioned in my prior point 4. Do underruns really happen on my xGHz machine? On my Ubuntu Lucid system, the dreaded Intel XOrg screen flicker is enough to cause some apps running at that time to lose audio. Moving from one virtual desktop or screen to another may cause paging. That's no proof, but underruns may happen more often than one would like. Apps must robustly handle them. Regards, Jörg Höhle

Sept. 9, 2011

What is the PulseAudio underrun bug?

by Joerg-Cyril.Hoehle＠t-systems.com

Hi, As I see that the PA team is preparing release candidates for 1.0, I wonder whether the Wine team communicated them the issues we face. Browsing open tickets http://pulseaudio.org/report/1 I found nothing obvious. The PA bug, as I face it in Ubuntu Lucid, is not something that happens randomly after N minutes or hours. It is *immediately* detectable. Symptoms: 1. winecfg audio test hangs. But Wine is a complex program, so I wrote a trivial one as follows: - set generic hw_params - prefill snd_pcm_write with e.g. 100ms of data; - start ALSA or use hw_params_set_start_threshold; - print out snd_pcm_state, snd_pcm_avail_update and snd_pcm_delay in a loop. 2. avail_update and avail_delay will freeze approx. at the time underrun would have happened with plug:dmix or plughw:0. In particular, delay will not decrease below < 0. By contrast, dmix or hw would see avail_update grow continuously, far above buffer_size, while delay decreases towards minus infinity -- regardless of whether XRUN state was entered or still RUNNING playing silence. 3. Optionally, XRUN mode is never entered, PA claims to be RUNNING. (XRUN is not a necessity, depending on hw_params_set_silence_*) >From there on, more snd_pcm_write(N frames) will not be heard, and avail_update() and delay() will solely bump to reflect that N frames have been queued, and remain frozen. snd_pcm_reset() won't help. snd_pcm_drain() will surprisingly play the buffered audio. Note that in non-blocking mode, this function will return -11 with "dmix" or "hw" ALSA devices, so here again PA differs from others. It looks like PA's front end (claiming to be running) has lost sync with its backend (which apparently stopped). 4. I don't know why and when, but the damage is not always limited to this one process. Sometimes the PA server will need to be restarted (pactl exit) otherwise no more sound will play for more than a click's time. It obviously corrupted its data structures. Andrew Eikum found out that activating the handle_underrun configuration in the newest alsa plugin package (released 2011-01-31!) allows to work around the bug. However when I read the comment to the patch, http://git.alsa-project.org/?p=alsa-plugins.git;a=commit;h=c20d516e22962012… I've the impression that using handle_underrun is backwards and is *not* the recommended way to use PulseAudio. IOW, PA without handle_underrun is subject to the underrun bug and that is abnormal behaviour. Or was it? Does the brandnew PA RC exhibit sane behaviour? Which is the "need handle_underrun" ticket in PA's bug tracker? http://pulseaudio.org/report/1 Where on Ubuntu's launchpad? What do they now about the issue? Regards, Jörg Höhle

Sept. 9, 2011

Re: winspool.drv: Correct test for Device Capabilities

by Nicolas Le Cam

2011/9/9 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > On 8/09/2011 8:35 PM, Marvin wrote: >> >> Hi, >> >> While running your changed tests on Windows, I think I found new failures. >> Being a bot and all I'm not very good at pattern recognition, so I might >> be >> wrong, but could you please double-check? >> Full results can be found at >> http://testbot.winehq.org/JobDetails.pl?Key=14060 >> >> Your paranoid android. >> >> >> === WINEBUILD (build) === >> Can't determine base name >> > Can someone explain what this error is and how to rectify it? > > Best Regards > Alistair Leslie-Hughes > > TestBot can't determine basename (winspool.drv) from the test executable name (winspool.drv_test.exe) because of a too restrictive regex in bin/WineRunBuild.pl line 180 [1]. Changing it to 'if ($OtherFileName =~ m/^([\w_\-]+)(|\.[\w]+)_test(|64)\.exe$/)' should fix the problem (same change should be applied at line 258). [1] http://wine.git.sourceforge.net/git/gitweb.cgi?p=wine/winetestbot;a=blob;f=… -- Nicolas Le Cam

Sept. 9, 2011

Auto-selecting local variable/parameters when 'p'rinting values using winedbg?

by Frédéric Delanoy

While debugging with winedbg, I sometimes stumble upon situations like those (especially for widely used names) Many symbols with name 'foo', choose the one you want (<cr> to abort): [1]: 0x1234567 foo in libwhatever.so.1 [2]: Local variable (in a register) of foo => 2 This can be cumbersome, e.g. when you don't want to see foo val in libc.so. Is it somehow possible to auto-select the "local value"? Frédéric

Sept. 9, 2011

Re: [2/8] msi/test: Mark some test results as broken.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14087 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:6000: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

Sept. 9, 2011

Re: winspool.drv: Correct test for Device Capabilities

by Alistair Leslie-Hughes

On 8/09/2011 8:35 PM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=14060 > > Your paranoid android. > > > === WINEBUILD (build) === > Can't determine base name > Can someone explain what this error is and how to rectify it? Best Regards Alistair Leslie-Hughes

Sept. 9, 2011

Re: [PATCH] cmd: Add help info for xcopy

by Christian Costa

Makes sense. I will send another patch once it is commited. Christian > Message du 09/09/11 09:53 > De : "Frédéric Delanoy" > A : wine-devel(a)winehq.org > Copie à : "Christian Costa" > Objet : Re: [PATCH] cmd: Add help info for xcopy > > On Fri, Sep 9, 2011 at 09:16, Christian Costa wrote: > > --- a/programs/cmd/builtins.c > +++ b/programs/cmd/builtins.c > @@ -68,7 +68,8 @@ static const WCHAR parmNoY[] = {'/','-','Y','\0'}; > static const WCHAR nullW[] = {'\0'}; > > const WCHAR externals[][10] = { > - {'A','T','T','R','I','B','\0'} > + {'A','T','T','R','I','B','\0'}, > + {'X','C','O','P','Y','\0'} Patch is OK, but for consistency, shouldn't the externals be put at the start of wcmdmain.c, just after the inbuilt[][]10]? This way, you could see directly which command is built-in, and which is external. Frédéric

Sept. 9, 2011

Re: [PATCH] cmd: Add help info for xcopy

by Frédéric Delanoy

On Fri, Sep 9, 2011 at 09:16, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > > --- a/programs/cmd/builtins.c > +++ b/programs/cmd/builtins.c > @@ -68,7 +68,8 @@ static const WCHAR parmNoY[] = {'/','-','Y','\0'}; > static const WCHAR nullW[] = {'\0'}; > > const WCHAR externals[][10] = { > - {'A','T','T','R','I','B','\0'} > + {'A','T','T','R','I','B','\0'}, > + {'X','C','O','P','Y','\0'} Patch is OK, but for consistency, shouldn't the externals be put at the start of wcmdmain.c, just after the inbuilt[][]10]? This way, you could see directly which command is built-in, and which is external. Frédéric

Sept. 9, 2011

Re: cmd: GOTO is a no-op and doesn't output anything in interactive mode

by Frédéric Delanoy

2011/9/9 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > programs/cmd/builtins.c | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > This patch depends on my other non-yet-commited goto patch (Avoid rereading batch file for every call/goto executed) Shouldn't probably have sent it yet. Sorry for the inconvenience. Frédéric

Sept. 9, 2011

crypt32: Test/correct CertGetNameString with NULL pvTypePara

by Juan Lang

Fix for bug 23287. --Juan

Sept. 8, 2011

Re: gdiplus/tests: Don't fail if Microsoft Sans Serif and Times New Roman are not installed.

by Francois Gouget

On Thu, 8 Sep 2011, Alexandre Julliard wrote: [...] > I don't think the name of the family really matters here. By using > Tahoma the Wine implementation is trying to make sure we always return > something, and that's what we should check: that we get a family, and > that it's valid for creating a font or something along those lines. We don't have a fallback for Monospace fonts so that if Courier New is not installed we return FontFamilyNotFound. What you're saying suggests that this is a bug. Does anyone have a font to recommend as the fallback? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Utilisateur" (nom commun) : Mot utilisé par les informaticiens en lieu et place d'"idiot".

Sept. 8, 2011

[PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.

by Joerg-Cyril.Hoehle＠t-systems.com

Andrew Eikum asked: >It would be nice to have tests for this, >Are these part of the tests you're >planning on submitting after you get the fixes in? That is part of my tests, the latest testbot job is https://testbot.winehq.org/JobDetails.pl?Key=14067 You can see that I still need to compute position estimates based on the high performance timer as Sleep() is not accurate enough. >and a fix for coreaudio if needed. Likewise for patch 2/2. The Mac never returns S_FALSE, so there was nothing to change. I've yet another patch about IsFormatSupported in my queue, but it needs more testing. For instance, I've not yet tested inconsistent formats (bad blockalign) or non PCM formats (e.g. A-law, ADPCM). In short, it looks like IsFormatSupported simply suggests GetMixFormat() in shared mode, but would it suggest linear PCM when given A-law? Regards, Jörg Höhle

Sept. 8, 2011

Re: gdiplus/tests: Don't fail if Microsoft Sans Serif and Times New Roman are not installed.

by Alexandre Julliard

Francois Gouget <fgouget(a)free.fr> writes: > I'm actually not entirely happy with this patch. > > Wine actually hardcodes the fallback fonts to Liberation Serif and > Tahoma. So we could instead check that if on Wine and the Windows fonts > are not installed then we get the fallback fonts. > > It's a bit what the test was trying to do with Microsoft Sans Serif > except that I also take exception with the todo_wine since the fix is > not to change Wine but to install the missing font. I don't think the name of the family really matters here. By using Tahoma the Wine implementation is trying to make sure we always return something, and that's what we should check: that we get a family, and that it's valid for creating a font or something along those lines. -- Alexandre Julliard julliard(a)winehq.org

Sept. 8, 2011

Re: [PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.

by Octavian Voicu

On Thu, Sep 8, 2011 at 6:37 PM, Octavian Voicu <octavian.voicu(a)gmail.com> wrote: > You are dereferencing 'closest' without checking if it's non-NULL. It > can be NULL if control jumps to the 'exit' label for several cases. > This only applies to winealsa; for wineoss there are no gotos. Disregard that, I see now that hr is S_FALSE only when closest is non-NULL. Sorry for the noise. Octavian

Sept. 8, 2011

Re: [PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.

by Octavian Voicu

--- a/dlls/winealsa.drv/mmdevdrv.c+++ b/dlls/winealsa.drv/mmdevdrv.c> @@ -1310,17 +1313,14 @@ exit: > LeaveCriticalSection(&This->lock); > HeapFree(GetProcessHeap(), 0, formats); > > - if(hr == S_OK || !out){ > - CoTaskMemFree(closest); > - if(out) > - *out = NULL; > - }else if(closest){ > + if(hr == S_FALSE && out) { > closest->nBlockAlign = > closest->nChannels * closest->wBitsPerSample / 8; > closest->nAvgBytesPerSec = > closest->nBlockAlign * closest->nSamplesPerSec; > *out = closest; > - } > + } else > + CoTaskMemFree(closest); You are dereferencing 'closest' without checking if it's non-NULL. It can be NULL if control jumps to the 'exit' label for several cases. This only applies to winealsa; for wineoss there are no gotos. Octavian

Sept. 8, 2011

Re: gdiplus/tests: Don't fail if Microsoft Sans Serif and Times New Roman are not installed.

by Vincent Povirk

> It's a bit what the test was trying to do with Microsoft Sans Serif > except that I also take exception with the todo_wine since the fix is > not to change Wine but to install the missing font. I'm not too concerned about what happens in this case, but one alternative would be to always test that the function successfully returns a font but only test that the font is what we expect when that font is installed.

Sept. 8, 2011

gdiplus/tests: Don't fail if Microsoft Sans Serif and Times New Roman are not installed.

by Francois Gouget

In Wine, accept their fallbacks if the native fonts are not installed. --- This is an alternative patch which is more strict as it only allows the hardcoded fallbacks, and only if running in Wine. diff --git a/dlls/gdiplus/tests/font.c b/dlls/gdiplus/tests/font.c index 323461a..9c261d9 100644 --- a/dlls/gdiplus/tests/font.c +++ b/dlls/gdiplus/tests/font.c @@ -34,6 +34,7 @@ static const WCHAR MicrosoftSansSerif[] = {'M','i','c','r','o','s','o','f','t',' static const WCHAR TimesNewRoman[] = {'T','i','m','e','s',' ','N','e','w',' ','R','o','m','a','n','\0'}; static const WCHAR CourierNew[] = {'C','o','u','r','i','e','r',' ','N','e','w','\0'}; static const WCHAR Tahoma[] = {'T','a','h','o','m','a',0}; +static const WCHAR LiberationSerif[] = {'L','i','b','e','r','a','t','i','o','n',' ','S','e','r','i','f',0}; static void test_createfont(void) { @@ -289,42 +290,52 @@ static void test_getgenerics (void) GpStatus stat; GpFontFamily* family; WCHAR familyName[LF_FACESIZE]; + int has_native; ZeroMemory(familyName, sizeof(familyName)/sizeof(WCHAR)); + stat = GdipCreateFontFamilyFromName(MicrosoftSansSerif, NULL, &family); + has_native = (stat != FontFamilyNotFound); + if (!has_native) + skip("Microsoft Sans Serif is missing\n"); stat = GdipGetGenericFontFamilySansSerif (&family); - if (stat == FontFamilyNotFound) + expect (Ok, stat); + if (stat != FontFamilyNotFound) { - skip("Microsoft Sans Serif not installed\n"); - goto serif; + stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); + expect (Ok, stat); + /* Wine uses Tahoma as a fallback if Microsoft Sans Serif is missing */ + ok (lstrcmpiW(familyName, MicrosoftSansSerif) == 0 || + (strcmp(winetest_platform, "wine") == 0 && !has_native && + lstrcmpiW(familyName, Tahoma) == 0), + "Expected Microsoft Sans Serif or a fallback, got %s\n", wine_dbgstr_w(familyName)); + stat = GdipDeleteFontFamily (family); + expect (Ok, stat); } - expect (Ok, stat); - stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); - expect (Ok, stat); - if (!lstrcmpiW(familyName, Tahoma)) - todo_wine ok ((lstrcmpiW(familyName, MicrosoftSansSerif) == 0), - "Expected Microsoft Sans Serif, got Tahoma\n"); - else - ok ((lstrcmpiW(familyName, MicrosoftSansSerif) == 0), - "Expected Microsoft Sans Serif, got %s\n", wine_dbgstr_w(familyName)); - stat = GdipDeleteFontFamily (family); - expect (Ok, stat); -serif: + /* First check that Times New Roman is installed because if not + * Wine substitutes another serif font. + */ + stat = GdipCreateFontFamilyFromName(TimesNewRoman, NULL, &family); + has_native = (stat != FontFamilyNotFound); + if (!has_native) + skip("Times New Roman is missing\n"); stat = GdipGetGenericFontFamilySerif (&family); - if (stat == FontFamilyNotFound) + expect (Ok, stat); + if (stat != FontFamilyNotFound) { - skip("Times New Roman not installed\n"); - goto monospace; + stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); + expect (Ok, stat); + /* Wine uses Liberation Serif as a fallback if Times New Roman + * is missing + */ + ok (lstrcmpiW(familyName, TimesNewRoman) == 0 || + (strcmp(winetest_platform, "wine") == 0 && !has_native && + lstrcmpiW(familyName, LiberationSerif) == 0), + "Expected Times New Roman or a fallback, got %s\n", wine_dbgstr_w(familyName)); + stat = GdipDeleteFontFamily (family); + expect (Ok, stat); } - expect (Ok, stat); - stat = GdipGetFamilyName (family, familyName, LANG_NEUTRAL); - expect (Ok, stat); - ok (lstrcmpiW(familyName, TimesNewRoman) == 0, - "Expected Times New Roman, got %s\n", wine_dbgstr_w(familyName)); - stat = GdipDeleteFontFamily (family); - expect (Ok, stat); -monospace: stat = GdipGetGenericFontFamilyMonospace (&family); if (stat == FontFamilyNotFound) { -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ If you think the whole world revolves around you, quit staring at the GPS display while driving.

Sept. 8, 2011

Re: [PATCH 1/2] mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.

by Andrew Eikum

It would be nice to have tests for this, and a fix for coreaudio if needed. Likewise for patch 2/2. Are these part of the tests you're planning on submitting after you get the fixes in? Andrew On Thu, Sep 08, 2011 at 04:09:37PM +0200, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > Hi, > > Wine is currently leaking memory because of this bug. > My tests show that S_FALSE indicates a format suggestion, > otherwise the out pointer is NULL. > I think MSDN says that, but it's not particularly clear. > > Regards, > Jörg Höhle >

Sept. 8, 2011

Re: gdiplus/tests: Don't fail if Microsoft Sans Serif and Times New Roman are not installed.

by Francois Gouget

I'm actually not entirely happy with this patch. Wine actually hardcodes the fallback fonts to Liberation Serif and Tahoma. So we could instead check that if on Wine and the Windows fonts are not installed then we get the fallback fonts. It's a bit what the test was trying to do with Microsoft Sans Serif except that I also take exception with the todo_wine since the fix is not to change Wine but to install the missing font. Changing the test as I described would let us detect when Microsoft decides to ship other fonts instead of these. We would also issue an error if neither font was found, such as on FreeBSD 8.1 for instance as it is a hint that we should find some other/additional fallback font. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

Sept. 8, 2011

Re: dinput: Remove an unused debug channel.

by Lucas Zawacki

err.. I know there's no debugging going on right now, but I'm planning on submiting a couple more patches to this file and I'll print some debug info then. 2011/9/8 Francois Gouget <fgouget(a)free.fr>: > --- > dlls/dinput/config.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/dlls/dinput/config.c b/dlls/dinput/config.c > index 1c6da6c..aedaa0e 100644 > --- a/dlls/dinput/config.c > +++ b/dlls/dinput/config.c > @@ -16,14 +16,12 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > > -#include "wine/debug.h" > #include "wine/unicode.h" > #include "objbase.h" > #include "dinput_private.h" > #include "device_private.h" > #include "resource.h" > > -WINE_DEFAULT_DEBUG_CHANNEL(dinput); > > typedef struct { > int nobjects; > -- > 1.7.5.4 > > > >

Sept. 8, 2011

Re: winspool.drv: Correct test for Device Capabilities

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14060 Your paranoid android. === WINEBUILD (build) === Can't determine base name

Sept. 8, 2011