September 2011 - Wine-Devel

Re: [PATCH 2/2] cmd: Launch the command with the /? option for external commands shipped with cmd.exe

by Frédéric Delanoy

On Wed, Sep 7, 2011 at 09:10, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > + WCHAR space_slashdot_ask[] = {' ', '/','?','\0'}; space_slash_questionmark would probably be a more appropriate name

Sept. 7, 2011

Re: winecfg: Specify a context for the 'Letter' paper size. (try 2)

by Octavian Voicu

On Wed, Sep 7, 2011 at 11:27 AM, Francois Gouget <fgouget(a)free.fr> wrote: > Actually, paper size is the more common term. ... > --- a/programs/winecfg/winecfg.rc > +++ b/programs/winecfg/winecfg.rc ... > - IDS_COL_DRIVELETTER "Letter" > + IDS_COL_DRIVELETTER "#msgctxt#Paper size#Letter" While paper size is probably the most commonly used meaning within Wine, it seems pretty obvious to me that in this context "Letter" means "letter of the alphabet", because it refers to the letter that is used for mapping drives in winecfg (A, B, ... Z). Octavian

Sept. 7, 2011

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

by Christian Costa

Yes. It is adressed in the next serie I just sent. Christian > Message du 07/09/11 08:34 > De : "Frédéric Delanoy" > A : "Christian Costa" > Copie à : "Wine Devel" > Objet : Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend) > > "help attrib" from within cmd, and "wine attrib /?" give different results. That should probably be aligned, for better integration, if possible. Frédéric.

Sept. 7, 2011

Re: [3/3] msxml3: Support creating IXMLParser Interface

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14026 Your paranoid android. === WNT4WSSP6 (32 bit xmlparser) === xmlparser.c:39: Test failed: failed to create IXMLParser

Sept. 7, 2011

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

by Frédéric Delanoy

"help attrib" from within cmd, and "wine attrib /?" give different results. That should probably be aligned, for better integration, if possible. Frédéric.

Sept. 7, 2011

Marking test cases as flaky?

by Dan Kegel

Hi folks, I've been running "make test" a lot lately, and occasionally (it happened five times today), a test will fail out of the blue, in one out of twenty or a hundred runs. It would be bad form for buildbot to reject a patch because of a spurious test failure, so I've been making a list of tests that fail, adding to it each time I run into a test that fails occasionally, and skipping the tests on that list during "make test". This is all fine... but one of the tests that fails occasionally is ddraw/visual.ok (see http://bugs.winehq.org/show_bug.cgi?id=28301 ). It really doesn't feel right to skip that entirely just because a few particular pixel comparisons fail sometimes. Plan A would be to fix the tests to not be flaky, but that's hard, and the buildbot needs a quick solution. Plan B might be to conditionally compile the flaky tests away, e.g.: --- a/dlls/ddraw/tests/visual.c +++ b/dlls/ddraw/tests/visual.c @@ -1490,6 +1490,7 @@ static void D3D1_TextureMapBlendTest(void) ok(hr == D3D_OK, "IDirect3DDevice3_EndScene failed, hr = %08x\n", hr); } +#ifndef WINE_SKIP_FLAKY_TEST_SEE_BUG_28301 color = D3D1_getPixelColor(DirectDraw1, Surface1, 5, 5); red = (color & 0x00ff0000) >> 16; green = (color & 0x0000ff00) >> 8; @@ -1513,6 +1514,7 @@ static void D3D1_TextureMapBlendTest(void) green = (color & 0x0000ff00) >> 8; blue = (color & 0x000000ff); ok(red == 0 && green == 0 && blue == 0xff, "Got color %08x, expected 000000ff or near\n", color); +#endif Then my blacklist would mostly be a bunch of -D definitions in CFLAGS, one per flaky test. Or we could use a single define for all flaky tests. I may try that privately, to increase buildbot's test coverage. Would something like that be useful for other people, or should I just stick with private patches? - Dan

Sept. 7, 2011

Re: Getting Wine's PO files on Launchpad

by Austin English

On Mon, Sep 5, 2011 at 11:30, Scott Ritchie <scott(a)open-vote.org> wrote: > On 09/05/2011 04:46 AM, Henri Verbeet wrote: >> On 5 September 2011 10:38, Michael Stefaniuc <mstefani(a)redhat.com> wrote: >>> Permission to relicense the existing translations with a BSD license... >>> https://help.launchpad.net/Translations/StartingToTranslate#Licensing_your_… >>> The license itself is sane but it will require quite some work and time >>> to accomplish the relicensing. >>> >> While BSD is an acceptable license, I can't say I'm really a fan, or >> that it's something I'd like to encourage. I'm probably the only one >> with that opinion though, and not much of a translator. > > I think the technical reason for this is that launchpad has a growing > intelligence about suggested translations built on its evergrowing > database of translations. That requires a permissive license for its > new translations, since the suggestions could be applied to different > projects that might fall under different copyrights. There's at least one other option: http://translationproject.org/html/welcome.html -- -Austin

Sept. 7, 2011

Re: buildbot status

by Scott Ritchie

On 09/01/2011 10:50 AM, Henri Verbeet wrote: > Looking at this from a slightly different angle, I think that if you > expect people to take buildbot results seriously, you should run it on > a configuration that's known to be solid, so that people can be > confident any failures are actual issues with the patch, instead of > e.g. fglrx or Ubuntu breaking something again. > > Finding out when Ubuntu breaks something is important too, and indeed one reason I started the daily Ubuntu builds and will be doing them with the development release. A testbot can't really know if it was Ubuntu breaking something or us breaking something that was only exposed on Ubuntu. We can make prior assumptions for individual machines though, such as it's usually fglrx's fault, and adjust our behavior/failure warnings accordingly. Thanks, Scott Ritchie

Sept. 7, 2011

Re: winecfg: Specify a context for the 'Letter' paper format.

by André Hentschel

Am 07.09.2011 00:48, schrieb Francois Gouget: > It's likely that letter does not always translate the same way for the paper format and the alphabet characters. > --- > > This is more to provide context for the translator than to avoid > conflicts. > > programs/winecfg/winecfg.rc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/winecfg/winecfg.rc b/programs/winecfg/winecfg.rc > index 5689e7c..26cf504 100644 > --- a/programs/winecfg/winecfg.rc > +++ b/programs/winecfg/winecfg.rc > @@ -77,7 +77,7 @@ BEGIN > IDS_DRIVE_LETTERS_EXCEEDED "You cannot add any more drives.\n\nEach drive must have a letter, from A to Z, so you cannot have more than 26." > IDS_SYSTEM_DRIVE_LABEL "System drive" > IDS_CONFIRM_DELETE_C "Are you sure you want to delete drive C?\n\nMost Windows applications expect drive C to exist, and will die messily if it doesn't. If you proceed remember to recreate it!" > - IDS_COL_DRIVELETTER "Letter" > + IDS_COL_DRIVELETTER "#msgctxt#Paper format#Letter" > IDS_COL_DRIVEMAPPING "Drive Mapping" > IDS_NO_DRIVE_C "You don't have a drive C. This is not so great.\n\nRemember to click 'Add' in the Drives tab to create one!\n" > END Isn't it the wrong context name? #msgctxt#Driveletter# would be better -- Best Regards, André Hentschel

Sept. 6, 2011

Re: dnsapi: Use internal name_skip function

by Austin English

2011/9/6 Dan Kegel <dank(a)kegel.com>: > Hi André, > your patch failed to build on an ubuntu 10.04 system here: > > ccache gcc -c -I. -I. -I../../../include -I../../../include > -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT > -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement > -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings > -Wpointer-arith -Wlogical-op -g -O0 -Werror -o name.o name.c > In file included from ns_parse.c:39: > ../../include/winbase.h:1583: error: expected declaration specifiers > or ‘...’ before ‘va_list’ > ../../include/winbase.h:1584: error: expected declaration specifiers > or ‘...’ before ‘va_list’ > make[1]: *** [ns_parse.o] Error 1 > > Inserting > #include <stdarg.h> > before including winbase.h makes the compiler happy. > - Dan The same on Alpine Linux (where the patch was meant to help). After including stdarg.h, the original failure goes away. -- -Austin

Sept. 6, 2011

re: dnsapi: Use internal name_skip function

by Dan Kegel

Hi André, your patch failed to build on an ubuntu 10.04 system here: ccache gcc -c -I. -I. -I../../../include -I../../../include -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O0 -Werror -o name.o name.c In file included from ns_parse.c:39: ../../include/winbase.h:1583: error: expected declaration specifiers or ‘...’ before ‘va_list’ ../../include/winbase.h:1584: error: expected declaration specifiers or ‘...’ before ‘va_list’ make[1]: *** [ns_parse.o] Error 1 Inserting #include <stdarg.h> before including winbase.h makes the compiler happy. - Dan ---------- Forwarded message ---------- From: <buildbot(a)kegel.com> Date: Tue, Sep 6, 2011 at 3:41 PM Subject: Re: 78446: Subject: dnsapi: Use internal name_skip function To: dank(a)kegel.com, wine-tests-results(a)winehq.org This is an experimental automated build and test service. Please feel free to ignore this email while we work the kinks out. The Buildbot has detected a failed build on builder runtests-heaptest while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests-heaptest/builds/13 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting) BUILD FAILED: failed shell_2 For more info about this message, see http://wiki.winehq.org/BuildBot

Sept. 6, 2011

Testbot 64 bit mingw?

by Stefan Dösinger

Hi, The ddrawmodes test has a problem on W7PROX64 when running as a 64 bit binary. The test times out, and debugging showed that it freezes in crash_callbackA, in dlls/ddraw/tests/ddrawmodes.c. The function is supposed to crash, DirectDrawEnumerateA catches the exception and returns DDERR_INVALIDPARAMS. The line in question is: *(volatile char*)0 = 2; I can reproduce the freeze on my local system with the binaries built by the testbot. I cannot reproduce them with my own 64 bit binaries, or with the ones from http://test.winehq.org/builds. Thus I suspect that a problem with mingw is preventing the test from working. The 32 bit build works fine, even on a 64 bit Windows system. The mingw version I'm using on my local system: $ x86_64-pc-linux-gnu-gcc --version x86_64-pc-linux-gnu-gcc (Gentoo 4.5.2 p1.1, pie-0.4.5) 4.5.2 Stefan

Sept. 6, 2011

Re: [1/2] shell32/tests: Fix path comparison

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14016 Your paranoid android. === WNT4WSSP6 (32 bit shlexec) === shlexec.c:193: Test failed: WaitForSingleObject(hProcess) returned 258

Sept. 6, 2011

Re: [2/2] shdoclc & user32 & wineconsole & wordpad: Specify a message context for cut and paste

by André Hentschel

Am 06.09.2011 18:02, schrieb Alexandre Julliard: > André Hentschel <nerv(a)dawncrow.de> writes: > >> @@ -44,7 +44,7 @@ IDR_BROWSE_CONTEXT_MENU MENU >> MENUITEM "Set as &Desktop Item", IDM_SETDESKTOPITEM >> MENUITEM SEPARATOR >> MENUITEM "Select &All", IDM_SELECTALL >> - MENUITEM "&Paste", IDM_PASTE >> + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE >> MENUITEM SEPARATOR >> MENUITEM "Create Shor&tcut", IDM_CREATESHORTCUT >> MENUITEM "Add to &Favorites...", IDM_ADDFAVORITES >> @@ -73,10 +73,10 @@ IDR_BROWSE_CONTEXT_MENU MENU >> MENUITEM "Set as Back&ground", IDM_SETWALLPAPER >> MENUITEM "Set as &Desktop Item...", IDM_SETDESKTOPITEM >> MENUITEM SEPARATOR >> - MENUITEM "Cu&t", IDM_CUT >> + MENUITEM "#msgctxt#Shell#Cu&t", IDM_CUT >> MENUITEM "&Copy", IDM_COPY >> MENUITEM "Copy Shor&tcut", IDM_COPYSHORTCUT >> - MENUITEM "&Paste", IDM_PASTE >> + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE > > That's not a very useful context. What are you trying to fix? > It seemed to be a good solution for the ampersand/underscore trouble i have left in the po translation. The position can differ for the same word even on Windows and sometimes a different position is the only way because of some bad word combinations. That was once discussed and said that msgctxt is the way to go. But yes, the context names are bad, maybe #ampersand# is better? -- Best Regards, André Hentschel

Sept. 6, 2011

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

by Frédéric Delanoy

> I don't have such an error here. Are you sure it is my patch that causes > this ? > Line 591 does not say much. Is it in the .cmd file or the .cmd.exp one. What > is the failing command ? > I don't see the point with testbot, there is no tests change in my patch. Don't have the error anymore, probably a temporary local glitch. For the testbot, that was effectively an error of me, since win obviously doesn't run cmd parsing code. When Dan's buildbot is stable enough, we could however test changes there. Sorry for the noise. Frédéric

Sept. 6, 2011

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

by Christian Costa

On 06/09/2011 15:33, Frédéric Delanoy wrote: > On Tue, Sep 6, 2011 at 09:35, Christian Costa<titan.costa(a)wanadoo.fr> wrote: >> -- >> >> It's just a resend. The patch is unmodified, just rebased on latest git. >> >> try4: >> - add missing NULL ending character to help_option string >> >> try3: >> - fix /? option. This fixes cmd tests regression >> >> try2: >> - keep attrib infos for help command >> - update po files >> >> I added a stub last year to make an installer work but didn't know the command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So here is a patch that takes what's in cmd.exe and move it to the standalone command. Some few code was taken from xcopy. > I've got test failures with your patch ("make test" in programs/cmd/tests) > First error: > batch.c:301: Test failed: unexpected char 0x6e position 7 in line 591 > (got 'r.test not found before delete, bad', wanted 'r.test found > before delete, good') > > Also, beware that testbot won't test your patch on windowses since it > doesn't change any file in tests/ directory > (you might want to submit it manually with, say, a small change in > test_builtins.cmd and/or test_builtins.exp) > > See http://wiki.winehq.org/CmdConformanceTests (recently written) if > you need help with the keywords, etc. > > Frédéric > > I don't have such an error here. Are you sure it is my patch that causes this ? Line 591 does not say much. Is it in the .cmd file or the .cmd.exp one. What is the failing command ? I don't see the point with testbot, there is no tests change in my patch. Christian

Sept. 6, 2011

Re: [2/2] shdoclc & user32 & wineconsole & wordpad: Specify a message context for cut and paste

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -44,7 +44,7 @@ IDR_BROWSE_CONTEXT_MENU MENU > MENUITEM "Set as &Desktop Item", IDM_SETDESKTOPITEM > MENUITEM SEPARATOR > MENUITEM "Select &All", IDM_SELECTALL > - MENUITEM "&Paste", IDM_PASTE > + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE > MENUITEM SEPARATOR > MENUITEM "Create Shor&tcut", IDM_CREATESHORTCUT > MENUITEM "Add to &Favorites...", IDM_ADDFAVORITES > @@ -73,10 +73,10 @@ IDR_BROWSE_CONTEXT_MENU MENU > MENUITEM "Set as Back&ground", IDM_SETWALLPAPER > MENUITEM "Set as &Desktop Item...", IDM_SETDESKTOPITEM > MENUITEM SEPARATOR > - MENUITEM "Cu&t", IDM_CUT > + MENUITEM "#msgctxt#Shell#Cu&t", IDM_CUT > MENUITEM "&Copy", IDM_COPY > MENUITEM "Copy Shor&tcut", IDM_COPYSHORTCUT > - MENUITEM "&Paste", IDM_PASTE > + MENUITEM "#msgctxt#Shell#&Paste", IDM_PASTE That's not a very useful context. What are you trying to fix? -- Alexandre Julliard julliard(a)winehq.org

Sept. 6, 2011

Re: ntdll: Fix two buffer overflow conditions in RtlDosPathNameToNtPathName_U.

by Octavian Voicu

On Tue, Sep 6, 2011 at 4:40 PM, Vitaliy Margolen <wine-devel(a)kievinfo.com> wrote: > The fix is not entirely correct. UNICODE_STRING does not have to have a > terminating \0 character. The code should not use str* functions on not > zero-terminated strings. I was also unsure about this when coding the patch, but I read here [1] that: "Specifies the length, in bytes, of the string pointed to by the Buffer member, not including the terminating NULL character, if any." So it's not a mistake to include a NULL character. I figured it's not worth the trouble to change the last strcpy into memcpy, especially because it could also be the case that it would introduce regressions (in case some other code wrongly depends on that NULL). Should I change offending strcpyW to memcpy? Octavian [1] http://msdn.microsoft.com/en-us/library/aa380518(v=vs.85).aspx

Sept. 6, 2011

Fwd: [ANNOUNCE] Git User's Survey 2011

by Andrew Eikum

It's that time of year again. I thought I'd forward this on to wine-devel since we're all Git users here. ----- Forwarded message from Jakub Narebski <jnareb(a)gmail.com> ----- Date: Mon, 5 Sep 2011 02:43:20 +0200 From: Jakub Narebski <jnareb(a)gmail.com> To: git(a)vger.kernel.org Subject: [ANNOUNCE] Git User's Survey 2011 User-Agent: KMail/1.9.3 Hello all, We would like to ask you a few questions about your use of the Git version control system. This survey is mainly to understand who is using Git, how and why. The results will be published to the Git wiki on the GitSurvey2011 page (https://git.wiki.kernel.org/index.php/GitSurvey2011) and discussed on the git mailing list. The survey would be open from 5 September till 3 October 2011. Please devote a few minutes of your time to fill this simple questionnaire, it will help a lot the git community to understand your needs, what you like of Git, and of course what you don't like of it. The survey can be found here: http://tinyurl.com/GitSurvey2011 https://www.survs.com/survey/VCAGZA8CT5 There is also alternate version which does not require cookies, but it doesn't allow one to go back to response and edit it. https://www.survs.com/survey/MRRGT8OEFV P.S. At request I can open a separate channel in survey, with a separate survey URL, so that responses from particular site or organization could be separated out. Please send me a email with name of channel, and I will return with a separate survey URL to use. -- Git Development Community -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ----- End forwarded message -----

Sept. 6, 2011

Re: script to run all good tests / all flaky tests / etc.

by Dan Kegel

On Tue, Sep 6, 2011 at 2:12 AM, Francois Gouget <fgouget(a)free.fr> wrote: > I found that most of the processes I had that were left behind were > winedbg processes showing the crash dialog. This was slowing things > down quite a bit with winetest because each was triggering the two > minutes timeout. In my case, it is iexplore -Embedding and rpcss, and only on win64? > I know you're avoiding crashing tests and you probably already avoid > this dialog but here goes anyway; I prime all my fresh wineprefixes > with: > > ./wine "./programs/regedit/regedit.exe.so" - <<__EOF__ > [HKEY_CURRENT_USER\Software\Wine\WineDbg] > "ShowCrashDialog"=dword:00000000 > __EOF__ I did that, but then I hit crashes that broke wineboot, so I switched to applying http://code.google.com/p/winezeug/source/browse/trunk/buildbot/winedbg-igno… which bakes that behavior in as default. Another annoyance: winedbg is hanging for me on exit after doing the backtrace, http://bugs.winehq.org/show_bug.cgi?id=28265 > And now I'll plug the conformance tests Wiki page where I > documented this: > http://wiki.winehq.org/ConformanceTests A fine page. - Dan

Sept. 6, 2011

Re: uxtheme: Return error on invalid parameters

by Alexandre Julliard

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > > Changelog: > uxtheme: Return error on invalid parameters Get/SetPropW already check the handle, don't add redundant checks. -- Alexandre Julliard julliard(a)winehq.org

Sept. 6, 2011

Re: [1/2] comctl32: Update the PROPSHEET{HEADER, PAGE} structures and add some PSH_XXX macros. (try 2)

by Alexandre Julliard

Francois Gouget <fgouget(a)codeweavers.com> writes: > @@ -59,57 +59,87 @@ typedef BOOL (CALLBACK *LPFNADDPROPSHEETPAGES)(LPVOID, LPFNADDPROPSHEETPAGE, LPA > /* > * Property sheet support (structures) > */ > +#ifndef _WIN32 > +typedef const VOID* PROPSHEETPAGE_RESOURCE; > +#elif defined(UNICODE) > +typedef LPCDLGTEMPLATEW PROPSHEETPAGE_RESOURCE; > +#else > +typedef LPCDLGTEMPLATEA PROPSHEETPAGE_RESOURCE; > +#endif That one should be disallowed too. And testing _WIN32 isn't useful in Wine. -- Alexandre Julliard julliard(a)winehq.org

Sept. 6, 2011

Re: ntdll: Fix two buffer overflow conditions in RtlDosPathNameToNtPathName_U.

by Vitaliy Margolen

On 09/06/2011 06:23 AM, Octavian Voicu wrote: > First one is an off-by-one error: RtlGetFullPathName_U, on success, returns > the number of bytes written, without counting the terminating NULL. The > allocated size for ntpath->Buffer didn't account for that NULL byte, so > for UNC paths the NULL byte would be overflown. > > Second one is caused by an USHORT overflow in ntpath->MaximumLength. > Calling the function with a path longer than 65535-8 bytes would allocate > a much shorter buffer and lead to a buffer overflow. > > -- > Steps to reproduce second issue are described here: > http://packetstormsecurity.org/files/view/76170/wine-overflow.txt > > Funny fact: Windows had the same USHORT overflow bug: > http://www.securityfocus.com/archive/1/323508 > --- > dlls/ntdll/path.c | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/dlls/ntdll/path.c b/dlls/ntdll/path.c > index 3207720..6138fa8 100644 > --- a/dlls/ntdll/path.c > +++ b/dlls/ntdll/path.c > @@ -383,8 +383,14 @@ BOOLEAN WINAPI RtlDosPathNameToNtPathName_U(PCWSTR dos_path, > if (!(ptr = RtlAllocateHeap(GetProcessHeap(), 0, sz))) return FALSE; > sz = RtlGetFullPathName_U(dos_path, sz, ptr, file_part); > } > + sz += (1 /* NUL */ + 4 /* unc\ */ + 4 /* \??\ */) * sizeof(WCHAR); > + if (sz> MAXWORD) > + { > + if (ptr != local) RtlFreeHeap(GetProcessHeap(), 0, ptr); > + return FALSE; > + } > > - ntpath->MaximumLength = sz + (4 /* unc\ */ + 4 /* \??\ */) * sizeof(WCHAR); > + ntpath->MaximumLength = sz; > ntpath->Buffer = RtlAllocateHeap(GetProcessHeap(), 0, ntpath->MaximumLength); > if (!ntpath->Buffer) > { The fix is not entirely correct. UNICODE_STRING does not have to have a terminating \0 character. The code should not use str* functions on not zero-terminated strings. Vitaliy

Sept. 6, 2011

Re: [The Official Wine Wiki] Update of "ConformanceTests"

by Joerg-Cyril.Hoehle＠t-systems.com

François Gouget asked: >> + * Depending on OSX settings, the firewall will ask whether to >> allow incoming network access for tests involving server sockets. >Does it cause test failures? Sorry, I've not tracked it down. Either I click "agree" fast enough (they occur towards the end of the ~20 minutes winetest.exe run) and the tests proceed, or presumably the test exe is killed after a timeout. I tend to "babysit" test execution for that reason (and because I only went online for the purpose of test execution, bug #20219). >Does one have to disable the firewall? I configured the Mac too long ago to remember. Presumably it's a matter of restrictive configuration, otherwise other users would have raised the topic already. Regards, Jörg Höhle

Sept. 6, 2011

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

by Frédéric Delanoy

On Tue, Sep 6, 2011 at 09:35, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > -- > > It's just a resend. The patch is unmodified, just rebased on latest git. > > try4: > - add missing NULL ending character to help_option string > > try3: > - fix /? option. This fixes cmd tests regression > > try2: > - keep attrib infos for help command > - update po files > > I added a stub last year to make an installer work but didn't know the command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So here is a patch that takes what's in cmd.exe and move it to the standalone command. Some few code was taken from xcopy. I've got test failures with your patch ("make test" in programs/cmd/tests) First error: batch.c:301: Test failed: unexpected char 0x6e position 7 in line 591 (got 'r.test not found before delete, bad', wanted 'r.test found before delete, good') Also, beware that testbot won't test your patch on windowses since it doesn't change any file in tests/ directory (you might want to submit it manually with, say, a small change in test_builtins.cmd and/or test_builtins.exp) See http://wiki.winehq.org/CmdConformanceTests (recently written) if you need help with the keywords, etc. Frédéric

Sept. 6, 2011