September 2011 - Wine-Devel

Re: [PATCH] cmd: Avoid rereading batch file for every call/goto executed (try 3)

by Eric Pouech

this won't work if a .bat file calls another .bat file the cache must be stored inside the context structure... A+ -- Eric Pouech

Sept. 5, 2011

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)

by Henri Verbeet

2011/9/5 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > + keys = HeapAlloc(GetProcessHeap(), 0, capacity * sizeof(WCHAR*)); > + vals = HeapAlloc(GetProcessHeap(), 0, capacity * sizeof(LARGE_INTEGER)); ... > + keys = HeapReAlloc(GetProcessHeap(), 0, keys, > + capacity * sizeof(WCHAR*)); > + vals = HeapReAlloc(GetProcessHeap(), 0, vals, > + capacity * sizeof(LARGE_INTEGER)); Memory allocations can fail. You also never free these, but I suppose that happens implicitly on process termination.

Sept. 5, 2011

Re: [1/5] ddraw: Add some NULL pointer tests

by Stefan Dösinger

Am 05.09.2011 um 00:30 schrieb Marvin: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=13949 > > Your paranoid android. > > > === W7PROX64 (64 bit ddrawmodes) === > Timeout I'm not sure how to interpret the testbot output: ddraw:ddrawmodes start - - ddraw:ddrawmodes done (258) I also don't expect that the added test makes a difference on x86 vs x86_64.

Sept. 5, 2011

Re: Getting Wine's PO files on Launchpad

by Henri Verbeet

On 5 September 2011 10:38, Michael Stefaniuc <mstefani(a)redhat.com> wrote: > Permission to relicense the existing translations with a BSD license... > https://help.launchpad.net/Translations/StartingToTranslate#Licensing_your_… > The license itself is sane but it will require quite some work and time > to accomplish the relicensing. > While BSD is an acceptable license, I can't say I'm really a fan, or that it's something I'd like to encourage. I'm probably the only one with that opinion though, and not much of a translator.

Sept. 5, 2011

Re: [PATCH 2/4] wined3d: Git rid of the rect checks for present in IWineD3DSurfaceImpl_BltOverride().

by Henri Verbeet

On 5 September 2011 10:45, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > The comment is slightly outdated, fbo_blit could handle this just fine, but > apparently the rest of the code doesn't call fbo_blit yet. So we're not quit > ready to remove this hack, yeah. > FBO blits aren't the issue, this is for when those aren't available.

Sept. 5, 2011

Re: [patch] Fake display interface

by GOUJON Alexandre

On 09/02/2011 10:57 PM, Jari Vetoniemi wrote: > Yeah, I'm aware of virtual desktop and used to create scripts to > launch applications using wine explorer \desktop=WIDTHxHEIGHT or > whatever the parameters were, it works well. But means that you have > to create always new shell script, and it also can prevent desktop > integration for certain application. If you globally enable that also, > it means that every application opens on the same virtual desktop. > Also virtual desktop won't fake the display resolutions to application > which is useful in certain cases. Please bottom post. I can't comment your code but I know there is a "wine 1.2" bug requesting this kind of feature : http://bugs.winehq.org/show_bug.cgi?id=11079

Sept. 5, 2011

Re: [2/4] msi/tests: Fix a number of test messages.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13969 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5996: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon) === WXPPROSP3 (32 bit install) === Timeout

Sept. 5, 2011

Re: [2/3] winhttp/tests: Initialize a variant with a known value.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13968 Your paranoid android. === W7PRO (32 bit winhttp) === winhttp.c:1971: Test failed: failed to send request 12152 winhttp.c:1977: Test failed: got 12019

Sept. 5, 2011

Re: Getting Wine's PO files on Launchpad

by Ferenc Gergely Szilagyi

Hello, the LP Translation FAQ writes: "I have no problem with BSD myself, but I also uploaded translations from upstream. What do I do? As long as the uploads were marked as translations that were published elsewhere, they fall under a separate copyright regime: those imports will retain their original copyright license. The BSD licence only applies to translations that are (as far as the system knows) original to Launchpad." Regards, Ferenc Gergely Szilagyi On Mon, Sep 5, 2011 at 10:38 AM, Michael Stefaniuc <mstefani(a)redhat.com>wrote: > Francois Gouget wrote: > > Launchpad has a PO file translation website. This makes it easier for > > non-developpers to contribute and review translations. > > > > https://translations.launchpad.net/ > > > > So what would it take to get Wine's PO files on Launchpad? > Permission to relicense the existing translations with a BSD license... > > https://help.launchpad.net/Translations/StartingToTranslate#Licensing_your_… > The license itself is sane but it will require quite some work and time > to accomplish the relicensing. > > The other probably more important thing is copyright assignment; > launchpad is infamous for that. Would potential translators need to sign > one of those? I didn't see that on a quick look but if it is required > that is a blocker IMHO. > > > * Launchpad tracks who translated what string and if we choose the > > 'Closed' permissions model only approved translators can update the > > translations. So that means we should be able to get patches with > > full attribution. > > > https://help.launchpad.net/Translations/YourProject/PermissionPolicies > > > > * Launchpad would need to pull updated PO files from Wine regularly. > > Ideally that would be automatic and happen daily (both to account > > for translations happening outside Launchpad and to take changes in > > the resource files into account quickly). > > > https://help.launchpad.net/Translations/YourProject/ImportingTranslations > > > > * Conversely Launchpad should submit patches back to Wine. Ideally that > > would be automated as much as possible but I'm fuzzy on the details > > here (especially on how to preserve attribution). As for the > > periodicity, maybe the best would be weekly or just before Alexandre > > makes a release. > > https://help.launchpad.net/Translations/YourProject/Exports > > https://help.launchpad.net/Translations/YourProject/PartialPOExport > > bye > michael > > >

Sept. 5, 2011

Re: [PATCH 2/4] wined3d: Git rid of the rect checks for present in IWineD3DSurfaceImpl_BltOverride().

by Stefan Dösinger

On Monday 05 September 2011 01:19:27 Henri Verbeet wrote: > On 5 September 2011 00:03, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > > On Sunday 04 September 2011 22:43:50 Henri Verbeet wrote: > >> These are no longer needed since present can handle these now. > > > > I think we can remove the entire special case and just do a blit. > > That's not what the comment says. The comment is slightly outdated, fbo_blit could handle this just fine, but apparently the rest of the code doesn't call fbo_blit yet. So we're not quit ready to remove this hack, yeah.

Sept. 5, 2011

Re: Getting Wine's PO files on Launchpad

by Michael Stefaniuc

Francois Gouget wrote: > Launchpad has a PO file translation website. This makes it easier for > non-developpers to contribute and review translations. > > https://translations.launchpad.net/ > > So what would it take to get Wine's PO files on Launchpad? Permission to relicense the existing translations with a BSD license... https://help.launchpad.net/Translations/StartingToTranslate#Licensing_your_… The license itself is sane but it will require quite some work and time to accomplish the relicensing. The other probably more important thing is copyright assignment; launchpad is infamous for that. Would potential translators need to sign one of those? I didn't see that on a quick look but if it is required that is a blocker IMHO. > * Launchpad tracks who translated what string and if we choose the > 'Closed' permissions model only approved translators can update the > translations. So that means we should be able to get patches with > full attribution. > https://help.launchpad.net/Translations/YourProject/PermissionPolicies > > * Launchpad would need to pull updated PO files from Wine regularly. > Ideally that would be automatic and happen daily (both to account > for translations happening outside Launchpad and to take changes in > the resource files into account quickly). > https://help.launchpad.net/Translations/YourProject/ImportingTranslations > > * Conversely Launchpad should submit patches back to Wine. Ideally that > would be automated as much as possible but I'm fuzzy on the details > here (especially on how to preserve attribution). As for the > periodicity, maybe the best would be weekly or just before Alexandre > makes a release. > https://help.launchpad.net/Translations/YourProject/Exports > https://help.launchpad.net/Translations/YourProject/PartialPOExport bye michael

Sept. 5, 2011

Re: [1/4] urlmon: Use CoTaskMemFree instead of HeapFree for memory allocated with CoTaskMemAlloc

by Jacek Caban

Hi Thomas, AFAICS secur_url wasn't allocated with CoTaskMemAlloc until this patch. Why are you changing it? Jacek

Sept. 5, 2011

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)

by Frédéric Delanoy

On Mon, Sep 5, 2011 at 06:47, Octavian Voicu <octavian.voicu(a)gmail.com> wrote: > 2011/9/5 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: >> + static WCHAR string[MAX_PATH]; > > Why make this static? It's only a temporary buffer and it's only used > once, when building the cache. Yeah true. Bad copy-paste from old WCMD_goto, although making it non-static won't change much, save conserving some memory. Will resubmit without the "static" part. Frédéric

Sept. 5, 2011

Re: Getting Wine's PO files on Launchpad

by Scott Ritchie

On 09/04/2011 03:26 PM, Francois Gouget wrote: > * Launchpad would need to pull updated PO files from Wine regularly. > Ideally that would be automatic and happen daily (both to account > for translations happening outside Launchpad and to take changes in > the resource files into account quickly). > https://help.launchpad.net/Translations/YourProject/ImportingTranslations > Launchpad already has a bzr branch for Wine that we should use here (via bzr-git imports) rather than messing with manual tarball uploads. https://launchpad.net/wine You can, for instance, do bzr get lp:wine (at least on an ubuntu machine) Thanks, Scott Ritchie

Sept. 5, 2011

Re: cmd: Avoid rereading batch file for every call/goto executed (try 2)

by Octavian Voicu

2011/9/5 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > + static WCHAR string[MAX_PATH]; Why make this static? It's only a temporary buffer and it's only used once, when building the cache. Octavian

Sept. 5, 2011

Re: [PATCH 2/4] wined3d: Git rid of the rect checks for present in IWineD3DSurfaceImpl_BltOverride().

by Henri Verbeet

On 5 September 2011 00:03, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > On Sunday 04 September 2011 22:43:50 Henri Verbeet wrote: >> These are no longer needed since present can handle these now. > I think we can remove the entire special case and just do a blit. That's not what the comment says.

Sept. 4, 2011

Re: [1/5] ddraw: Add some NULL pointer tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13949 Your paranoid android. === W7PROX64 (64 bit ddrawmodes) === Timeout

Sept. 4, 2011

Getting Wine's PO files on Launchpad

by Francois Gouget

Launchpad has a PO file translation website. This makes it easier for non-developpers to contribute and review translations. https://translations.launchpad.net/ So what would it take to get Wine's PO files on Launchpad? * Launchpad tracks who translated what string and if we choose the 'Closed' permissions model only approved translators can update the translations. So that means we should be able to get patches with full attribution. https://help.launchpad.net/Translations/YourProject/PermissionPolicies * Launchpad would need to pull updated PO files from Wine regularly. Ideally that would be automatic and happen daily (both to account for translations happening outside Launchpad and to take changes in the resource files into account quickly). https://help.launchpad.net/Translations/YourProject/ImportingTranslations * Conversely Launchpad should submit patches back to Wine. Ideally that would be automated as much as possible but I'm fuzzy on the details here (especially on how to preserve attribution). As for the periodicity, maybe the best would be weekly or just before Alexandre makes a release. https://help.launchpad.net/Translations/YourProject/Exports https://help.launchpad.net/Translations/YourProject/PartialPOExport -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

Sept. 4, 2011

Re: [PATCH 2/4] wined3d: Git rid of the rect checks for present in IWineD3DSurfaceImpl_BltOverride().

by Stefan Dösinger

On Sunday 04 September 2011 22:43:50 Henri Verbeet wrote: > These are no longer needed since present can handle these now. I think we can remove the entire special case and just do a blit. This hack is related to the ddraw windowed backbuffer hack you removed a while ago, except that the back->front blit is used by a handful of fullscreen apps too.

Sept. 4, 2011

Re: cmd: Avoid unneeded local variable in WCMD_goto

by Frédéric Delanoy

2011/9/4 Frédéric Delanoy <frederic.delanoy(a)gmail.com>: > --- > programs/cmd/builtins.c | 9 ++++----- > 1 files changed, 4 insertions(+), 5 deletions(-) Please ignore this patch. The changes it brings are incorporated in another patch ("cmd: Avoid rereading batch file for every call/goto executed") Frédéric

Sept. 4, 2011

Undocumented registry settings

by Vitaliy Margolen

Henri, Would you mind documenting recently added registry entries to wined3d on Wiki page http://wiki.winehq.org/UsefulRegistryKeys ? I can't find description of "AlwaysOffscreen". Vitaliy.

Sept. 4, 2011

Re: WINEDEBUG=warn+heap make test crashes in dsound?

by Michael Stefaniuc

Hi Dan, On 09/03/2011 02:33 AM, Dan Kegel wrote: > is this up your alley? You've been looking at dsound recently, iirc. is this a regression? If not I wouldn't bother with it as it looks like it will automatically fix itself during the COM cleanup. But good to know, I'll run the tests with warn+heap too. bye michael > export WINEDEBUG=warn+heap > ../../../tools/runtest -q -P wine -M dsound.dll -T ../../.. -p > dsound_test.exe.so ds3d.c && touch ds3d.ok > ALSA lib pcm_pulse.c:1008:(_snd_pcm_pulse_open) Unknown field handle_underrun > ... > ds3d.c:467: Test failed: buffer size changed after SetFormat() - > previous size was 88200, current size is 22052 > fixme:dsound3d:IDirectSound3DListenerImpl_QueryInterface Unknown IID > {31efac30-515c-11d0-a9aa-00aa0061be93} > wine: Unhandled page fault on read access to 0xfeef021a at address > 0x68d6775f (thread 002c), starting debugger... > Backtrace: > =>0 0x68d6775f IDirectSound3DListenerImpl_Release+0xe9(iface=0x1d5170) > [/home/dank/wine-git/dlls/dsound/sound3d.c:791] in dsound (0x0033f768) > 1 0x684bce32 test_primary_3d_with_listener+0x677(lpGuid=(nil)) > [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1228] in dsound_test > (0x0033f868) > 2 0x684bd181 dsenum_callback+0x183(lpGuid=(nil), > lpcstrDescription="Primary Sound Driver", lpcstrModule="", > lpContext=0x0(nil)) > [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1283] in dsound_test > (0x0033f8a8) > 3 0x68d558e4 a_to_w_callback+0xe0(guid=(nil), descW="Primary Sound > Driver", modW="", data=0x33fc80) > [/home/dank/wine-git/dlls/dsound/dsound_main.c:291] in dsound > (0x0033f938) > 4 0x68d55c3b DirectSoundEnumerateW+0x2ab(lpDSEnumCallback=0x68d55803, > lpContext=0x33fc80) > [/home/dank/wine-git/dlls/dsound/dsound_main.c:370] in dsound > (0x0033fc68) > 5 0x68d55985 DirectSoundEnumerateA+0x88(lpDSEnumCallback=0x684bcffd, > lpContext=0x0(nil)) > [/home/dank/wine-git/dlls/dsound/dsound_main.c:321] in dsound > (0x0033fc98) > 6 0x684bd50d ds3d_tests+0x2a() > [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1307] in dsound_test > (0x0033fcc8) > 7 0x684bd5cd func_ds3d+0x7b() > [/home/dank/wine-git/dlls/dsound/tests/ds3d.c:1326] in dsound_test > (0x0033fcf8) > 8 0x684d04d3 run_test+0x9e(name="ds3d.c") > [/home/dank/wine-git/dlls/dsound/tests/../../../include/wine/test.h:556] > in dsound_test (0x0033fd58)

Sept. 4, 2011

RFC - The ProductName registry entry

by Bruno Jesus

Louis Lenders sent the following url patch to fix bug #28065, it was rejected because it fixes the product name so even if you set other version inside winecfg the registry entry will still say "Windows XP". http://www.winehq.org/pipermail/wine-patches/2011-August/105414.html I have made a small change to winecfg to make it save the correct ProductName based on the selected OS and would like comments. If I ever send my patch to git Louis Lenders patch will need to get in too because we would need a default ProductName setting in registry and his patch was correct because the default wine OS is XP, am I right? The patch is quite simple and it tries to never let 2 ProductName exist in different windows versions. Thanks in advance, Bruno

Sept. 4, 2011

bug in OLEPictureImpl_Load (and possibly other stream readers)

by Michael Blumenkrantz

Hi, I have been working with Bernhard Loos (jhgf) for the past couple days to track down the source of http://bugs.winehq.org/show_bug.cgi?id=28235, and today I am happy to report that I have finally located it!. Attached are two files: olefail.cpp - the source olefail.txt - actually olefail.exe renamed to evade mailing list filters :) This is a tiny demo app, most of which is copied right out of MSDN, which showcases the problem. To break it down: *On Windows, OLEPictureImpl_Load will read exactly 2 bytes for the header to attempt to determine the length in the case that the stat() member function of the stream interface is broken. This is acknowledged in a large block comment at olepicture.c:1339. Wine then ignores this fact and reads 8 bytes. This is just the tip of the bug, however! *The major bug is that after this, at olepicture.c:1412, wine decides to attempt to read a buffer of unknown size and content UNTIL THE END OF THE BUFFER. While this may work for reading a string, when reading a binary buffer you MUST know the size. I'm sure we all know this :) *Unless the stream reader interface is fairly smart at this point and returns 0 bytes read (which seems unlikely if the stat() mechanism is broken), wine is guaranteed to crash. The solution here is to remove the broken "try until you die" method of attempting to read more than 2 bytes of the unknown buffer. Instead, simply return an error as Windows does and move on.

Sept. 4, 2011

Re: ubuntu ppa -- nice to have on development version too

by Scott Ritchie

On 09/02/2011 10:04 AM, Susan Cragin wrote: > There was discussion about putting a daily wine build on the ubuntu ppa. > I'd like to put in a word for having it on the development version (currently oneiric) as well as the stable version (natty). > Right now wine only seems to have a natty ppa. > > > > > > Yes I'll do an oneiric recipe soon.

Sept. 3, 2011