September 2011 - Wine-Devel

Re: [PATCH 5/5] cmd: fix parameter parsing of quotes and special chars

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13898 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@

Sept. 1, 2011

Re: 78259: Subject: [PATCH 4/5] wined3d: Make the device parameter to wined3d_device_get_light_enable() const.

by buildbot＠kegel.com

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/204 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

Sept. 1, 2011

Re: [PATCH 4/5] cmd: fix handling of special characters

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13897 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@

Sept. 1, 2011

Re: [PATCH 3/5] cmd: improve treatment of quotes in command line

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13896 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@

Sept. 1, 2011

Re: [PATCH 2/5] cmd: use GetCommandline() rather than argv

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13895 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@

Sept. 1, 2011

Re: [PATCH 1/5] cmd/tests: add more tests for command line parsing

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13894 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing @todo_wine(a)0@space@

Sept. 1, 2011

Re: ws2_32: Avoid an unhandled read exception on WSAIoctl (resend)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13889 Your paranoid android. === WVISTAADM (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W2K8SE (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PRO (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (32 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead === W7PROX64 (64 bit sock) === sock.c:2968: Test failed: expected WSAEINVAL, got 10014 instead

Sept. 1, 2011

Re: 78258: Subject: [PATCH 3/5] wined3d: Get rid of some redundant else statements in IWineD3DSurfaceImpl_BltOverride().

by buildbot＠kegel.com

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/203 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

Sept. 1, 2011

Re: 78256: Subject: [PATCH 1/5] wined3d: Print a FIXME for any flags passed to wined3d_surface_flip().

by Henri Verbeet

On 1 September 2011 20:51, <buildbot(a)kegel.com> wrote: > Backtrace: > =>0 0x7bc4772c HEAP_CreateFreeBlock+0xbb(subheap=0x110014, ptr=0x130910, size=0xdffe8) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ntdll/heap.c:583] in ntdll (0x0032f444) > 1 0x7bc47a57 HEAP_ShrinkBlock+0x42(subheap=0x110014, pArena=0x1308e8, size=0x20) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ntdll/heap.c:685] in ntdll (0x0032f468) > 2 0x7bc4abdd RtlAllocateHeap+0x2a8(heap=0x110000, flags=0x2, size=0x1a) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ntdll/heap.c:1699] in ntdll (0x0032f4c8) > 3 0x40063383 OpenDriverA+0x96(lpDriverName="winealsa.drv", lpSectionName=0x0(nil), lParam=0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/driver.c:361] in winmm (0x0032f518) > 4 0x400666ac MMDRV_Install+0x151(drvRegName="winealsa.drv", drvFileName="winealsa.drv", bIsMapper=0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/lolvldrv.c:456] in winmm (0x0032f5c8) > 5 0x400670d1 MMDRV_Init+0x3b7() [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/lolvldrv.c:571] in winmm (0x0032f658) > 6 0x40064d4d MMDRV_InitSingleType+0x2a(type=0x5) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/lolvldrv.c:80] in winmm (0x0032f668) > 7 0x40065993 MMDRV_Get+0xc9(_hndl=0x0(nil), type=0x5, bCanBeID=0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/lolvldrv.c:261] in winmm (0x0032f768) > 8 0x4007c537 WINMM_DRVMessage+0xac(dev=0, message=0x814, param1=0x13050c, param2=0, is_out=0x1) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/waveform.c:2774] in winmm (0x0032f7b8) > 9 0x4007c839 waveOutMessage+0x111(hWaveOut=(nil), uMessage=0x814, dwParam1=0x13050c, dwParam2=0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winmm/waveform.c:2832] in winmm (0x0032f7f8) > 10 0x4002ed0b DSOUND_ReopenDevice+0x153(device=0x1304f8, forcewave=0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/dsound/primary.c:108] in dsound (0x0032f878) > 11 0x400225de DirectSoundDevice_Initialize+0x47e(ppDevice=0x1222dc, lpcGUID=0x400428f0) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/dsound/dsound.c:1412] in dsound (0x0032f9a8) > 12 0x40020b4a IDirectSound8_IDirectSound8_Initialize+0x8e(iface=0x1222f8, lpcGuid=(nil)) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/dsound/dsound.c:920] in dsound (0x0032f9e8) > 13 0x400214a6 DirectSoundCreate8+0x164(lpcGUID=(nil), ppDS=0x12d518, pUnkOuter=(nil)) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/dsound/dsound.c:1143] in dsound (0x0032fa38) > 14 0x68f08e96 DSoundRender_create+0x20d(pUnkOuter=(nil), ppv=0x32fbfc) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/dsoundrender.c:519] in quartz (0x0032fbc8) > 15 0x68f289fa DSCF_CreateInstance+0xa2(iface=0x122a60, pOuter=(nil), riid=0x6857404c, ppobj=0x685796d4) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/main.c:130] in quartz (0x0032fc18) > 16 0x686cce9c CoCreateInstance+0x29a(rclsid=0x68575e9c, pUnkOuter=(nil), dwClsContext=0x1, iid=0x6857404c, ppv=0x685796d4) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ole32/compobj.c:2641] in ole32 (0x0032fc98) > 17 0x68565c80 create_dsound_renderer+0x43() [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/tests/dsoundrender.c:46] in quartz_test (0x0032fcd8) > 18 0x68566e45 func_dsoundrender+0x25() [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/tests/dsoundrender.c:225] in quartz_test (0x0032fcf8) > 19 0x685727a2 run_test+0x9e(name="dsoundrender.c") [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/tests/../../../include/wine/test.h:556] in quartz_test (0x0032fd58) > 20 0x68572bb9 main+0x23a(argc=<couldn't compute location>, argv=0x1103d8) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/quartz/tests/../../../include/wine/test.h:624] in quartz_test (0x0032fe28) > 21 0x68572c46 __wine_spec_exe_entry+0x69(peb=0x7ffdf000) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/winecrt0/exe_entry.c:36] in quartz_test (0x0032fe60) > 22 0x7b85fc74 call_process_entry+0xb() in kernel32 (0x0032fe78) > 23 0x7b85fdbb start_process+0x144(peb=0x7ffdf000) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/kernel32/process.c:1087] in kernel32 (0x0032fec8) > 24 0x7bc7dee8 call_thread_func+0xb() in ntdll (0x0032fed8) > 25 0x7bc7df26 call_thread_entry_point+0x33(entry=0x7b85fc76, arg=0x7ffdf000) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ntdll/signal_i386.c:2499] in ntdll (0x0032ffb8) > 26 0x7bc53805 start_process+0x25(kernel_start=0x7b85fc76) [/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/ntdll/loader.c:2612] in ntdll (0x0032ffe8) > 27 0x68028b4d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) I have some doubts about this being caused by this patch.

Sept. 1, 2011

Re: 78256: Subject: [PATCH 1/5] wined3d: Print a FIXME for any flags passed to wined3d_surface_flip().

by buildbot＠kegel.com

The Buildbot has detected a failed build on builder runtests while building Wine. Full details are available at: http://buildbot.kegel.com/builders/runtests/builds/201 BUILD FAILED: failed shell_3 For more info about this message, see http://wiki.winehq.org/BuildBot

Sept. 1, 2011

Re: configure.ac: add -Werror to default compiler options

by Dan Kegel

On Thu, Sep 1, 2011 at 8:52 AM, Dan Kegel <dank(a)kegel.com> wrote: > On Thu, Sep 1, 2011 at 1:35 AM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: >> Here is a warning report from a 64bit system. I get a lot of warnings >> on both 32 and 64bit wines. Many of them are "variable set but not >> used" (unused error returns, ...). >> >> http://bugs.winehq.org/show_bug.cgi?id=26768 was filed a while ago for >> the oleaut32 spam. > > Wow. Guess we have a ways to go. Finally dug up AJ's position on the question: http://www.winehq.org/pipermail/wine-devel/2008-September/069203.html So, no -Werror by default in git. Buildbot may at some point start complaining about patches that introduce new warnings, though. Dan

Sept. 1, 2011

Re: buildbot status

by Henri Verbeet

On 1 September 2011 19:00, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > I had a quick look at the D3DCREATE_FPU_PRESERVE code: shouldn't we do > something like ddraw where we set the FPU control word in every method and > restore it afterwards? I think we can't blame the driver for crashing if we > hand it over the FPU in a messed up state. It probably needs some more test, > e.g. what do methods other than CreateDevice do when FPU_PRESERVE is not set > and the FPU is in some non-standard mode. > > No idea yet why the visual tests don't work. > What it comes down to is this: Both Mesa and NVIDIA can manage to somehow make this work, fglrx isn't interested in making it work. That's their good right of course, but the consequence is that I from my side am not particularly interested in making things work with fglrx. I'd much rather spend that time working with the r300g and r600g people on making those drivers as good as possible. Now if you can justify working on this, either towards your employer or towards yourself in your own time, I'm certainly not going to stop you. All I care about in that regard is that any resulting patches are up to standards. However, what I want to avoid is the situation where I'm spending time debugging fglrx because the buildbot has test failures there. Looking at this from a slightly different angle, I think that if you expect people to take buildbot results seriously, you should run it on a configuration that's known to be solid, so that people can be confident any failures are actual issues with the patch, instead of e.g. fglrx or Ubuntu breaking something again.

Sept. 1, 2011

Re: po: Fix some typography issues in the Czech translation.

by Octavian Voicu

On Thu, Sep 1, 2011 at 7:21 PM, Dan Kegel <dank(a)kegel.com> wrote: > I just checked, and none of our .c, .h, or .po files have embedded > CR's. I guess it would be ok to strip trailing CR's on incoming > patches, I'll do that. That's weird, did they blacklist the 0x0d character from the encoding of Unicode characters? Pasted all the Unicode characters from a Wikipedia page in a file and couldn't find any 0x0d in the file. In any case, is Alexandre also going to strip CRs? If not, there isn't much point in doing that, as patch wouldn't go in with the CRs. Octavian

Sept. 1, 2011

Re: buildbot status

by Stefan Dösinger

On Thursday 01 September 2011 18:46:58 Stefan Dösinger wrote: > Fwiw, the d3d8 and d3d9 device tests fail, no idea why, the d3d9 query test > fails(this is something we can fix). The ddraw, d3d8 and d3d9 visual tests > can't read back the backbuffer, so they refuse to run. This crash happens in the CreateDevice call that uses the D3DCREATE_FPU_PRESERVE flag. The exception is a division by zero exception in the driver. I had a quick look at the D3DCREATE_FPU_PRESERVE code: shouldn't we do something like ddraw where we set the FPU control word in every method and restore it afterwards? I think we can't blame the driver for crashing if we hand it over the FPU in a messed up state. It probably needs some more test, e.g. what do methods other than CreateDevice do when FPU_PRESERVE is not set and the FPU is in some non-standard mode. No idea yet why the visual tests don't work.

Sept. 1, 2011

Re: configure.ac: add -Werror to default compiler options

by André Hentschel

Am 01.09.2011 17:52, schrieb Dan Kegel: > On Thu, Sep 1, 2011 at 1:35 AM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: >> Here is a warning report from a 64bit system. I get a lot of warnings >> on both 32 and 64bit wines. Many of them are "variable set but not >> used" (unused error returns, ...). >> >> http://bugs.winehq.org/show_bug.cgi?id=26768 was filed a while ago for >> the oleaut32 spam. > > Wow. Guess we have a ways to go. > - Dan > > Also beside Micheal's comment -Werror is a bad idea for crosscompiling, compiling with other compilers, compiling on new/uncommon systems, compiling on other architectures and so on... -- Best Regards, André Hentschel

Sept. 1, 2011

Re: buildbot status

by Stefan Dösinger

Fwiw, the d3d8 and d3d9 device tests fail, no idea why, the d3d9 query test fails(this is something we can fix). The ddraw, d3d8 and d3d9 visual tests can't read back the backbuffer, so they refuse to run. On Thursday 01 September 2011 18:18:11 Henri Verbeet wrote: > On 1 September 2011 17:38, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > > On Thursday 01 September 2011 13:04:34 Henri Verbeet wrote: > >> Did the tests start passing on fglrx then? > > > > As far as I know they don't. But do they have to? > > If running those tests is the point of that machine, I'd say so. With > a known broken configuration, you risk just running into the same > known bugs every time you change something or add a new test, wasting > everyone's time. An important consideration here is that apparently > upstream isn't interested in fixing this kind of bug, and there's no > way for us to fix them ourselves.

Sept. 1, 2011

Re: po: Fix some typography issues in the Czech translation.

by Dan Kegel

On Thu, Sep 1, 2011 at 7:52 AM, Octavian Voicu <octavian.voicu(a)gmail.com> wrote: > 2011/9/1 Dan Kegel <dank(a)kegel.com>: >> This patch found a bug in my scripts - it failed to grep the patch >> for sender and subject - but it looks like there might be something >> wrong with the patch itself, it doesn't apply here. > > The patch uses dos line endings, that's why it doesn't apply. That's it, thanks. (I had seen them, but thought patch tools were smart enough to ignore 'em; I guess patch does if the whole patch is in CRLF format, but in this case, the preamble wasn't.) I just checked, and none of our .c, .h, or .po files have embedded CR's. I guess it would be ok to strip trailing CR's on incoming patches, I'll do that. But there's something even fishier about http://source.winehq.org/patches/data/78249 -- it ends in a block of NUL characters. What's up with that? hexdump -C shows ... 00001560 20 0d 0a 20 23 3a 20 77 69 6e 68 6c 70 33 32 2e | .. #: winhlp32.| 00001570 72 63 3a 36 34 0d 0a 20 23 2c 20 66 75 7a 7a 79 |rc:64.. #, fuzzy| 00001580 0d 0a 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00001590 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| * 00001d80 00 00 0a 0a |....| - Dan

Sept. 1, 2011

Re: buildbot status

by Henri Verbeet

On 1 September 2011 17:38, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > On Thursday 01 September 2011 13:04:34 Henri Verbeet wrote: >> Did the tests start passing on fglrx then? > As far as I know they don't. But do they have to? > If running those tests is the point of that machine, I'd say so. With a known broken configuration, you risk just running into the same known bugs every time you change something or add a new test, wasting everyone's time. An important consideration here is that apparently upstream isn't interested in fixing this kind of bug, and there's no way for us to fix them ourselves.

Sept. 1, 2011

Re: buildbot status

by Dan Kegel

On Thu, Sep 1, 2011 at 8:38 AM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > On Thursday 01 September 2011 13:04:34 Henri Verbeet wrote: >> Did the tests start passing on fglrx then? > As far as I know they don't. But do they have to? > > If I remember correctly Dan's previous patchwatcher scripts kept track of > tests that were failing, so they didn't require a fully successful test run. > The important thing was that the tests succeeded or failed reliably. > > The new setup looks much less sophisticated in that regard Right - I have not yet forward ported the code that tracks known failures. It hasn't been needed so far -- I've gotten away with a simple blacklist -- but once I start doing things like valgrinding, checking compiler warnings, or running on ATI I'll probably need to bring it back. - Dan

Sept. 1, 2011

Re: configure.ac: add -Werror to default compiler options

by Dan Kegel

On Thu, Sep 1, 2011 at 1:35 AM, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > Here is a warning report from a 64bit system. I get a lot of warnings > on both 32 and 64bit wines. Many of them are "variable set but not > used" (unused error returns, ...). > > http://bugs.winehq.org/show_bug.cgi?id=26768 was filed a while ago for > the oleaut32 spam. Wow. Guess we have a ways to go. - Dan

Sept. 1, 2011

Re: buildbot status

by Stefan Dösinger

On Thursday 01 September 2011 13:04:34 Henri Verbeet wrote: > Did the tests start passing on fglrx then? As far as I know they don't. But do they have to? If I remember correctly Dan's previous patchwatcher scripts kept track of tests that were failing, so they didn't require a fully successful test run. The important thing was that the tests succeeded or failed reliably. The new setup looks much less sophisticated in that regard, at very least it can't check single ok() lines(or I haven't found the code that does this)

Sept. 1, 2011

Re: [1/5] ddraw: Simplify Z format parsing a bit, remove ERRs

by Stefan Dösinger

On Thursday 01 September 2011 13:27:28 Henri Verbeet wrote: > On 1 September 2011 11:01, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > > case 32: > > if(DDPixelFormat->u2.dwStencilBitDepth == 8) > > > > return WINED3DFMT_D24_UNORM_S8_UINT; > > > > - else > > + else if (DDPixelFormat->u2.dwStencilBitDepth == 4) > > > > return WINED3DFMT_S4X4_UINT_D24_UNORM; > > I'm not sure if this is intentional or not, but you fallthrough to the > default case here. It was intentional, but you're right that it is inconsistent.

Sept. 1, 2011

Re: [1/7] cmd: Add support for LSS comparison operator in if statements

by Alexandre Julliard

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > + else if ((s = StrStrIW (p, lssW))) { > + s += 3; > + a = StrToIntW(condition); > + b = StrToIntW(WCMD_parameter (s, 0, NULL)); I don't think you want to use strstr for that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

Sept. 1, 2011

Re: po: Fix some typography issues in the Czech translation.

by Octavian Voicu

2011/9/1 Dan Kegel <dank(a)kegel.com>: > This patch found a bug in my scripts - it failed to grep the patch > for sender and subject - but it looks like there might be something > wrong with the patch itself, it doesn't apply here. The patch uses dos line endings, that's why it doesn't apply. Octavian

Sept. 1, 2011

Re: setupapi: Fix a few pointer cast warnings.

by Jerome Leclanche

If anyone wants to have a shot at a proper fix, by all means -- I don't have the C skills to figure this one out properly ;) On Thu, Sep 1, 2011 at 3:24 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Jerome Leclanche <adys.wh(a)gmail.com> writes: > >> From c8a7535beebb152641330d3d1410d17345522867 Mon Sep 17 00:00:00 2001 >> From: Jerome Leclanche <adys(a)azura> >> Date: Thu, 1 Sep 2011 12:51:26 +0100 >> Subject: [PATCH] setupapi: Fix a few pointer cast warnings. > > That's just hiding the pointer truncation bug. > > -- > Alexandre Julliard > julliard(a)winehq.org >

Sept. 1, 2011