September 2011 - Wine-Devel

Re: winscard

by Bruno Jesus

On Fri, Sep 30, 2011 at 06:42, Vincent Hardy <vincent.hardy.be(a)gmail.com> wrote: > Hi all, > > Here are four patches that are a partial but functional implementation of > winscard. Congratulations =) > I installed "Belgian Electronic Identity Card MiddleWare" > (http://eid-mw.googlecode.com/files/BeidMW35-6995.msi) > > I tested winscard by starting beid35gui.exe and I can see my identity card > data. I can help you test this (although currently I'm lacking the time to), I have 8 different contact and contactless readers and dozens of different card types. And several demo applications and full fledged hsm applications that run with over 200 smartcards at the same time =) > Moreover, this should help to solve this bug > http://bugs.winehq.org/show_bug.cgi?id=26978. > > Are these 4 patches good enough to be sent to wine-patch ? > > winscard is really useful for me and probably for other people too. I'm not used to patch reviewing but here are my comments: You don't need to check for invalid parameters on the functions, at least in most of them. pcsclite should do that by itself and for example in the SCardListreaders you don't need to interpret AUTOALLOCATE because pcsclite handles that [1]. In SCardConnect you are also checking and returning the invalid parameters error but pcsclite checks that [1]. Again with SCardStatus, I guess it should be as simple as a forward to pcsclite. You're defining MAX_ATR_SIZE 36 but the standard ISO 7816 value is 33 bytes and both pcsclite and windows winscard use 33. At least once you do HeapAlloc + memset zero, usually this can be done by passing a flag HEAP_ZERO_MEMORY to HeapAlloc. > > Vincent > [1] = http://pcsclite.alioth.debian.org/api/winscard__clnt_8c_source.html Best wishes, Bruno

Sept. 30, 2011

Re: Buildbot status

by Frédéric Delanoy

On Fri, Sep 30, 2011 at 00:33, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > On Thu, Sep 29, 2011 at 8:59 PM, Dan Kegel <dank(a)kegel.com> wrote: >> Do you object to Greg's existing testbot emails, too > > Kinda, yeah. I read wine-devel for developer comments, insights, > development about wine, etc. Bot emails feel kind of wrong here; I > especially dislike WTB's because a lot of them are timeout-sort of > spam on one odd machine. Well as long as the test failures remain available from http://source.winehq.org/patches/ (e.g. http://source.winehq.org/patches/data/79447.testfail) I don't see why the list should receive automatic replies/mails. That should probably be opt-in so interested people can still receive messages on their private email address. Don't know if that's currently possible for WTB, though, or if it's a hardcoded list of recipients. Maarten probably knows better

Sept. 30, 2011

winscard

by Vincent Hardy

Hi all, Here are four patches that are a partial but functional implementation of winscard. I installed "Belgian Electronic Identity Card MiddleWare" (http://eid-mw.googlecode.com/files/BeidMW35-6995.msi) I tested winscard by starting beid35gui.exe and I can see my identity card data. Moreover, this should help to solve this bug http://bugs.winehq.org/show_bug.cgi?id=26978. Are these 4 patches good enough to be sent to wine-patch ? winscard is really useful for me and probably for other people too. Vincent

Sept. 30, 2011

Re: Favorite bug: deadlock preventing backtraces?

by Maarten Lankhorst

Hey Dan, On 09/29/2011 06:00 AM, Dan Kegel wrote: > On one of my boxes, if I run winmm/midi.ok in a loop, it will > eventually deadlock/crash > ( http://bugs.winehq.org/show_bug.cgi?id=28388 ): > err:ntdll:RtlpWaitForCriticalSection section 0x110060 "heap.c: main > process heap section" wait timed out in thread 0022, blocked by 001f, > retrying (60 sec) > wine: Critical section 00110060 wait failed at address 0x7bc3484a > (thread 0022), starting debugger... > err:ntdll:RtlpWaitForCriticalSection section 0x110060 "heap.c: main > process heap section" wait timed out in thread 0022, blocked by 001f, > retrying (60 sec) > > Sadly, no backtrace follows ( http://bugs.winehq.org/show_bug.cgi?id=28265 ). > Since I'm not around when it finally happens, I haven't tried btall yet. > > I suppose I should write a shell script to watch for that error > message in the log, > and run btall then... any better ideas? > > (I did try giving winedbg a private heap, didn't seem to prevent the deadlock.) > > I'm wondering if it's because of the lock in virtual_handle_stack_fault, what if you remove that? :P

Sept. 30, 2011

Re: [1/3] kernel32: Reset LastError if GetModuleFileName() succeeds.

by Francois Gouget

On Fri, 30 Sep 2011, Francois Gouget wrote: > This is necessary because LastError may already be set to > ERROR_INSUFFICIENT_BUFFER which would mislead the caller. And of course the older versions of Windows (up to XP SP3!) don't reset lasterror so the test bit of the patch cannot go in. I'd still argue that GetModuleFileNameW() should reset LastError though. -- Francois Gouget <fgouget(a)codeweavers.com>

Sept. 30, 2011

Re: [1/3] kernel32: Reset LastError if GetModuleFileName() succeeds.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=14640 Your paranoid android. === WNT4WSSP6 (32 bit module) === module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 === W2KPROSP4 (32 bit module) === module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 === WXPPROSP3 (32 bit module) === module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737 module.c:50: Test failed: LastError was not reset: -559038737 module.c:58: Test failed: LastError was not reset: -559038737

Sept. 30, 2011

Re: Buildbot status

by Jerome Leclanche

On Thu, Sep 29, 2011 at 8:59 PM, Dan Kegel <dank(a)kegel.com> wrote: > Do you object to Greg's existing testbot emails, too Kinda, yeah. I read wine-devel for developer comments, insights, development about wine, etc. Bot emails feel kind of wrong here; I especially dislike WTB's because a lot of them are timeout-sort of spam on one odd machine.

Sept. 29, 2011

Re: gdiplus: Include an alpha channel in HBITMAPs created from Bitmaps.

by Vincent Povirk

Don't commit this. Seems I forgot about top-down vs. bottom-up dibs. On Thu, Sep 29, 2011 at 12:03 PM, Vincent Povirk <madewokherd(a)gmail.com> wrote: > For bug 55549. >

Sept. 29, 2011

Re: Buildbot status

by Dan Kegel

On Thu, Sep 29, 2011 at 1:25 PM, Octavian Voicu <octavian.voicu(a)gmail.com> wrote: > On Thu, Sep 29, 2011 at 12:59 PM, Dan Kegel <dank(a)kegel.com> wrote: >> Do you object to Greg's existing testbot emails, too? > > They're annoying when they are spurious... Yes. That's why I've been focusing on reducing the spurious email rate, and won't turn email to wine-devel on until there have been no spurious emails for five days.

Sept. 29, 2011

Status for the ID3DXEffect interface

by Rico Schüller

Hi, I'd like to say a word for the effect interface in d3dx9_xx.dll, what's already done and what's on the todo list. The parser for binary effects works pretty much. It should nearly parse the effect files completely, but it should fail on effect files which contain functions (if anyone has a binary effect with a function, I'd be interested in it). It is also possible to Get/Set some values, but not yet all, because there are some tricky cases which I haven't figured out completely yet (an example is GetVector() on an D3DXPT_INT). I'm currently working on the correct applying for the states and making some progress with that. But it seems to me that there are a lot of special cases in that. Todo: - Apply the states - Handle parameter blocks - State savings: State saving and restoring in Begin/End is needed. - ASCII effects: The effect could be supplied as byte code or as ASCII text. - ID3DXEffectPool: The support for effect pools is needed. I'm not sure if it might be useful to post an example of a commented binary effect file to make the format "visible" without reading the code. At least it could help when writing the ASCII effect parser. Cheers Rico

Sept. 29, 2011