January 2012 - Wine-Devel - list.winehq.org

Re: [2/2] scrrun: Register Scripting interfaces

by Alistair Leslie-Hughes

On 26/01/2012 1:03 AM, Nikolay Sivov wrote: > On 1/25/2012 15:21, Jacek Caban wrote: > > That's what I meant, it should be implemented in one place, after that > you probably won't need > duplicated *.idls. Where would such a file live? Best Regards Alistair Leslie-Hughes

Jan. 26, 2012

Re: po: Remove extraneous full stops from the Japanese translation.

by Francois Gouget

On Wed, 25 Jan 2012, Alexandre Julliard wrote: > Francois Gouget <fgouget(a)free.fr> writes: > > > You were right on both points: > > 1) All these error messages have a trailing full stop in English, > > French and Japanese. > > 2) They also tend to be much more verbose than Wine's messages and > > usually form a proper sentence. > > > > I'm not going to fix point 2. > > > > But I think point 1 can and should be fixed. The question is how to do > > it without spending a month in the process or fuzzying all the existing > > translations. It probably needs to be scripted somehow and then the > > patch for both winerror.mc and the po files submitted? (or just submit > > the patch for winerror.mc and the script?) > > I'm not sure that doing 1 without 2 is all that useful. If they are > supposed to be proper sentences and are not, they will look ugly with or > without full stop. I don't think the messages below are more ugly with a full stop or even ugly at all in the first place. Invalid address. Service not active. Media changed. Property set not found. That's why I don't plan on doing 2: I consider the current messages to be terse but fine, and I'm not convinced waxing eloquent like Windows is any better. (I'm attaching my hack for checking the Windows messages, forgot to do it before) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The nice thing about meditation is that it makes doing nothing quite respectable -- Paul Dean

Jan. 25, 2012

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

by Stefan Dösinger

Am 25.01.2012 14:40 schrieb "Andrew Eikum" <aeikum(a)codeweavers.com>: > What about > changing them to WARN so that they don't print to the console by > default? Everyone knows there are workarounds, but is anyone really > gaining anything by having these flood the console? I agree with this sentiment, althougj Henri's point is valid too. The specific issue here is that proper handling of the WRITEONLY flag isn't obvious, so a proper fix hasn't happened yet and is unlilely to happen soon. The negative effects of not handling writeonly are small too, so besides the fixme spam this issue is low priority IMO

Jan. 25, 2012

Re: [2/2] scrrun: Register Scripting interfaces

by Nikolay Sivov

On 1/25/2012 15:21, Jacek Caban wrote: > On 01/25/12 11:59, Nikolay Sivov wrote: >> On 1/25/2012 12:35, Alistair Leslie-Hughes wrote: >>> Hi, >>> >>> >>> Changelog: >>> scrrun: Register Scripting interfaces >> Some of this are already used in wshom.ocx, I'm not sure which one >> should take precedence and implement that. Probably it changed in >> recent Windows versions? > Note that there is already an overlap with wscript.exe and wshom.ocx. We > may consider moving common parts to a global header if needed, but I'm > not sure we care much at this point. Also it looks like scrrun.dll it > the dependency of others. It exports DoOpenPipeStream, which suggests > that others should use it at least for streams implementation, but it's > undocumented, so it problematic for us anyway. That's what I meant, it should be implemented in one place, after that you probably won't need duplicated *.idls. > > Jacek > >

Jan. 25, 2012

Re: ieframe: Fixed a typo in IDocObjectService::FireNavigateComplete2

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16644 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3152: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3245: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2502: Test failed: expected GetOverridesKeyPath webbrowser.c:2506: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2507: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2116: Test failed: put_Resizable failed: 80004001 webbrowser.c:2117: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2121: Test failed: put_Resizable failed: 80004001 webbrowser.c:2122: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2502: Test failed: expected GetOverridesKeyPath webbrowser.c:2506: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2507: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:407: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2116: Test failed: put_Resizable failed: 80004001 webbrowser.c:2117: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2121: Test failed: put_Resizable failed: 80004001 webbrowser.c:2122: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2502: Test failed: expected GetOverridesKeyPath webbrowser.c:2506: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2507: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2792: Test failed: expected TranslateUrl webbrowser.c:2793: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2795: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2801: Test failed: ReadyState = 1, expected 4 webbrowser.c:2611: Test failed: ReadyState = 1, expected 4 webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:832: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:839: Test failed: ReadyState = 1, expected 4 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:816: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:788: Test failed: ReadyState = 1, expected 4 webbrowser.c:1547: Test failed: unexpected call GetDropTarget webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3188: Test failed: doc != doc2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:1547: Test failed: unexpected call GetDropTarget webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2658: Test failed: expected TranslateUrl webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3195: Test failed: doc != doc2 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:1547: Test failed: unexpected call GetDropTarget webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:2658: Test failed: expected TranslateUrl webbrowser.c:2665: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2792: Test failed: expected TranslateUrl webbrowser.c:2793: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2801: Test failed: ReadyState = 1, expected 4 webbrowser.c:2611: Test failed: ReadyState = 1, expected 4 webbrowser.c:832: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:839: Test failed: ReadyState = 1, expected 4 webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:611: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:614: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:618: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:622: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1536: Test failed: unexpected call GetOptionKeyPath webbrowser.c:356: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:466: Test failed: unexpected nCmdID 26 webbrowser.c:466: Test failed: unexpected nCmdID 29 webbrowser.c:986: Test failed: unexpected call GetContainer webbrowser.c:514: Test failed: unexpected call webbrowser.c:788: Test failed: ReadyState = 1, expected 4 webbrowser.c:1547: Test failed: unexpected call GetDropTarget Timeout

Jan. 25, 2012

Re: po: Remove extraneous full stops from the Japanese translation.

by Alexandre Julliard

Francois Gouget <fgouget(a)free.fr> writes: > You were right on both points: > 1) All these error messages have a trailing full stop in English, > French and Japanese. > 2) They also tend to be much more verbose than Wine's messages and > usually form a proper sentence. > > I'm not going to fix point 2. > > But I think point 1 can and should be fixed. The question is how to do > it without spending a month in the process or fuzzying all the existing > translations. It probably needs to be scripted somehow and then the > patch for both winerror.mc and the po files submitted? (or just submit > the patch for winerror.mc and the script?) I'm not sure that doing 1 without 2 is all that useful. If they are supposed to be proper sentences and are not, they will look ugly with or without full stop. -- Alexandre Julliard julliard(a)winehq.org

Jan. 25, 2012

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

by Andrew Eikum

On Wed, Jan 25, 2012 at 02:03:04PM +0100, Henri Verbeet wrote: > The code looks like it would do what was intended to me. The problem I > have with it, and I'm pretty sure I've mentioned this before, is that > reducing debug output shouldn't be a goal on its own. If you're a > user, and the messages make you feel scared/sad/whatever, just use > WINEDEBUG=-all, or even WINEDEBUG=-d3d if the other messages do make > you happy. If you're a developer, just fix the actual problem already. > There's another, similar FIXME in wined3d_swapchain_set_gamma_ramp() that floods on certain games. These messages are extremely annoying when trying to check for other, more interesting messages. What about changing them to WARN so that they don't print to the console by default? Everyone knows there are workarounds, but is anyone really gaining anything by having these flood the console? Andrew

Jan. 25, 2012

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

by Henri Verbeet

On 25 January 2012 01:25, Francois Gouget <fgouget(a)free.fr> wrote: > I don't pretend to know what Henry meant but reported_once is not > initialized. It's probably put into a zero-initialized section by the > compiler but it looks worrying to me (I believe something like this has > been debated on the Linux kernel mailing list). > Variables with static storage duration (mostly globals and things marked static) are zero-initialized before program startup unless explicitly initialized. That also means they are typically placed in .bss, which I guess is what you're referring to with the lkml discussion. The code looks like it would do what was intended to me. The problem I have with it, and I'm pretty sure I've mentioned this before, is that reducing debug output shouldn't be a goal on its own. If you're a user, and the messages make you feel scared/sad/whatever, just use WINEDEBUG=-all, or even WINEDEBUG=-d3d if the other messages do make you happy. If you're a developer, just fix the actual problem already.

Jan. 25, 2012

Re: [2/2] scrrun: Register Scripting interfaces

by Jacek Caban

On 01/25/12 11:59, Nikolay Sivov wrote: > On 1/25/2012 12:35, Alistair Leslie-Hughes wrote: >> Hi, >> >> >> Changelog: >> scrrun: Register Scripting interfaces > Some of this are already used in wshom.ocx, I'm not sure which one > should take precedence and implement that. Probably it changed in > recent Windows versions? Note that there is already an overlap with wscript.exe and wshom.ocx. We may consider moving common parts to a global header if needed, but I'm not sure we care much at this point. Also it looks like scrrun.dll it the dependency of others. It exports DoOpenPipeStream, which suggests that others should use it at least for streams implementation, but it's undocumented, so it problematic for us anyway. Jacek

Jan. 25, 2012

Re: [2/2] scrrun: Register Scripting interfaces

by Alistair Leslie-Hughes

Hi, On 25/01/2012 9:59 PM, Nikolay Sivov wrote: > On 1/25/2012 12:35, Alistair Leslie-Hughes wrote: >> Hi, >> >> >> Changelog: >> scrrun: Register Scripting interfaces > Some of this are already used in wshom.ocx, I'm not sure which one > should take precedence and implement that. Probably it changed in recent > Windows versions? > On second thoughts, does it really mater since these interfaces aren't public anyway. As long as they are defined the same it shouldn't mater. Best Regards Alistair Leslie-Hughes

Jan. 25, 2012