January 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 2/3] winecoreaudio: Implement the lock-free callback design.

by Joerg-Cyril.Hoehle＠t-systems.com

Peter Rosin wrote: >> Of the same vein, one liners like >> EnterCS >> This-> playing = StateStopped; >> LeaveCS >> are suspicious too. What does that guarantee? >Perhaps that another thread doing as below isn't fooled into >calling both one() and three()? Right. The next question is: What does that not guarantee (that you'd like to have)? Alexandre asked: >Can you point to a real app that triggers the bug? The children's use of the Mac has decreased since XMas because of a new laptop, however IIRC Sid Meyer's Pirates! was the most likely to dead-lock, more than Haegemonia: Legions of Iron (which crashes from time to time on its own). Heroes of Might & Magic V runs well. When an MS window app crashes rarely, you often don't know whether it's an app bug or not. The typical audio dead-lock scenario goes as follows: The load average / performance meter window suddenly goes to >50% green. Hitting ^C in wine't terminal window yields 100% CPU usage, half red / half green. Often enough, another ^C is not enough to kill wine and the children would call me to issue killall -INT wineserver. Better ask users what they think about winecoreaudio. Regards, Jörg Höhle

Jan. 31, 2012

Re: Updated clang-static-analyzer results (just in time for 1.4 ;))

by Jacek Caban

Hi Austin, On 01/31/12 06:11, Austin English wrote: > Enjoy: http://www.mediafire.com/?aiomfk1cr9bc61y > Using: > wine-1.4-rc1-34-g01947e0 > > LLVM commit 683d1e1d449e6e790ff4c0b6340a4bbf144ff919 / git-svn-id: > http://llvm.org/svn/llvm-project/llvm/trunk(a)149340 > 91177308-0d34-0410-b5e6-96231b3b80d8 > > austin(a)aw21 ~ $ sha1sum scan-build-2012-01-30-1.tar.bz2 > 8b3b2573c3595c805431b2ab40c6958805f37497 scan-build-2012-01-30-1.tar.bz2 This produces tons of cases in tests that we don't care about. I'd suggest running such analyzes with --disable-tests. Jacek

Jan. 31, 2012

Re: Warning report for wine-1.4-rc1

by Jerome Leclanche

Yes, i build with translations disabled. J. Leclanche On Tue, Jan 31, 2012 at 1:01 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 31 January 2012 13:41, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > > ../../../tools/wrc/po.c:127:12: warning: ‘string_has_context’ defined but > > not used [-Wunused-function] > > > http://source.winehq.org/patches/data/83335 should fix that, but this > also means you're building without libgettextpo. >

Jan. 31, 2012

Re: Warning report for wine-1.4-rc1

by Henri Verbeet

On 31 January 2012 13:41, Jerome Leclanche <adys.wh(a)gmail.com> wrote: > ../../../tools/wrc/po.c:127:12: warning: ‘string_has_context’ defined but > not used [-Wunused-function] > http://source.winehq.org/patches/data/83335 should fix that, but this also means you're building without libgettextpo.

Jan. 31, 2012

Warning report for wine-1.4-rc1

by Jerome Leclanche

Some new warnings. Inlining it instead of attaching it this time, I hope that's ok. ========== 32-bit ========== ccache gcc -msse4 -O3 -Wall -m32 -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o newstruc.o ../../../tools/wrc/newstruc.c ccache gcc -msse4 -O3 -Wall -m32 -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -fno-omit-frame-pointer -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o po.o ../../../tools/wrc/po.c ../../../tools/wrc/po.c:127:12: warning: ‘string_has_context’ defined but not used [-Wunused-function] ========== 64-bit ========== ccache gcc -msse4 -O3 -Wall -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o newstruc.o ../../../tools/wrc/newstruc.c ccache gcc -msse4 -O3 -Wall -c -I../../../tools/wrc -I. -I../../../include -I../../include -D__WINESRC__ -DINCLUDEDIR="\"/usr/include/wine\"" -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o po.o ../../../tools/wrc/po.c ../../../tools/wrc/po.c:127:12: warning: ‘string_has_context’ defined but not used [-Wunused-function] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/dbghelp -I. -I../../../include -I../../include -D__WINESRC__ -D_IMAGEHLP_SOURCE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o cpu_x86_64.o ../../../dlls/dbghelp/cpu_x86_64.c ../../../dlls/dbghelp/cpu_x86_64.c: In function ‘is_inside_epilog’: ../../../dlls/dbghelp/cpu_x86_64.c:341:14: warning: variable ‘rex’ set but not used [-Wunused-but-set-variable] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/ntdll -I. -I../../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o signal_x86_64.o ../../../dlls/ntdll/signal_x86_64.c ../../../dlls/ntdll/signal_x86_64.c: In function ‘is_inside_epilog’: ../../../dlls/ntdll/signal_x86_64.c:2632:14: warning: variable ‘rex’ set but not used [-Wunused-but-set-variable] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/oleaut32 -I. -I../../../include -I../../include -D__WINESRC__ -D_OLEAUT32_ -DCOM_NO_WINDOWS_H -DENTRY_PREFIX=OLEAUTPS_ -DPROXY_DELEGATION -DWINE_REGISTER_DLL -DPROXY_CLSID=CLSID_PSFactoryBuffer -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o safearray.o ../../../dlls/oleaut32/safearray.c ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/oleaut32 -I. -I../../../include -I../../include -D__WINESRC__ -D_OLEAUT32_ -DCOM_NO_WINDOWS_H -DENTRY_PREFIX=OLEAUTPS_ -DPROXY_DELEGATION -DWINE_REGISTER_DLL -DPROXY_CLSID=CLSID_PSFactoryBuffer -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o tmarshal.o ../../../dlls/oleaut32/tmarshal.c ../../../dlls/oleaut32/tmarshal.c:426:3: warning: #warning You need to implement stubless proxies for your architecture [-Wcpp] ../../../dlls/oleaut32/tmarshal.c: In function ‘serialize_param’: ../../../dlls/oleaut32/tmarshal.c:717:279: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:793:73: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:794:56: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:800:50: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:802:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:802:41: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:807:51: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:809:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:809:41: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:895:92: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c: In function ‘deserialize_param’: ../../../dlls/oleaut32/tmarshal.c:1076:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/oleaut32/tmarshal.c:1079:78: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c:1086:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/oleaut32/tmarshal.c:1181:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/oleaut32/tmarshal.c:1189:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/oleaut32/tmarshal.c: In function ‘init_proxy_entry_point’: ../../../dlls/oleaut32/tmarshal.c:1699:17: warning: unused variable ‘xasm’ [-Wunused-variable] ../../../dlls/oleaut32/tmarshal.c: At top level: ../../../dlls/oleaut32/tmarshal.c:1317:1: warning: ‘xCall’ defined but not used [-Wunused-function] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/setupapi -I. -I../../../include -I../../include -D__WINESRC__ -D_SETUPAPI_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o devinst.o ../../../dlls/setupapi/devinst.c ../../../dlls/setupapi/devinst.c: In function ‘SETUPDI_AllocateDeviceInfo’: ../../../dlls/setupapi/devinst.c:470:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/setupapi/devinst.c: In function ‘SETUPDI_FreeDeviceInfo’: ../../../dlls/setupapi/devinst.c:527:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c: In function ‘SetupDiGetDeviceRegistryPropertyA’: ../../../dlls/setupapi/devinst.c:3106:278: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/setupapi/devinst.c: In function ‘SetupDiGetDeviceRegistryPropertyW’: ../../../dlls/setupapi/devinst.c:3167:278: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/setupapi/devinst.c: In function ‘CM_Get_Device_IDA’: ../../../dlls/setupapi/devinst.c:3940:45: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c: In function ‘CM_Get_Device_IDW’: ../../../dlls/setupapi/devinst.c:3958:45: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c:3970:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c: In function ‘CM_Get_Device_ID_Size’: ../../../dlls/setupapi/devinst.c:3982:47: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/setupapi/devinst.c:3993:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] -- ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/winmm -I. -I../../../include -I../../include -D__WINESRC__ -D_WINMM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o winmm.o ../../../dlls/winmm/winmm.c ../../../dlls/winmm/winmm.c: In function ‘MMSYSTEM_GetMidiStream’: ../../../dlls/winmm/winmm.c:975:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ../../../dlls/winmm/winmm.c: In function ‘MMSYSTEM_MidiStream_MessageHandler’: ../../../dlls/winmm/winmm.c:1092:43: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../../../dlls/winmm/winmm.c: In function ‘midiStreamOpen’: ../../../dlls/winmm/winmm.c:1304:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] -- ccache gcc -msse4 -O3 -Wall -c -I../../../programs/winedbg -I. -I../../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wwrite-strings -Wpointer-arith -Wlogical-op -I/usr/include/freetype2 -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o be_x86_64.o ../../../programs/winedbg/be_x86_64.c ../../../programs/winedbg/be_x86_64.c: In function ‘be_x86_64_is_func_call’: ../../../programs/winedbg/be_x86_64.c:346:11: warning: variable ‘segment’ set but not used [-Wunused-but-set-variable] ========== system ========== Operating System Linux azura 3.0.0-14-generic #23-Ubuntu SMP Mon Nov 21 20:28:43 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux Configuration (32-bit) '--prefix=/usr' '--libdir=/usr/lib32' '--disable-tests' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' Configuration (64-bit) '--prefix=/usr' '--libdir=/usr/lib' '--enable-tests' '--enable-win64' '--with-alsa' '--with-freetype' '--without-gstreamer' '--with-jpeg' '--with-ldap' '--with-openal' '--with-opengl' '--with-openssl' '--with-png' '--with-x' '--with-xinerama' '--with-xinput2' '--with-xml' '--with-xrandr' '--without-capi' '--without-cms' '--without-cups' '--without-curses' '--without-fontconfig' '--without-gettextpo' '--without-gnutls' '--without-gphoto' '--without-gsm' '--without-hal' '--without-mpg123' '--without-opencl' '--without-oss' '--without-sane' '--without-tiff' '--without-v4l' '--without-xslt' '--without-xxf86vm' 'CC=ccache gcc -msse4 -O3 -Wall' Warning report for wine-1.4-rc1 generated on Tue Jan 31 12:38:27 GMT 2012 J. Leclanche

Jan. 31, 2012

Re: [PATCH 3/4] ddraw/tests: Add an IDirect3DTexture2::Load color key test

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16746 Your paranoid android. === W7PROX64 (64 bit ddraw4) === ddraw4.c:1247: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. ddraw4.c:1249: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. Timeout === TEST64_W7SP1 (64 bit ddraw4) === ddraw4.c:1247: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. ddraw4.c:1249: Test failed: Failed to get Direct3DTexture2 interface, hr 0x80004002. Timeout

Jan. 31, 2012

Re: [PATCH 2/4] ddraw/tests: Add an IDirect3DTexture::Load color key test

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16745 Your paranoid android. === WNT4WSSP6 (32 bit ddraw2) === ddraw2.c:1117: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1129: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1131: Test failed: Got unexpected hr 0x887600d7. ddraw2.c:1140: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1143: Test failed: dwColorSpaceLowValue is 0xff. ddraw2.c:1144: Test failed: dwColorSpaceHighValue is 0xff. ddraw2.c:1152: Test failed: Got unexpected hr 0x88760064. ddraw2.c:1155: Test failed: dwColorSpaceLowValue is 0xff. ddraw2.c:1156: Test failed: dwColorSpaceHighValue is 0xff. === W7PROX64 (64 bit ddraw2) === ddraw2.c:1111: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. ddraw2.c:1113: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. Timeout === TEST64_W7SP1 (64 bit ddraw2) === ddraw2.c:1111: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. ddraw2.c:1113: Test failed: Failed to get Direct3DTexture interface, hr 0x80004002. Timeout

Jan. 31, 2012

Re: [PATCH 2/2] urlmon: Properly handle relative URIs with specified host in combine_uri

by Jacek Caban

On 01/31/12 10:42, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=16738 > > Your paranoid android. > > > === W7PROX64 (64 bit uri) === > uri.c:10092: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[31].dword_props[1]. > uri.c:10095: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[31].dword_props[1]. > uri.c:10092: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[32].dword_props[1]. > uri.c:10095: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[32].dword_props[1]. > uri.c:10408: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[31].dword_props[1]. > uri.c:10411: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[31].dword_props[1]. > uri.c:10408: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[32].dword_props[1]. > uri.c:10411: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[32].dword_props[1]. It looks like some IE versions have an obvious bug. I will send another version. Jacek

Jan. 31, 2012

Re: [PATCH 2/2] urlmon: Properly handle relative URIs with specified host in combine_uri

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16738 Your paranoid android. === W7PROX64 (64 bit uri) === uri.c:10092: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[31].dword_props[1]. uri.c:10095: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[31].dword_props[1]. uri.c:10092: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[32].dword_props[1]. uri.c:10095: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[32].dword_props[1]. uri.c:10408: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[31].dword_props[1]. uri.c:10411: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[31].dword_props[1]. uri.c:10408: Test failed: Error: IUri_GetPropertyDWORD returned 0x00000001, expected 0x00000000 on uri_combine_tests[32].dword_props[1]. uri.c:10411: Test failed: Error: Expected 80, but got 0 instead on uri_combine_tests[32].dword_props[1].

Jan. 31, 2012

Re: configure.ac: remove an extraneous semicolon (Clang)

by Austin English

On Mon, Jan 30, 2012 at 23:21, Ken Thomases <ken(a)codeweavers.com> wrote: > On Jan 30, 2012, at 10:09 PM, Austin English wrote: > >> @@ -1723,7 +1723,7 @@ then >> saved_CFLAGS="$CFLAGS" >> CFLAGS="$CFLAGS -Wlogical-op -Werror" >> AC_CACHE_CHECK([for broken string.h that generates warnings with -Wlogical-op], ac_cv_c_logicalop_noisy, >> - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <string.h>]], [[char*f(const char *h,char n) {return strchr(h,n);}]])],[ac_cv_c_logicalop_noisy=no],[ac_cv_c_logicalop_noisy=yes])) >> + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <string.h>]], [[char*f(const char *h,char n) {return strchr(h,n)}]])],[ac_cv_c_logicalop_noisy=no],[ac_cv_c_logicalop_noisy=yes])) >> CFLAGS="$saved_CFLAGS" >> if test "$ac_cv_c_logicalop_noisy" = "no" >> then > > That doesn't look extraneous to me. You're right, misread the output from config.log, my mistake. > Also, static analysis of the configure test programs seems like it would produce tons of noise. Those are often not sane programs by normal standards. Actually, it's mostly clean using Clang.. -- -Austin

Jan. 31, 2012