January 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 3/5] d3d10/tests: Add a state groups test.

by Henri Verbeet

On 2 January 2012 22:22, Marvin <testbot(a)testbot.winehq.org> wrote: > === WINEBUILD (build) === > Patch failed to apply > I think this happens because bin/RetrievePatches.pl writes patches in the wrong encoding after retrieving them from http://source.winehq.org/patches/. The attached patch may help, but unfortunately it's untested. Note that http://source.winehq.org/patches/ doesn't explicitly specify an encoding either for the patches, but HTTP::Message seems to be good enough at guessing.

Jan. 3, 2012

Re: new d3d9/device.ok test always fails here, but not a regression?

by Saulius Krasuckas

* On Mon, 2 Jan 2012, Dan Kegel wrote: > > If an app stops working because some missing feature is added to an > existing DLL, it should not be tagged as a regression even though it is > from the app's point of view, right? > (Thinking of the installers for Photoshop CS3 and Visual Studio 2005.) > I wonder if we need a separate keyword for that, like 'appregression'. I would call it 'newfeature' or even 'weaknewfeature' to avoid similarity between sound of 'regression' and 'appregression'. S.

Jan. 3, 2012

Re: [PATCH 2/5] wined3d: Recognize some more Intel GPUs.

by Henri Verbeet

On 3 January 2012 03:03, Christian Inci <chris.pcguy.inci(a)gmail.com> wrote: > I'm using a Netbook with an Intel Atom N450 (Pineview, PCI ID: 8086:a011), which has 256MB under 2GB of RAM. > Personally, I think we need a way for detecting the correct VRAM size for IGD's, as it usually depends on the total RAM size. (If not already implemented. I'm not familiar with the directx subset of Wine. ;-) ) > Yeah. We'd need something like NVX_gpu_memory_info, but that's an experimental extension at the moment, and has been that for a while.

Jan. 3, 2012

Re: [PATCH 2/5] wined3d: Recognize some more Intel GPUs.

by Christian Inci

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Henri, I'm using a Netbook with an Intel Atom N450 (Pineview, PCI ID: 8086:a011), which has 256MB under 2GB of RAM. Personally, I think we need a way for detecting the correct VRAM size for IGD's, as it usually depends on the total RAM size. (If not already implemented. I'm not familiar with the directx subset of Wine. ;-) ) Kind regards, Chris -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPAmH5AAoJEBs38cNfaEHvzBsH/2Xlg5bfOc6Cudr2dIgD2XJk +ru6bHLM51tN2aacQphRNm6y1e60DEPvEiBei8hSZ0dU+mP0C/WsuOMjHIz3+LIg kXfRgqfjExqXoCaZuDnjnFpVjkdnF+NJUJlvvqTRm2hmZIbvKIdvKUagyNx8rmnG 4Bro+00qzU7KlAuYHZZptlFcCF4efndllCKonMBt2IqxpePz84Kx7YfjTABXvZS4 +JeYVlMiZ8wcCzcE3C7MHWwXToas1vAE7BHWiCQ9sUrs0Me4e7KqurvFKm690sf+ L63eD16R9xfgS/SBWFEG74iehb8bEjZNZgpxMrjdZdU7vAVjskfhnAvAjFkkNxU= =IRzs -----END PGP SIGNATURE-----

Jan. 3, 2012

Warning report for wine-1.3.36

by Jerome Leclanche

No change since 1.3.35. J. Leclanche

Jan. 2, 2012

Re: [PATCH 3/5] d3d10/tests: Add a state groups test.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16235 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

Jan. 2, 2012

[PATCH RFC 4/5] dsound: Clean up channels

by Joerg-Cyril.Hoehle＠t-systems.com

Alexander, I'm not familiar with dsound + if (ichannels > 2) + FIXME("Conversion from %u to %u channels is not implemented, falling back to stereo", ichannels, ochannels); + dsb->mix_channels = 2; Does you code support 8 channels? Look through git history, and you'll see some patches made specifically for 6 or even 8 channel audio plus some 8->2 and 2->8 conversions. Without having a 5:1 or 7:1 card, I think this gives hints as to what apps expect from conversions. Of course, there's always a risk that an old bug analysis was biased by other bugs, leading to misconceptions and misbeliefs about the actual needs and behaviour. About dsound: convert from fixed to floating point Using floats for frequencies is not bad. After all, modern mmdevapi does it too in IAudioClockAdjustment::SetSampleRate Just avoid computing byte positions from floats... BTW, AUDCLNT_STREAMFLAGS_RATEADJUST hints that the DSound mixer implements stuff that mmdevapi's mixer needs... Regards, Jörg Höhle

Jan. 2, 2012

Re: ieframe: Improved test traces

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16234 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3166: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:405: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2750: Test failed: expected TranslateUrl webbrowser.c:2751: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2752: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2758: Test failed: ReadyState = 1, expected 4 webbrowser.c:2582: Test failed: ReadyState = 1, expected 4 webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:807: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:814: Test failed: ReadyState = 1, expected 4 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:892: Test failed: ReadyState = 1, expected 4 webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3125: Test failed: doc != doc2 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2623: Test failed: expected TranslateUrl webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2843: Test failed: expected RequestUIActivate webbrowser.c:2935: Test failed: Got 0x80004002 webbrowser.c:3133: Test failed: doc != doc2 webbrowser.c:3030: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040C9B2

Jan. 2, 2012

Re: urlmon: When detecting text/html look for HEAD or BODY tags too and only in first 256 bytes

by Jacek Caban

On 01/02/12 14:53, Paul Chitescu wrote: > Changelog: > urlmon: When detecting text/html look for HEAD or BODY tags too and only in > first 256 bytes Please add a test case. > > This fixes bug #27115 and similar. > > Note that this is just a minor improvement. The entire implementation should > be changed to follow the IE way: > http://msdn.microsoft.com/en-us/library/ms775147(v=vs.85).aspx > It mostly is except that page is full of mistakes (as proven by our tests). Jacek

Jan. 2, 2012

Re: new d3d9/device.ok test always fails here, but not a regression?

by Dan Kegel

On Mon, Jan 2, 2012 at 2:58 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Obviously it's important, and we have an importance field in bugzilla > for that. But the regression keyword has a specific meaning: there has > to be a piece of code that worked and then got broken. Bugs in newly > added code cannot be regressions. > > Similarly, if we add a dll and some app starts using it and breaks, > technically that's not a regression even though the behavior got worse, > because it has always been broken, it just wasn't exercised before. OK, thanks for the clarification. If an app stops working because some missing feature is added to an existing DLL, it should not be tagged as a regression even though it is from the app's point of view, right? (Thinking of the installers for Photoshop CS3 and Visual Studio 2005.) I wonder if we need a separate keyword for that, like 'appregression'. - Dan

Jan. 2, 2012