January 2012 - Wine-Devel - list.winehq.org

Re: dinput: Support INFINITE as number of effect iterations (try 2)

by Marcel Hasler

2012/1/29 Vitaliy Margolen <wine-devel(a)kievinfo.com>: > On 01/28/2012 05:56 PM, Marcel Hasler wrote: >> >> According to the DirectX reference, IDirectInputEffect::Start accepts >> INFINITE (aka -1) for the number of iterations. However, passing -1 to >> Linux via input_event results in no effect being played at all. This >> patch sets the number of iterations to the maximum signed value >> allowed if INFINITE is passed. >> >> This fixes bug 29712. >> >> This patch supersedes patch 83233. It does the same thing but adds a >> comment and should be easier to understand. > > > In general looks good. Would be nice to point out that linux/input.h says > that any durations should not exceed 0x7fff as a maximum value. > > Please don't make code "easier to read" by adding needless if / else. Your > first patch was fine. > > Vitaliy. Thanks for your feedback. I just had another look at linux/input.h and realized I made a mistake. The member 'value' is actually declared __s32, so it really should be 0x7fffffff. Is there any predefined constant that could be used for this, rather than using a literal? This is what the code looks like at the moment: /* Linux doesn't accept INFINITE, use the maximum __s32 value instead */ event.value = (dwIterations == INFINITE) ? 0x7fffffff : dwIterations; The limit 0x7fff mentioned in input.h doesn't concern the number of iterations, just durations. I couldn't find anything on an upper limit for 'value'. I've tested 0x7fffffff and it works just fine. Marcel

Jan. 29, 2012

Re: patch msvcrt.dll file.c MSVCRT_tmpfile() open_flags --> stream_flags

by Vitaliy Margolen

On 01/29/2012 07:25 AM, fred wrote: > Hi Wine-Team > > A old bugfix on my system > You need to fix at least these issues with your e-mail: - One e-mail per patch. - All patches needs to be submitted using git format-patch.. - You have to specify your full name in From: address For more details see: http://wiki.winehq.org/SubmittingPatches Vitaliy.

Jan. 29, 2012

Re: dinput: Support INFINITE as number of effect iterations (try 2)

by Vitaliy Margolen

On 01/28/2012 05:56 PM, Marcel Hasler wrote: > According to the DirectX reference, IDirectInputEffect::Start accepts > INFINITE (aka -1) for the number of iterations. However, passing -1 to > Linux via input_event results in no effect being played at all. This > patch sets the number of iterations to the maximum signed value > allowed if INFINITE is passed. > > This fixes bug 29712. > > This patch supersedes patch 83233. It does the same thing but adds a > comment and should be easier to understand. In general looks good. Would be nice to point out that linux/input.h says that any durations should not exceed 0x7fff as a maximum value. Please don't make code "easier to read" by adding needless if / else. Your first patch was fine. Vitaliy.

Jan. 29, 2012

re: Best way to overlay a filesystem for a Wine app?

by Dan Kegel

Hi Scott, I agree with what Vrit said. Here's what I recall learning from helping package Picasa: - don't package the installer - rely on the system's update manager to pull updated versions of the package from the repository - install everything read-only into /opt/companyname/appname - start the app using a shell script that creates a wineprefix on 1st run - The wineprefix should have real directories (so the app can create files in Program Files, ugh), should symlink to all the readonly files in /opt, and have real copies of any files that can't be read-only As Vrit said, the script that creates the wineprefix is very app-specific, but once you write one, it's probably easy to write the next one. - If you are running your own repo, you should put exactly one app per repo. Otherwise you run into trouble because Canonical would want to review all the apps in the repo every time you update any one of them. So no overlay filesystem needed, symlinks should usually suffice. (Picasa also went further and bundled a snapshot of wine, too, and modified the app slightly to display unix paths, which required adding one little extension to wine. I'm sure the wine patch is around if someone wants it. And since it was in a non-ubuntu repo, it had to do a strange song and dance to avoid autoupdates being disabled when the user upgraded to a new version of ubuntu. This was considered safe because picasa was fairly well self-contained and maintained, and was unlikely to break on system updates.) In case you want to look at picasa's scripts, the download page seems to be gone, but the repo seems to still be there: http://dl.google.com/linux/deb/pool/non-free/p/picasa/picasa_3.0-current_i3… http://dl.google.com/linux/deb/pool/non-free/p/picasa/picasa_3.0-current_am… 4ecf30186ce76430a7791cee2608f47e07b015e6 picasa_3.0-current_amd64.deb fe8e83b29a10b5d663e87861d85512faea036c06 picasa_3.0-current_i386.deb Still installs and runs ok on 11.10.

Jan. 29, 2012

Re: HRBlock error. Sure would like to do my taxes on Linux using Wine.

by Nikolay Sivov

On 1/28/2012 04:12, Ken Stephens wrote: > I get the following error when trying to load HRBlock software: This is a developers list, please use bugs.winehq.org to report problems.

Jan. 29, 2012

Re: [po]updated korean resource(2012-1-28)

by Frédéric Delanoy

2012/1/28 Hwang YunSong(황윤성) <hys545(a)dreamwiz.com> > > fuzzy sections tranlated > > <http://www.dreamwiz.com/> http://www.dreamwiz.com/ > > <http://mall.shinsegae.com/display/display/planshop.do?disp_ctg_id=10049845&…> > > You should send your patch in plain text format (as all mails to wine-devel / wine-patches). Also, you shouldn't specify a date in the patch subject line (Change PO-Revision-Date in the po file instead for instance) so "[po]updated korean resource(2012-1-28)" should be sthg like "po: Update Korean translation" to conform to naming conventions (see http://wiki.winehq.org/SubmittingPatches) Frédéric

Jan. 29, 2012

Re: HRBlock error. Sure would like to do my taxes on Linux using Wine.

by Matijn Woudt

On Sat, Jan 28, 2012 at 2:12 AM, Ken Stephens <kens(a)cad2cam.com> wrote: > > I get the following error when trying to load HRBlock software: > > > > [kens(a)atlas HRBlock2011]$ wine tcauto.exe > err:winediag:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth >= 3.0.25 is in your path. Usually, you can find it in the winbind package of your distribution. Have you even looked at your output log? It seems that this might be the problem. Other than that, this list is for Wine development, not for any bugs. Try bugzilla for that [1]. - Matijn [1] http://bugs.winehq.org

Jan. 29, 2012

Re: HRBlock error. Sure would like to do my taxes on Linux using Wine.

by L. Rahyen

Please do not post messages like that to wine-devel. Post it to wine-users mailing list instead.

Jan. 29, 2012

Re: kernel32: add a stub for LCMapStringEx (try 2)

by Dmitry Timoshkov

Austin English <austinenglish(a)gmail.com> wrote: > Forgot the include changes. Forwarding it to LCMapString would be much better. -- Dmitry.

Jan. 29, 2012

Re: kernel32: add a stub for LCMapStringEx (try 2)

by Vitaliy Margolen

On 01/29/2012 10:54 AM, Dmitry Timoshkov wrote: > Austin English<austinenglish(a)gmail.com> wrote: > >> Forgot the include changes. > > Forwarding it to LCMapString would be much better. > Also could we please stop adding stubs before the release? It seems every new stub dll opens up another can of worms (or should I say bugs). If we looking to stabilize Wine it's sure is the wrong way to do it. - Vitaliy

Jan. 29, 2012