October 2012 - Wine-Devel - list.winehq.org

Re: user32: Fix the edit class extra byte count on non-x86 platforms (try 2)

by Alexandre Julliard

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -5173,10 +5173,10 @@ const struct builtin_class_descr EDIT_builtin_class = > editW, /* name */ > CS_DBLCLKS | CS_PARENTDC, /* style */ > WINPROC_EDIT, /* proc */ > -#ifdef __i386__ > - sizeof(EDITSTATE *) + sizeof(WORD), /* extra */ > -#else > +#ifdef _WIN64 > sizeof(EDITSTATE *), /* extra */ > +#else > + sizeof(EDITSTATE *) + sizeof(WORD), /* extra */ > #endif Why do you need that? -- Alexandre Julliard julliard(a)winehq.org

Oct. 4, 2012

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

by Qian Hong

Hello, On Thu, Oct 4, 2012 at 3:34 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > I just tested with japanese locale, I don't have a localized japanese > Windows here. Hello, Now I tested on my Chinese Windows, change the locale to Japanese as the steps from http://windows.microsoft.com/en-US/windows-vista/Change-the-system-locale , the result is the same as WXPPROJASP3 . Could this patch be got in first? Thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

Oct. 4, 2012

Re: [PATCH 2/2] ntoskrnl.exe: Implement MmMapLockedPagesSpecifyCache & MmUnmapLockedPages and improve MmUnlockPages stub.

by Christian Costa

Le 04/10/2012 07:28, Dmitry Timoshkov a écrit : > Christian Costa <titan.costa(a)gmail.com> wrote: > >> + /* Read memory from the client process memory */ >> + if (!ReadProcessMemory(process, (LPCVOID)((ULONG)(mdl->StartVa) + mdl->ByteOffset), (LPVOID)(((ULONG)mdl->MappedSystemVa) + mdl->ByteOffset), mdl->ByteCount, &bytes)) > This kind of casts is broken. > 2nd version of the patch fixes the casts.

Oct. 4, 2012

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

by Dmitry Timoshkov

Qian Hong <fracting(a)gmail.com> wrote: > What version of Japanese Windows did you test last time? I just tested with japanese locale, I don't have a localized japanese Windows here. -- Dmitry.

Oct. 4, 2012

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

by Qian Hong

Hello, On Thu, Oct 4, 2012 at 3:19 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > I wouldn't pay too much attention to the XP results, what about results > on newer Windows versions? I don't have Japanese version of Vista or Win7, there seems no Japanese Vista or Japanese Win7 in our winehq testbots. I tested on Japanese version of Win8 preview, and the result is the same as XP. What version of Japanese Windows did you test last time? Thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

Oct. 4, 2012

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

by Dmitry Timoshkov

Qian Hong <fracting(a)gmail.com> wrote: > On Thu, Oct 4, 2012 at 3:03 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > > On what system do you see broken results? I'm asking because i did run > > this test with japanese locale at the time I touched it last time. > > Please see https://testbot.winehq.org/JobDetails.pl?Key=21902#k207 ( > WXPPROJASP3 ) I wouldn't pay too much attention to the XP results, what about results on newer Windows versions? -- Dmitry.

Oct. 4, 2012

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

by Qian Hong

Hello, On Thu, Oct 4, 2012 at 3:03 PM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > On what system do you see broken results? I'm asking because i did run > this test with japanese locale at the time I touched it last time. Please see https://testbot.winehq.org/JobDetails.pl?Key=21902#k207 ( WXPPROJASP3 ) Thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

Oct. 4, 2012

Re: [PATCH 1/2] gdi32/tests: Fixed broken tests on non English system Part 1.

by Dmitry Timoshkov

Qian Hong <fracting(a)gmail.com> wrote: > --- > dlls/gdi32/tests/font.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) On what system do you see broken results? I'm asking because i did run this test with japanese locale at the time I touched it last time. -- Dmitry.

Oct. 4, 2012

Re: [PATCH 2/2] ntoskrnl.exe: Implement MmMapLockedPagesSpecifyCache & MmUnmapLockedPages and improve MmUnlockPages stub.

by Dmitry Timoshkov

Christian Costa <titan.costa(a)gmail.com> wrote: > + /* Read memory from the client process memory */ > + if (!ReadProcessMemory(process, (LPCVOID)((ULONG)(mdl->StartVa) + mdl->ByteOffset), (LPVOID)(((ULONG)mdl->MappedSystemVa) + mdl->ByteOffset), mdl->ByteCount, &bytes)) This kind of casts is broken. -- Dmitry.

Oct. 4, 2012

Re: [PATCH 1/2] ntoskrnl.exe: Implement IoGetCurrentProcess and KeGetCurrentThread.

by Dmitry Timoshkov

Christian Costa <titan.costa(a)gmail.com> wrote: > PEPROCESS WINAPI IoGetCurrentProcess(void) > { > - FIXME("() stub\n"); > - return NULL; > + TRACE("()\n"); > + > + /* Return current process id since PEPROCESS is opaque and drivers should not access the struct directly */ > + return (PEPROCESS)PsGetCurrentProcessId(); > } The returned pointer is supposed to be passed to various other ntoskrnl APIs, and it's needs to be a valid pointer to the kernel object. Besides many not trivial kernel drivers (if not all) really dig into internal kernel structures. Same for KeGetCurrentThread. -- Dmitry.

Oct. 4, 2012