October 2012 - Wine-Devel - list.winehq.org

Re: ImmIsUIMessageA/W

by André Hentschel

Am 03.10.2012 17:19, schrieb Aric Stewart: > Great! > > Looking at the application I have that was requiring this i have found that by adding the "IME" window class it has actually corrected its behavior. > > You are correct to have removed that redirection and I will not submit a patch to re-add it as it is incorrect. > > thanks for the help! > -aric > Great, thanks for resolving this!

Oct. 3, 2012

Re: ImmIsUIMessageA/W

by Aric Stewart

Great! Looking at the application I have that was requiring this i have found that by adding the "IME" window class it has actually corrected its behavior. You are correct to have removed that redirection and I will not submit a patch to re-add it as it is incorrect. thanks for the help! -aric On 10/2/12 5:34 PM, André Hentschel wrote: > Am 02.10.2012 21:23, schrieb Aric Stewart: >> I have a proposed patch that I have tested with World of Tanks and it does not cause http://bugs.winehq.org/show_bug.cgi?id=27554 to reappear for me on either mac or Linux. >> >> Would you be able to test it and confirm that I am not reintroduction the issues? > > doesn't work here with WoT v0.6.4, after loading i get a black screen caused by a loop: > > $WINEDEBUG=imm WINEPREFIX=~/.winewot/ wine WorldOfTanks.exe > err:menubuilder:init_xdg error looking up the desktop directory > trace:imm:DllMain 0x7df30000, 1, 0x1 > fixme:win:EnumDisplayDevicesW ((null),0,0xeb0518,0x00000000), stub! > fixme:win:EnumDisplayDevicesW ((null),1,0xeb0518,0x00000000), stub! > trace:imm:DllMain 0x7e590000, 1, (nil) > trace:imm:ImmGetContext (nil) > trace:imm:ImmGetContext (nil) > fixme:win:EnumDisplayDevicesW ((null),0,0x32eafc,0x00000000), stub! > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 3, (nil) > trace:imm:DllMain 0x7df30000, 2, (nil) > fixme:toolhelp:CreateToolhelp32Snapshot Unimplemented: heap list snapshot > fixme:toolhelp:Heap32ListFirst : stub > fixme:d3d:swapchain_init The application requested more than one back buffer, this is not properly supported. > Please configure the application to use double buffering (1 back buffer) if possible. > fixme:d3d:wined3d_swapchain_set_gamma_ramp Ignoring flags 0x1. > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 2, (nil) > fixme:avrt:AvSetMmThreadCharacteristicsW (L"Audio",0x4aaea24): stub > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 2, (nil) > fixme:d3d9:Direct3DShaderValidatorCreate9 stub > fixme:d3d:resource_check_usage Unhandled usage flags 0x8. > fixme:d3d:resource_check_usage Unhandled usage flags 0x8. > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 3, (nil) > ImportError: No module named BWAutoImport > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 2, (nil) > fixme:d3d:resource_check_usage Unhandled usage flags 0x8. > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 2, (nil) > fixme:win:EnumDisplayDevicesW ((null),0,0x32e940,0x00000000), stub! > fixme:d3d:resource_check_usage Unhandled usage flags 0x8. > fixme:d3d:resource_check_usage Unhandled usage flags 0x8. > trace:imm:ImmIsUIMessageW ((nil), 200, 0, 25166336) > trace:imm:ImmIsUIMessageW ((nil), ff, 0, 2024552) > trace:imm:ImmIsUIMessageW ((nil), ff, 0, 2024552) > fixme:thread:NtQueryInformationThread Cannot get kerneltime or usertime of other threads > trace:imm:ImmGetContext 0x20058 > trace:imm:IMM_GetThreadData Thread Data Created > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:LoadDefaultWineIME Attempting to fall back to wine default IME > trace:imm:ImeInquire > trace:imm:ImeSelect 0x14970fd8 TRUE > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:ImmCreateContext Created context 0x14970fd8 > trace:imm:ImmGetContext returning 0x14970fd8 > trace:imm:ImmGetConversionStatus 0x14970fd8 0x32f024 0x32f028 > trace:imm:ImmSetOpenStatus 0x14970fd8 1 > trace:imm:IME_WindowProc Incoming Message 0x81 (0x00000000, 0x0032ef6c) > trace:imm:ImmGetContext 0x20058 > trace:imm:ImmGetContext returning 0x14970fd8 > trace:imm:IME_WindowProc Incoming Message 0x83 (0x00000000, 0x0032edb4) > trace:imm:ImmGetContext 0x20058 > trace:imm:ImmGetContext returning 0x14970fd8 > trace:imm:IME_WindowProc Non-standard message 0x83 > trace:imm:IME_WindowProc Incoming Message 0x1 (0x00000000, 0x0032ef6c) > trace:imm:ImmGetContext 0x20058 > trace:imm:ImmGetContext returning 0x14970fd8 > trace:imm:IME_WindowProc Incoming Message 0xc (0x00000000, 0x0032e2f0) > trace:imm:ImmGetContext 0x20058 > trace:imm:ImmGetContext returning 0x14970fd8 > trace:imm:IME_WindowProc Non-standard message 0xc > trace:imm:IME_WindowProc Incoming Message 0x5 (0x00000000, 0x00010001) > trace:imm:ImmGetContext 0x20058 > trace:imm:ImmGetContext returning 0x14970fd8 > trace:imm:IME_WindowProc Non-standard message 0x5 > trace:imm:IME_WindowProc Incoming Message 0x3 (0x00000000, 0x00000000) > trace:imm:ImmGetContext 0x20058 > trace:imm:ImmGetContext returning 0x14970fd8 > trace:imm:IME_WindowProc Non-standard message 0x3 > trace:imm:ImmNotifyIME (0x14970fd8, 3, 0, 6) > trace:imm:NotifyIME 0x14970fd8 3 0 6 > trace:imm:NotifyIME IMC_SETOPENSTATUS > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:ImmSetConversionStatus 0x14970fd8 0 0 > trace:imm:ImmSetOpenStatus 0x14970fd8 1 > fixme:imm:ImmReleaseContext (0x20058, 0x14970fd8): stub > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:DllMain 0x7df30000, 2, (nil) > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > trace:imm:ImmIsUIMessageW ((nil), 282, 8, 0) > trace:imm:ImmGetDefaultIMEWnd Default is 0x20062 > trace:imm:IMM_GetImmHkl Seeking ime for keyboard 0x4070407 > trace:imm:IME_WindowProc Incoming Message 0x282 (0x00000008, 0x00000000) > trace:imm:ImeHandleNotify WM_IME_NOTIFY:IMN_SETOPENSTATUS > ( repeats endless, need to kill it with wineserver -k ) > >

Oct. 3, 2012

Re: AppDB: Could someone please block this Spammer (UCE)

by Rosanne DiMesio

On Wed, 3 Oct 2012 16:24:54 +0200 "Joerg Schiermeier" <newsletter(a)Schiermeier-Software.de> wrote: > Hello André, > > AH> In the meantime you could change your preferences in the appdb (Send email notifications) > > Than I'm in peace - that's right. > > But this have a side-effect: > I also will not be informed by AppDB if someone add a new test or a > comment in my attended applications: the mails to remain an > applications maintainer to do his work are also switched off. > > This isn't really what I want. > > My Preferences screen has an option to "Disable global e-mail notifications (only send for maintained apps)", but I'm not sure if that's something only admins have. -- Rosanne DiMesio <dimesio(a)earthlink.net>

Oct. 3, 2012

Re: AppDB: Could someone please block this Spammer (UCE)

by Joerg Schiermeier

Hello André, AH> In the meantime you could change your preferences in the appdb (Send email notifications) Than I'm in peace - that's right. But this have a side-effect: I also will not be informed by AppDB if someone add a new test or a comment in my attended applications: the mails to remain an applications maintainer to do his work are also switched off. This isn't really what I want. -- Kindly regards Joerg Schiermeier Bielefeld/Germany

Oct. 3, 2012

Re: AppDB: Could someone please block this Spammer (UCE)

by Joerg Schiermeier

Hello Rosanne, sorry for misspelling your first name in my mail before. > I tried deleting the spammer's account, and the system asked me if > I really wanted to, but it didn't delete it even after I said yes. > I'm not sure that would have helped anyway, as he could easily just > create a new account. couldn't you simply reset the spammers password? So if his account is powned he will have to get a new one. > We really do need some sort of moderation for > AppDB comments similar to what's on the forum. In general this is a good idea. -- Regards Joerg Schiermeier Bielefeld/Germany

Oct. 3, 2012

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error

by Marcus Meissner

On Tue, Oct 02, 2012 at 01:19:37PM +0200, Jacek Caban wrote: > Hi Marcus, > > On 10/01/12 23:00, Marcus Meissner wrote: > > Hi, > > > > Various coverity issues complain about user-after-free scenarios, > > all involving this code path. > > > > I strongly think if call_ret signals error, we also need to return > > an error condition to avoid the callers from proceeding as if nothing > > happened. > > > > Second reiteration with Jaceks comment applied > > Sorry for not catching this later, I was concentrated on your comment > instead of the code, but the important thing is that true call_ret means > success (and wininet doing request asynchronously is signalled as an > error). It means that in this case we want to return RPC_S_OK. What is > the exact problem? Ok, my fix was likely bad. Coverity is spotting use-after-free scenarios. CID 715805 rpcrt4_http_prepare_in_pipe() /* prepare in pipe */ status = send_echo_request(in_request, async_data, cancel_event); if (status != RPC_S_OK) return status; ... here it thinks async_data might be returned freed in the non-async case ... memset(&buffers_in, 0, sizeof(buffers_in)); buffers_in.dwStructSize = sizeof(buffers_in); /* FIXME: get this from the registry */ buffers_in.dwBufferTotal = 1024 * 1024 * 1024; /* 1Gb */ prepare_async_request(async_data); ... but it is again referenced here ... ret = HttpSendRequestExW(in_request, &buffers_in, NULL, 0, 0); status = wait_async_request(async_data, ret, cancel_event); if (status != RPC_S_OK) return status; send_echo_request() looks like: static RPC_STATUS send_echo_request(HINTERNET req, RpcHttpAsyncData *async_data, HANDLE cancel_event) { DWORD bytes_read; BYTE buf[20]; BOOL ret; RPC_STATUS status; prepare_async_request(async_data); ret = HttpSendRequestW(req, NULL, 0, NULL, 0); status = wait_async_request(async_data, ret, cancel_event); if (status != RPC_S_OK) return status; status = rpcrt4_http_check_response(req); if (status != RPC_S_OK) return status; InternetReadFile(req, buf, sizeof(buf), &bytes_read); /* FIXME: do something with retrieved data */ return RPC_S_OK; } so with the bumped reference count via prepare_async_request I think it might be safe here. (and so is a coverity misdetection I think now) Ciao, Marcus

Oct. 3, 2012

Re: AppDB: Could someone please block this Spammer (UCE)

by André Hentschel

Am 03.10.2012 05:01, schrieb Rosanne DiMesio: > On Tue, 2 Oct 2012 23:48:22 +0200 > "newsletter [at] Schiermeier-Software" <newsletter(a)Schiermeier-Software.de> wrote: > >> >> Please Rosane, help us...! >> >> Thanks a lot! >> > > I'd love to, but if the AppDB has a way to ban users, I don't have access to it. I've already deleted the comments from the Office 2007 page (twice), and it looks like someone else deleted them from the Photoshop page. > > I tried deleting the spammer's account, and the system asked me if I really wanted to, but it didn't delete it even after I said yes. I'm not sure that would have helped anyway, as he could easily just create a new account. We really do need some sort of moderation for AppDB comments similar to what's on the forum. > > The spammer's display name is menujusukses, email is rian_barkah88(a)ymail.com. > > The delete routines look good, can't tell why they don't work. I can't find a ban function... @Alexander: could you have a look at this problem, this user seems to spam some days now and Rosane can't delete him. Maybe we should forward wine-bugs to his e-mail address to spam back ;) -- Best Regards, André Hentschel

Oct. 3, 2012

Re: [1/2] vbscript: Support vb* constants for message box buttons

by Nikolay Sivov

On 10/3/2012 13:54, Jacek Caban wrote: > Hi Nikolay, > > On 10/03/12 13:34, Nikolay Sivov wrote: >> Support vb* constants for message box buttons > How about using MB_* constants from winuser.h instead of hardcoding them > here? Other than that, the patch looks good to me. > > Jacek Sure, that would be cleaner. I sent updated version, thanks.

Oct. 3, 2012

Re: imm32: have IMM class return TRUE for WM_QUERYENDSESSION

by Aric Stewart

Looking over my documentation it is explicit about many messages that cannot be passed to DefWndProc, but it looks like we can us it. I will revise the patch and send that. -aric On 10/3/12 4:31 AM, Alexandre Julliard wrote: > Aric Stewart <aric(a)codeweavers.com> writes: > >> resolves bug 31832 >> --- >> dlls/imm32/imm.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) > > Is there any reason why we are not simply calling DefWindowProc? >

Oct. 3, 2012

Re: [2/2] vbscript: Support vb* constants for message box return value (try2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21981 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Oct. 3, 2012