October 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] vbscript: Added Left() implementation

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21919 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Oct. 1, 2012

Re: [1/4] Assorted spelling fixes.

by Julian Rüger

Hi Francois, > - * size [I] How much percent of cache space should be free. > + * size [I] How many percents of the cache should be free. Maybe something like "Precentage of cache that should be free" would sound more natural. However I'm not sure of the intended meaning here, it could be "freed". Best regards, Julian

Oct. 1, 2012

Re: mshtml: Implement IHTMLFrameBase_put_name()

by Nikolay Sivov

On 10/1/2012 11:14, Jacek Caban wrote: > Hi Nikolay, > > On 09/30/12 20:36, Nikolay Sivov wrote: >> http://bugs.winehq.org/show_bug.cgi?id=31835 > The code may be simple and obvious, but I'd still like to see a test. A > simple call should be enough just to make sure it's executed when I test > new Gecko builds. > > Jacek Sure, will do.

Oct. 1, 2012

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error

by Jacek Caban

Hi Marcus, On 09/29/12 11:44, Marcus Meissner wrote: > Hi, > > Various coverity issues complain about user-after-free scenarios, > all involving this code path. > > I strongly think if call_ret signals error, we also need to return > an error condition to avoid the callers from proceeding as if nothing > happened. Agreed, thanks for catching it. > Ciao, Marcus > --- > dlls/rpcrt4/rpc_transport.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c > index 686ce68..e572b78 100644 > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c > @@ -1882,7 +1882,7 @@ static RPC_STATUS wait_async_request(RpcHttpAsyncData *async_data, BOOL call_ret > > if(call_ret) { > RpcHttpAsyncData_Release(async_data); > - return RPC_S_OK; > + return call_ret; /* The Http* status codes map into the RPC_S namespace */ Not really, Http* APIs return BOOL and GetLastError() call is needed to get error code. AFAIR, when I tested this code, most HTTP-related errors were translated to RPC_S_SERVER_UNAVAILABLE by rpcrt4. That may be a better choice here as well. Jacek

Oct. 1, 2012

Re: mshtml: Implement IHTMLFrameBase_put_name()

by Jacek Caban

Hi Nikolay, On 09/30/12 20:36, Nikolay Sivov wrote: > http://bugs.winehq.org/show_bug.cgi?id=31835 The code may be simple and obvious, but I'd still like to see a test. A simple call should be enough just to make sure it's executed when I test new Gecko builds. Jacek

Oct. 1, 2012

Re: d3dx9_36 [patch 2/5, try 4]: Speed-up some tests.

by Rico Schüller

On 01.10.2012 03:28, Nozomi Kodama wrote: > + for (order = 0; order <= D3DXSH_MAXORDER + 1 ; order++) Well, I'm not sure what you are doing with the spaces ... I say it again, if you got a comment, read it carefully take a look at your code and fix it. I mentioned white space issues a couple of times. And I think I mentioned the problem already ... I accidentally send it to wine-patches instead of wine-devel (sorry, this was my mistake): http://www.winehq.org/pipermail/wine-patches/2012-September/118230.html. Cheers Rico

Oct. 1, 2012

Re: d3dx9_36 [patch 1/5, try 4]: Implement D3DXSHMultiply4

by Rico Schüller

On 01.10.2012 03:27, Nozomi Kodama wrote: > I used FLOAT * WINAPI, though I don't like it. Yeah, that's not much of an issue... and this is not the showstopper. > + TRACE("(out %p, a %p, b %p)\n", out, a, b); What I'm a bit curious about is, why do you reinvent a new style in a new patch (see http://www.winehq.org/pipermail/wine-devel/2012-September/097133.html and http://www.winehq.org/pipermail/wine-devel/2012-September/097131.html)? I'm not sure if my wording is that hard to understand. For me the preferred option for the TRACE is: "TRACE("out %p, a %p, b %p\n", out, a, b);" And the one also used in the file is: "TRACE("(%p, %p, %p)\n", out, a, b);" Please use exactly one of those. Not mixture, no extra brackets... Sorry, I should have written an answer to the (try 3), but I wasn't fast enough. Cheers Rico

Oct. 1, 2012

Re: ws2_32: Fix TRACE format in WS_getsockname (try 2)

by Dmitry Timoshkov

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > - TRACE("socket: %04lx, ptr %p, len %8x\n", s, name, *namelen); > + TRACE("socket: %04lx, ptr %p, len %08x\n", s, name, namelen?*namelen:0); Adding some spaces to make this slightly more readable wouldn't hurt IMHO. -- Dmitry.

Oct. 1, 2012

Re: ws2_32: Fix TRACE format in WS_getsockname

by Dmitry Timoshkov

Bruno Jesus <00cpxxx(a)gmail.com> wrote: > @@ -2444,7 +2444,7 @@ int WINAPI WS_getsockname(SOCKET s, struct WS_sockaddr *name, int *namelen) > int fd; > int res; > > - TRACE("socket: %04lx, ptr %p, len %8x\n", s, name, *namelen); > + TRACE("socket: %04lx, ptr %p, len %08x\n", s, name, *namelen); > > /* Check if what we've received is valid. Should we use IsBadReadPtr? */ > if( (name == NULL) || (namelen == NULL) ) Taking into account check after the trace printing the contents of namelen should be replaced by printing its pointer. -- Dmitry.

Oct. 1, 2012

Re: [PATCH 5/5] ntoskrnl.exe: Implement IoAllocateMdl.

by Dmitry Timoshkov

Christian Costa <titan.costa(a)gmail.com> wrote: > PMDL WINAPI IoAllocateMdl( PVOID VirtualAddress, ULONG Length, BOOLEAN SecondaryBuffer, BOOLEAN ChargeQuota, PIRP Irp ) > { > PMDL mdl; > + ULONG address = (ULONG)VirtualAddress; This won't work on 64-bit. > + mdl->StartVa = (PVOID)page_address; and this. > + mdl->ByteCount = Length; > + mdl->ByteOffset = address - page_address; Probably the type of size holding parameters/variables should be SIZE_T. -- Dmitry.

Oct. 1, 2012