November 2012 - Wine-Devel - list.winehq.org

Re: [spam-high] Re: [PATCH 3/7] advapi: Implement GetNamedSecurityInfoW on top of GetSecurityInfo (try 3).

by Charles Davis

On Nov 4, 2012, at 10:11 PM, Erich E. Hoover wrote: > If the object is resolvable with CreateFile then it doesn't matter if > it's a file, directory, named pipe, or some other miscellaneous thing. True, and of course by "file" I meant "any object that can act like a file," which includes directories, pipes, devices, etc. I will add that the 'type' parameter also affects how the path that gets passed in is parsed. But you're right, CreateFile() will fail anyway for those kinds of paths, so I guess it's OK to ignore the 'type' for now. > I templated part 2 after how GetSecurityInfo works (it also ignores > the SE_OBJECT_TYPE), I'm not even sure what type of object you'd call > the function with where it might matter. I can name at least four: registry keys (HKEY), services (SC_HANDLE), window stations (HWINSTA), and desktops (HDESK). On native, all those types of objects are protected with ACLs, and all those types have unique functions for manipulating them. But you don't have to worry about that for now; just supporting file-like objects is fine right now, especially since Wine only supports one user per prefix right now, so objects that exist in the file-system are the only ones where we have to worry about other users. (Besides, Wine probably doesn't even support multiple window station and desktop objects anyway...) Sorry for the noise. Chip > > Erich > > On Sun, Nov 4, 2012 at 3:15 PM, Charles Davis <cdavis5x(a)gmail.com> wrote: >> >> On Nov 4, 2012, at 1:30 AM, Erich E. Hoover wrote: >> >>> This patch implements GetNamedSecurityInfoW on top of the more >>> fundamental GetSecurityInfo function, permitting the return of more >>> accurate ownership information for files. PlayReady uses this >>> information to determine if its files have the appropriate >>> permissions, without the correct permissions it will attempt to recopy >>> the individualization file (and fail). Additionally, this patch adds >>> tests for retrieving the ACL information set on files. >>> >>> This version fixes some problems in the tests on older Windows >>> versions, sorry I didn't catch that earlier. It now also fixes a >>> mistake I made between testing try 2 and pushing it out :/ >> >>> + hfile = CreateFileW( name, access, FILE_SHARE_READ|FILE_SHARE_WRITE|FILE_SHARE_DELETE, >>> + NULL, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, 0 ); >> Only works on files right now, huh? You might then want to check to make sure the caller says it's a file by comparing the 'type' against SE_FILE_OBJECT, and return ERROR_CALL_NOT_IMPLEMENTED if they didn't. After all, part of the point of that parameter is to tell you which function you need to call to open the object in the first place :). (Same for patch 2.) >> >> Chip >>

Nov. 5, 2012

Re: [PATCH 2/4] msvcrt: Improved _atoflt_l precision

by Alexandre Julliard

Piotr Caban <piotr(a)codeweavers.com> writes: > --- > dlls/msvcrt/string.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M msvcr90.dll -T ../../.. -p msvcr90_test.exe.so msvcr90.c && touch msvcr90.ok msvcr90.c:895: Test failed: got ret 0, expected ret 4, for 1e-39 make: *** [msvcr90.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

Nov. 5, 2012

Netflix (was: [PATCH 1/7] advapi: Implement SetSecurityInfo on top of NtSetSecurityObject.)

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2012-11-04 06:46, schrieb Erich E. Hoover: > Once this patch series has been applied then Netflix (using > Silverlight 4.x) will successfully load and play movies and TV > shows, Out of curiosity, how does the video playback part of Netflix perform? I imagine that it is using DirectDraw overlays or Direct3D9 YUV surfaces, which are somewhat supported, but have many rough edges. Is playback performant enough for full HD videos? How does the CPU usage compare to Windows? Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJQl9YQAAoJEN0/YqbEcdMwlF4P/3s2AiUWuc9XBLKeWqEfPdwq SLt0Hmx9MVHbiWt9SojsLZDGc79OImA18Ay8k98T3igH30KHLm7lUbCcYrczrVsQ cFrJ0Lrz5clYWrJR6bw0UckQEYXYdgb+EZte4laq9Y7HoIsg+gw9Z+tF86qDarZ+ +DNAOejD5ybiUBEBZ0JvBr/pSmsj9OXFLFJ1CxxZituUMnyk/mK7Uet+1Pid/XqA lIkid9NQa7Wi/+EB3XD82mUtTopgyzWGeT36GszFnybWQCBjQ0jjAj4Qip5RQZ61 CgBREvjCs/qqPA15BinHcpCWZytC7HjROwHEpmm4I3UssSDBXwCkqQ0Q4mPIwRct rOsvWdZmoYHT/aI7JbJo4y9oWBackGeJrtiaXOigoXE1z/v+dtu/ha9yhOj4rUsd wEVyffTsqsEID4XJLkchrHB0uWe/YQrnNTLKkjVEWvaogl1lqJr79wiq7Z46iH0D U63XQQnqMgw1RXnvd8YjqWgUFvOnkveXrHxKPeYQkNxN88hvXLdPjah/tWBZpt8q 9IDURMZ/kNdJNF7E5ziwu0ulGZ9dsvQ8YtbIh6oWP+7zXax3m8N7Gl7dkKl+ltOS 1UgJgTuXkEnv25FDPFucWN2/hlrw9AT3msghl3n4ItuX5NouhlU7MvZR2P+9P/TC bTK3AwL1hmZZxLgCgWWd =QJTC -----END PGP SIGNATURE-----

Nov. 5, 2012

Re: [PATCH 5/5] jscript: Added more enumerable attribute tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22760 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Nov. 5, 2012

Re: Call for papers - FOSDEM 2013

by Julian Rüger

It would be really cool if someone could manage to record some talks and upload them to eg. youtube, for those who can't attend. I would be especially interested in Stefan's proposed talk. Thanks everyone and have a nice FOSDEM! Best regards, Julian Am Freitag, den 02.11.2012, 14:26 +0100 schrieb Stefan Dösinger: > Am 2012-11-01 19:59, schrieb Jeremy White: > > So I would like to formally 'call for papers' for FOSDEM. Please > > email suggested topics to wineconf(a)winehq.org, where I'll collate > > them and piece them into a schedule. > Will this be talk-only or do you also plan written conference > proceedings? I suspect it'll be talk-only. > > I propose a talk about the status of 3D rendering support for games on > Linux. I don't intend to make this highly Wine-specific, and instead > include the state of Mesa, fglrx, nvidia and OSX graphics drivers. >

Nov. 5, 2012

Re: [2/2] opengl32: Implement the wglUseFontOutlines WGL_FONT_LINES format (resend)

by Alexandre Julliard

Sam Edwards <cfsworks(a)gmail.com> writes: > Also review carefully: I use if(format) instead of if(format == > WGL_FONT_POLYGONS) because WGL_FONT_POLYGONS isn't defined anywhere in > Wine. You should add the define in the appropriate header and make use of it. -- Alexandre Julliard julliard(a)winehq.org

Nov. 5, 2012

Re: [PATCH 2/5] mstask/tests: Avoid test failures on NT4

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > This is not visible with winetest (mstask.dll: n/a), but > testbot results for mstask test patches would be marked as failed. That's a testbot bug. -- Alexandre Julliard julliard(a)winehq.org

Nov. 5, 2012

Re: [PATCH 1/5] mstask: Implement ITaskScheduler_GetTargetComputer

by Alexandre Julliard

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -28,6 +28,22 @@ typedef struct > LONG ref; > } TaskSchedulerImpl; > > +static LPWSTR get_unc_computername(void) > +{ > + static WCHAR buffer[MAX_COMPUTERNAME_LENGTH + 3]; /* extra space for two '\' and a zero */ > + DWORD len = MAX_COMPUTERNAME_LENGTH + 1; /* extra space for the zero */ > + > + if (*buffer) > + return buffer; > + > + if (!GetComputerNameW(buffer + 2, &len)) > + return NULL; > + > + buffer[1] = '\\'; > + buffer[0] = '\\'; > + return buffer; > +} You don't need a static buffer. -- Alexandre Julliard julliard(a)winehq.org

Nov. 5, 2012

Re: [spam-high] Re: [PATCH 3/7] advapi: Implement GetNamedSecurityInfoW on top of GetSecurityInfo (try 3).

by Erich E. Hoover

If the object is resolvable with CreateFile then it doesn't matter if it's a file, directory, named pipe, or some other miscellaneous thing. I templated part 2 after how GetSecurityInfo works (it also ignores the SE_OBJECT_TYPE), I'm not even sure what type of object you'd call the function with where it might matter. Erich On Sun, Nov 4, 2012 at 3:15 PM, Charles Davis <cdavis5x(a)gmail.com> wrote: > > On Nov 4, 2012, at 1:30 AM, Erich E. Hoover wrote: > >> This patch implements GetNamedSecurityInfoW on top of the more >> fundamental GetSecurityInfo function, permitting the return of more >> accurate ownership information for files. PlayReady uses this >> information to determine if its files have the appropriate >> permissions, without the correct permissions it will attempt to recopy >> the individualization file (and fail). Additionally, this patch adds >> tests for retrieving the ACL information set on files. >> >> This version fixes some problems in the tests on older Windows >> versions, sorry I didn't catch that earlier. It now also fixes a >> mistake I made between testing try 2 and pushing it out :/ > >> + hfile = CreateFileW( name, access, FILE_SHARE_READ|FILE_SHARE_WRITE|FILE_SHARE_DELETE, >> + NULL, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, 0 ); > Only works on files right now, huh? You might then want to check to make sure the caller says it's a file by comparing the 'type' against SE_FILE_OBJECT, and return ERROR_CALL_NOT_IMPLEMENTED if they didn't. After all, part of the point of that parameter is to tell you which function you need to call to open the object in the first place :). (Same for patch 2.) > > Chip >

Nov. 5, 2012

Re: [PATCH 3/7] advapi: Implement GetNamedSecurityInfoW on top of GetSecurityInfo (try 3).

by Charles Davis

On Nov 4, 2012, at 1:30 AM, Erich E. Hoover wrote: > This patch implements GetNamedSecurityInfoW on top of the more > fundamental GetSecurityInfo function, permitting the return of more > accurate ownership information for files. PlayReady uses this > information to determine if its files have the appropriate > permissions, without the correct permissions it will attempt to recopy > the individualization file (and fail). Additionally, this patch adds > tests for retrieving the ACL information set on files. > > This version fixes some problems in the tests on older Windows > versions, sorry I didn't catch that earlier. It now also fixes a > mistake I made between testing try 2 and pushing it out :/ > + hfile = CreateFileW( name, access, FILE_SHARE_READ|FILE_SHARE_WRITE|FILE_SHARE_DELETE, > + NULL, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS, 0 ); Only works on files right now, huh? You might then want to check to make sure the caller says it's a file by comparing the 'type' against SE_FILE_OBJECT, and return ERROR_CALL_NOT_IMPLEMENTED if they didn't. After all, part of the point of that parameter is to tell you which function you need to call to open the object in the first place :). (Same for patch 2.) Chip

Nov. 4, 2012