December 2012 - Wine-Devel - list.winehq.org

Re: wshom: Basic support for REG_SZ values in RegRead()

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23189 Your paranoid android. === WINEBUILD (build) === Can't determine base name

Dec. 3, 2012

Re: wshom: Basic support for REG_SZ values in RegRead()

by Nikolay Sivov

On 12/3/2012 15:35, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/JobDetails.pl?Key=23189 > > Your paranoid android. > > > === WINEBUILD (build) === > Can't determine base name Hmm, my guess would be that it's .ocx extension that confuses it?

Dec. 3, 2012

Re: [PATCH 1/4] kernel32: Support UTF-7 in MultiByteToWideChar.

by Dmitry Timoshkov

Alex Henrie <alexhenrie24(a)gmail.com> wrote: > I came back to the problem of UTF-7 support and made some improvements > to my previous submission. The tests are now more stringent, especially > in regard to null terminator checking, and they test the srclen > parameter more thoroughly now as well. > > I also noticed that a related test for error checking was marked > todo_wine. The fix was trivial and is included as a fourth patch. > > Please let me know what you think. I'm willing to put some more effort > into this. Why don't you put it in libs/wine where other unicode conversion routines are implemented? Also you probably need to add support for composition/ surrogates like other implementations do. -- Dmitry.

Dec. 3, 2012

Re: comdlg32: Resize Find dialog to fit translations

by Dmitry Timoshkov

Aurimas Fišeras <aurimas(a)gmail.com> wrote: > What about something like the attached patch? I resized both check boxes > and the direction group, positioned radio buttons in the direction group > one above the other. > > I checked this dialog on Windows XP Lithuanian UI, and it had similar > differences from the English one. That's an acceptable approach. -- Dmitry.

Dec. 3, 2012

Re: [PATCH 4/6] server: Store and return security attributes with extended file attributes (try 5).

by Anssi Hannula

Hi, 27.11.2012 00:45, Erich E. Hoover kirjoitti: > This patch adds the ability to store and retrieve the security > attributes of a file by turning them into extended file attributes (if > available). These attributes are stored in the attribute > "user.WINEACL" in the form: > <ACE1>;<ACE2>;...;<ACEN> > where each ACE takes the form: > <Type>,<Flags>,<Mask>,<SID> > With this information it is possible to more accurately store the ACL > information files, and also allows patch 5 to tell whether it's > necessary for an ACL to be inherited by a contained file in a folder. I don't see the need for an uppercase "WINEACL" in the attribute name, especially since all the examples in e.g. attr(5) are lowercase. Moreover, [1] recommends using application specific namespaces in the attribute name, so IMHO a better attribute name would be "user.wine.acl". </bikeshedding> Thanks for your work on this :) [1] http://www.freedesktop.org/wiki/CommonExtendedAttributes -- Anssi Hannula

Dec. 3, 2012

Re: testbot failures in advapi32 (security)

by Detlef Riekenberg

Dec. 2, 2012

Re: Small patch to make Adobe Lightroom 4.x work with wine 1.5.17

by Marcus Meissner

Hi, Sorry for not answering sooner, I was distracted by work and a broken workstation at home :/ On Sun, Dec 02, 2012 at 04:19:24PM +0100, Roland Baudin wrote: > Hi, > > here is a small patch that allows me to make Adobe Photoshop > Lightroom 4.x work very well with wine 1.5.17. > > First let me recall that Adobe Photoshop Lightroom is *the* catalog > and raw development application for professional photographers and > hobbyists. > > The patch has two parts. The first part essentially modifies the > file sync.c from the kernel32 dll and implements some functions > related to Condition Variables. I found an original patch by Marcus > Meissner and I fixed it because it led to a 100% CPU load. I tried > to contact Marcus to discuss my changes with him, but he didn't > answer and so I submit my changes to this list, otherwise my work > would be lost... So generally, my patch is basically just a "hack" to get it work. While it does work mostly, it is not the best and correct implementation, and Alexandre wants a correct implementation of Condition Variables. I don't have the time to do it right currently. :/ > The second part modifies the file menu.c from the user32 dll. It > allows the menu bar to appear in Lightroom when the windows version > is set to winxp. I'm not the author of this patch but if I remember > well, I found it several monthes ago somewhere in the wine patch > list. This might be easier to get in as above, but it should be seperated out and likely needs a testcase. Perhaps the other gurus can take it ;) > With the patch applied, I was able to run Lightroom 4.2 flawessly, > and it's very stable. I (and other users) have found only minor bugs > (like a limitation of the number of shown thumbnails to 455 per > folder on a 22 inches display) but the patch is a huge step forward > for Lightroom. > > Here is a link where I explain the whole installation procedure > (message #34) : http://www.pentaxforums.com/forums/digital-processing-software-printing/159… > > I apologize because I don't have the skills to write a test for the > functions of this patch... No worries, even feedback and hacky patches help to show where Wine can go :) Ciao, Marcus

Dec. 2, 2012

Re: comdlg32: Resize Find dialog to fit translations

by Aurimas Fišeras

2012.12.02 20:32, Dmitry Timoshkov rašė: > Aurimas Fišeras <aurimas(a)gmail.com> wrote: > >>>> Controls resized to fit translations for more languages. Tested with >>>> resource editor. >>> >>> Did you see a comment in that file just before dialog templates? >>> >> Hello, >> I obviously didn't notice that comment. >> >> Why do we have such a limitation? > > Applications that use custom dialog templates and subclass the original > ones (or rather the algorithm in comctl32 that resizes custom dialogs) > depend on this . > >> I checked the sizes of this dialog before conversion to po files [1] and >> they were quite different between various languages. > > If the dialog sizes differ from Windows templates - that's a bug and > should be fixed. > I see. What about something like the attached patch? I resized both check boxes and the direction group, positioned radio buttons in the direction group one above the other. I checked this dialog on Windows XP Lithuanian UI, and it had similar differences from the English one.

Dec. 2, 2012

Re: comdlg32: Resize Find dialog to fit translations

by Dmitry Timoshkov

Aurimas Fišeras <aurimas(a)gmail.com> wrote: > >> Controls resized to fit translations for more languages. Tested with > >> resource editor. > > > > Did you see a comment in that file just before dialog templates? > > > Hello, > I obviously didn't notice that comment. > > Why do we have such a limitation? Applications that use custom dialog templates and subclass the original ones (or rather the algorithm in comctl32 that resizes custom dialogs) depend on this . > I checked the sizes of this dialog before conversion to po files [1] and > they were quite different between various languages. If the dialog sizes differ from Windows templates - that's a bug and should be fixed. -- Dmitry.

Dec. 2, 2012

Small patch to make Adobe Lightroom 4.x work with wine 1.5.17

by Roland Baudin

Hi, here is a small patch that allows me to make Adobe Photoshop Lightroom 4.x work very well with wine 1.5.17. First let me recall that Adobe Photoshop Lightroom is *the* catalog and raw development application for professional photographers and hobbyists. The patch has two parts. The first part essentially modifies the file sync.c from the kernel32 dll and implements some functions related to Condition Variables. I found an original patch by Marcus Meissner and I fixed it because it led to a 100% CPU load. I tried to contact Marcus to discuss my changes with him, but he didn't answer and so I submit my changes to this list, otherwise my work would be lost... The second part modifies the file menu.c from the user32 dll. It allows the menu bar to appear in Lightroom when the windows version is set to winxp. I'm not the author of this patch but if I remember well, I found it several monthes ago somewhere in the wine patch list. With the patch applied, I was able to run Lightroom 4.2 flawessly, and it's very stable. I (and other users) have found only minor bugs (like a limitation of the number of shown thumbnails to 455 per folder on a 22 inches display) but the patch is a huge step forward for Lightroom. Here is a link where I explain the whole installation procedure (message #34) : http://www.pentaxforums.com/forums/digital-processing-software-printing/159… I apologize because I don't have the skills to write a test for the functions of this patch... Have a nice day, RB -- X File Explorer http://roland65.free.fr/xfe TexMaths http://roland65.free.de/texmaths Toutes Choses http://roland65.free.fr/ttc

Dec. 2, 2012