December 2012 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] oleaut32/tests: Add test for ITypeInfo2_fnGetContainingTypeLib (Try 3, resend)

by Nikolay Sivov

On 12/20/2012 14:50, Tatyana Fokina wrote: Hi, Tatyana. Main problem is that your test will crash if run without patch 2/2, that's not how it should be done. You need to merge these patches together to keep tests working or send implementation fix first, so next test patch will work. > + hr = ITypeInfo2_GetContainingTypeLib(ti2, (ITypeLib **)&tl, &Index); > + ok(hr == S_OK, " ITypeInfo2_GetContainingTypeLib failed on Index\n"); > + if(tl) ITypeLib_Release(tl); You don't need a cast here. > + hr = ITypeInfo2_GetContainingTypeLib(ti2, NULL, &Index); > + ok(hr == S_OK, " ITypeInfo2_GetContainingTypeLib failed on ITypeLib = NULL\n"); Please test index value here and above to make sure it really returns something.

Dec. 20, 2012

Re: oleaut32: Indentation Fix

by Alexandre Julliard

Andrew Talbot <andrew.talbot(a)talbotville.com> writes: > Changelog: > oleaut32: Indentation Fix. Please avoid reformatting hundreds of lines for no reason. Only fix the parts where the indentation is actually incorrect. -- Alexandre Julliard julliard(a)winehq.org

Dec. 20, 2012

Re: msxml3: Add custom handling for DISPID_VALUE for node map

by Nikolay Sivov

On 12/19/2012 17:22, Jacek Caban wrote: > On 12/19/12 08:24, Nikolay Sivov wrote: >> Add custom handling for DISPID_VALUE for node map > If this has to be done for all IDispatchEx objects with DISPID_VALUE, it > may be worth considering changing dispex.c. Something like: > > if(id == DISPID_VALUE && wFlags == DISPATCH_METHOD) > wFlags |= DISPATCH_PROPERTYGET; > > before ITypeInfo::Invoke call should do the trick and replace both this > patch and already committed node list patch. So I did more testing and it doesn't work like that for all DISPID_VALUE methods, what a surprise: http://www.winehq.org/pipermail/wine-patches/2012-December/120928.html Do you think it's still better to centrally change it in dispex.c and wrongly accept DISPATCH_METHOD when we shouldn't? > > Cheers, > Jacek

Dec. 20, 2012

Re: Need help to install Xlib/xfree86 devlopnemt packeg in ubuntu 10 LTS

by Hamid Lohar

I am installing it from source file (wine 1.5.x.tar.bz2) by running wine install i get error "x support not found, wine can not fount x, please instal xlib/xfree86 devlopment files". That is the error. Sorry for late reply. On 12/7/12, Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > On Thu, Dec 6, 2012 at 3:32 PM, Hamid Lohar <hmdlohar(a)gmail.com> wrote: >> Dear sir, >> I am installing wine 1.3 from source file but i getting fail to >> install beacose of Xlib/xfree86 devlopnemt packeg so i neet that >> packege please help me. >>> > > You don't provide enough information about your issue: what's the > error message? distrib? > These questions should be asked on wine-users/forum anyway (also the > only supported versions are latest 1.4.x and 1.5.x). >

Dec. 20, 2012

Re: windowscodecs: Adjust a type in PngDecoder_Frame_GetColorContexts.

by Gerald Pfeifer

On Sat, 15 Dec 2012, Alexandre Julliard wrote: >> Current snapshots of GCC 4.8.0 issue a warning about some of the >> new code in windowscodecs/pngformat.c: >> >> pngformat.c: In function 'PngDecoder_Frame_GetColorContexts': >> pngformat.c:882:5: warning: passing argument 5 of 'ppng_get_iCCP' from >> incompatible pointer type [enabled by default] >> if (ppng_get_iCCP(This->png_ptr, This->info_ptr, &name, &compression_type,&profile, &len)) >> pngformat.c:882:5: note: expected 'png_bytepp' but argument is of type 'char **' >> >> The patch below addresses this. > That will break on older libpng. Do you have an idea on how to work around the warning (on newer libpng)? The patch below does it for me, but there may be a better one... Gerald ChangeLog: Add cast to avoid compiler warning (GCC 4.8) in PngDecoder_Frame_GetColorContexts. diff --git a/dlls/windowscodecs/pngformat.c b/dlls/windowscodecs/pngformat.c index 4183d8e..0d238d5 100644 --- a/dlls/windowscodecs/pngformat.c +++ b/dlls/windowscodecs/pngformat.c @@ -879,7 +879,7 @@ static HRESULT WINAPI PngDecoder_Frame_GetColorContexts(IWICBitmapFrameDecode *i EnterCriticalSection(&This->lock); - if (ppng_get_iCCP(This->png_ptr, This->info_ptr, &name, &compression_type, &profile, &len)) + if (ppng_get_iCCP(This->png_ptr, This->info_ptr, &name, &compression_type, (BYTE**)&profile, &len)) { if (cCount && ppIColorContexts) {

Dec. 19, 2012

Re: [PATCH 0/5] Moving bare consoles to wineconsole (try #2)

by Eric Pouech

hmm, that was intended to work (and did work for try#1, even though I didn't retest it in #2) :-( I'll look at it A+ 2012/12/19 Alexandre Julliard <julliard(a)winehq.org> > Eric Pouech <eric.pouech(a)orange.fr> writes: > > >> Try #2 (changes from previous patch) > > > > > - fix changelog of first patch (wastWineHelp...) > > > - fix date in header for new file > > > - remove setting title code (will be fixed in later patch) > > > > > > Actually the problem is not only the title. For instance it's > > still > > sending escape sequences when stdout is redirected. > > > > > > did you test that for the last patch in the patchset or for items in > > the middle of the patchset ? > > Yes, it happens with all the patches applied. > > -- > Alexandre Julliard > julliard(a)winehq.org > -- -- Eric Pouech

Dec. 19, 2012

Re: msxml3: Add custom handling for DISPID_VALUE for node map

by Nikolay Sivov

On 12/19/2012 17:22, Jacek Caban wrote: > On 12/19/12 08:24, Nikolay Sivov wrote: >> Add custom handling for DISPID_VALUE for node map > If this has to be done for all IDispatchEx objects with DISPID_VALUE, it > may be worth considering changing dispex.c. Something like: > > if(id == DISPID_VALUE && wFlags == DISPATCH_METHOD) > wFlags |= DISPATCH_PROPERTYGET; > > before ITypeInfo::Invoke call should do the trick and replace both this > patch and already committed node list patch. Sure, I thought about that too. First one was to fix an open bug, and to do this for all interfaces I'll need tests for everything with DISPID_VALUE, but you're right node map patch could wait for now. > > Cheers, > Jacek

Dec. 19, 2012

Re: msxml3: Add custom handling for DISPID_VALUE for node map

by Jacek Caban

On 12/19/12 08:24, Nikolay Sivov wrote: > Add custom handling for DISPID_VALUE for node map If this has to be done for all IDispatchEx objects with DISPID_VALUE, it may be worth considering changing dispex.c. Something like: if(id == DISPID_VALUE && wFlags == DISPATCH_METHOD) wFlags |= DISPATCH_PROPERTYGET; before ITypeInfo::Invoke call should do the trick and replace both this patch and already committed node list patch. Cheers, Jacek

Dec. 19, 2012

Re: [PATCH 0/5] Moving bare consoles to wineconsole (try #2)

by Alexandre Julliard

Eric Pouech <eric.pouech(a)orange.fr> writes: >> Try #2 (changes from previous patch) > > > - fix changelog of first patch (was WineHelp...) > > - fix date in header for new file > > - remove setting title code (will be fixed in later patch) > > > Actually the problem is not only the title. For instance it's > still > sending escape sequences when stdout is redirected. > > > did you test that for the last patch in the patchset or for items in > the middle of the patchset ? Yes, it happens with all the patches applied. -- Alexandre Julliard julliard(a)winehq.org

Dec. 19, 2012

Re: [PATCH 0/5] Moving bare consoles to wineconsole (try #2)

by Eric Pouech

> Try #2 (changes from previous patch) > > - fix changelog of first patch (was WineHelp...) > > - fix date in header for new file > > - remove setting title code (will be fixed in later patch) > > Actually the problem is not only the title. For instance it's still > sending escape sequences when stdout is redirected. > > did you test that for the last patch in the patchset or for items in the middle of the patchset ? it's intended to work only for the last one in the patchset as it's easier to do it when the old code is removed, and not changing the old code to make it work in patch#2 and erase it in next patch A+ -- -- Eric Pouech

Dec. 19, 2012