February 2012 - Wine-Devel - list.winehq.org

Re: [2/3] msi: Use the return value of IXMLDOMNode_get_text (clang).

by Juan Lang

Hi Hans, hr = IXMLDOMNode_get_text( node, &s ); IXMLDOMNode_Release( node ); - if (!strcmpW( s, product_code )) r = ERROR_SUCCESS; - SysFreeString(s); + if (hr == S_OK && !strcmpW( s, product_code )) r = ERROR_SUCCESS; + SysFreeString( s ); Is it really safe to free s if IXMLDOMNode_get_text failed? --Juan

Feb. 3, 2012

re: Wine automated testing update

by Dan Kegel

Jeremy wrote: > the VMWare folks are not willing to provide a permanent license for VMWare to us. > > So, we've shifted gears, and are exploring whether something like qemu + > kvm would be a sufficient alternate. What's the plan for automated MacOSX testing? I hear 10.7 supports running in a VM...

Feb. 3, 2012

Re: quartz: AMFilterData_ParseFilterData returns a pointer to a pointer to filter data

by Aric Stewart

Yeah, I agree there is something odd happening with this function. It clearly wants a pointer to a pointer, and then graphedit and all the sample code I see online frees the inner pointer but never the outer pointer. So I cannot alloc that outer pointer of we get a leak. It does not help that the documentation for this method says "Normal applications will never call this function" And then proceeds to not describe it very well. I felt like a static and an field in the object where roughly equivalent. I can do some tests. -aric On 2/3/12 4:45 AM, Chris Robinson wrote: > On Friday, February 03, 2012 2:43:57 PM Dmitry Timoshkov wrote: >> Aric Stewart<aric(a)codeweavers.com> wrote: >>> - REGFILTER2 *prf2; >>> + static REGFILTER2 *prf2; >> >> What's the point of this change? > > It returns a pointer to the pointer, so the variable needs to remain valid > after the function exits. The code doesn't really feel safe, though. At the > very least, I think the pointer should perhaps be made part of the > implementation object, but even that feels kinda ugly. What happens if it's > called multiple times? > > > REGFILTER **r1, **r2; > > obj->ParseFilterData(data1, cb1,&r1); > obj->ParseFilterData(data2, cb2,&r2); > > ok(r1 == r2, "Oops\n"); > > CoTaskMemFree(*r1); > /* *r2 is freed now, too */ > > > Doesn't really seem right to me. > >

Feb. 3, 2012

Re: quartz: AMFilterData_ParseFilterData returns a pointer to a pointer to filter data

by Chris Robinson

On Friday, February 03, 2012 2:43:57 PM Dmitry Timoshkov wrote: > Aric Stewart <aric(a)codeweavers.com> wrote: > > - REGFILTER2 *prf2; > > + static REGFILTER2 *prf2; > > What's the point of this change? It returns a pointer to the pointer, so the variable needs to remain valid after the function exits. The code doesn't really feel safe, though. At the very least, I think the pointer should perhaps be made part of the implementation object, but even that feels kinda ugly. What happens if it's called multiple times? REGFILTER **r1, **r2; obj->ParseFilterData(data1, cb1, &r1); obj->ParseFilterData(data2, cb2, &r2); ok(r1 == r2, "Oops\n"); CoTaskMemFree(*r1); /* *r2 is freed now, too */ Doesn't really seem right to me.

Feb. 3, 2012

Re: Wine automated testing update

by John Klehm

For what it's worth VirtualBox has always treated me well virtualizing XP on Win7 and Ubuntu 11.10 as well. --John On Wed, Feb 1, 2012 at 11:27 PM, Lei Zhang <thestig(a)google.com> wrote: > On Wed, Feb 1, 2012 at 12:11 PM, Jeremy White <jwhite(a)codeweavers.com> wrote: >> 1. Test qemu/kvm with a few Windows versions to see if it'll work. > > I've had good luck running 32-bit Windows in qemu + kvm. You'll > probably need to add -rtc=localtime. If you plan to run it headless > and connect via the build in vnc, add -usbdevice tablet. > >

Feb. 3, 2012

Re: quartz: AMFilterData_ParseFilterData returns a pointer to a pointer to filter data

by Dmitry Timoshkov

Aric Stewart <aric(a)codeweavers.com> wrote: > - REGFILTER2 *prf2; > + static REGFILTER2 *prf2; What's the point of this change? -- Dmitry.

Feb. 3, 2012

Re: gdi32/tests: Add tests for default font selection.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16799 Your paranoid android. === W2KPROSP4 (32 bit font) === font.c:4145: Test failed: expected vertical face, got System === WXPPROSP3 (32 bit font) === font.c:4145: Test failed: expected vertical face, got System === W2K3R2SESP2 (32 bit font) === font.c:4145: Test failed: expected vertical face, got System

Feb. 3, 2012

Re: Profiing windows apps

by Ralph Little

Hi Stefan, > If the testing doesn't reveal anything, look out for IDirectDraw::GetCaps > calls in the logs or IDirect3Dx::EnumZBufferFormats. IDirectDraw::GetCaps > returns a DDCAPS structure which has dwZBufferBitDepths containing some flags > for z buffer bit depths. EnumZBufferFormats calls a callback multiple times > with available DDPIXELFORMAT structures. The application may not like some > flags we set there. You know, my gut says that this is the right place to look, particularly IDirect3Dx::EnumZBufferFormats. I see why you suggest this: what if none are returned to the application? I will look into it. What The Sims is passing to CreateSurface just looks wrong. In the meantime, I will generate a full ddraw trace and add it to the bug log as you suggest and then check it through. Cheers, and thanks for the help. It is much appreciated. Ralph >________________________________ > From: Stefan Dösinger <stefandoesinger(a)gmx.at> >To: wine-devel(a)winehq.org; Ralph Little <littlesincanada(a)yahoo.co.uk> >Sent: Wednesday, February 1, 2012 11:52:15 AM >Subject: Re: Profiing windows apps > >Hi, > >Am Dienstag, 31. Januar 2012, 21:51:01 schrieb Ralph Little: >> IDirectDraw * pDD = NULL; >> IDirectDrawSurface * pDDSPrimary = NULL; >> DDSURFACEDESC ddsd; >Take a look at dlls/ddraw/tests/ddraw*.c > >> ...<initialisation etc>... >Make sure you use the version of the interface the game uses. There are some >behavioral differences between them. E.g. with zbuffers >DDSURFACEDESC(IDirectDraw, IDirectDraw2) has dwZBufferBitDepth(and >DDSD_ZBUFFERBITDEPTH), while DDSURFACEDESC2(IDirectDraw4, IDirectDraw7) always >uses a pixel format. > >As far as I can see from the bug report the game is using IDirectDraw4. > >> memset(&ddsd, 0, sizeof(ddsd)); >> ddsd.dwSize = sizeof(ddsd); >> ddsd.dwFlags = DDSD_CAPS | DDSD_PIXELFORMAT | DDSD_HEIGHT | DDSD_WIDTH; >> ddsd.ddsCaps.dwCaps = DDSCAPS_SYSTEMMEMORY | DDSCAPS_ZBUFFER; >Is it really trying to create a system memory z buffer? (Ok, I just saw this >in the logs attached to the bug report - that's really odd). > >> ddsd.dwHeight = 600; >> ddsd.dwWidth = 800; >> ddsd.ddpfPixelFormat.dwSize = sizeof(DDPIXELFORMAT); >Try to set ddsd.ddpfPixelFormat.dwZBufferBitDepth to e.g. 16 and >ddsd.ddpfPixelFormat.dwZBitMask to 0x0000ffff. Keep dwFlags set to 0. Als try >to keep dwSize at 0. > >> I assume that if the caller specifies DDSCAPS_ZBUFFER, the you must also >> specify some PIXEL format information. DDSD_PIXELFORMAT is present, but >> there are no format flags. >Basically that, or dwZBufferBitDepth. See zbufferbitdepth_test in >dlls/ddraw/tests/dsurface.c for some tests on this. (Don't add any new tests >there btw - use tests/ddraw*.c). > >> I have to admit that I am a bit of a novice when it comes to DirectX so any >> guidance here would be helpful. I see that the lpSurface is NULL, which I >> thought was an error. However, I see that this is optional if the caller >> wishes the system to manage the surface memory. >Correct. > >> Any error returned by this function the Sims at this point to causes it to >> crash. Therefore, it seems to me that if it succeeds in Windows, it must >> have passed something different. If only we could see the source :D >If the testing doesn't reveal anything, look out for IDirectDraw::GetCaps >calls in the logs or IDirect3Dx::EnumZBufferFormats. IDirectDraw::GetCaps >returns a DDCAPS structure which has dwZBufferBitDepths containing some flags >for z buffer bit depths. EnumZBufferFormats calls a callback multiple times >with available DDPIXELFORMAT structures. The application may not like some >flags we set there. > >Also please attach a full +ddraw log to the bug report. If it is too big >compress it. bzip2 should do a pretty decent job, if all fails try lrzip. > > >

Feb. 2, 2012

Re: [PATCH 1/2] ddraw/tests: Add some IDirect3DViewport interface tests (try 2)

by Stefan Dösinger

Am Donnerstag, 2. Februar 2012, 15:02:27 schrieb Henri Verbeet: > Well yeah, get_refcount() returns ULONG now, but you should fix the > type of "ref" and the format strings as well. Argh, today is not my day...

Feb. 2, 2012

Re: [PATCH 1/2] ddraw/tests: Add some IDirect3DViewport interface tests (try 2)

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16784 Your paranoid android. === WNT4WSSP6 (32 bit ddraw2) === ddraw2.c:421: Test failed: Got unexpected count 3. ddraw2.c:430: Test failed: Got unexpected clip rect {14, 33, 646, 237}, expected {14, 33, 646, 486}.

Feb. 2, 2012