March 2012 - Wine-Devel - list.winehq.org

Re: wined3d: Added PCI device IDs for AMD Radeon 6750M & 6770M

by Gaurav Jain

On 2012-03-31, at 4:49 PM, Henri Verbeet wrote: > On 31 March 2012 21:20, Gaurav Jain <gaurav(a)gauravjain.org> wrote: >> CARD_AMD_RADEON_HD6600M = 0x6741, >> + CARD_AMD_RADEON_HD6750M = 0x6741, > If those are actually supposed to be the same, I don't think there's > much of a point in this patch. > Ahh... I didn't catch that the 6600M & 6750M was identical. Is there even a 6600M? My google search only found a 6630M, 6650M & 6670M. I believe 6600M is the series. I can remove the 6750M from the patch if you'd like. Please note that there is another duplicate entry for 5700 & 5750. The 6770M did have a different PCI ID, would you like the patch modified with only changes for the 6770M?

March 31, 2012

Re: [PATCH] wined3d: When releasing resources, don't perform any other operations on device if it has been released.

by Henri Verbeet

On 31 March 2012 23:30, Christian Costa <titan.costa(a)gmail.com> wrote: > Do you have a better idea ? > My first guess would be to check if vertex buffers are perhaps supposed to take a reference to the D3D interface. > Btw, the problem is easily reproductible. The bugzlla entry contain the > download link. > Yes, we have a lot of those.

March 31, 2012

Re: [PATCH] wined3d: When releasing resources, don't perform any other operations on device if it has been released.

by Christian Costa

Le 31/03/2012 22:46, Henri Verbeet a écrit : > This looks wrong. Is there a legitimate way that this can happen? > > > The FIXME in wined3d_device_decref says : FIXME("Device released with resources still bound, acceptable but unexpected.\n"); If this is "acceptable", resources must not use the device afterwards because it's released. If it's legitimate ? I don't know. The game craches when exiting. This may be due to a bad objects and resources freeing. Do you have a better idea ? Btw, the problem is easily reproductible. The bugzlla entry contain the download link. Christian

March 31, 2012

Re: wined3d: Added PCI device IDs for AMD Radeon 6750M & 6770M

by Henri Verbeet

On 31 March 2012 21:20, Gaurav Jain <gaurav(a)gauravjain.org> wrote: > CARD_AMD_RADEON_HD6600M = 0x6741, > + CARD_AMD_RADEON_HD6750M = 0x6741, If those are actually supposed to be the same, I don't think there's much of a point in this patch.

March 31, 2012

Re: [PATCH] wined3d: When releasing resources, don't perform any other operations on device if it has been released.

by Henri Verbeet

This looks wrong. Is there a legitimate way that this can happen?

March 31, 2012

Re: msi: add support for MSIRUNMODE_REBOOTNOW in MsiGetMode

by Austin English

On Sat, Mar 31, 2012 at 06:00, Hans Leidekker <hans(a)codeweavers.com> wrote: > On Fri, 2012-03-30 at 17:27 -0700, Austin English wrote: >> + case MSIRUNMODE_REBOOTNOW: >> + r = package->need_reboot; >> + break; >> + > > MSIRUNMODE_REBOOTNOW and MSIRUNMODE_REBOOTATEND are not the same thing. > > It seems I misunderstood the analysis then. I'll leave it to you then :). -- -Austin

March 31, 2012

Wine test bot and win16 exe

by Christian Costa

Hi, I wrote a win16 exe test file using open watcom but I cannot submit it to winebot. I fails saying "Unricognized file type". This is a little annoying. Is this a known limitation of wine test bot ? Thanks Christian

March 31, 2012

Re: quartz: update ICOM_THIS_MULTI to follow the new COM standard

by Jacek Caban

On 3/31/12 3:36 PM, John Klehm wrote: > On Fri, Mar 30, 2012 at 11:08 AM, Jacek Caban<jacek(a)codeweavers.com> wrote: >> On 03/30/12 17:55, Aric Stewart wrote: >>> diff --git a/dlls/quartz/quartz_private.h b/dlls/quartz/quartz_private.h >>> index 35cd52b..d2f680c 100644 >>> --- a/dlls/quartz/quartz_private.h >>> +++ b/dlls/quartz/quartz_private.h >>> @@ -38,7 +38,7 @@ >>> #define BYTES_FROM_MEDIATIME(time) SEC_FROM_MEDIATIME(time) >>> #define MSEC_FROM_MEDIATIME(time) ((time) / 10000) >>> >>> -#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=(impl*)((char*)(iface) - offsetof(impl,field)) >>> +#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=CONTAINING_RECORD(iface, impl, field) >> These should disappear once the clean up of affected code is done. >> > > Just for my own curiosity, I assume these pages are the preferred way? > > http://wiki.winehq.org/COMGuideline > http://wiki.winehq.org/ComCleanup Yes, that's the preferred way. Jacek

March 31, 2012

Re: quartz: update ICOM_THIS_MULTI to follow the new COM standard

by John Klehm

On Fri, Mar 30, 2012 at 11:08 AM, Jacek Caban <jacek(a)codeweavers.com> wrote: > On 03/30/12 17:55, Aric Stewart wrote: >> diff --git a/dlls/quartz/quartz_private.h b/dlls/quartz/quartz_private.h >> index 35cd52b..d2f680c 100644 >> --- a/dlls/quartz/quartz_private.h >> +++ b/dlls/quartz/quartz_private.h >> @@ -38,7 +38,7 @@ >> #define BYTES_FROM_MEDIATIME(time) SEC_FROM_MEDIATIME(time) >> #define MSEC_FROM_MEDIATIME(time) ((time) / 10000) >> >> -#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=(impl*)((char*)(iface) - offsetof(impl,field)) >> +#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=CONTAINING_RECORD(iface, impl, field) > > These should disappear once the clean up of affected code is done. > Just for my own curiosity, I assume these pages are the preferred way? http://wiki.winehq.org/COMGuideline http://wiki.winehq.org/ComCleanup

March 31, 2012

Re: msi: add support for MSIRUNMODE_REBOOTNOW in MsiGetMode

by Hans Leidekker

On Fri, 2012-03-30 at 17:27 -0700, Austin English wrote: > + case MSIRUNMODE_REBOOTNOW: > + r = package->need_reboot; > + break; > + MSIRUNMODE_REBOOTNOW and MSIRUNMODE_REBOOTATEND are not the same thing.

March 31, 2012