March 2012 - Wine-Devel - list.winehq.org

Re: [5/8] scrrun: Implement IFileSystem3 FileExists

by Jacek Caban

Hi Alistair, On 03/27/12 11:42, Alistair Leslie-Hughes wrote: > + static const WCHAR existing_fileW[] = { > + 'c', ':', '\\', 'W', 'i', 'n', 'd', 'o', 'w', 's', '\\', 's', 'y', 's', 't', 'e', 'm', '3', > + '2', '\\', 'n', 't', 'd', 'l', 'l', '.', 'd', 'l', 'l', 0}; Hardcoding even such paths is not a god idea. Cheers, Jacek

March 27, 2012

Re: Web based translation tool

by Michal Čihař

Hi Dne Tue, 27 Mar 2012 00:00:04 +0200 Frédéric Delanoy <frederic.delanoy(a)gmail.com> napsal(a): > On Mon, Mar 26, 2012 at 16:23, Michal Čihař <michal(a)cihar.com> wrote: > > It turned out such feature seems to be important for more projects, so I > > will end up implementing some way of merging of commits for 1.0. > > Details can be found at https://github.com/nijel/weblate/issues/16 > > I don't know how your tool/system exactly works, so my comment may be > a bit naive/wrong, but instead of merging commits, couldn't there be > instead (or as a complement) some kind of session/transaction system > where a user translates a number of msgids, then sort of "commits" its > changes to close the session/transaction, which would trigger the git > commit creation? You've basically described what I've outlined in issue referenced above and implemented just now in Git, so yes I think this is better approach than merging :-). -- Michal Čihař | http://cihar.com | http://blog.cihar.com

March 27, 2012

Re: [6/8] scrrun: Implement IFileSystem3 FolderExists

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17493 Your paranoid android. === WINEBUILD (build) === Make failed

March 27, 2012

Re: [3/8] scrrun: Add IFileSystem3 support

by Jacek Caban

Hi Alistair, On 03/27/12 11:41, Alistair Leslie-Hughes wrote: > +typedef struct FileSystem > +{ > + IFileSystem3 IFileSystem3_iface; > + LONG ref; > +} FileSystem; > + > +static inline FileSystem *impl_from_IFileSystem3( IFileSystem3 *iface ) > +{ > + return CONTAINING_RECORD(iface, FileSystem, IFileSystem3_iface); > +} Is there any reason for this to be heap-based object? It looks to me like it would better be a static object (AFAICS you don't even need FileSystem struct since you're not going to store anything in it). Cheers, Jacek

March 27, 2012

Re: [5/8] scrrun: Implement IFileSystem3 FileExists

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17492 Your paranoid android. === WINEBUILD (build) === Make failed

March 27, 2012

Re: [4/8] scrrun: Add scrrun tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=17491 Your paranoid android. === WINEBUILD (build) === Make failed

March 27, 2012

Re: winex11.drv: Do not trash existing clip rectangle if XInput2 is not available.

by Alexandre Julliard

Vitaliy Margolen <wine-devel(a)kievinfo.com> writes: > If Dmitry fixes a real bug that means dinput shouldn't depend on > broken behavior. And I'm questioning that exact behavior which > shouldn't have been there in the first place. Dinput's exclusive mode > works regardless of what ClipCursor is set to. Of course the behavior is not identical to Windows, but that's because we can't intercept mouse events under X11 at the level where dinput would have to do it. If you have suggestions on how to do this differently please explain them. Just claiming "it's wrong because it's not like Windows" is not helpful in this case. -- Alexandre Julliard julliard(a)winehq.org

March 27, 2012

Re: Need suggestion to choose a GSoC idea

by Qian Hong

Hi Holy, On Tue, Mar 27, 2012 at 12:38 PM, HolyCause <holy.cause(a)gmail.com> wrote: > I already asked Austin about that for my GSoC proposal: > >> in short, I think this effort is best spent somewhere else. GUI >> testing is really hard to get right, and very expensive(time, effort, >> disk space, cpu power, etc.). > > Thanks for reminder, I agree GUI testing is expensive, but I think manpower is more expensive :) However I've no idea how hard is it to get GUI testing right yet, maybe you are right, but from my view it is worth to try. > I've since decided against GSoC for this year, but my idea revolved around > improving cmd's parser, notably getting Firefox/Chromium and/or other > software to build under wine (or at least, isolate potential/existing issues > to non-cmd parts). I was partway through fixing > http://bugs.winehq.org/show_bug.cgi?id=21174 > > Dan Kegel seemed pretty interested in the project. If you're interested you > could e-mail him. Thanks, if this idea is not suitable for GSoC, I'll push it in my todo list. I'll contact to Dan and Austin once I'm going to do this. Thank you for your suggestion and good luck to your GSoC project! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

March 27, 2012

Re: [PATCH] cmd/tests: If we rewind to the beginning of the line, don't increment line number.

by Christian Costa

Le 27/03/2012 08:32, Frédéric Delanoy a écrit : > On Mon, Mar 26, 2012 at 10:13, Christian Costa<titan.costa(a)gmail.com> wrote: >> If some particular cases, a bias is introduced in the line number which make error message >> mismatch the content of the .exp file. This patch fixes that. >> --- >> programs/cmd/tests/batch.c | 4 ++++ > I guess this should be marked as a prerequisite to/included in your > new attrib patches list > > Frédéric > All cmd tests benefit from this patch but yes it could be part of the attrib patches set. Christian

March 27, 2012

Re: [PATCH] cmd/tests: If we rewind to the beginning of the line, don't increment line number.

by Frédéric Delanoy

On Mon, Mar 26, 2012 at 10:13, Christian Costa <titan.costa(a)gmail.com> wrote: > If some particular cases, a bias is introduced in the line number which make error message > mismatch the content of the .exp file. This patch fixes that. > --- > programs/cmd/tests/batch.c | 4 ++++ I guess this should be marked as a prerequisite to/included in your new attrib patches list Frédéric

March 27, 2012